Paths

Table of Contentst

Differential D19739

When using "bin/bulk export --overwrite", actually overwrite the file
ClosedPublic
Actions

Authored by epriestley on Oct 8 2018, 6:22 PM.

Tags

None

Referenced Files

	F13046342: D19739.id.diff
	Thu, Apr 18, 9:00 AM

	Unknown Object (File)
	Wed, Apr 17, 2:44 PM

	Unknown Object (File)
	Tue, Apr 16, 11:18 PM

	Unknown Object (File)
	Tue, Apr 16, 9:31 PM

	Unknown Object (File)
	Sat, Apr 13, 11:47 AM

	Unknown Object (File)
	Fri, Apr 12, 10:33 PM

	Unknown Object (File)
	Sun, Mar 31, 5:14 PM

	Unknown Object (File)
	Sat, Mar 30, 2:16 PM

View All 71 Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13210: Plans: 2018 Week 41-44 Bonus Content

Commits

rP4f557ff075ad: When using "bin/bulk export --overwrite", actually overwrite the file

Summary

Depends on D19738. Ref T13210. Currently, when you use "--overwrite", we just append the new content. Instead, actually overwrite the file.

Test Plan

Used --overwrite, saw an actual clean overwrite instead of an append.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 8 2018, 6:22 PM

Harbormaster completed remote builds in B21003: Diff 47160.Oct 8 2018, 6:23 PM

epriestley requested review of this revision.Oct 8 2018, 6:23 PM

amckinley accepted this revision.Oct 9 2018, 8:44 PM

This revision is now accepted and ready to land.Oct 9 2018, 8:44 PM

Closed by commit rP4f557ff075ad: When using "bin/bulk export --overwrite", actually overwrite the file (authored by epriestley). · Explain WhyOct 11 2018, 3:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

bulk/

management/

PhabricatorBulkManagementExportWorkflow.php

4 lines

Diff 47166

View Options

src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php

When using "bin/bulk export --overwrite", actually overwrite the fileClosedPublicActions