Page MenuHomePhabricator

thaiphv (Thai Pham)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 12 2015, 12:31 PM (201 w, 1 d)
Availability
Available

Recent Activity

Nov 24 2017

thaiphv added a comment to D18770: Add support for nullable parameter types.

When can this diff be landed?

Nov 24 2017, 2:01 AM

Sep 25 2017

thaiphv added a comment to D18621: Add support for nullable return types.

When will this be landed?

Sep 25 2017, 2:40 AM

Mar 16 2017

thaiphv added a comment to D17232: Improve `ArcanistDeprecationXHPASTLinterRule` by lowercasing keys in `xhpast.deprecated.functions`.

Can this be reviewed again and landed?

Mar 16 2017, 2:45 AM

Feb 13 2017

thaiphv updated the diff for D17232: Improve `ArcanistDeprecationXHPASTLinterRule` by lowercasing keys in `xhpast.deprecated.functions`.
  • Move the lowercasing logic into ArcanistXHPASTLinterRule::getFunctionCalls
Feb 13 2017, 12:35 PM

Jan 22 2017

thaiphv updated the diff for D17232: Improve `ArcanistDeprecationXHPASTLinterRule` by lowercasing keys in `xhpast.deprecated.functions`.
  • Use CaseInsensitiveArray to store xhpast.deprecated.functions
  • Fix jshint.lint-test
Jan 22 2017, 12:18 PM

Jan 19 2017

thaiphv created D17232: Improve `ArcanistDeprecationXHPASTLinterRule` by lowercasing keys in `xhpast.deprecated.functions`.
Jan 19 2017, 10:35 PM

Nov 15 2016

thaiphv updated the test plan for D16875: Ensure that `PHUIInvisibleCharacterTestCase` is compatible with PHP 5.3.
Nov 15 2016, 10:20 PM
thaiphv retitled D16875: Ensure that `PHUIInvisibleCharacterTestCase` is compatible with PHP 5.3 from to Ensure that `PHUIInvisibleCharacterTestCase` is compatible with PHP 5.3.
Nov 15 2016, 10:18 PM

Mar 21 2016

thaiphv added a comment to D15212: Fix incorrect variable for linter standards.

Can someone please review and accept this fix?

Mar 21 2016, 1:09 AM

Sep 25 2015

thaiphv added a comment to D14107: Fix wrong indentation returned by AASTNode::getIndentation() when calling it on a statement node that is preceded by a comment token..

I've tested the function myself use the cases below:

Sep 25 2015, 6:33 AM
thaiphv added a comment to D14107: Fix wrong indentation returned by AASTNode::getIndentation() when calling it on a statement node that is preceded by a comment token..

I'm not sure if PhutilTestCase supports testing abstract classes like this one.

Sep 25 2015, 6:29 AM
thaiphv updated the diff for D14107: Fix wrong indentation returned by AASTNode::getIndentation() when calling it on a statement node that is preceded by a comment token..

Fix the review comment.

Sep 25 2015, 6:26 AM

Sep 15 2015

thaiphv updated the diff for D14107: Fix wrong indentation returned by AASTNode::getIndentation() when calling it on a statement node that is preceded by a comment token..
  • Ensure that a next token is available
Sep 15 2015, 3:04 AM
thaiphv retitled D14107: Fix wrong indentation returned by AASTNode::getIndentation() when calling it on a statement node that is preceded by a comment token. from to Fix wrong indentation returned by AASTNode::getIndentation() when calling it on a statement node that is preceded by a comment token..
Sep 15 2015, 2:56 AM