Page MenuHomePhabricator
Feed All Stories

Jul 20 2018

epriestley added a comment to T13172: Saved meme-maker results are case-insensitive.

how did this ever escape us

Jul 20 2018, 10:23 PM · Macros
epriestley awarded T13172: Saved meme-maker results are case-insensitive a The World Burns token.
Jul 20 2018, 10:23 PM · Macros
amckinley triaged T13172: Saved meme-maker results are case-insensitive as Unbreak Now! priority.
Jul 20 2018, 10:22 PM · Macros
epriestley triaged T13171: Config has some kind of goofy looking face emoji as a Unicode glyph, which renders as particular nonsense in recent versions of macOS as High priority.
Jul 20 2018, 10:09 PM · Design
epriestley added a revision to T13167: AWS is rebooting several production hosts (July 2018): Unknown Object (Differential Revision).
Jul 20 2018, 10:00 PM · Phacility, Ops
epriestley added a comment to T13167: AWS is rebooting several production hosts (July 2018).

See email. An instance got an invite into an awkward state by cancelling the invite after the user had accepted it but before they registered an account.

Jul 20 2018, 9:52 PM · Phacility, Ops
epriestley added a revision to T13141: MySQL 8.0.4+ uses "caching_sha2_password", which is incompatible with older clients and raises error 2054 ("The server requested authentication method unknown to the client") with virtually no setup guidance: Unknown Object (Differential Revision).
Jul 20 2018, 9:44 PM · Setup
epriestley added a revision to T13168: epriestley new laptop / not reading documentation setup issues: Unknown Object (Differential Revision).
Jul 20 2018, 9:39 PM · Phacility, Setup
epriestley added a comment to T13141: MySQL 8.0.4+ uses "caching_sha2_password", which is incompatible with older clients and raises error 2054 ("The server requested authentication method unknown to the client") with virtually no setup guidance.

The GRANT syntax also appears to have changed. We currently do this (in Phacility-specific code):

Jul 20 2018, 8:59 PM · Setup
epriestley added a comment to T13098: Plans: Arcanist toolsets and extensions.

Also ignore the untamed-wilds branch, I'm just pulling it out of the wreckage of my explosion-prone laptop (see also T13168).

Jul 20 2018, 8:20 PM · Arcanist, Plans
epriestley added a comment to T13098: Plans: Arcanist toolsets and extensions.

ignore me

Jul 20 2018, 8:18 PM · Arcanist, Plans
amckinley added a revision to T13065: Move storage for `mailKey` to the Mail application: Unknown Object (Differential Revision).
Jul 20 2018, 7:00 PM · Mail
epriestley added a revision to T13167: AWS is rebooting several production hosts (July 2018): Unknown Object (Differential Revision).
Jul 20 2018, 5:31 PM · Phacility, Ops
epriestley added a revision to T13167: AWS is rebooting several production hosts (July 2018): Unknown Object (Differential Revision).
Jul 20 2018, 5:30 PM · Phacility, Ops
epriestley added a revision to T13167: AWS is rebooting several production hosts (July 2018): Unknown Object (Differential Revision).
Jul 20 2018, 5:28 PM · Phacility, Ops
epriestley added a comment to T13169: In DarkConsole, Query profiling in "Analyze" mode helpfully includes stack traces to help identify where a query came from, but these aren't clearly labeled and look like error traces.

(Yell if I'm assuming too much here.)

Jul 20 2018, 5:16 PM · Infrastructure
epriestley renamed T13169: In DarkConsole, Query profiling in "Analyze" mode helpfully includes stack traces to help identify where a query came from, but these aren't clearly labeled and look like error traces from Query profiling errors out pretty often in darkconsole to In DarkConsole, Query profiling in "Analyze" mode helpfully includes stack traces to help identify where a query came from, but these aren't clearly labeled and look like error traces.
Jul 20 2018, 5:16 PM · Infrastructure
epriestley renamed T13170: Conduit "maniphest.search" method call allows ordering by "project" column on arbitrary queries, but this internal column is only meaningful when "Group By" is "Project" from task search by project errors out to Conduit "maniphest.search" method call allows ordering by "project" column on arbitrary queries, but this internal column is only meaningful when "Group By" is "Project".
Jul 20 2018, 5:14 PM · Conduit
epriestley added a comment to T13170: Conduit "maniphest.search" method call allows ordering by "project" column on arbitrary queries, but this internal column is only meaningful when "Group By" is "Project".

The fix I'd propose is:

Jul 20 2018, 5:13 PM · Conduit
epriestley added a comment to T13170: Conduit "maniphest.search" method call allows ordering by "project" column on arbitrary queries, but this internal column is only meaningful when "Group By" is "Project".

This isn't meaningful, but we can raise a more specific error.

Jul 20 2018, 5:09 PM · Conduit
epriestley added a comment to T13169: In DarkConsole, Query profiling in "Analyze" mode helpfully includes stack traces to help identify where a query came from, but these aren't clearly labeled and look like error traces.

When you "Analyze", we include a stack trace of where the query was issued from so you can hunt it down if you aren't sure. Does that explain the behavior?

Jul 20 2018, 5:05 PM · Infrastructure
epriestley renamed T13168: epriestley new laptop / not reading documentation setup issues from New laptop setup issues to epriestley new laptop / not reading documentation setup issues.
Jul 20 2018, 5:04 PM · Phacility, Setup
epriestley added a revision to T13167: AWS is rebooting several production hosts (July 2018): Unknown Object (Differential Revision).
Jul 20 2018, 5:03 PM · Phacility, Ops
epriestley added a revision to T13167: AWS is rebooting several production hosts (July 2018): Unknown Object (Differential Revision).
Jul 20 2018, 4:54 PM · Phacility, Ops
epriestley renamed T13167: AWS is rebooting several production hosts (July 2018) from AWS is rebooting every host (July 2018) to AWS is rebooting several production hosts (July 2018).
Jul 20 2018, 4:52 PM · Phacility, Ops
amckinley added a revision to T13151: Plans: 2018 Week 23 - Week 30 Bonus Content: Unknown Object (Differential Revision).
Jul 20 2018, 3:48 AM · Plans

Jul 19 2018

amckinley added a comment to T12857: Temporary directory fullness can cause daemon issues?.

EC2 volume ddata005.phacility.net filled up, causing problems for instances hosted on db005, leading to PHI771. I'll dig back into the CloudWatch monitoring stuff I setup a few months ago and make the db hosts report storage metrics the same way the repo hosts already do.

Jul 19 2018, 11:42 PM · Diffusion, Ops, Daemons, Phacility
mbinder added a comment to T10915: Allow story points to just be task count.

Bumping this just to say that another team I work with wants to track WIP using count instead of points. In their case, they are a support team, so their board is populated by cross-tagging tasks that belong to other teams. When those cross-tag tasks have story points for the team that originated the task, the story points show on the support team, as well. This means that the support team can't default the story points to 1 just to get the count in WIP.

Jul 19 2018, 8:34 PM · Restricted Project, Feature Request
avivey created T13170: Conduit "maniphest.search" method call allows ordering by "project" column on arbitrary queries, but this internal column is only meaningful when "Group By" is "Project".
Jul 19 2018, 7:49 PM · Conduit
yelirekim added a comment to T13169: In DarkConsole, Query profiling in "Analyze" mode helpfully includes stack traces to help identify where a query came from, but these aren't clearly labeled and look like error traces.

Oh also apparently query profiling doesn't always come up when you click on it, here is an example error

Jul 19 2018, 7:38 PM · Infrastructure
yelirekim created T13169: In DarkConsole, Query profiling in "Analyze" mode helpfully includes stack traces to help identify where a query came from, but these aren't clearly labeled and look like error traces.
Jul 19 2018, 7:37 PM · Infrastructure
epriestley added a comment to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.

Via PHI773, filter_input_array(INPUT_ENV, FILTER_UNSAFE_RAW); does not appear to work if variables_order excludes E.

Jul 19 2018, 3:20 PM · Infrastructure

Jul 18 2018

jcox awarded T13168: epriestley new laptop / not reading documentation setup issues a The World Burns token.
Jul 18 2018, 8:34 PM · Phacility, Setup
epriestley added a comment to T7303: Provide OAuth access to Conduit.

Plans, yes. Timing is trickier. Currently, we only have one outstanding request for this feature (PHI760, which mostly wants project.search). So it's in queue somewhere, but currently beyond the forecasting horizon.

Jul 18 2018, 6:01 PM · Restricted Project, Conduit, Restricted Project
zeeg added a comment to T7303: Provide OAuth access to Conduit.

@epriestley any timing/plans for expanding? Would love to replace our older user token flows with an OAuth flow. We'd need a few other methods though:

Jul 18 2018, 5:58 PM · Restricted Project, Conduit, Restricted Project
epriestley added a comment to T7303: Provide OAuth access to Conduit.

Conduit API methods define a getRequiredScope() method, which tells you the scope they require.

Jul 18 2018, 5:53 PM · Restricted Project, Conduit, Restricted Project
zeeg added a comment to T7303: Provide OAuth access to Conduit.

Are there any obvious ways to see scope requirements/availability today, even if it means spelunking into the source code?

Jul 18 2018, 5:42 PM · Restricted Project, Conduit, Restricted Project
jmeador added a comment to T13168: epriestley new laptop / not reading documentation setup issues.
  • Install XCode. Find the secret "Install Command Line Tools" option inside the Hidden Chamber of XCode and click it.

xcode-select --install should be possible without a full XCode installation.

Jul 18 2018, 5:37 PM · Phacility, Setup
epriestley added a comment to T13168: epriestley new laptop / not reading documentation setup issues.

Build just the extension from source?

Jul 18 2018, 12:48 AM · Phacility, Setup

Jul 17 2018

epriestley updated the task description for T13168: epriestley new laptop / not reading documentation setup issues.
Jul 17 2018, 11:17 PM · Phacility, Setup
epriestley updated the task description for T13168: epriestley new laptop / not reading documentation setup issues.
Jul 17 2018, 11:11 PM · Phacility, Setup
epriestley added a revision to T13168: epriestley new laptop / not reading documentation setup issues: Unknown Object (Differential Revision).
Jul 17 2018, 11:06 PM · Phacility, Setup
epriestley added projects to T13168: epriestley new laptop / not reading documentation setup issues: Setup, Phacility.
Jul 17 2018, 11:04 PM · Phacility, Setup
epriestley triaged T13168: epriestley new laptop / not reading documentation setup issues as Low priority.
Jul 17 2018, 10:59 PM · Phacility, Setup
epriestley triaged T13167: AWS is rebooting several production hosts (July 2018) as Normal priority.
Jul 17 2018, 10:20 PM · Phacility, Ops
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 17 2018, 8:41 PM · Plans
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 17 2018, 5:16 PM · Plans
epriestley lowered the priority of T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive from Normal to Wishlist.

I'm going to look at improving the push logs a bit to show which rule blocked a push to address the actual use case in PHI765, which makes this more of a distance nice-to-have.

Jul 17 2018, 5:15 PM · Diffusion, Herald
epriestley triaged T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive as Normal priority.
Jul 17 2018, 4:56 PM · Diffusion, Herald

Jul 16 2018

epriestley added a comment to T13165: Copy detection in Git is very eager about empty files.

T1022 is possibly somewhat-vaguely-adjacent on symlink stuff.

Jul 16 2018, 11:22 PM · Differential, Arcanist, Git
yelirekim updated subscribers of T13165: Copy detection in Git is very eager about empty files.

@jcox do you know how to reproduce arc diff dying when you try to create certain types of diffs that move or remove symlinks? I think that's adjacent, if not identical to what's being talked about here.

Jul 16 2018, 10:39 PM · Differential, Arcanist, Git
monufer updated the task description for T12334: Arc land is not enforcing Herald Rule.
Jul 16 2018, 5:00 PM · Bug Report
jasonrumney added a comment to T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule'.

I think the following change to src/applications/herald/controller/HeraldRuleController.php line 672 (as of 185c28f307e4) should provide an immediate improvement to at least indicate that they are different rules:

Jul 16 2018, 2:18 PM · Restricted Project, Herald

Jul 13 2018

epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Jul 13 2018, 7:10 PM · Differential, Plans
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 13 2018, 7:04 PM · Plans
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Jul 13 2018, 6:58 PM · Differential, Plans
epriestley added a comment to T13165: Copy detection in Git is very eager about empty files.

As a special case of this, if you commit an empty a.py file, then add content to it and also add a new empty b.py file in a commit on top of it, the new empty b.py will be detected as a copy of a.py based on the previous (empty) content of the file. I think Git is being pretty reasonable/consistent here, but this is potentially also expectation-defying:

Jul 13 2018, 6:29 PM · Differential, Arcanist, Git
epriestley added a revision to T13156: Plans: Improve Phacility UI for managing instance managers and cards: Unknown Object (Differential Revision).
Jul 13 2018, 6:14 PM · Plans, Phacility
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 13 2018, 5:58 PM · Plans
epriestley added a parent task for T13165: Copy detection in Git is very eager about empty files: T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 13 2018, 4:14 PM · Differential, Arcanist, Git
epriestley added a subtask for T13164: Plans: 2018 Week 31 - 33 Bonus Content: T13165: Copy detection in Git is very eager about empty files.
Jul 13 2018, 4:14 PM · Plans
epriestley triaged T13165: Copy detection in Git is very eager about empty files as Wishlist priority.
Jul 13 2018, 4:12 PM · Differential, Arcanist, Git
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 13 2018, 4:01 PM · Plans
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 13 2018, 3:59 PM · Plans
epriestley triaged T13164: Plans: 2018 Week 31 - 33 Bonus Content as Normal priority.
Jul 13 2018, 3:59 PM · Plans
epriestley added a comment to T13091: Ferret "Relevance" order does not always have all the columns it needs available.

Trying to reproduce this locally just hits the ft_doc.epochModified issue. I'm not immediately sure why the behavior differs between my local install and secure, but that issue probably needs to be fixed first.

Jul 13 2018, 3:57 PM · Search
epriestley added a comment to T13091: Ferret "Relevance" order does not always have all the columns it needs available.

Actually, I'm not entirely right in merging that task -- T13163 isn't quite the same as the other two issues here. I think they're similar, but the query text is relevant in the case of T13163. Notably:

Jul 13 2018, 3:50 PM · Search
epriestley merged T13163: Unhandled Exception: Query "ManiphestTaskQuery" failed to return a value from getPagingValueMap() for column "rank". into T13091: Ferret "Relevance" order does not always have all the columns it needs available.
Jul 13 2018, 3:44 PM · Search
epriestley merged task T13163: Unhandled Exception: Query "ManiphestTaskQuery" failed to return a value from getPagingValueMap() for column "rank". into T13091: Ferret "Relevance" order does not always have all the columns it needs available.
Jul 13 2018, 3:44 PM · Maniphest

Jul 11 2018

ekubischta awarded T1894: Support commenting on Phriction documents a Like token.
Jul 11 2018, 5:47 PM · Restricted Project, Restricted Project, Phriction

Jul 10 2018

cspeckmim added a comment to T13153: Use a bloom filter (or low-resolution hashing?) to reserve unique identifiers in a GDPR-compliant way with reasonable technical foundations.

ugh, zucchini

Jul 10 2018, 2:55 AM · Guides

Jul 9 2018

epriestley added a revision to T13151: Plans: 2018 Week 23 - Week 30 Bonus Content: Unknown Object (Differential Revision).
Jul 9 2018, 9:36 PM · Plans
epriestley updated the task description for T13151: Plans: 2018 Week 23 - Week 30 Bonus Content.
Jul 9 2018, 9:31 PM · Plans

Jul 8 2018

siepkes awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Jul 8 2018, 9:34 AM · Workboards (v3), Restricted Project

Jul 5 2018

arpagon awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Jul 5 2018, 8:12 PM · Workboards (v3), Restricted Project
epriestley updated the task description for T13156: Plans: Improve Phacility UI for managing instance managers and cards.
Jul 5 2018, 5:21 PM · Plans, Phacility
shuLhan awarded T5793: Add support for personal workboards a Like token.
Jul 5 2018, 9:51 AM · User Delight, Wikimedia, Workboards

Jul 3 2018

aklapper created T13163: Unhandled Exception: Query "ManiphestTaskQuery" failed to return a value from getPagingValueMap() for column "rank"..
Jul 3 2018, 8:27 AM · Maniphest

Jul 2 2018

DragonBe added a comment to P2084 T12785 patch.

I really haven't looked into the backwards compatibility issue as we're already test-driving on PHP 7.3 preview, so I can't help you out there. Your suggestion to detect the PHP version and offer this solution only for versions of PHP 7 and higher seems like the most obvious approach.

Jul 2 2018, 9:03 AM
mcorteel added a comment to P2084 T12785 patch.

I didn't even suggest dropping support, I'm merely listing the options to allow both versions to work.
We use a manually patched version of arcanist because it suits our company's use case, but it wouldn't be suitable for a merge in Phabricator's codebase in this state.

Jul 2 2018, 8:39 AM
20after4 edited the content of Community Resources.
Jul 2 2018, 1:05 AM

Jun 29 2018

dwilches added a comment to T5427: Force a line break in a table cell.

@mydeveloperday Thanks! That'll work

Jun 29 2018, 11:32 PM · Remarkup
mydeveloperday added a comment to T5427: Force a line break in a table cell.

@dwilches I needed the same ,just wrote up my solution here

Jun 29 2018, 4:33 PM · Remarkup
DragonBe added a comment to P2084 T12785 patch.

Tough decision to make. Given the fact that most PHP projects are abandoning PHP 5 support is great, but with forcing users to upgrade is not always a good thing, as I'm not sure how this would impact the corporate/enterprise customers.

Jun 29 2018, 11:40 AM
DragonBe awarded T7408: Consider dropping support for older versions of PHP a Like token.
Jun 29 2018, 11:35 AM · Restricted Project, Infrastructure
mcorteel added a comment to P2084 T12785 patch.

@DragonBe Backwards compatibility is broken by this fix. I'm not sure what the phabricator policy is regarding this, but I see two options:

  • Creating another test engine (one for PHPUnit <= 5 and one for PHPUnit > 5)
  • Parsing output differently depending on the PHPUnit version and reuse the old code where needed. This would require a little work to do things properly I guess.
Jun 29 2018, 10:54 AM
aklapper added a comment to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.

In https://phabricator.wikimedia.org/T76732#2803813 ksmith brings up that "In the search bar in the toolbar at the top of the screen, searching for "Maps" brings up Maps as the third option. Searching for "Discovery" brings up Discovery as the second option."

Jun 29 2018, 9:37 AM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search

Jun 28 2018

amckinley created T13162: Diffusion repository status page shows out-of-date messages.
Jun 28 2018, 7:49 PM · Diffusion
20after4 added a comment to T13103: Document favicon customization and validate the "ui.favicons" configuration option.

Can't wait for "connect 2" to come out on playstation six.

Jun 28 2018, 11:53 AM · Files, Aphront, Infrastructure

Jun 27 2018

dwilches added a comment to T5427: Force a line break in a table cell.

Is there a workaround for including a newline in a table's cells? I've tried with both pipe and HTML syntax, and with %%%, triple back-tick and <br> with no success.

Jun 27 2018, 6:30 PM · Remarkup
dwilches awarded T5427: Force a line break in a table cell a Like token.
Jun 27 2018, 6:28 PM · Remarkup
epriestley updated the task description for T13151: Plans: 2018 Week 23 - Week 30 Bonus Content.
Jun 27 2018, 6:02 PM · Plans
epriestley updated the task description for T13151: Plans: 2018 Week 23 - Week 30 Bonus Content.
Jun 27 2018, 6:02 PM · Plans
epriestley added a revision to T13151: Plans: 2018 Week 23 - Week 30 Bonus Content: Unknown Object (Differential Revision).
Jun 27 2018, 5:55 PM · Plans
epriestley updated the task description for T13151: Plans: 2018 Week 23 - Week 30 Bonus Content.
Jun 27 2018, 5:47 PM · Plans
epriestley added a revision to T13151: Plans: 2018 Week 23 - Week 30 Bonus Content: Restricted Differential Revision.
Jun 27 2018, 5:46 PM · Plans
epriestley added a revision to T13151: Plans: 2018 Week 23 - Week 30 Bonus Content: Unknown Object (Differential Revision).
Jun 27 2018, 5:02 PM · Plans
epriestley updated the task description for T13151: Plans: 2018 Week 23 - Week 30 Bonus Content.
Jun 27 2018, 4:35 PM · Plans
scp awarded T12996: Parallelize substages of `arc diff` a Love token.
Jun 27 2018, 4:20 PM · Arcanist
epriestley added a comment to T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`.

PHI781 asks for [ ] Show on commit message template. for "Maniphest Tasks:".

Jun 27 2018, 3:57 PM · Restricted Project, Restricted Project, Custom Fields