Page MenuHomePhabricator
Feed All Stories

May 5 2017

amckinley claimed T12626: Update Pholio for Modular Transactions.
May 5 2017, 1:22 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request

May 4 2017

amckinley added a revision to T12623: Update Slowvote for Modular Transactions: Unknown Object (Differential Revision).
May 4 2017, 11:45 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley added a comment to T12674: Update developer docs to include rCORGI setup.

test 2

May 4 2017, 11:44 PM
epriestley closed T12546: "bin/remote deploy" picks up deployment keys locally instead of on the bastion as Resolved by committing Restricted Diffusion Commit.
May 4 2017, 10:29 PM · Ops, Infrastructure, Phacility
chad claimed T12625: Update Phriction for Modular Transactions.
May 4 2017, 9:42 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley added a comment to P2047 DifferentialSetBaseCommitConduitAPIMethod.php.

For mention purposes, see also T12618.

May 4 2017, 8:01 PM · Customer Impact
epriestley added a comment to P2047 DifferentialSetBaseCommitConduitAPIMethod.php.
NOTE: Anyone who can see a diff can call this method to mutate it. Diffs are normally immutable after creation, so they don't have an edit policy which we can check for.
May 4 2017, 8:00 PM · Customer Impact
epriestley created P2047 DifferentialSetBaseCommitConduitAPIMethod.php.
May 4 2017, 7:59 PM · Customer Impact
chad updated the task description for T10448: Modularize mail tags.
May 4 2017, 7:01 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad closed T12672: Update Countdown for Modular Transactions, a subtask of T10448: Modularize mail tags, as Resolved.
May 4 2017, 7:01 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad closed T12672: Update Countdown for Modular Transactions as Resolved.
May 4 2017, 7:01 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad added a comment to T12672: Update Countdown for Modular Transactions.

derp this is done.

May 4 2017, 7:01 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
amckinley closed T12589: Add yourself to corporate website /about/ as Resolved by committing Restricted Diffusion Commit.
May 4 2017, 6:46 PM · Public & Media Relations
amckinley created T12674: Update developer docs to include rCORGI setup.
May 4 2017, 6:25 PM
amckinley added a revision to T12589: Add yourself to corporate website /about/: Unknown Object (Differential Revision).
May 4 2017, 6:23 PM · Public & Media Relations
chad created T12673: Update Projects for Modular Transactions.
May 4 2017, 5:16 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad created T12672: Update Countdown for Modular Transactions.
May 4 2017, 5:15 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad created T12671: Update Maniphest for modular transactions.
May 4 2017, 5:15 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad updated the task description for T10448: Modularize mail tags.
May 4 2017, 5:04 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad updated the task description for T10448: Modularize mail tags.
May 4 2017, 5:03 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley closed T12669: differential.revision.search doesn't return the reviewers. as Resolved.

Sounds good, let us know if you run into issues.

May 4 2017, 4:34 PM · Bug Report
chad added a comment to T12670: Workboard action UI needs improvements.

or vue

May 4 2017, 4:24 PM · Customer Impact, Design, Workboards
chad added a comment to T12670: Workboard action UI needs improvements.

good time to learn react

May 4 2017, 4:23 PM · Customer Impact, Design, Workboards
chad added a comment to T12670: Workboard action UI needs improvements.

It's a day of re-thinking the entire UI for me. I don't want to shoe-horn stuff in.

May 4 2017, 4:23 PM · Customer Impact, Design, Workboards
epriestley added a project to T12670: Workboard action UI needs improvements: Customer Impact.

From blame, it looks like D15278 originally stuffed these and some other things into a bit of a weird place -- I think we had some other problems with too much stuff in dropdowns at the time, and that was sort of a "shove this stuff under a rug for now" change? But I don't really remember.

May 4 2017, 4:22 PM · Customer Impact, Design, Workboards
cos added a comment to T12669: differential.revision.search doesn't return the reviewers..

thanks - I'll upgrade!

May 4 2017, 4:21 PM · Bug Report
epriestley added a comment to T12670: Workboard action UI needs improvements.

T.T

May 4 2017, 4:19 PM · Customer Impact, Design, Workboards
chad updated subscribers of T12670: Workboard action UI needs improvements.

Too slow @epriestley

May 4 2017, 4:18 PM · Customer Impact, Design, Workboards
chad created T12670: Workboard action UI needs improvements.
May 4 2017, 4:17 PM · Customer Impact, Design, Workboards
epriestley added a comment to T12669: differential.revision.search doesn't return the reviewers..

You should be able to use the "reviewers" attachment to get reviewer information. Here's an example of a query which asks for this attachment, and a response which includes it:

May 4 2017, 3:40 PM · Bug Report
cos created T12669: differential.revision.search doesn't return the reviewers..
May 4 2017, 2:54 PM · Bug Report
cos added a comment to T12588: create subtask side menu to allow creation of subtasks of different types to the parent task.

thanks - we'll give this a go. It's not clear how often people will need to use this so I agree with your concern about UI clutter.

May 4 2017, 2:47 PM · Feature Request
richardvanvelzen updated the language for P2046 D17819-#215382.diff from autodetect to diff.
May 4 2017, 2:40 PM
richardvanvelzen edited P2046 D17819-#215382.diff.
May 4 2017, 2:40 PM
epriestley added a comment to T12616: Modernize display code for inline comments.

Just some notes for myself:

May 4 2017, 2:25 PM · Inline Comments
richardvanvelzen edited P2046 D17819-#215382.diff.
May 4 2017, 2:14 PM
epriestley moved T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does) from Backlog to Requests on the Customer Impact board.
May 4 2017, 1:34 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley moved T12658: Make it more clear what renaming a user does and doesn't affect from Backlog to Active Impact on the Customer Impact board.
May 4 2017, 1:33 PM · Customer Impact, Feature Request
epriestley moved T12668: "arc help land" says "current branch", but means "branch targeted by the land operation" from Backlog to Active Impact on the Customer Impact board.
May 4 2017, 1:33 PM · Arcanist
backstageel awarded T5051: Burn down charts for Milestones a Love token.
May 4 2017, 12:22 PM · Restricted Project, Wikimedia, Projects
mirage315 updated Q614: Does notification server has some ring tone when message pop up? from Does notification server has some ring tone when message popup? to Does notification server has some ring tone when message pop up?.
May 4 2017, 5:53 AM · Notifications
mirage315 updated Q614: Does notification server has some ring tone when message pop up? from to Does notification server has some ring tone when message popup?.
May 4 2017, 5:49 AM · Notifications
epriestley created T12668: "arc help land" says "current branch", but means "branch targeted by the land operation".
May 4 2017, 4:34 AM · Arcanist
wjiang added a revision to T12667: Let default parameters linter rule support `...` in variadic function: Unknown Object (Differential Revision).
May 4 2017, 2:12 AM · Feature Request
wjiang created T12667: Let default parameters linter rule support `...` in variadic function.
May 4 2017, 2:10 AM · Feature Request
amckinley added a comment to T11476: Record transaction histories when users edit application capabilities.

This still needs another transaction type for installations/uninstallations; diff coming soon.

May 4 2017, 12:53 AM · Contributor Onboarding, Restricted Project, Applications, Feature Request

May 3 2017

amckinley merged T12666: Make Conpherence sidebar show unread counts into T7332: Notification / Message icons should update in real-time.
May 3 2017, 11:54 PM · Conpherence (v4), Aphlict, Notifications
amckinley merged task T12666: Make Conpherence sidebar show unread counts into T7332: Notification / Message icons should update in real-time.
May 3 2017, 11:54 PM · Conpherence, Feature Request
epriestley added a comment to T12666: Make Conpherence sidebar show unread counts.

Probably just a flavor of T7332? I think the non-realtime counts (e.g., after page load) have been accurate for me.

May 3 2017, 8:12 PM · Conpherence, Feature Request
epriestley added a comment to T9577: Why do workboards have story point displays and limits if there's no way to customize the size of a card?.

Yes, see maniphest.points in Config.

May 3 2017, 7:56 PM · Workboards
lmiller287 added a comment to T9577: Why do workboards have story point displays and limits if there's no way to customize the size of a card?.

Was this feature ever delivered? Just looking to hop on the right thread in regards to setting up variable task point values

May 3 2017, 7:52 PM · Workboards
chad added a comment to T12666: Make Conpherence sidebar show unread counts.

It should, just not real time.

May 3 2017, 6:40 PM · Conpherence, Feature Request
amckinley created T12666: Make Conpherence sidebar show unread counts.
May 3 2017, 6:38 PM · Conpherence, Feature Request
epriestley added a comment to T3498: Allow ignore whitespace in Audit/Diffusion diffs.

Yes, this will be implemented.

May 3 2017, 5:59 PM · Diffusion
joineral32 added a comment to T3498: Allow ignore whitespace in Audit/Diffusion diffs.

Is there any chance this will ever get implemented? The lack of this feature makes our lives a lot harder, and it's a highly ubiquitous feature (GitLab, GitHub, BitBucket, Gerrit, etc. all have it). We're trying to modernize a very old codebase, and any time anybody auto-formats a file to match our standard, Phabricator's diffs become completely useless. This wouldn't be a problem if we were using any other tool.

May 3 2017, 5:58 PM · Diffusion
epriestley added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

Also, just so I don't completely forget about it:

May 3 2017, 5:25 PM · XHPAST
epriestley added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

Changes in D17802, D17803, D17816 and D17817 all seem generally fine to me from cursory inspection. If D17819 seems sane for fixing the "huge blobs of unstable JSON" problem, let's stick them all on that, I'll take a closer look at the nodes, and we can get everything in? Good luck racing each other on minor version numbers.

May 3 2017, 5:24 PM · XHPAST
epriestley added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Restricted Differential Revision.
May 3 2017, 5:09 PM · XHPAST
epriestley added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
May 3 2017, 5:07 PM · XHPAST
chad added a comment to T12665: Color the whole area of a task in order to differentiate tasks under a same column.

ok, I'll add the request to T10293

May 3 2017, 1:58 PM · Feature Request
chad updated the task description for T10293: Plan rest of "CoverImage" feature.
May 3 2017, 1:58 PM · Workboards, Projects (v3)
chad merged T12665: Color the whole area of a task in order to differentiate tasks under a same column into T10293: Plan rest of "CoverImage" feature.
May 3 2017, 1:57 PM · Workboards, Projects (v3)
chad merged task T12665: Color the whole area of a task in order to differentiate tasks under a same column into T10293: Plan rest of "CoverImage" feature.
May 3 2017, 1:57 PM · Feature Request
RikiWiki added a comment to T12665: Color the whole area of a task in order to differentiate tasks under a same column.

ok, thank you very much as usual. Just one thing: i don´t see it as a design request, but as a feature to have categories cross-column.

May 3 2017, 1:50 PM · Feature Request
chad added a comment to T12665: Color the whole area of a task in order to differentiate tasks under a same column.

(You are always welcome to fork Phabricator to provide specific needs to your team)

May 3 2017, 1:43 PM · Feature Request
chad added a comment to T12665: Color the whole area of a task in order to differentiate tasks under a same column.

See Contributing Feature Requests and Describing Root Problems for what information is required on a feature request. We unfortunately do not take design suggestions as requests.

May 3 2017, 1:43 PM · Feature Request
chad closed T12665: Color the whole area of a task in order to differentiate tasks under a same column as Invalid.
May 3 2017, 1:39 PM · Feature Request
joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
May 3 2017, 12:00 PM · XHPAST
joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
May 3 2017, 11:42 AM · XHPAST
holysoros edited the content of Organizations Using Phabricator.
May 3 2017, 10:43 AM
holysoros edited the content of Organizations Using Phabricator.
May 3 2017, 10:42 AM
RikiWiki updated the task description for T12665: Color the whole area of a task in order to differentiate tasks under a same column.
May 3 2017, 7:49 AM · Feature Request
RikiWiki created T12665: Color the whole area of a task in order to differentiate tasks under a same column.
May 3 2017, 7:45 AM · Feature Request
epriestley added a comment to T10448: Modularize mail tags.

Yeah, that directly helps with this. I think I have a pretty good plan for the actual mail part that isn't too crazy complicated, but the cutover/migration bit will be much simpler/smoother if we get things swapped over -- at least, most of the way -- ahead of this.

May 3 2017, 2:51 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad added a comment to T10448: Modularize mail tags.

Just to clarify, it is good to be moving all the apps to modular transactions? This task is my primary motivator to cleaning that up.

May 3 2017, 2:45 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request

May 2 2017

20after4 awarded T12003: Explain to users how fulltext queries are parsed and executed a Love token.
May 2 2017, 9:27 PM · Search
chad added a comment to T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000.

56174329.jpg (508×914 px, 46 KB)

May 2 2017, 8:11 PM · Inline Comments, Differential, Bug Report
epriestley added a comment to T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000.

I'm thinking about resolving this by having three states instead:

May 2 2017, 6:48 PM · Inline Comments, Differential, Bug Report
johnny-bit added a comment to T12655: ArcanistTextLinter: Detect trailing tabs.

@epriestley - I have "almost" ready test suite, hovewer I can't work out line ending test with CR/LF endings. - D17814

May 2 2017, 5:51 PM · Lint, Bug Report
johnny-bit added a revision to T12655: ArcanistTextLinter: Detect trailing tabs: Unknown Object (Differential Revision).
May 2 2017, 5:49 PM · Lint, Bug Report
epriestley updated the task description for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:12 PM · Arcanist, Differential
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T8647: Arc Patch does not patch images.
May 2 2017, 5:02 PM · Arcanist, Differential
epriestley added a parent task for T8647: Arc Patch does not patch images: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:02 PM · Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T6157: Failing to parse patch with binary delta.
May 2 2017, 5:01 PM · Arcanist, Differential
epriestley added a parent task for T6157: Failing to parse patch with binary delta: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:01 PM · Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T6094: Arc patch fails with 'inconsistent old filename on line NNN'.
May 2 2017, 5:01 PM · Arcanist, Differential
epriestley added a parent task for T6094: Arc patch fails with 'inconsistent old filename on line NNN': T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:01 PM · Arcanist
epriestley added a parent task for T9069: arc patch can't handle binary file correctly: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:01 PM · Differential, Restricted Project, Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T9069: arc patch can't handle binary file correctly.
May 2 2017, 5:01 PM · Arcanist, Differential
epriestley added a parent task for T4977: arc patch fails even when cherry pick appears successful: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:00 PM · Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T4977: arc patch fails even when cherry pick appears successful.
May 2 2017, 5:00 PM · Arcanist, Differential
epriestley added a parent task for T1022: arc patch fails to properly apply a patch which changes a symlink to a real file: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:00 PM · Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T1022: arc patch fails to properly apply a patch which changes a symlink to a real file.
May 2 2017, 5:00 PM · Arcanist, Differential
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously.
May 2 2017, 5:00 PM · Arcanist, Differential
epriestley added a parent task for T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:00 PM · Subversion, Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T11570: `arc patch` download empty binary file from hosted svn repository.
May 2 2017, 5:00 PM · Arcanist, Differential
epriestley added a parent task for T11570: `arc patch` download empty binary file from hosted svn repository: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:00 PM · Arcanist, Bug Report
epriestley closed T11635: tagging a differential revision with a milestone breaks `arc diff` as Resolved.

I think this was fixed by T12659 -- yell if you're still seeing issues?

May 2 2017, 4:59 PM · Restricted Project, Arcanist, Bug Report
epriestley added a parent task for T8768: Under Mercurial, `arc patch` mishandles files with spaces in them : T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:58 PM · Git, Mercurial, Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .
May 2 2017, 4:58 PM · Arcanist, Differential