Page MenuHomePhabricator

Failing to parse patch with binary delta
Open, WishlistPublic

Description

https://github.com/facebook/hhvm/pull/3805.patch has as part of it:

diff --git a/hphp/test/slow/object_property/invalidWith__get.php.expectf b/hphp/test/slow/object_property/invalidWith__get.php.expectf
index 033c3ac88947362c4227a3ae44d556d5d2665ef0..0dd4757a6bbe6cd99b57f092f3a5e69a4158fce3 100644
GIT binary patch
delta 21
ccmey(*vd4agxfi>Bsn87DJNASZDMH~09UpM8~^|S

delta 11
ScmZo=`pr0@gwbtceH#E7tpsHN

And when parsing it I'm getting Expected 'literal NNNN' to start git binary patch.

Your code looks like it isn't happy with the word delta and instead wants only literal.

Event Timeline

ptarjan created this task.Sep 22 2014, 9:52 AM
ptarjan raised the priority of this task from to Needs Triage.
ptarjan updated the task description. (Show Details)
ptarjan added a subscriber: ptarjan.
chad added a subscriber: chad.
epriestley triaged this task as Wishlist priority.Oct 2 2014, 7:45 PM
epriestley added a subscriber: epriestley.

We haven't seen other requests for this yet.

epriestley moved this task from Backlog to arc patch on the Arcanist board.Feb 11 2016, 6:33 PM