Page MenuHomePhabricator
Feed All Stories

Mar 7 2017

avivey added a comment to T12279: Timezone Asia/Jerusalem incorrectly listed under UTC-0.

I wouldn't expect anything in the logs; You can try running a script and running something like this:

$d = new DateTimeZone("Asia/Jerusalem");
var_dump($d->getOffset(new DateTime('@'.time())));

IF you're getting back FALSE, then it's definitely this.

Mar 7 2017, 10:21 AM · Bug Report
cinek added a comment to T12362: PhrequentSearchEngine missing in Dashboards.

Hooray!

Mar 7 2017, 10:11 AM · Dashboards, Phrequent, Bug Report
20after4 added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

@ksmith: Thanks to the new 'favorites' menu, each user can customize their menu, there is no longer a global 'create new' menu, as it's been replaced.

Mar 7 2017, 9:43 AM · EditEngine, Maniphest, Custom Fields, Feature Request
fooishbar awarded T12314: Support formal task subtypes (like "bug" vs "feature") a Mountain of Wealth token.
Mar 7 2017, 9:25 AM · EditEngine, Maniphest, Custom Fields, Feature Request
johnny-bit added a comment to T12362: PhrequentSearchEngine missing in Dashboards.

This was fixed in rPb28da10336ca 😄

Mar 7 2017, 9:18 AM · Dashboards, Phrequent, Bug Report
cinek created T12362: PhrequentSearchEngine missing in Dashboards.
Mar 7 2017, 9:03 AM · Dashboards, Phrequent, Bug Report
bcorcoran added a comment to T12360: PhabricatorDataNotAttachedException on /people/commits/ID/.

Beautiful and timely fix. Thanks!

Mar 7 2017, 5:05 AM · Diffusion, People, Bug Report
bcorcoran awarded T12360: PhabricatorDataNotAttachedException on /people/commits/ID/ a Like token.
Mar 7 2017, 4:56 AM · Diffusion, People, Bug Report
chad edited the content of Developer Setup.
Mar 7 2017, 2:24 AM
chad edited the content of Developer Setup.
Mar 7 2017, 2:24 AM
chad added a project to T12356: Calendar Notification is not respecting my Time Zone Settings: Calendar.
Mar 7 2017, 2:16 AM · Calendar, Bug Report
chad closed T12361: Test as Spite.
Mar 7 2017, 1:59 AM · Feature Request
• ahn.jihyun created T12361: Test.
Mar 7 2017, 1:35 AM · Feature Request
chad closed T12360: PhabricatorDataNotAttachedException on /people/commits/ID/ as Resolved by committing Restricted Diffusion Commit.
Mar 7 2017, 1:24 AM · Diffusion, People, Bug Report
chad added a revision to T12360: PhabricatorDataNotAttachedException on /people/commits/ID/: Unknown Object (Differential Revision).
Mar 7 2017, 12:44 AM · Diffusion, People, Bug Report
chad claimed T12360: PhabricatorDataNotAttachedException on /people/commits/ID/.
Mar 7 2017, 12:43 AM · Diffusion, People, Bug Report
zhiyuchen added a comment to T12279: Timezone Asia/Jerusalem incorrectly listed under UTC-0.

@avivey Thanks! my php version is PHP 5.5.9, would you recommend upgrading? I didn't find anything in my php error log though, any suggestion where else I could look into to find out the cause?

Mar 7 2017, 12:18 AM · Bug Report

Mar 6 2017

bcorcoran created T12360: PhabricatorDataNotAttachedException on /people/commits/ID/.
Mar 6 2017, 11:28 PM · Diffusion, People, Bug Report
ksmith added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

Our phabricator instance (WMF) is shared by many(!) different projects and teams. If I understand the current proposal, all the subtypes and forms would be available to all users across all teams and projects, except where specific access is limited (e.g. security issues). I think that forces us to either: a) have very few subtypes, which manage to achieve consensus, or b) have a lot of subtypes, which would mean that everyone's "create new" menu would be very cluttered.

Mar 6 2017, 11:25 PM · EditEngine, Maniphest, Custom Fields, Feature Request
chad changed the edit policy for Cowboy Commits.
Mar 6 2017, 9:44 PM
eliaspro added a comment to T5380: Better handling of anchored links in Phriction.

I'd love to see anchor indicators when hovering headings.

Mar 6 2017, 9:38 PM · Remarkup, Phriction
johnny-bit added a comment to T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.

You guys fast.

Mar 6 2017, 9:13 PM · Dashboards, Bug Report
chad added a comment to T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.

I fixed that hours ago.

Mar 6 2017, 8:45 PM · Dashboards, Bug Report
johnny-bit added a comment to T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.

Hi! I think I've hit similar issue, but for another type of panel. We've used to use PhrequentSearchEngine panel to show phrequent/query/tracking/ (Currently tracking), which apparently got removed in D17341. Currently tracking on main dashboard was quite interesting indicator for current work aaand could be fun until phrequent gets more useul 😄

Mar 6 2017, 8:37 PM · Dashboards, Bug Report
epriestley closed T12359: Registration does not accept valid email addresses as Wontfix.

You can adjust the validation here:

Mar 6 2017, 8:24 PM · Bug Report
lambdafu added a comment to T3179: Importing data from external systems (like GitHub, JIRA, Trac, Asana, Trello, etc.).

I have written a couple of scripts to semi-automatically convert trac ("done") and roundup (WIP) to phabricator. The included patch based on D10754 but extended does quite a good job at faking timestamps even for subtasks and notifications etc, but the whole thing is neither complete nor bullet-proof or even convenient. Good enough for people who don't mind to get their hands dirty: https://github.com/lambdafu/phabricator-test

Mar 6 2017, 8:22 PM · Guides, Doorkeeper
lambdafu updated the task description for T12359: Registration does not accept valid email addresses.
Mar 6 2017, 8:17 PM · Bug Report
lambdafu created T12359: Registration does not accept valid email addresses.
Mar 6 2017, 8:13 PM · Bug Report
alexmv updated the task description for T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.
Mar 6 2017, 7:23 PM · Installing & Upgrading, Differential
chad updated the task description for T12270: Unbeta Badges.
Mar 6 2017, 7:02 PM · Badges (v0)
chad added a revision to T12270: Unbeta Badges: Unknown Object (Differential Revision).
Mar 6 2017, 6:08 PM · Badges (v0)
chad added a comment to T12357: Remarkup: **bold** effect in Header section is not discernible.

I went with a different color, but we could also do text-shadow or a background-color... lmk if this seems bad in practice.

Mar 6 2017, 5:37 PM · Remarkup, Bug Report
chad closed T12357: Remarkup: **bold** effect in Header section is not discernible as Resolved by committing Restricted Diffusion Commit.
Mar 6 2017, 5:28 PM · Remarkup, Bug Report
epriestley added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

I think that's right, yes.

Mar 6 2017, 5:28 PM · Installing & Upgrading, Differential
epriestley added a comment to T12337: Provide conduit access to related tasks and in particular 'mentions'.

Users do count, but I thiiiiiink user mentions are a special kind of mention because they have more complicated rules and you can't read them with edge.search today. T4654 discusses better rules around "notify me when I'm mentioned"; there are some related Conpherence-specific tasks too.

Mar 6 2017, 5:23 PM · Feature Request
epriestley closed T12358: Not secure generating as Invalid.

Sometimes, Apache is configured with a rule which prevents any access to any URL which contains /..

Mar 6 2017, 5:15 PM · Bug Report
chad added a revision to T12357: Remarkup: **bold** effect in Header section is not discernible: Unknown Object (Differential Revision).
Mar 6 2017, 3:58 PM · Remarkup, Bug Report
chad added a comment to T12357: Remarkup: **bold** effect in Header section is not discernible.
In T12357#214422, @chad wrote:

What would you suggest as a fix?

Mar 6 2017, 3:31 PM · Remarkup, Bug Report
chad added a comment to T12357: Remarkup: **bold** effect in Header section is not discernible.

What would you suggest as a fix?

Mar 6 2017, 3:26 PM · Remarkup, Bug Report
chad added a comment to T12358: Not secure generating.

This is not a bug. If you feel this is a security issue, please file an appropriate task on HackerOne. https://hackerone.com/phabricator

Mar 6 2017, 3:17 PM · Bug Report
d.mulyavko created T12358: Not secure generating.
Mar 6 2017, 3:12 PM · Bug Report
avivey added a comment to T12356: Calendar Notification is not respecting my Time Zone Settings.

I would argue that at least for email ("External Targets"), we should always include the timezone when rendering times. When we allowed custom time-format, I've also added it there (Partly because there wasn't the time-zone warning we have now, partly because I kept my phabricator config to PST when traveling, and partly to make copying the time easier).

Mar 6 2017, 10:38 AM · Calendar, Bug Report
avivey renamed T12357: Remarkup: **bold** effect in Header section is not discernible from Display bold text with a different color in titles to Remarkup: **bold** effect in Header section is not discernible.
Mar 6 2017, 10:31 AM · Remarkup, Bug Report
mcorteel created T12357: Remarkup: **bold** effect in Header section is not discernible.
Mar 6 2017, 10:23 AM · Remarkup, Bug Report
borna.emami added Q117: Is there a way to bulk accept audits? (Answer 523).
Mar 6 2017, 10:11 AM
alexmv added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

The table in the description references a getConduitFieldKey method – which I can't find reference to ever existing in the source. Was that supposed to be getFieldKeyForConduit?

Mar 6 2017, 7:15 AM · Installing & Upgrading, Differential
friesenschrauber created T12356: Calendar Notification is not respecting my Time Zone Settings.
Mar 6 2017, 6:58 AM · Calendar, Bug Report
20after4 added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

Weakness: Subtyping is Probably Only Useful in Maniphest

Subtyping is likely to involve a large number of changes in shared infrastructure (EditEngine), but they will probably only ever be useful in Maniphest. Although most applications now use EditEngine, I can't really come up with any good use cases for subtyping in other applications. Perhaps Calendar could use subtyping on events, but this feels like a solution searching for a problem.

Mar 6 2017, 12:44 AM · EditEngine, Maniphest, Custom Fields, Feature Request
20after4 added a comment to T12337: Provide conduit access to related tasks and in particular 'mentions'.

I don't suppose users count as objects in this context? I'd love to have a way to be notified of new @mentions for my username. A client app that queries conduit occasionally and sends me desktop notifications, well, that would just be super cool.

Mar 6 2017, 12:33 AM · Feature Request
20after4 awarded T12337: Provide conduit access to related tasks and in particular 'mentions' a Mountain of Wealth token.
Mar 6 2017, 12:29 AM · Feature Request
20after4 added a comment to T12353: Convert PhabricatorSearchDocumentQuery to cursor based paging.

I agree that results should almost always be on the first page and ideally near the top of the first page. I'm also tempted to say that 10 results per page might be closer to the right number than 100.

Mar 6 2017, 12:28 AM · Elasticsearch, Wikimedia, Search

Mar 5 2017

eliaspro added a comment to T9363: improve handling of panels that do not always return results.

While the number (>0) of query results would decide whether a given panel is shown or not, also exposing the actual number of results would be IMHO interesting in the context of tabbed panels, so that each tab title could be shown as demonstrated in the mock-up below (please excuse my non-designer-ish CSS skills):

Mar 5 2017, 10:46 PM · Dashboards (v2), ApplicationSearch, Restricted Project, Restricted Project
eliaspro added a comment to T6532: Support "Login As" functionality for Administrators.

I agree with the general understanding of Adminstrators not being in absolute power.
But then again, it would be useful to be able to have a way to test the effective policies applied to a given user.

Mar 5 2017, 9:54 PM
eliaspro added a comment to T12355: Daemons are having a rough time starting on `admin`.

In terms of application/code stability, it would be good to handle this properly.

Mar 5 2017, 9:02 PM · Phacility, Daemons, Ops
eadler closed D17468: Remove the the duplicate words.
Mar 5 2017, 6:37 PM
epriestley accepted D17468: Remove the the duplicate words.

courageous 🎆

Mar 5 2017, 6:12 PM
eadler created D17468: Remove the the duplicate words.
Mar 5 2017, 5:56 PM
chad updated subscribers of T10319: Generate unique? profile images for each new user.

True story, I built these because of @jmeador

Mar 5 2017, 5:05 PM · Feature Request, People
epriestley added a comment to T10319: Generate unique? profile images for each new user.

I dropped the cache, looks like they're working.

Mar 5 2017, 5:01 PM · Feature Request, People
chad added a comment to T10319: Generate unique? profile images for each new user.

I presume these will pop in as cache expires?

Mar 5 2017, 4:29 PM · Feature Request, People
chad added a comment to T10319: Generate unique? profile images for each new user.

rolling.

Mar 5 2017, 4:26 PM · Feature Request, People
chad closed T10319: Generate unique? profile images for each new user as Resolved by committing Restricted Diffusion Commit.
Mar 5 2017, 4:25 PM · Feature Request, People
epriestley added a comment to T12355: Daemons are having a rough time starting on `admin`.

Specifically, I suspect it won't affect repo because db restarts separately, so the database won't be unavailable when daemons on repo restart.

Mar 5 2017, 12:32 PM · Phacility, Daemons, Ops
epriestley added a comment to T12355: Daemons are having a rough time starting on `admin`.

It looks like this might be an issue with MySQL not being available yet when the daemons start. The deployment script restarts MySQL, then immediately restarts the daemons, and a bunch of this stuff is ending up in the log in the 1-2 seconds after the restart:

Mar 5 2017, 12:32 PM · Phacility, Daemons, Ops
epriestley added a project to T12355: Daemons are having a rough time starting on `admin`: Phacility.
Mar 5 2017, 12:24 PM · Phacility, Daemons, Ops
epriestley created T12355: Daemons are having a rough time starting on `admin`.
Mar 5 2017, 12:24 PM · Phacility, Daemons, Ops
epriestley added a comment to T12353: Convert PhabricatorSearchDocumentQuery to cursor based paging.

I believe that's unavoidable with offset-based paging (the solution is to switch to cursor-based paging, but I think we can't do that for fulltext).

Mar 5 2017, 12:18 PM · Elasticsearch, Wikimedia, Search
20after4 added a comment to T12353: Convert PhabricatorSearchDocumentQuery to cursor based paging.

I'll investigate further into the slowness (I wasn't involved in the debugging so far so I don't know more than what's said in the task)

Mar 5 2017, 11:22 AM · Elasticsearch, Wikimedia, Search
filterfish added a comment to T12349: The language stanza in a code block shouldn't be indexed..

Hrrm, it looks like my reply to your email bounced. Short answer is that we don't offer anything special for academic or open source right now. We'd like to in the future, but are focusing on building our core business first.

Mar 5 2017, 8:43 AM · Bug Report
filterfish added a comment to T12349: The language stanza in a code block shouldn't be indexed..

The document contains "bash". This behavior seems correct to me.

Mar 5 2017, 8:40 AM · Bug Report
constantx edited the content of Organizations Using Phabricator.
Mar 5 2017, 7:35 AM
epriestley edited the content of 2017 Week 9 (Early March).
Mar 5 2017, 2:34 AM
joshuaspence edited the content of 2017 Week 9 (Early March).
Mar 5 2017, 2:24 AM
chad added a revision to T10319: Generate unique? profile images for each new user: Unknown Object (Differential Revision).
Mar 5 2017, 12:36 AM · Feature Request, People
epriestley added a comment to T10319: Generate unique? profile images for each new user.

🍞 🐦

Mar 5 2017, 12:30 AM · Feature Request, People
epriestley added a comment to T10319: Generate unique? profile images for each new user.

fancy 👑

Mar 5 2017, 12:30 AM · Feature Request, People
chad added a comment to T10319: Generate unique? profile images for each new user.

awwyiss

Mar 5 2017, 12:22 AM · Feature Request, People
epriestley added a comment to T10319: Generate unique? profile images for each new user.

I think bin/cache purge --purge-user will do it (but for every user). There's no way to do it for just one user, I don't think.

Mar 5 2017, 12:22 AM · Feature Request, People
epriestley edited the content of Changelog.
Mar 5 2017, 12:19 AM
epriestley created 2017 Week 9 (Early March).
Mar 5 2017, 12:18 AM
chad added a comment to T10319: Generate unique? profile images for each new user.

is there a simple way to reset the cache?

Mar 5 2017, 12:16 AM · Feature Request, People
epriestley added a comment to T12337: Provide conduit access to related tasks and in particular 'mentions'.

I've implemented a new edge.search API method. This method generally works similarly to other *.search API methods:

Mar 5 2017, 12:04 AM · Feature Request

Mar 4 2017

chad added a revision to T10319: Generate unique? profile images for each new user: Unknown Object (Differential Revision).
Mar 4 2017, 11:47 PM · Feature Request, People
epriestley added a revision to T12337: Provide conduit access to related tasks and in particular 'mentions': Restricted Differential Revision.
Mar 4 2017, 11:25 PM · Feature Request
chad added a revision to T10319: Generate unique? profile images for each new user: Unknown Object (Differential Revision).
Mar 4 2017, 9:31 PM · Feature Request, People
epriestley added a comment to T12351: diviner generate book failed.

This should now be fixed in HEAD of master. Thanks for the report!

Mar 4 2017, 6:27 PM · Bug Report
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Mar 4 2017, 6:11 PM · Phage, Infrastructure
epriestley closed T12351: diviner generate book failed as Resolved by committing Restricted Diffusion Commit.
Mar 4 2017, 5:54 PM · Bug Report
epriestley added a revision to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: Unknown Object (Differential Revision).
Mar 4 2017, 5:54 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley added a revision to T12337: Provide conduit access to related tasks and in particular 'mentions': Unknown Object (Differential Revision).
Mar 4 2017, 5:53 PM · Feature Request
epriestley added a revision to T12335: Ability to lock a task to prevent further edits: Unknown Object (Differential Revision).
Mar 4 2017, 4:07 PM · Maniphest, Feature Request
epriestley added a comment to T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald.

Here's the intended behavior from the source:

Mar 4 2017, 3:28 PM · Feature Request
swisspol added a comment to T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald.

Got it thanks. And would a build be triggered by plan changes flag through the web form? Or only with another arc diff call?

Mar 4 2017, 3:17 PM · Feature Request
epriestley added a revision to T12351: diviner generate book failed: Unknown Object (Differential Revision).
Mar 4 2017, 3:17 PM · Bug Report
epriestley added a comment to T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald.

The build system should be able to call Phabricator via Conduit and ask for revision status today if you want a short-term fix.

Mar 4 2017, 3:13 PM · Feature Request
swisspol added a comment to T12350: Add support for "Plan Changes" as a condition for Differential Revision in Herald.

I understand why this may fall under T2543 but this other task appears to be of much bigger scope and take a very long time to be done, while this seems like a minor enhancement. Plan changes is just an attribute of the revision like summary, reviewers, etc... which you can use as conditions in herald, so why not just add it to herald.

Mar 4 2017, 3:03 PM · Feature Request
epriestley added a comment to T12349: The language stanza in a code block shouldn't be indexed..

Hrrm, it looks like my reply to your email bounced. Short answer is that we don't offer anything special for academic or open source right now. We'd like to in the future, but are focusing on building our core business first.

Mar 4 2017, 12:10 PM · Bug Report
epriestley added a comment to T12353: Convert PhabricatorSearchDocumentQuery to cursor based paging.

(That is, the expected failure mode of this query when it fails to scale is "silently return an incomplete result set", not "be really slow".)

Mar 4 2017, 11:51 AM · Elasticsearch, Wikimedia, Search
epriestley added a comment to T12353: Convert PhabricatorSearchDocumentQuery to cursor based paging.

To start with here, let's identify exactly what's slow? It's not clear to me from the downstream task unless I'm just misreading, and not evident to me from reasoning about the behavior of this query. This query strategy is fundamentally not scalable, but I would not expect it to be slow unless the ElasticSearch query is slow.

Mar 4 2017, 11:48 AM · Elasticsearch, Wikimedia, Search
epriestley closed T12354: testing as Invalid.
Mar 4 2017, 11:43 AM · Feature Request