Page MenuHomePhabricator
Create Task
Maniphest T12349

The language stanza in a code block shouldn't be indexed.
Closed, WontfixPublic
Actions

Description

I use the language stanza in code blocks (eg bash) and I've noticed that if I search for bash the results will include "documents" that contain lang=bash.

For example this task, once it's been created, will be return if I search for the r u b y (without the spaces!)

def sum(array)
  array.inject(:+)
end

I'm using mysql indexing. I'm using the latest stable branch with versions:

arcanistrARC822bc53ca306e06314560d8a76f68771d732e8e0
libphutilrPHU76983f49b179e575187c7dc5098cd1fbfac300c7
phabricatorrP216f6be11ece53cb1daafc8fff636dbdb0d7ef3d
mysql5.5.52
php5.6.24

And yes, I did re-index after upgrading to the latest version!

Event Timeline

filterfish created this task.Mar 4 2017, 2:56 AM
filterfish added a comment.Mar 4 2017, 2:59 AM

This is the search that shows the problem: https://secure.phabricator.com/search/query/lOkcMy6H_Jmk/#R

epriestley closed this task as Wontfix.Mar 4 2017, 3:53 AM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

The document contains "bash". This behavior seems correct to me.

epriestley added a comment.Mar 4 2017, 12:10 PM

Hrrm, it looks like my reply to your email bounced. Short answer is that we don't offer anything special for academic or open source right now. We'd like to in the future, but are focusing on building our core business first.

filterfish added a comment.Mar 5 2017, 8:40 AM
In T12349#214207, @epriestley wrote:

The document contains "bash". This behavior seems correct to me.

The document doesn't contain the word bash; the metadata contains the word bash. Indexing the metadata is like indexing the elements in an html document, if I search for "body" I don't want to see every single document.

filterfish added a comment.Mar 5 2017, 8:43 AM
In T12349#214295, @epriestley wrote:

Hrrm, it looks like my reply to your email bounced. Short answer is that we don't offer anything special for academic or open source right now. We'd like to in the future, but are focusing on building our core business first.

That's odd. I do use greylisting but that shouldn't effect anything and I get the automatic emails from noreply@phabricator.com. Anyway thanks for getting back to me and it makes sense that you are focusing on your core business.

Phabricator · Built by Phacility