Page MenuHomePhabricator
Feed All Stories

Jan 11 2017

epriestley resigned from D1105: Initialize immediately, throw when accessing node data before merge..

iiam

Jan 11 2017, 3:33 PM
epriestley closed T11551: Conduit API "project.create" return error with ERR-CONDUIT-CORE when only "name" passed as parameter as Wontfix.

We've formally frozen this method after D17158. The UI now encourages project.edit.

Jan 11 2017, 3:31 PM · Restricted Project, Conduit, Bug Report
GustavHeinz created T12095: Differential reads and writes draft status to different tables, leading to various UI inconsistencies.
Jan 11 2017, 2:24 PM · Differential, Bug Report
avivey closed T10393: Differential revision's images cannot be viewed as raw files as Resolved.

Can't reproduce this - assuming fixed?

Jan 11 2017, 10:53 AM · Restricted Project, Differential, Files, Bug Report
avivey added a comment to T12094: Upgrade from Jun 18 2014.

(Note that this kind of requests are normally not supported - see Support Resources. This is not likely a bug in Phabricator).

Jan 11 2017, 10:41 AM · Support Request
avivey edited projects for T12094: Upgrade from Jun 18 2014, added: Support Request; removed Bug Report.

The order of stopping/starting daemons/webserver isn't important, as long as both are down during the upgrade.

Jan 11 2017, 10:36 AM · Support Request
avivey updated the task description for T12094: Upgrade from Jun 18 2014.
Jan 11 2017, 10:20 AM · Support Request
avivey updated the task description for T12094: Upgrade from Jun 18 2014.
Jan 11 2017, 10:18 AM · Support Request
n3v3rf411 edited the content of Organizations Using Phabricator.
Jan 11 2017, 10:08 AM
Coul created T12094: Upgrade from Jun 18 2014.
Jan 11 2017, 9:35 AM · Support Request
chad closed T12093: Bypass "need review" for a specific folder as Invalid.

This doesn't appear to be a feature request or bug report, so closing out. If you need support with Phabricator, please see Support Resources.

Jan 11 2017, 4:36 AM · Feature Request
yliu120 created T12093: Bypass "need review" for a specific folder.
Jan 11 2017, 3:33 AM · Feature Request

Jan 10 2017

bcooksley added a project to T9383: Support `git notes`: KDE.

Some parts of KDE use git notes fairly extensively for certain specific workflows.
How difficult would it be to have Phabricator permit pushing Notes, even if Phabricator itself didn't do much with them (doesn't need to display them)?

Jan 10 2017, 11:12 PM · KDE, Git, Diffusion
epriestley added a comment to T12092: conduit.querydiffs generates error when optional `id` argument is empty.

Intentional; see T12026 and T12027.

Jan 10 2017, 10:00 PM · Bug Report
rbalik added a comment to T12092: conduit.querydiffs generates error when optional `id` argument is empty.

Thanks a lot for the quick fix here. Works great now. Was the change to get rid of potential arc commands in the Diffusion review intentional or is that also a bug?

Jan 10 2017, 9:51 PM · Bug Report
epriestley closed T12089: New red/green highlight colors are incorrect for added or removed new lines as Resolved.

Presumably resolved by D17171?

Jan 10 2017, 9:48 PM · Design, Differential
epriestley added a comment to T12092: conduit.querydiffs generates error when optional `id` argument is empty.

Thanks for the report. This should be resolved at HEAD of master. Let us know if you run into anything else.

Jan 10 2017, 9:48 PM · Bug Report
epriestley closed T12092: conduit.querydiffs generates error when optional `id` argument is empty as Resolved by committing Restricted Diffusion Commit.
Jan 10 2017, 9:47 PM · Bug Report
epriestley added a revision to T12092: conduit.querydiffs generates error when optional `id` argument is empty: Unknown Object (Differential Revision).
Jan 10 2017, 9:45 PM · Bug Report
epriestley merged T12091: arc patch fails with conduit error into T12092: conduit.querydiffs generates error when optional `id` argument is empty.
Jan 10 2017, 9:43 PM · Bug Report
epriestley merged task T12091: arc patch fails with conduit error into T12092: conduit.querydiffs generates error when optional `id` argument is empty.
Jan 10 2017, 9:43 PM · Arcanist, Bug Report (Needs Information)
john.snow updated the task description for T12092: conduit.querydiffs generates error when optional `id` argument is empty.
Jan 10 2017, 9:43 PM · Bug Report
epriestley added a comment to T12092: conduit.querydiffs generates error when optional `id` argument is empty.

This was collateral damage from D17164.

Jan 10 2017, 9:43 PM · Bug Report
john.snow created T12092: conduit.querydiffs generates error when optional `id` argument is empty.
Jan 10 2017, 9:38 PM · Bug Report
rbalik added a comment to T12091: arc patch fails with conduit error.

I dunno, I get this error every time. I just tried it again patching back on the same repo that generated the diff:

Jan 10 2017, 9:23 PM · Arcanist, Bug Report (Needs Information)
rbalik added a comment to T12091: arc patch fails with conduit error.

hmm, that's pretty much it. lemme make sure i'm not missing anything

Jan 10 2017, 9:20 PM · Arcanist, Bug Report (Needs Information)
rbalik added a comment to T12091: arc patch fails with conduit error.

Oh and libphutil is at c5848b71c10 and arcanist is at ade25facf

Jan 10 2017, 9:20 PM · Arcanist, Bug Report (Needs Information)
chad added a comment to T12091: arc patch fails with conduit error.

I am also at HEAD and cannot reproduce that error. What steps am I missing?

Jan 10 2017, 9:19 PM · Arcanist, Bug Report (Needs Information)
rbalik added a comment to T12091: arc patch fails with conduit error.
  1. Create a diffusion review with arc diff
    1. Run arc patch <ID of review>
Jan 10 2017, 9:18 PM · Arcanist, Bug Report (Needs Information)
jboning added a comment to T12087: Clusterizing a repository onto a service with multiple machines results in ambiguous leader.

Hurray, thank you!

Jan 10 2017, 9:18 PM · Restricted Project, Bug Report
chad edited projects for T12091: arc patch fails with conduit error, added: Bug Report (Needs Information), Arcanist; removed Bug Report.
Jan 10 2017, 9:17 PM · Arcanist, Bug Report (Needs Information)
chad added a comment to T12091: arc patch fails with conduit error.

Please include reproduction steps. This is always required on every bug report.

Jan 10 2017, 9:17 PM · Arcanist, Bug Report (Needs Information)
chad added a revision to T12089: New red/green highlight colors are incorrect for added or removed new lines: Unknown Object (Differential Revision).
Jan 10 2017, 9:14 PM · Design, Differential
rbalik created T12091: arc patch fails with conduit error.
Jan 10 2017, 9:14 PM · Arcanist, Bug Report (Needs Information)
epriestley added a comment to T12087: Clusterizing a repository onto a service with multiple machines results in ambiguous leader.

After D17169, the clusterize command, the error message, and the documentation should be more helpful in anticipating and resolving this situation. (The documentation may take ~24 hours to actually regenerate.)

Jan 10 2017, 8:46 PM · Restricted Project, Bug Report
epriestley closed T12087: Clusterizing a repository onto a service with multiple machines results in ambiguous leader as Resolved by committing Restricted Diffusion Commit.
Jan 10 2017, 8:46 PM · Restricted Project, Bug Report
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 10 2017, 8:33 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T12090: `bin/hunks migrate` fails on differential_hunks row with NULL changes field as Resolved by committing Restricted Diffusion Commit.
Jan 10 2017, 8:28 PM · Restricted Project, Bug Report
epriestley added a revision to T12087: Clusterizing a repository onto a service with multiple machines results in ambiguous leader: Unknown Object (Differential Revision).
Jan 10 2017, 8:28 PM · Restricted Project, Bug Report
chad added a comment to T5867: Move Quick Create to MenuItemEngine.

oh ok, I think I can do that

Jan 10 2017, 8:13 PM · Design
epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

we can probably ditch that outright?

Jan 10 2017, 8:13 PM · Design
epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

You should be able to return a list of appropriately configured PhabricatorEditEngineProfileMenuItem objects as builtins, rather than defining a new class for each application -- since "Create Task" is just "EditEngine link to the create task form", etc.

Jan 10 2017, 8:12 PM · Design
chad added a comment to T5867: Move Quick Create to MenuItemEngine.

I also think you have some special magic that turns "Create Task" into a mini-menu automagically - we can probably ditch that outright?

Jan 10 2017, 8:11 PM · Design
chad added a comment to T5867: Move Quick Create to MenuItemEngine.

I think I need to make PhabricatorProfileMenuItem files for each "default" I want to ship?

Jan 10 2017, 8:05 PM · Design
epriestley added a comment to T12090: `bin/hunks migrate` fails on differential_hunks row with NULL changes field.

I marked D17168 as fixing this -- it just makes the replacement migration more robust, but I think that's the best we can do from the upstream. No idea how null ended up there in the first place, but I'd guess we have no way to figure it out and our lives would be no richer for knowing.

Jan 10 2017, 7:56 PM · Restricted Project, Bug Report
jboning added a comment to T12090: `bin/hunks migrate` fails on differential_hunks row with NULL changes field.

Aha, of course. Thank you!!

Jan 10 2017, 7:55 PM · Restricted Project, Bug Report
epriestley added a revision to T12090: `bin/hunks migrate` fails on differential_hunks row with NULL changes field: Unknown Object (Differential Revision).
Jan 10 2017, 7:55 PM · Restricted Project, Bug Report
jboning updated the task description for T12090: `bin/hunks migrate` fails on differential_hunks row with NULL changes field.
Jan 10 2017, 7:55 PM · Restricted Project, Bug Report
epriestley added a comment to T12090: `bin/hunks migrate` fails on differential_hunks row with NULL changes field.

You should be able to safely update these rows to have '' instead of NULL, then continue:

Jan 10 2017, 7:52 PM · Restricted Project, Bug Report
jboning added a project to T12090: `bin/hunks migrate` fails on differential_hunks row with NULL changes field: Restricted Project.
Jan 10 2017, 7:50 PM · Restricted Project, Bug Report
jboning added a comment to T12090: `bin/hunks migrate` fails on differential_hunks row with NULL changes field.

I'd be happy just to have a good workaround, since I don't think we're particularly attached to these mostly-contentless rows. My ideas for possibilities so far are:

  • Delete the offending differential_hunks rows manually. I worry that this might cause some inconsistency.
  • bin/destroy the revisions containing the offending hunks. This seems a bit heavy-handed though.
Jan 10 2017, 7:50 PM · Restricted Project, Bug Report
epriestley added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

Ah, sorry, I overlooked that you're using edges.

Jan 10 2017, 7:49 PM · Bug Report
jboning created T12090: `bin/hunks migrate` fails on differential_hunks row with NULL changes field.
Jan 10 2017, 7:48 PM · Restricted Project, Bug Report
jcox added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

Doing that without defining getFieldTransactions() in my class yields this exception:

Transaction with key "1" has invalid type "devTestPHIDs". This type is not recognized. Valid types are: update, comment, title, summary, testPlan, reviewers.add, reviewers.remove, reviewers.set, repositoryPHID, tasks.add, tasks.remove, tasks.set, view, edit, projects.add, projects.remove, projects.set, subscribers.add, subscribers.remove, subscribers.set, phabricator:auditors.
Jan 10 2017, 7:39 PM · Bug Report
chad awarded T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages a Love token.
Jan 10 2017, 7:12 PM · Installing & Upgrading, Differential
epriestley updated the task description for T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.
Jan 10 2017, 7:09 PM · Installing & Upgrading, Differential
epriestley added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

Oh -- try subclassing DifferentialCommitMessageCustomField instead of DifferentialCommitMessageField directly?

Jan 10 2017, 7:07 PM · Bug Report
cspeckmim added a comment to T4416: Drop "-u" flag from `hg pull` in daemons?.

Ah ok I was just thinking that if anything happened to be depending on the state of the working copy then removing the -u argument could affect those.

Jan 10 2017, 7:00 PM · Mercurial, Diffusion
jcox added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

Thanks for the help Evan. I've gone through and converted everything as you suggested. The conduit method then started telling me

Jan 10 2017, 6:31 PM · Bug Report
epriestley added a comment to T4416: Drop "-u" flag from `hg pull` in daemons?.

The other side of the Conduit call still issues an hg (or git, or whatever) command in most cases, but sending everything through Conduit means a different host (one which actually does have a working copy) can give us the answer if necessary.

Jan 10 2017, 5:27 PM · Mercurial, Diffusion
epriestley added a comment to T4416: Drop "-u" flag from `hg pull` in daemons?.

They shouldn't interact -- T10753 is mostly about clustering. When Diffusion and the daemons need to ask questions about a Mercurial repository, they're supposed to issue a Conduit call so Phabricator can get an answer by asking another host if it needs to. In a few cases, they currently just issue an hg command, which only works if the repository is present (and up to date) on local disk.

Jan 10 2017, 5:26 PM · Mercurial, Diffusion
cspeckmim added a comment to T4416: Drop "-u" flag from `hg pull` in daemons?.

This might depend on T10753?

Jan 10 2017, 5:22 PM · Mercurial, Diffusion
epriestley moved T6636: Show Audit status of referenced commits in Maniphest from Backlog to Audit States on the Audit board.
Jan 10 2017, 5:20 PM · Audit, Diffusion, Maniphest
epriestley moved T8690: Modernize PhabricatorCommitSearchEngine from Backlog to EditEngine on the Audit board.
Jan 10 2017, 5:20 PM · Audit, Restricted Project, ApplicationSearch, Diffusion
epriestley moved T6273: Inline comments do not support editing (Pholio, Differential, Diffusion) from Backlog to Inlines on the Audit board.
Jan 10 2017, 5:20 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley moved T4343: Implement "arc audit" from Backlog to Future on the Audit board.
Jan 10 2017, 5:20 PM · Audit, Diffusion
epriestley moved T4416: Drop "-u" flag from `hg pull` in daemons? from Backlog to Mercurial on the Diffusion board.
Jan 10 2017, 5:19 PM · Mercurial, Diffusion
epriestley moved T1130: Add Mercurial tag/bookmark support to Diffusion from Backlog to Mercurial on the Diffusion board.
Jan 10 2017, 5:19 PM · Mercurial, Diffusion
cspeckmim added a comment to T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position.

乁༼☯‿☯✿༽ㄏ

Jan 10 2017, 5:19 PM · Diffusion, Mercurial
epriestley moved T6118: Support for Mercurial extensions in hosted repositories from Backlog to Mercurial on the Diffusion board.
Jan 10 2017, 5:18 PM · Mercurial, Diffusion
epriestley added a project to T8303: Mercurial hooks: Mercurial.
Jan 10 2017, 5:18 PM · Mercurial, Diffusion
epriestley moved T8303: Mercurial hooks from Backlog to Mercurial on the Diffusion board.
Jan 10 2017, 5:18 PM · Mercurial, Diffusion
epriestley added a project to T6273: Inline comments do not support editing (Pholio, Differential, Diffusion): Audit.
Jan 10 2017, 5:17 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley merged T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position into T9548: Support Mercurial's bundle2 wire protocol.
Jan 10 2017, 5:15 PM · Diffusion, Mercurial
epriestley merged task T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position into T9548: Support Mercurial's bundle2 wire protocol.
Jan 10 2017, 5:15 PM · Diffusion, Mercurial
epriestley added a comment to T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position.

I'm just going to merge this into T9548 since I think bundle2 support will fix it?

Jan 10 2017, 5:15 PM · Diffusion, Mercurial
epriestley moved T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position from Backlog to Mercurial on the Diffusion board.
Jan 10 2017, 5:14 PM · Diffusion, Mercurial
epriestley moved T9548: Support Mercurial's bundle2 wire protocol from Backlog to Mercurial on the Diffusion board.
Jan 10 2017, 5:14 PM · Diffusion, Mercurial
epriestley moved T10753: Remove Mercurial daemon working copy operations from Backlog to Mercurial on the Diffusion board.
Jan 10 2017, 5:14 PM · Infrastructure, Daemons, Diffusion, Mercurial
epriestley added a project to T8690: Modernize PhabricatorCommitSearchEngine: Audit.
Jan 10 2017, 5:13 PM · Audit, Restricted Project, ApplicationSearch, Diffusion
epriestley moved T8370: Index "TODO" comments and other references present in source code from Backlog to Far Future on the Diffusion board.
Jan 10 2017, 5:13 PM · Transactions, Diffusion
epriestley added a project to T6636: Show Audit status of referenced commits in Maniphest: Audit.
Jan 10 2017, 5:12 PM · Audit, Diffusion, Maniphest
epriestley added a project to T4343: Implement "arc audit": Audit.
Jan 10 2017, 5:11 PM · Audit, Diffusion
epriestley moved T9482: Problems in the "Commits in this Package that Need Attention" view from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:09 PM · Restricted Project, Restricted Project, Audit
epriestley moved T7676: Packages that are configured to auto-audit often generate audits that are un-closable from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:07 PM · Owners, Audit
epriestley moved T2393: Adds a "Needs Verification" state to Audits from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:06 PM · Restricted Project, Audit
epriestley moved T5928: Clarify language around self-accepting Audits from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:06 PM · Audit
epriestley moved T6024: Display (post-push) audit-state in Diffusion commit-list from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:06 PM · Restricted Project, Audit, Diffusion
epriestley moved T9544: way to search for commits with no audit status from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:06 PM · Restricted Project, Restricted Project, Audit
epriestley moved T8683: Ability to query audits where all auditors have replied from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:06 PM · Audit
epriestley moved T7504: Manually added auditors doesn't change commit audit status from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:05 PM · Audit
epriestley closed T9423: Timeout error when loading "All Audits" query from a user who should not have access to any commits/audits as Resolved.

I believe this was resolved by the introduction of the "query overheating" mechanism, described in T11773.

Jan 10 2017, 5:04 PM · Audit
epriestley merged T1397: Navigating the repository tree while auditing into T5815: Make it easier to work through a queue of stuff.
Jan 10 2017, 5:00 PM · Restricted Project, Maniphest, Differential, Audit
epriestley merged task T1397: Navigating the repository tree while auditing into T5815: Make it easier to work through a queue of stuff.
Jan 10 2017, 4:59 PM · Audit, Diffusion
epriestley added a comment to T1397: Navigating the repository tree while auditing.

I'm going to merge this into T5815, which is a more general discussion of action queues.

Jan 10 2017, 4:59 PM · Audit, Diffusion
epriestley moved T5338: Incorrect handling of merge commits from Backlog to Herald on the Audit board.
Jan 10 2017, 4:58 PM · Differential, Audit
epriestley moved T6557: Automatic auditing should ignore merges from Backlog to Herald on the Audit board.
Jan 10 2017, 4:58 PM · Audit
epriestley closed T10965: [Needs Audit] shows "Query Errors : This query specifies an invalid parameter." as Invalid.

I can't reproduce this; we can't move forward without reproduction steps.

Jan 10 2017, 4:58 PM · Audit, Bug Report
epriestley merged T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail into T10448: Modularize mail tags.
Jan 10 2017, 4:56 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley merged task T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail into T10448: Modularize mail tags.
Jan 10 2017, 4:56 PM · Restricted Project, Mail, Audit, Notifications