Page MenuHomePhabricator
Feed All Stories

Sep 9 2016

chad added a comment to D16532: Unsafe copysign xform in DAGCombiner.

hi

Sep 9 2016, 7:50 PM
mcinally retitled D16532: Unsafe copysign xform in DAGCombiner from to Unsafe copysign xform in DAGCombiner.
Sep 9 2016, 7:27 PM
chad changed the visibility for Q488: Using a external CDN for Phabricator static content?.
Sep 9 2016, 5:34 PM
avivey added Q488: Using a external CDN for Phabricator static content? (Answer 456).
Sep 9 2016, 5:00 PM
chad closed T10781: Conpherence new links are missing styles as Resolved by committing Restricted Diffusion Commit.
Sep 9 2016, 2:16 PM · Conpherence, Bug Report
• panc.marko updated Q488: Using a external CDN for Phabricator static content? from to Using a external CDN for Phabricator static content?.
Sep 9 2016, 9:16 AM
starruler added a comment to T11608: Make it easier to review stacks of diffs.

If revisions in other states displayed like in your screenshot @epriestley that would solve the first 90%.

Sep 9 2016, 5:14 AM · Restricted Project, Differential, Feature Request
chad added a revision to T10781: Conpherence new links are missing styles: Unknown Object (Differential Revision).
Sep 9 2016, 4:36 AM · Conpherence, Bug Report
chad awarded D16525: Check for empty output from git ls-tree a Pirate Logo token.
Sep 9 2016, 2:18 AM
epriestley accepted D16525: Check for empty output from git ls-tree.
Sep 9 2016, 2:18 AM
chad closed T9294: Phriction document-created email notifications do not include Edit Notes as Resolved by committing Restricted Diffusion Commit.
Sep 9 2016, 2:18 AM · Phriction
chad closed T10131: Wiki pages are not completely print friendly as Resolved by committing Restricted Diffusion Commit.
Sep 9 2016, 2:14 AM · Feature Request, Phriction
chad added a revision to T9294: Phriction document-created email notifications do not include Edit Notes: Unknown Object (Differential Revision).
Sep 9 2016, 2:13 AM · Phriction
20after4 retitled D16525: Check for empty output from git ls-tree from to Check for empty output from git ls-tree.
Sep 9 2016, 2:10 AM
20after4 added a revision to T10155: Error when displaying a repository with only one empty commit: D16525: Check for empty output from git ls-tree.
Sep 9 2016, 2:10 AM · Diffusion, Bug Report
epriestley added a comment to T11051: "Explain Why" isn't properly explaining why revisions were closed.

Caught another case of this:

Sep 9 2016, 2:07 AM · Restricted Project, Differential, Bug Report
chad closed T9622: Allow Phriction pages to have Project tags, a subtask of T9379: Build Phriction v3, as Resolved.
Sep 9 2016, 1:50 AM · Phriction
chad closed T9622: Allow Phriction pages to have Project tags as Resolved.
Sep 9 2016, 1:50 AM · Projects, Phriction, Restricted Project
chad added a revision to T10131: Wiki pages are not completely print friendly: Unknown Object (Differential Revision).
Sep 9 2016, 1:48 AM · Feature Request, Phriction
epriestley closed T11610: Call to a member function getCommitDetail() on a non-object as Resolved by committing Restricted Diffusion Commit.
Sep 9 2016, 12:16 AM · Diffusion, Herald
epriestley closed T11607: Put inline styles on `{key ...}` for email as Resolved by committing Restricted Diffusion Commit.
Sep 9 2016, 12:11 AM · Remarkup

Sep 8 2016

epriestley added a revision to T11607: Put inline styles on `{key ...}` for email: Unknown Object (Differential Revision).
Sep 8 2016, 11:39 PM · Remarkup
epriestley added a comment to T11608: Make it easier to review stacks of diffs.

I guess it's not particularly useful in this case anyway.

Sep 8 2016, 11:29 PM · Restricted Project, Differential, Feature Request
epriestley added a comment to T11608: Make it easier to review stacks of diffs.

Oh, that hint only shows for accepted revisions right now.

Sep 8 2016, 11:28 PM · Restricted Project, Differential, Feature Request
cspeckmim added a comment to T11608: Make it easier to review stacks of diffs.

What about creating a new query in Diffusion which is the same as the default, but orders the revisions by Creation Date (Oldest First)? You can then use that query in your dashboard. Does that help for this scenario?

Sep 8 2016, 11:27 PM · Restricted Project, Differential, Feature Request
epriestley added a comment to T11608: Make it easier to review stacks of diffs.

Do they actually have dependencies declared? Any idea why the screenshot doesn't show the "Open Dependencies" marker visible here?

Sep 8 2016, 11:26 PM · Restricted Project, Differential, Feature Request
epriestley claimed T11610: Call to a member function getCommitDetail() on a non-object.
Sep 8 2016, 11:24 PM · Diffusion, Herald
epriestley added a revision to T11610: Call to a member function getCommitDetail() on a non-object: Unknown Object (Differential Revision).
Sep 8 2016, 11:21 PM · Diffusion, Herald
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 8 2016, 10:49 PM · Restricted Project, Prioritized, Calendar
avivey added a comment to T11609: Don't resize small pictures in Remarkup.

oh, wow, the preview already handles tiny pictures differently...

Sep 8 2016, 10:49 PM · Remarkup
joshuaspence added a comment to T11610: Call to a member function getCommitDetail() on a non-object.

I was able to reproduce on this install by passing rPf712ae718ccc1c94d882c626ca8626b77346026b to the Herald test console.

Sep 8 2016, 10:46 PM · Diffusion, Herald
joshuaspence created T11610: Call to a member function getCommitDetail() on a non-object.
Sep 8 2016, 10:46 PM · Diffusion, Herald
starruler added a comment to T11608: Make it easier to review stacks of diffs.

I know of that view, but it's at least two clicks and some scrolling away. It doesn't help you decide which diff to start reviewing at the differential homepage or in the diffs widget.

Sep 8 2016, 10:44 PM · Restricted Project, Differential, Feature Request
avivey created T11609: Don't resize small pictures in Remarkup.
Sep 8 2016, 10:44 PM · Remarkup
avivey added a comment to T11608: Make it easier to review stacks of diffs.

something like

pasted_file (205×449 px, 22 KB)
?

Sep 8 2016, 10:39 PM · Restricted Project, Differential, Feature Request
starruler added a comment to T11608: Make it easier to review stacks of diffs.

I sure hope I followed the 2.5 pages worth of rules for writing a feature request...

Sep 8 2016, 10:26 PM · Restricted Project, Differential, Feature Request
starruler created T11608: Make it easier to review stacks of diffs.
Sep 8 2016, 10:24 PM · Restricted Project, Differential, Feature Request
epriestley created T11607: Put inline styles on `{key ...}` for email.
Sep 8 2016, 8:51 PM · Remarkup
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 8 2016, 8:49 PM · Restricted Project, Prioritized, Calendar
jcox closed T11567: Allow dashes in monospace font preferences as Resolved by committing Restricted Diffusion Commit.
Sep 8 2016, 8:29 PM · Contributor Onboarding, User Preferences
epriestley moved T11586: Display errors/nonprintable characters more clearly when warning users about invalid data inputs from Backlog to Basic on the Contributor Onboarding board.
Sep 8 2016, 8:27 PM · Contributor Onboarding
epriestley assigned T11586: Display errors/nonprintable characters more clearly when warning users about invalid data inputs to jcox.
Sep 8 2016, 8:26 PM · Contributor Onboarding
jcox added a revision to T11567: Allow dashes in monospace font preferences: Unknown Object (Differential Revision).
Sep 8 2016, 8:25 PM · Contributor Onboarding, User Preferences
jcox closed T11595: PhabricatorApplicationDatasource returns applications which have been uninstalled (e.g., in "Pin Application") as Resolved by committing Restricted Diffusion Commit.
Sep 8 2016, 7:08 PM · Contributor Onboarding, Bug Report
avivey added a comment to T11118: Herald Rule to assign Owners to an Audit.

We're looking for a similar concept for Reviewers:
Even if the Author of a review is one of the Owners, we still want to automatically add that package.
This is mostly just T1125 - we want to make it easier to assign reviewers, and Owners has good UI for selecting paths.

Sep 8 2016, 6:44 PM · Restricted Project, Audit, Herald, Owners, Feature Request
avivey changed the visibility for T1125: Suggest field defaults in "arc diff".
Sep 8 2016, 6:36 PM · Arcanist
jcox added a revision to T11595: PhabricatorApplicationDatasource returns applications which have been uninstalled (e.g., in "Pin Application"): Unknown Object (Differential Revision).
Sep 8 2016, 6:24 PM · Contributor Onboarding, Bug Report
michaeljs1990 added a comment to T3179: Importing data from external systems (like GitHub, JIRA, Trac, Asana, Trello, etc.).

@snaik phabricator doesn't currently support this. You can write your own however using PHPExcel. I can't see upstream supporting this as I can't imagine it would take significantly more time to just pull up muliple tabs unless the tickets are of very poor quality.

Sep 8 2016, 6:22 PM · Guides, Doorkeeper
• snaik added a comment to T3179: Importing data from external systems (like GitHub, JIRA, Trac, Asana, Trello, etc.).

Hi all, is there a way to import tasks from an excel spreadsheet? Its often way faster to write tasks down in excel (for bug bashes, costing meetings, etc) and later import them into Phabricator.

Sep 8 2016, 6:16 PM · Guides, Doorkeeper
epriestley closed T11396: Calendar stub events do not respect recurring event end dates as Resolved by committing Restricted Diffusion Commit.
Sep 8 2016, 5:20 PM · Restricted Project, Calendar
epriestley added a revision to T11396: Calendar stub events do not respect recurring event end dates: Unknown Object (Differential Revision).
Sep 8 2016, 4:16 PM · Restricted Project, Calendar
epriestley added a comment to T11606: Allow custom fields to accept function tokens like "viewer()".

This would be nice to have but is somewhat involved:

Sep 8 2016, 3:48 PM · Custom Fields, Typeahead, Feature Request
epriestley renamed T11606: Allow custom fields to accept function tokens like "viewer()" from Maniphest Custom-field doesn't support "Current View" function, bug or design ? to Allow custom "users" fields to accept function tokens like "viewer()".
Sep 8 2016, 3:46 PM · Custom Fields, Typeahead, Feature Request
epriestley closed T11534: Repository clustering does not respect disabled bindings? as Invalid.

From reviewing the code, it appears that this should be handled correctly already.

Sep 8 2016, 3:43 PM · Almanac, Clusters
AmyLewis created T11606: Allow custom fields to accept function tokens like "viewer()".
Sep 8 2016, 3:39 PM · Custom Fields, Typeahead, Feature Request
epriestley closed T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages as Resolved.

Presuming resolved until we hear otherwise.

Sep 8 2016, 2:49 PM · Setup
epriestley added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

Someone in IRC hit this on stable and I haven't seen more reports on master, so I'm going to bring the changes over.

Sep 8 2016, 2:22 PM · Setup
epriestley added a comment to T11084: LDAP Unable to Connect.

See also T4947 for some discussion of SELinux.

Sep 8 2016, 2:10 PM · Bug Report
HuMMeL621 moved T4245: Make repository URIs slightly prettier from Preflight to Backlog on the Prioritized board.
Sep 8 2016, 8:08 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
HuMMeL621 moved T4245: Make repository URIs slightly prettier from Backlog to Preflight on the Prioritized board.
Sep 8 2016, 8:08 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
• gamerman315 added a comment to T11084: LDAP Unable to Connect.

Ran into this issue myself over the past few days on a fresh install of CentOS 7 connecting to a Windows Server 2008 R2 domain controller with active directory. I was able to use ldapsearch and the provided bin/auth tool to query the active directory server successfully but yet through the web interface for phabricator it kept rejecting with the error describe in the original post. After some debugging I determined it to be due to SELinux blocking the ldap connection from httpd. Turns out you can run the following command to allow for httpd to use php-ldap to connect out to the active directory server.

Sep 8 2016, 4:26 AM · Bug Report
nfirmani added a comment to T11520: Arc Lint - Severity configuration behaves differently for different linters.

rel T483960

Sep 8 2016, 12:43 AM · Bug Report
jdforrester awarded T10339: Figure out the UI for Maniphest task search by points a Hungry Hippo token.
Sep 8 2016, 12:33 AM · Maniphest

Sep 7 2016

20after4 awarded T11399: Add support for locations in calendar events a Love token.
Sep 7 2016, 11:51 PM · Calendar, Feature Request
20after4 added a comment to T11399: Add support for locations in calendar events.

IMO, Pokémon catching is an essential feature, please implement that first.

Sep 7 2016, 11:51 PM · Calendar, Feature Request
20after4 added a comment to T10145: Adding a panel to a dashboard multiple times.

T10612: Editing a panel causes it to duplicate in dashboard may be the same root cause as this bug.

Sep 7 2016, 11:45 PM · Dashboards (v2), Bug Report
20after4 added a comment to T11533: Upgrading: Changes to Default Homepage.

Ut seems to be T10145

Sep 7 2016, 11:43 PM · NUX, Dashboards, Installing & Upgrading
20after4 awarded T10145: Adding a panel to a dashboard multiple times a Burninate token.
Sep 7 2016, 11:42 PM · Dashboards (v2), Bug Report
chad added a comment to T11533: Upgrading: Changes to Default Homepage.

Or if it isn't, please file a bug report.

Sep 7 2016, 11:40 PM · NUX, Dashboards, Installing & Upgrading
chad added a comment to T11533: Upgrading: Changes to Default Homepage.

This change didn't touch Dashboards. I think you want T10612 or maybe T10145?

Sep 7 2016, 11:39 PM · NUX, Dashboards, Installing & Upgrading
20after4 added a comment to T10145: Adding a panel to a dashboard multiple times.

I'm also seeing this bug.

Sep 7 2016, 11:37 PM · Dashboards (v2), Bug Report
20after4 added a comment to T11533: Upgrading: Changes to Default Homepage.

I think this change broke dashboard editing slightly. Now when adding a panel to a dashboard column, the same panel gets added twice, once for each column. Removing either of the dupes removes both.

Sep 7 2016, 11:34 PM · NUX, Dashboards, Installing & Upgrading
chad closed T9195: Durable column menu should always display as Resolved by committing Restricted Diffusion Commit.
Sep 7 2016, 9:28 PM · Conpherence
chad added a revision to T9195: Durable column menu should always display: Unknown Object (Differential Revision).
Sep 7 2016, 9:26 PM · Conpherence
MrOnosa awarded T9195: Durable column menu should always display a Love token.
Sep 7 2016, 8:15 PM · Conpherence
chad added a comment to T11605: Add possibility to snooze tasks.

I am marking this invalid, but we're happy to re-open if you can clearly describe your workflow and why Dashboards / Saved Queries / Flags / Tags / Herald, etc, are unable to solve your problems. We currently manage thousands of open tasks here between two developers, and we're not currently experiencing any issues with workload.

Sep 7 2016, 8:07 PM · Feature Request
chad closed T11605: Add possibility to snooze tasks as Invalid.

Problem: Overwhelming lists of (assigned) tasks steal focus.

Sep 7 2016, 8:00 PM · Feature Request
bizrad6 added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

Confirmed by updating to the latest, thanks again!

Sep 7 2016, 7:30 PM · Restricted Project, Bug Report
bizrad6 added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

Awesome, thanks for the quick fix!

Sep 7 2016, 7:00 PM · Restricted Project, Bug Report
epriestley added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

I believe this is now fixed in HEAD of master. Let us know if you're still seeing issues.

Sep 7 2016, 6:35 PM · Restricted Project, Bug Report
epriestley closed T11604: Error adding URL to a JIRA issue the first time to Differential comment as Resolved by committing Restricted Diffusion Commit.
Sep 7 2016, 6:16 PM · Restricted Project, Bug Report
ftdysa added a comment to T11605: Add possibility to snooze tasks.

Also, if you just want to look at a subset of tasks you can always create a query panel using flags on your dashboard and flag the tasks you care about. I've been doing that lately and it feels pretty good to me.

Sep 7 2016, 6:01 PM · Feature Request
epriestley added a revision to T11604: Error adding URL to a JIRA issue the first time to Differential comment : Unknown Object (Differential Revision).
Sep 7 2016, 5:51 PM · Restricted Project, Bug Report
avivey added a comment to T11605: Add possibility to snooze tasks.

Why are you trying to snooze a task? Why don't you just, you know, do the thing?

Sep 7 2016, 5:36 PM · Feature Request
caov297 added a comment to Q485: PhabricatorFileDataController class handRequest doesn't have valid viewer/user for CDN file request.

I was thinking of adding some code to phabricator to set the phusr cookie for alternate-file-domain (aws cloudfront) when a user login as well in order for me to track user download of software packages in the file application. What is the security risk involve in doing this? Is there a better way of capturing a userid when they download a file being served from a CDN?

Sep 7 2016, 5:32 PM
mna created T11605: Add possibility to snooze tasks.
Sep 7 2016, 5:22 PM · Feature Request
epriestley added a comment to T10961: JIRA instructions are a bit out of date with modern JIRA.

We also say "Only supports JIRA 6" but that means "JIRA 6 or newer", since JIRA 7 works fine.

Sep 7 2016, 5:07 PM · Auth, Documentation
bizrad6 added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

Sounds good, thanks!

Sep 7 2016, 4:45 PM · Restricted Project, Bug Report
epriestley added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

Let me take a shot at it locally first, I don't immediately see a real way that D16494 could have fixed this given your repro steps.

Sep 7 2016, 4:43 PM · Restricted Project, Bug Report
bizrad6 added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

Happy to bring those changes in and test it out. Also happy to test any patches if testing JIRA related stuff is a pain.

Sep 7 2016, 4:36 PM · Restricted Project, Bug Report
epriestley added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

(I'd be a little surprised if it was and it still merits a real fix even if it doesn't happen in practice anymore.)

Sep 7 2016, 4:34 PM · Restricted Project, Bug Report
epriestley added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

There is a small possibility that this was "fixed" by D16494 on Sep 5.

Sep 7 2016, 4:34 PM · Restricted Project, Bug Report
bizrad6 created T11604: Error adding URL to a JIRA issue the first time to Differential comment .
Sep 7 2016, 4:23 PM · Restricted Project, Bug Report
epriestley closed T11583: When initializing a new database, just apply adjustments without prompting as Resolved by committing Restricted Diffusion Commit.
Sep 7 2016, 4:09 PM · NUX, Setup
epriestley added a comment to T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints.

I believe all that stuff is fixed in HEAD of master, let us know if you're still seeing issues (other than text not being searchable: it isn't currently supported). Thanks for the report!

Sep 7 2016, 4:08 PM · Bug Report
epriestley closed T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints as Resolved by committing Restricted Diffusion Commit.
Sep 7 2016, 4:08 PM · Bug Report
epriestley added a revision to T11583: When initializing a new database, just apply adjustments without prompting: Restricted Differential Revision.
Sep 7 2016, 2:54 PM · NUX, Setup
MattSeen added a comment to T11566: Provide more complete guidance on using regular expressions in Herald.

Sorry for the late reply. What an incredibly well written and thoughtful response! Thanks!

Sep 7 2016, 2:47 PM · Herald, Documentation
epriestley added a comment to T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints.
  • text does not support searching, and does not claim to support searching (e.g., is not listed on "Constraints"). The intent is to eventually expose fulltext/content search here rather than exact-match search.
  • We did not validate constraint keys, so it would appear that we might support searching on invalid constraints. D16507 fixes this: we now throw an explicit exception pointing at the error.
  • link does support searching, but did not handle query constraints correctly. D16508 fixes this, and it now should apply these constraints properly.
Sep 7 2016, 2:40 PM · Bug Report
epriestley added a revision to T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints: Unknown Object (Differential Revision).
Sep 7 2016, 2:38 PM · Bug Report