Page MenuHomePhabricator

PhabricatorApplicationDatasource returns applications which have been uninstalled (e.g., in "Pin Application")
Closed, ResolvedPublic

Description

Hi,

When using Customize Menu, users see all applications, even the one they don't have access to (Can Use policy) and that they don't see from the applications menu.

We're using the latest stable, ca30df847e4e99aec46dd97c7bd9b4f7d8542cab

Regards

Event Timeline

epriestley added a subscriber: epriestley.

In PhabricatorApplicationDatasource, do a PhabricatorApplication::isClassInstalledForViewer(...) test on each application and skip it if it is not installed. You can get the class name with get_class($application_object).

In most other typeaheads we still return these results, but with "Disabled" or "Closed" or similar, which sorts them to the bottom of the list and greys them out. This makes it less confusing when a user types a result that they know should find a hit (like the username of a disabled user) and get nothing back, and is occasionally useful (e.g., to find tasks still assigned to someone who left the company).

In the case of applications, I think this is probably so rare that it's not worth bothering with for now.

epriestley renamed this task from Customize Menu show all applications to PhabricatorApplicationDatasource returns applications which have been uninstalled (e.g., in "Pin Application").Sep 6 2016, 1:40 PM
epriestley moved this task from Backlog to Basic on the Contributor Onboarding board.