Page MenuHomePhabricator
Create Task
Maniphest T11593

*.search Conduit API methods with invalid constraints silently ignore the constraints
Closed, ResolvedPublic
Actions

Description

Version

Summary

Queries that utilize link and text custom fields seem to not be filtering properly using constraints via conduit maniphest.search.
The below query returns all tasks, instead of only those that match. I'd expect only task 1 should be returned (since it matches the full string passed in)

Reproduction Steps

  1. Add custom field of either link or text type.
{
  "trac-url": {
    "name": "Trac Ticket",
    "type": "link",
    "caption": "Linked trac ticket",
    "required": false,
    "search": true
  }
}
  1. Add 2 tasks. On one, fill out the Trac Ticket field. On the other, leave it empty. The URL doesn't matter.
  2. Call maniphest.search with this, using the bogus URL from step 2.
{
  "custom.trac-url": [
    "https://mysite.com/project/ticket/1"
  ]
}
  1. Response includes multiple tasks instead of only the one that matches the URL.

For completeness, see Q475: maniphest.search with "link" custom fields doesn't seem to work for my original use-case and example.

Revisions and Commits

rP Phabricator
D16508rP76af4d649bfc Fix ContainsConstraints for array-valued custom field constraints in "*.search"…
D16507rP38ae81fb3916 Throw when callers pass an invalid constraint to a "*.search" method

Related Objects

Event Timeline

jonathanrseawright renamed this task from maniphest.search with link/text constraints return all tasks, instead of ony to maniphest.search with link/text constraints return all tasks, instead of the ones that match.Sep 5 2016, 3:52 PM
jonathanrseawright created this task.
jonathanrseawright mentioned this in Q475: maniphest.search with "link" custom fields doesn't seem to work.
jonathanrseawright updated the task description. (Show Details)Sep 5 2016, 3:58 PM
epriestley added a subscriber: epriestley.Sep 5 2016, 4:47 PM

Does this work?

{
  "custom.trac-url": "https://mysite.com/project/ticket/1"
}
jonathanrseawright added a comment.Sep 5 2016, 4:49 PM

Nope, that doesn't work either..

epriestley added a comment.Sep 5 2016, 4:52 PM

Alright, thanks. I'll look at this in more detail.

jonathanrseawright added a comment.Sep 5 2016, 4:53 PM

Sounds good. Let me know how I can help

epriestley added a comment.Sep 6 2016, 11:25 PM

Oh, this isn't expected to work. These don't currently expose a constraint. You can find an exhaustive list of constraints in the "Custom Query Constraints" table on the API page, and no constraint will be listed for these fields.

I'll change *.search methods to fail explicitly if an invalid constraint is provided.

epriestley renamed this task from maniphest.search with link/text constraints return all tasks, instead of the ones that match to *.search Conduit API methods with invalid constraints silently ignore the constraints.Sep 6 2016, 11:26 PM
epriestley added a revision: D16507: Throw when callers pass an invalid constraint to a "*.search" method.Sep 7 2016, 2:25 PM
epriestley added a revision: D16508: Fix ContainsConstraints for array-valued custom field constraints in "*.search" methods.Sep 7 2016, 2:38 PM
epriestley added a comment.Sep 7 2016, 2:40 PM
  • text does not support searching, and does not claim to support searching (e.g., is not listed on "Constraints"). The intent is to eventually expose fulltext/content search here rather than exact-match search.
  • We did not validate constraint keys, so it would appear that we might support searching on invalid constraints. D16507 fixes this: we now throw an explicit exception pointing at the error.
  • link does support searching, but did not handle query constraints correctly. D16508 fixes this, and it now should apply these constraints properly.
epriestley closed this task as Resolved by committing rP76af4d649bfc: Fix ContainsConstraints for array-valued custom field constraints in "*.search"….Sep 7 2016, 4:07 PM
epriestley added a commit: rP38ae81fb3916: Throw when callers pass an invalid constraint to a "*.search" method.
epriestley added a commit: rP76af4d649bfc: Fix ContainsConstraints for array-valued custom field constraints in "*.search"….
epriestley added a comment.Sep 7 2016, 4:08 PM

I believe all that stuff is fixed in HEAD of master, let us know if you're still seeing issues (other than text not being searchable: it isn't currently supported). Thanks for the report!

jonathanrseawright awarded a token.Sep 10 2016, 10:38 PM
Phabricator · Built by Phacility