Page MenuHomePhabricator
Feed All Stories

Jun 17 2016

epriestley added a project to T11159: Cluster detection of "replication OK" is unreasonably optimistic: Prioritized.
Jun 17 2016, 5:30 PM · Prioritized, Clusters
epriestley added a comment to T11114: Move Differential to EditEngine.

We discussed this briefly out-of-band, but the draft part of this is probably only sensible as "soft" prioritization:

Jun 17 2016, 5:29 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
avivey awarded T11167: Unbeta Feedback on Badges a Yellow Medal token.
Jun 17 2016, 5:28 PM · Restricted Project, Badges (v0)
epriestley added a comment to T3875: Allow arc to perform cascading rebases, maybe during or after `arc land`.
  • Does that description sound approximately like what you're hitting?
  • Are both smarter arc land and arc cascade interesting, or are you only running into pain in one of the cases?
  • Do you anticipate cases where git reflog and local notes could fail as sources (lots of pushing/pulling to different working copies, I guess)?
  • Anyone know offhand how to git rebase -i master; delete the first few lines; save and exit; non-interactively?
Jun 17 2016, 5:15 PM · Prioritized, Restricted Project, Arcanist
epriestley added a comment to T3875: Allow arc to perform cascading rebases, maybe during or after `arc land`.

I think the immediate issue here tends to manifest as arc land requiring users to manually rebase before it will work.

Jun 17 2016, 5:12 PM · Prioritized, Restricted Project, Arcanist
scode added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

@eadler Did you have enough insight/recollection as to whether all our reported cases were due to users editing in the web UI?

Jun 17 2016, 4:51 PM · Prioritized, Restricted Project, Arcanist, Bug Report
epriestley added a comment to T8909: Provide ability to hide all inline or done comments.

Here are the interactions I can come up with which we'll potentially get wrong by implementing this naively:

Jun 17 2016, 4:23 PM · Inline Comments, Prioritized, Restricted Project, Restricted Project, Differential, FreeBSD
epriestley added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

From a technical point of view I think the ideal solution to this is to make the commit message format unambiguously parseable, but I'm not immediately sure how to do that without making other things worse. It's valuable for messages to be human-readable and human-editable, and I think we'd be worse overall if we tried to escape or encode messages in Git itself (or represent them as XML or whatever).

Jun 17 2016, 4:05 PM · Prioritized, Restricted Project, Arcanist, Bug Report
eadler added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

I'm not sure I have a good answer to that. :/

Jun 17 2016, 3:48 PM · Prioritized, Restricted Project, Arcanist, Bug Report
epriestley added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

What's the behavior you'd expect or prefer when a user writes this commit message?

Jun 17 2016, 3:15 PM · Prioritized, Restricted Project, Arcanist, Bug Report
epriestley added a comment to T11172: Unable to configure Arcanist as per the quick start tutorial.

I can't reproduce this. Here's what I did.

Jun 17 2016, 3:01 PM · Documentation, Bug Report
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
Jun 17 2016, 2:52 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T4631: Allow Differential to raise warnings on the server side via Conduit: Unknown Object (Differential Revision).
Jun 17 2016, 2:52 PM · Restricted Project, Differential, Arcanist
epriestley added a comment to T4631: Allow Differential to raise warnings on the server side via Conduit.

My understanding is that the root issue here is that you're adding reviewers via Herald/Owners (per T10939) so the "no reviewers" warning is inaccurate or misleading in many cases because owners will be added automatically after the revision is created.

Jun 17 2016, 2:48 PM · Restricted Project, Differential, Arcanist
• damio awarded T11171: When clicking an image in the comment edit modal, the image modal gets under the edit modal a Manufacturing Defect? token.
Jun 17 2016, 2:42 PM · Lightbox, Bug Report
chad added a comment to T11163: Speed up wiki documents creation.

How often do you anticipate needing this functionality?

Jun 17 2016, 2:36 PM · Phriction, Feature Request
chad added a comment to T11162: Unable to Edit Projects as Administrator, Showing Restricted.

We require reproduction steps for bug reports. I would also use an up to date version of Phabricator before filing the bug report (it's required that you update before filing a bug).

Jun 17 2016, 2:31 PM · Projects, Bug Report (Needs Information)
grooveek created T11172: Unable to configure Arcanist as per the quick start tutorial.
Jun 17 2016, 2:22 PM · Documentation, Bug Report
chad added a comment to T11160: View Wiki Docs that only pertain to a certain group.

Create a custom query inside Phriction, save it, then go to Dashboards and make a Panel with that query.

Jun 17 2016, 2:16 PM · Dashboards, Phriction, Bug Report
chad added a comment to T11171: When clicking an image in the comment edit modal, the image modal gets under the edit modal.

looks like an awesome feature to me

Jun 17 2016, 2:14 PM · Lightbox, Bug Report
• damio created T11171: When clicking an image in the comment edit modal, the image modal gets under the edit modal.
Jun 17 2016, 2:08 PM · Lightbox, Bug Report
epriestley closed T11170: A way to add SASS / SCSS to the paste languages as Resolved.

Configure pygments.dropdown-choices.

Jun 17 2016, 1:53 PM · Paste, Feature Request
• rmaspoch created T11170: A way to add SASS / SCSS to the paste languages.
Jun 17 2016, 1:46 PM · Paste, Feature Request
• rmaspoch added a comment to T11160: View Wiki Docs that only pertain to a certain group.

Thank you we basically created two projects to group the members into those two projects and i removed myself and only stayed in one and that seemed to kind of work. I see only the files i expected but also some deleted files history that is greyed out. It would be nice to have an easy place to put custom queries to be used for each of the apps but I love Phabricator so keep up the good work thanks.

Jun 17 2016, 1:42 PM · Dashboards, Phriction, Bug Report
epriestley closed T11169: User without "can edit" permission, can change task via comment action as Invalid.

This is expected. You do not need edit permission to comment on a task or take other actions available in the action dropdown.

Jun 17 2016, 1:37 PM · Policy, Bug Report
rphl created T11169: User without "can edit" permission, can change task via comment action.
Jun 17 2016, 1:27 PM · Policy, Bug Report
epriestley moved T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches from Paused to The Queue on the Prioritized board.
Jun 17 2016, 12:24 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
• honza awarded T7568: Support Desktop Notifications in Conpherence a Like token.
Jun 17 2016, 12:21 PM · Conpherence (v4)
richardvanvelzen added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
Jun 17 2016, 9:53 AM · XHPAST
eadler moved T11114: Move Differential to EditEngine from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2016, 7:10 AM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
eadler moved T1084: Preview what's new in a diff when attaching it to an existing revision from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2016, 7:09 AM · Restricted Project, Differential, Arcanist
eadler moved T2452: Implement "arc blame" from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2016, 7:09 AM · Restricted Project, Arcanist, OS Students 2013
eadler moved T5171: Create an `arc log` workflow from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2016, 7:09 AM · Restricted Project, Arcanist
eadler moved T5172: Create an `arc status` workflow from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2016, 7:09 AM · Prioritized, Restricted Project, Arcanist
eadler moved T5852: arc should ignore abandoned revisions when landing from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2016, 7:09 AM · Restricted Project, Arcanist
eadler moved T6072: Improve usability of `arc diff` from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2016, 7:09 AM · Restricted Project, Documentation, Arcanist
eadler moved T7488: Add shell completion support to PhutilArgumentWorkflow from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2016, 7:09 AM · Restricted Project, libphutil
eadler moved T9116: Shell completion doesn't work for filenames containing a space from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2016, 7:09 AM · Restricted Project, Arcanist
eadler moved T9717: `arc lint --everything` will not lint directories (as opposed to files) under git from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2016, 7:09 AM · Restricted Project, Lint, Arcanist
eadler moved T10650: `arc land` can raise misleading error message if a branch exists in the remote but has never been fetched from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2016, 7:09 AM · Restricted Project, Arcanist
eadler moved T9924: Add support for git worktree from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2016, 7:08 AM · FreeBSD, Restricted Project, Arcanist, Feature Request
eadler moved T10852: Updating a very large diff continues to warn against updating very large diffs from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2016, 7:08 AM · Restricted Project, Feature Request, Arcanist
eadler moved T10945: Replace "repository.query" with "diffusion.repository.search" in Arcanist from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2016, 7:08 AM · Restricted Project, Conduit, Arcanist, Diffusion
eadler added a project to T6072: Improve usability of `arc diff`: Restricted Project.
Jun 17 2016, 7:06 AM · Restricted Project, Documentation, Arcanist
eadler added a project to T5852: arc should ignore abandoned revisions when landing: Restricted Project.
Jun 17 2016, 7:06 AM · Restricted Project, Arcanist
eadler added a project to T5171: Create an `arc log` workflow: Restricted Project.
Jun 17 2016, 7:04 AM · Restricted Project, Arcanist
eadler added a project to T5172: Create an `arc status` workflow: Restricted Project.
Jun 17 2016, 7:04 AM · Prioritized, Restricted Project, Arcanist
eadler added a project to T2452: Implement "arc blame": Restricted Project.
Jun 17 2016, 7:02 AM · Restricted Project, Arcanist, OS Students 2013
eadler added a project to T1084: Preview what's new in a diff when attaching it to an existing revision : Restricted Project.
Jun 17 2016, 7:00 AM · Restricted Project, Differential, Arcanist
eadler added a project to T9116: Shell completion doesn't work for filenames containing a space: Restricted Project.
Jun 17 2016, 6:58 AM · Restricted Project, Arcanist
eadler added a project to T7488: Add shell completion support to PhutilArgumentWorkflow: Restricted Project.
Jun 17 2016, 6:58 AM · Restricted Project, libphutil
eadler renamed T9717: `arc lint --everything` will not lint directories (as opposed to files) under git from `arc lint --everything` will not lint directories under git to `arc lint --everything` will not lint directories (as opposed to files) under git.
Jun 17 2016, 6:57 AM · Restricted Project, Lint, Arcanist
eadler added projects to T9924: Add support for git worktree: Restricted Project, FreeBSD.
Jun 17 2016, 6:56 AM · FreeBSD, Restricted Project, Arcanist, Feature Request
eadler added a project to T10650: `arc land` can raise misleading error message if a branch exists in the remote but has never been fetched: Restricted Project.
Jun 17 2016, 6:55 AM · Restricted Project, Arcanist
eadler added a project to T10852: Updating a very large diff continues to warn against updating very large diffs: Restricted Project.
Jun 17 2016, 6:55 AM · Restricted Project, Feature Request, Arcanist
eadler added a project to T10945: Replace "repository.query" with "diffusion.repository.search" in Arcanist: Restricted Project.
Jun 17 2016, 6:55 AM · Restricted Project, Conduit, Arcanist, Diffusion
hach-que added a comment to T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page.

In the case of Projects (v3) it looks like you used it to bucket things based on who was assigned, but this doesn't seem like a very feasible / useful thing to do until T5474 is done, because otherwise it's a very manual process.

Jun 17 2016, 6:32 AM · Projects, Feature Request
hach-que added a comment to T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page.

It feels like the more formal / correct way to do it I guess? Like, I'd expect in future that reporting would occur over milestones in a project, and not columns on a workboard, because the columns don't have any relation between them (as opposed to milestones which explicitly have a "next" and "previous" milestone).

Jun 17 2016, 6:29 AM · Projects, Feature Request
vinzent awarded Blog Post: Write, Review, Merge, Publish: Phabricator Review Workflow a Like token.
Jun 17 2016, 5:40 AM
chad added a comment to T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page.

I guess another question is, what are you using Milestones for if they are just a column on the parent?

Jun 17 2016, 5:15 AM · Projects, Feature Request
chad added a comment to T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page.

We used full workboards on our Milestone for Projects (v3). If we linked by default to the parent project, that functionality would be lost. Any sort of auto-redirect to the parent loses all project functionality and power.

Jun 17 2016, 5:10 AM · Projects, Feature Request
hach-que updated subscribers of T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page.

As far as I understood it, milestones being projects were an implementation detail, because @epriestley didn't want to have two separate structures for sub-projects and milestones.

Jun 17 2016, 4:59 AM · Projects, Feature Request
chad added a comment to T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page.

You can default a project's page to whatever you want in under Manage Menu. But I don't think that's what you want. I understand what you want, I just would have concerns that it might be unexpected in most cases, especially if you're running the Milestone as a full fledged project with it's own boards.

Jun 17 2016, 4:57 AM · Projects, Feature Request
chad added a comment to T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page.

What's the point of it being a project then?

Jun 17 2016, 4:52 AM · Projects, Feature Request
hach-que added a comment to T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page.

(I realise that milestones are projects, but I simplified my response to distinguish between the parent project and the milestone that is under that parent project)

Jun 17 2016, 4:51 AM · Projects, Feature Request
hach-que added a comment to T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page.

No, I'm suggesting that when you click the "Project (Milestone)" tag in the UI, it should take you to the project's workboard.

Jun 17 2016, 4:51 AM · Projects, Feature Request
chad added a comment to T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page.

You're suggesting Milestones should not be projects?

Jun 17 2016, 4:50 AM · Projects, Feature Request
hach-que added a comment to T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page.

Where is this configurable?

Jun 17 2016, 4:46 AM · Projects, Feature Request
chad added a comment to T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page.

It's configurable.

Jun 17 2016, 4:42 AM · Projects, Feature Request
hach-que created T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page.
Jun 17 2016, 4:18 AM · Projects, Feature Request
avivey edited projects for T11165: Changing a callsign throws a 404, added: Diffusion; removed Differential.
Jun 17 2016, 3:40 AM · Diffusion (v3), Bug Report
chad claimed T11166: When an install has no footer, Maniphest task previews have no bottom margin.
Jun 17 2016, 2:06 AM · PHUI
chad added a comment to T11164: Badges: Unwanted entry at the history.

We should get this punted out of prototype status, don't think there is a lot to cover before that. See T11167 if you find additional items.

Jun 17 2016, 2:06 AM · Badges, Bug Report
epriestley closed T10751: Make Phabricator Highly Available as Resolved.

This spawned a healthy set of followups, but I believe the core work described here is now resolved and accounted for and all future work is covered in narrower followup tasks.

Jun 17 2016, 2:05 AM · Restricted Project, Infrastructure, Prioritized
epriestley closed T10512: Implement `user.search` Conduit API method as Resolved.

Appears resolved and accounted for.

Jun 17 2016, 2:02 AM · Prioritized, Restricted Project, People, Conduit, Feature Request
epriestley closed T10917: Build Glorious High-Security Notification/Audit Infrastructure as Resolved.

I believe this is resolved and accounted for, let us know if anyone runs into issues.

Jun 17 2016, 2:01 AM · Auth, Prioritized, Security, Feature Request
epriestley closed T10694: Improve behavior of context for inline comments in mail as Resolved.

This appears to be resolved and accounted for. There's one followup in T11120 (8bit vs base64 mail encoding) which also might be fixed now. If anyone runs into issues, let us know.

Jun 17 2016, 2:01 AM · Prioritized, Restricted Project, Differential, Mail
epriestley closed T6916: Allow video embed in remarkup as Resolved.

I believe this is now resolved and accounted for. See the remarkup documentation for some details.

Jun 17 2016, 1:57 AM · Prioritized, Remarkup
epriestley added a revision to T6916: Allow video embed in remarkup: Unknown Object (Differential Revision).
Jun 17 2016, 1:48 AM · Prioritized, Remarkup
epriestley closed T5187: Make "Upload File" dialog have a vanilla file upload control as Resolved.

I believe this is resolved and accounted for, let us know if anyone is hitting issues.

Jun 17 2016, 1:47 AM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley closed T5187: Make "Upload File" dialog have a vanilla file upload control, a subtask of T6523: Allow creating/adding images to mocks with a vanilla upload control, as Resolved.
Jun 17 2016, 1:47 AM · Prioritized, Pholio, Wikimedia
epriestley closed T6523: Allow creating/adding images to mocks with a vanilla upload control as Resolved.

I believe this is now fixed and all the business stuff is wrapped up on our side. If anyone runs into issues, feel free to file a followup describing what you're hitting.

Jun 17 2016, 1:46 AM · Prioritized, Pholio, Wikimedia
epriestley added a comment to T11166: When an install has no footer, Maniphest task previews have no bottom margin.

Sorry, my screenshot was garbage since all the text to the right was INCREDIBLY CONFIDENTIAL SECRETS.

Jun 17 2016, 1:43 AM · PHUI
chad added a comment to T11166: When an install has no footer, Maniphest task previews have no bottom margin.

Oh, on task view, I was looking the edit page.

Jun 17 2016, 1:42 AM · PHUI
chad moved T11167: Unbeta Feedback on Badges from v1 to v0 on the Badges board.
Jun 17 2016, 1:41 AM · Restricted Project, Badges (v0)
chad created T11167: Unbeta Feedback on Badges.
Jun 17 2016, 1:41 AM · Restricted Project, Badges (v0)
chad added a comment to T11164: Badges: Unwanted entry at the history.

Isn't Badges a Prototype?

Jun 17 2016, 1:34 AM · Badges, Bug Report
chad added a comment to T11166: When an install has no footer, Maniphest task previews have no bottom margin.

Yeah doesn't repro in Chrome.

Jun 17 2016, 1:33 AM · PHUI
epriestley created T11166: When an install has no footer, Maniphest task previews have no bottom margin.
Jun 17 2016, 12:31 AM · PHUI
Luke081515.2 created T11165: Changing a callsign throws a 404.
Jun 17 2016, 12:19 AM · Diffusion (v3), Bug Report
Luke081515.2 created T11164: Badges: Unwanted entry at the history.
Jun 17 2016, 12:04 AM · Badges, Bug Report

Jun 16 2016

carlos.prado.vsys edited the content of Organizations Using Phabricator.
Jun 16 2016, 11:39 PM
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

FWIW, examining every ref like that is a complete no-go for our situation

Jun 16 2016, 11:29 PM · Restricted Project, Prioritized, Audit, Restricted Project
joshuaspence added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

OK, so I just manually removed the branch from info/refs and packed-refs and I think that maybe that worked?

Jun 16 2016, 11:03 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

I think D16136 will "fix" the problem and I can't come up with any problems it creates, although it would be nice to figure out where the mystery ref is coming from.

Jun 16 2016, 11:02 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a revision to T9028: Phabricator handles commits which are published and later deleted poorly: Unknown Object (Differential Revision).
Jun 16 2016, 11:01 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

okay so basically ghosts?

Jun 16 2016, 11:00 PM · Restricted Project, Prioritized, Audit, Restricted Project
joshuaspence added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

Ah interesting. From our GitLab host, I see that git branch --all shows a whole bunch of local branches and only a single branch of the form remotes/origin/url_shortener.

Jun 16 2016, 10:58 PM · Restricted Project, Prioritized, Audit, Restricted Project
joshuaspence added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

Ah interesting. From our GitLab host, I see that git branch --all shows a whole bunch of local branches and only a single branch of the form remotes/origin/url_shortener.

Jun 16 2016, 10:54 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

I think checking if git ls-remote origin in the working copy lists a refs/remotes/origin/XYZ ref in the authoritative remote is the easiest way to check, although I'm not 100% sure that refs/remotes/ isn't magic with respect to ls-remote.

Jun 16 2016, 10:53 PM · Restricted Project, Prioritized, Audit, Restricted Project