Page MenuHomePhabricator

Updating a very large diff continues to warn against updating very large diffs
Open, WishlistPublic

Description

Understood that this is a pretty severe edge-case for a very minor annoyance

  1. I merged a longstanding branch which resulted in a merge commit of 512 files (unplanned power of 2, or phab caps at reporting > 512).
  2. I used arc diff to create a diff of the merge commit. I needed ~2 others to review certain parts of the merge which I was concerned with, which is why I created a diff.
  3. I was presented with a note from arc diff suggesting that large commits are not a good fit for review.
  4. Caution to the wind and continue anyways.
  5. Update the merge commit with additional changes/fixes.
  6. Update the diff with arc diff
  7. I was again presented with a note from arc diff suggesting that large commits are not a good fit for review.

This was only a minor annoyance but assuming that the existing diff is already considered sufficiently large, having the warning repeat seemed unnecessary. There may have been a better way to handle review of the large commit to create small diffs of the areas I was concerned with, but I wasn't able to come up with a clean way to accomplish that due to it being a merge.

Event Timeline

cspeckmim renamed this task from Updating a very large diff continues to warn against creating very large diffs to Updating a very large diff continues to warn against updating very large diffs.Apr 22 2016, 2:56 AM
cspeckmim updated the task description. (Show Details)

I think we generate this warning long before attaching the diff to a revision, so it isn't trivial to know where to look for a "you already confirmed this prompt once for the current revision" flag.

We also don't currently store such a flag anywhere in a queryable form.

epriestley triaged this task as Wishlist priority.Apr 22 2016, 10:44 AM
eadler added a project: Restricted Project.Jun 17 2016, 6:55 AM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jun 17 2016, 7:08 AM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 9:05 PM