There are a few pieces here, since we have to thread the needle through many layers to get where we want to go.

See also T13317.

See PHI1312. The modified JIRA rules reportedly misfire on URIs with anchors or parameters. For now, the plan is to just skip these URIs. In the future, we might specialize URIs which (for example) link to comments on foreign objects.

I'm going to close this in favor of T13291. Referencing files by full URI currently works, and relative references and other behavior is planned.

Getting rid of the indirect writes on handle reads would probably be nice eventually, but doesn't directly accomplish anything today.

I think that might be everything? Not entirely sure, but haven't seen any more since the last deploy.

D20573 has one issue where the "Select" buttons in the "Merge Duplicates In" dialog are now closing the dialog. We might be missing a JX.pass() / e.prevent() (hopefully) or might need to get slightly more creative in distinguishing between navigation links and javascript magic links.

See PHI954. The "support pact members" cache is currently updated only when you actually click "Support", but this is often silly and unintuitive.

Aha! This user very cleverly added noreply@admin.phacility.com to their user account before they were disabled.

I deployed that last round of things to secure. Not totally confident I got everything, but hopefully we're in better shape now.

The change above seems to have worked around things, I'll leave this open until we can confirm that PHP 7.3.6 or some later version fixes the underlying issue.

uhoh looks like I'm a dum dum

This is doing somewhat better now, but I've still seen:

If this table is retained, there's a mystery meat "branch" icon meaning "default branch" in the leftmost column. This should get a label/tip.

The shallow <hash> frames can not advertise capabilities.

Here's what goes over the wire:

To reproduce this, you can:

To reproduce the first issue, do this:

D20573 will fix this, but perhaps not in the most graceful way possible.

I applied this change to 20180208.maniphest.02.populate.php:

See also PHI1275. Now that Phriction supports relative references in [[ ... ]] syntax, moves should be able to modify those references.

I'm just going to close this in the hope it fades quietly into the night now that it has been "fixed".

D20563 probably fixes mail. I don't think (?) it will fix notifications but haven't hunted that down yet.

This likely affects other similar dialogs. The fix is to duct-tape something in Quicksand to something in the "click an area to click a link" behavior, most likely.