Page MenuHomePhabricator
Feed Advanced Search

Jan 6 2017

epriestley merged task T10569: Subproject tasks in parent project backlog into T11036: Put subproject columns on workboards.
Jan 6 2017, 7:28 PM · Workboards, Projects, Feature Request
epriestley added a comment to T10569: Subproject tasks in parent project backlog.

I'm going to merge this into T11036, which specifically describes subproject columns.

Jan 6 2017, 7:28 PM · Workboards, Projects, Feature Request
epriestley moved T11022: Implement a `current-milestone-of(project)` tokenizer function from Backlog to Far Future on the Projects board.
Jan 6 2017, 7:25 PM · Projects, Feature Request
epriestley triaged T11022: Implement a `current-milestone-of(project)` tokenizer function as Low priority.

One concern I have with this is that the largest sequential milestone may not be the "current" milestone. If you're currently in Sprint 4, someone may reasonably create Sprint 5 before Sprint 4 concludes.

Jan 6 2017, 7:25 PM · Projects, Feature Request
epriestley renamed T11022: Implement a `current-milestone-of(project)` tokenizer function from Query for latest milestone to Implement a `current-milestone-of(project)` tokenizer function.
Jan 6 2017, 7:16 PM · Projects, Feature Request
epriestley closed T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page as Resolved.

Per above, this is working as intended. I'm open to implementing "Copy Columns from <Previous Milestone>" if anyone actually wants that, but it seems like I may have just made it up. Feel free to file a new task if you'd like to see it.

Jan 6 2017, 7:15 PM · Projects, Feature Request
epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

Yep, that looks good to me.

Jan 6 2017, 7:11 PM · Design
epriestley added a comment to T12074: conduit API extensions for subprojects and milestones..

For (2), the specific problem is that there's no way to look up the milestone PHID, right? If you have the PHID I believe maniphest.search lets you find tasks tagged with a particular milestone:

Jan 6 2017, 7:10 PM · Feature Request
epriestley added a comment to T12073: Phabricator does not change status to accepted if you comment when you accept.

I think this should be fixed by D17146, which landed a few hours ago. Presumably you're running some ancient stone-age version of Phabricator that's 6 or more hours old?

Jan 6 2017, 12:46 AM · Differential, Bug Report
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

I think I got all of these, but yell if you catch any more.

Jan 6 2017, 12:27 AM · PHUI, Bug Report
epriestley closed T10687: jx-tooltip does whatever it feels like as Resolved by committing Restricted Diffusion Commit.
Jan 6 2017, 12:03 AM · PHUI, Bug Report
epriestley closed T12064: Tooltip for "Preview" in comment box overflows horizontally as Resolved by committing Restricted Diffusion Commit.
Jan 6 2017, 12:03 AM · Bug Report

Jan 5 2017

epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

This should do it:

Jan 5 2017, 11:10 PM · Daemons, Bug Report
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

(After T12071 we will almost certainly require "E", so you could get ahead of that now.)

Jan 5 2017, 10:54 PM · Daemons, Bug Report
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

Actually, it looks like PHP defaults to "EGPCS" but ships with config files that use "GPCS" (??? why would you do this ???), so this is probably not something that got changed or configured intentionally or accidentally.

Jan 5 2017, 10:53 PM · Daemons, Bug Report
epriestley closed T12070: phd no longer recognizes PHABRICATOR_ENV? as Resolved by committing Restricted Diffusion Commit.
Jan 5 2017, 10:48 PM · Daemons, Bug Report
epriestley closed T12070: phd no longer recognizes PHABRICATOR_ENV?, a subtask of T12071: Require "E" be defined in variables_order so $_ENV is correctly populated, as Resolved.
Jan 5 2017, 10:48 PM · Infrastructure
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

Perfect, thanks! That's what I expected, so D17148 should resolve this. Alternatively, setting that value to "EGPCS" (without upgrading, just restarting the daemons) should also resolve this.

Jan 5 2017, 10:48 PM · Daemons, Bug Report
epriestley added a comment to T12069: `arc diff --reviewers` inserts reviewers twice..

I believe this is now fixed at HEAD of master. You should be able to pick up the change with arc upgrade now (if you run master) or in about 36 hours (if you run stable).

Jan 5 2017, 10:36 PM · Arcanist, Bug Report
epriestley closed T12069: `arc diff --reviewers` inserts reviewers twice. as Resolved by committing Restricted Diffusion Commit.
Jan 5 2017, 10:35 PM · Arcanist, Bug Report
epriestley added a project to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated: Infrastructure.
Jan 5 2017, 10:35 PM · Infrastructure
epriestley added a revision to T12070: phd no longer recognizes PHABRICATOR_ENV?: Unknown Object (Differential Revision).
Jan 5 2017, 10:33 PM · Daemons, Bug Report
epriestley added a revision to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated: Unknown Object (Differential Revision).
Jan 5 2017, 10:33 PM · Infrastructure
epriestley added a parent task for T11940: Commit hooks in hosted Git repositories fail under Git 2.11.0: T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.
Jan 5 2017, 10:30 PM · Bug Report
epriestley added a subtask for T12071: Require "E" be defined in variables_order so $_ENV is correctly populated: T11940: Commit hooks in hosted Git repositories fail under Git 2.11.0.
Jan 5 2017, 10:30 PM · Infrastructure
epriestley added a subtask for T12071: Require "E" be defined in variables_order so $_ENV is correctly populated: T12070: phd no longer recognizes PHABRICATOR_ENV?.
Jan 5 2017, 10:27 PM · Infrastructure
epriestley added a parent task for T12070: phd no longer recognizes PHABRICATOR_ENV?: T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.
Jan 5 2017, 10:27 PM · Daemons, Bug Report
epriestley created T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.
Jan 5 2017, 10:27 PM · Infrastructure
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

While I'm chasing this down, can you show me the output of this command?

Jan 5 2017, 10:26 PM · Daemons, Bug Report
epriestley added a comment to T12070: phd no longer recognizes PHABRICATOR_ENV?.

This is an unintended side effect of D17100 but resolution isn't straightforward.

Jan 5 2017, 10:14 PM · Daemons, Bug Report
epriestley added a revision to T12069: `arc diff --reviewers` inserts reviewers twice.: Restricted Differential Revision.
Jan 5 2017, 10:01 PM · Arcanist, Bug Report
epriestley added a comment to T12069: `arc diff --reviewers` inserts reviewers twice..

This is D17122 interacting with some extremely high-quality code in arc.

Jan 5 2017, 9:56 PM · Arcanist, Bug Report
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 5 2017, 7:17 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T12068: Inbound Emails View Mail Body shows the wrong command as Resolved by committing Restricted Diffusion Commit.
Jan 5 2017, 4:59 PM · Bug Report
epriestley closed T12067: Inbound Email Reply-to not set correctly as Invalid.

This is far afield from an actionable bug report.

Jan 5 2017, 4:58 PM · Bug Report
epriestley added a revision to T10687: jx-tooltip does whatever it feels like: Unknown Object (Differential Revision).
Jan 5 2017, 4:53 PM · PHUI, Bug Report
epriestley added a revision to T12064: Tooltip for "Preview" in comment box overflows horizontally: Unknown Object (Differential Revision).
Jan 5 2017, 4:53 PM · Bug Report
epriestley added a comment to T12067: Inbound Email Reply-to not set correctly.

Using postfix instead of sendmail

Jan 5 2017, 4:21 PM · Bug Report
epriestley added a comment to T12068: Inbound Emails View Mail Body shows the wrong command.

We could possibly remove it entirely since I think it isn't useful for 99% of users, but D17144 just fixes the command.

Jan 5 2017, 3:40 PM · Bug Report
epriestley added a revision to T12068: Inbound Emails View Mail Body shows the wrong command: Unknown Object (Differential Revision).
Jan 5 2017, 3:40 PM · Bug Report
epriestley claimed T12068: Inbound Emails View Mail Body shows the wrong command.
Jan 5 2017, 3:38 PM · Bug Report
epriestley added a comment to T11989: Wage an endless war against HP Printer Fax Support.

That one is somewhat interesting because the user created a safe-looking object, then edited the objectionable content into it. I had hoped we might see a few years of uneasy peace before things escalated so far.

Jan 5 2017, 3:33 PM · Abuse
epriestley added a comment to T12064: Tooltip for "Preview" in comment box overflows horizontally.

I think this really is the same as T10687, but the jittery bad degenerate behavior is only when a scrollbar gets added, so probably laptop + mouse works to repro but not laptop + touchpad?

Jan 5 2017, 3:21 AM · Bug Report
epriestley awarded T12065: Can't close actions in Maniphest a Evil Spooky Haunted Tree token.
Jan 5 2017, 3:18 AM · Bug Report
epriestley added a comment to T12065: Can't close actions in Maniphest.

Thanks for the excellent bug report with high-quality reproduction steps. Your clear, thorough reproduction steps made fixing this issue extremely easy!

Jan 5 2017, 3:17 AM · Bug Report
epriestley closed T12065: Can't close actions in Maniphest as Resolved by committing Restricted Diffusion Commit.
Jan 5 2017, 3:17 AM · Bug Report
epriestley added a revision to T12065: Can't close actions in Maniphest: Unknown Object (Differential Revision).
Jan 5 2017, 3:15 AM · Bug Report
epriestley claimed T12065: Can't close actions in Maniphest.
Jan 5 2017, 3:11 AM · Bug Report
epriestley closed T12061: When problems occur in phd inside sudo error messages are neither printed nor logged as Invalid.

Specifically, this was already improved by D15726 in April 2016.

Jan 5 2017, 3:09 AM · Feature Request

Jan 4 2017

epriestley closed T10136: Show warning in Revision when build failed as Resolved by committing Restricted Diffusion Commit.
Jan 4 2017, 11:12 PM · Restricted Project, Differential, Feature Request
epriestley added a revision to T10136: Show warning in Revision when build failed: Unknown Object (Differential Revision).
Jan 4 2017, 10:07 PM · Restricted Project, Differential, Feature Request
epriestley added a comment to T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker.

The revision editor and diff editor should no longer be racing to edit the diff. The two revision editors may be racing now, but that race is significantly easier to resolve if it crops up.

Jan 4 2017, 9:57 PM · Restricted Project, Harbormaster (v3), Differential
epriestley added a comment to T9276: Display when builds happen with status somewhere handy, like the differential timeline.

This should work again now. The behavior probably needs refinement -- I don't remember exactly where we left it and I think there was some disagreement about who should or shouldn't receive build failure notifications before D10911 accidentally disabled this, but I think T9892 and other Harbormaster tasks discuss most of that.

Jan 4 2017, 9:56 PM · Restricted Project, Harbormaster (v3), Differential
epriestley closed T9276: Display when builds happen with status somewhere handy, like the differential timeline as Resolved by committing Restricted Diffusion Commit.
Jan 4 2017, 9:46 PM · Restricted Project, Harbormaster (v3), Differential
epriestley closed T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker as Resolved by committing Restricted Diffusion Commit.
Jan 4 2017, 9:46 PM · Restricted Project, Harbormaster (v3), Differential
epriestley closed T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker, a subtask of T8657: Harbormaster v1 Errata, as Resolved.
Jan 4 2017, 9:46 PM · Harbormaster
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Chrome upstream has patched this, now:

Jan 4 2017, 9:31 PM · Bug Report
epriestley added a revision to T9276: Display when builds happen with status somewhere handy, like the differential timeline: Unknown Object (Differential Revision).
Jan 4 2017, 9:24 PM · Restricted Project, Harbormaster (v3), Differential
epriestley added a revision to T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker: Unknown Object (Differential Revision).
Jan 4 2017, 9:24 PM · Restricted Project, Harbormaster (v3), Differential
epriestley added a comment to T10939: Support for OWNERS files.

From elsewhere:

Jan 4 2017, 8:40 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

I'm not actually sure which will end up being easier, I think they have like 95% of the same problems. Quick Create probably is a bit easier, though.

Jan 4 2017, 7:07 PM · Design
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Haha, maybe it's like when Blizzard uses a simulator to build a colorblind mode they screw it up, therefor the simulator must not work?

Jan 4 2017, 7:03 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Ah, cool. I'm 100% onboard with it if an actual affected user has confirmed that the change is good, I'm just really uneasy about accessibility changes that don't actually involve the affected users.

Jan 4 2017, 7:02 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Do you specifically not want to add a red-green colorblind mode to the existing "Accessibility" settings?

Jan 4 2017, 6:59 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

If a change only had one of those colors (e.g., just one added section, or just one removed section) I think I'd have no clue if it was removed-red or added-red.

Jan 4 2017, 6:55 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

You were thinking about doing this one first, then Home later, right?

Jan 4 2017, 6:19 PM · Design
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

That's easy to add, but I'd worry it will result in much worse readability for all users for diffs with a lot of small corrections. If there are just 1-2 big edits the extra "+" and "-" probably aren't a big deal, but choppier edits will get a lot of extra annotation.

Jan 4 2017, 6:09 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a comment to T9515: Build a "quorum" mechanism and associated UI.

100% accurate mockup of this feature

Jan 4 2017, 6:04 PM · Restricted Project, Notifications, Phacility, Auth
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

I'm hesitant about using math to solve this because I think Blizzard did that in Overwatch (apparently? or something?) and ended up with modes that were worse for colorblind users than users with normal vision:

Jan 4 2017, 6:00 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a comment to T12061: When problems occur in phd inside sudo error messages are neither printed nor logged.

What version of Phabricator are you running? See Providing Version Information for help.

Jan 4 2017, 5:18 PM · Feature Request
epriestley closed T12062: Survive import of artificially manufactured Git commits with no timestamps as Resolved by committing Restricted Diffusion Commit.
Jan 4 2017, 5:07 PM · Diffusion
epriestley added a revision to T12062: Survive import of artificially manufactured Git commits with no timestamps: Unknown Object (Differential Revision).
Jan 4 2017, 3:45 PM · Diffusion
epriestley closed T11978: Storage Tools Not Actually Upgrading Database as Resolved.

Cool, glad things are back in working order. Thanks for following up.

Jan 4 2017, 3:37 PM · Bug Report (Needs Information)
epriestley added a comment to T12062: Survive import of artificially manufactured Git commits with no timestamps.

I believe this reproduces by following the steps in T11537#192019, but deleting all timestamp information completely.

Jan 4 2017, 3:15 PM · Diffusion
epriestley created T12062: Survive import of artificially manufactured Git commits with no timestamps.
Jan 4 2017, 3:00 PM · Diffusion
epriestley closed T12058: url rewriting 302 redirects do not respect custom port as Resolved by committing Restricted Diffusion Commit.
Jan 4 2017, 2:55 PM · Bug Report
epriestley closed T12056: Searching for symbol / filename "PhabricatorProfilePanel" does not list commit when this symbol / file was removed as Wontfix.

This is working as intended.

Jan 4 2017, 2:54 PM · Bug Report
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

What color scheme would the user prefer?

Jan 4 2017, 8:38 AM · Accessibility, Design, Feature Request, Restricted Project

Jan 3 2017

epriestley added a comment to T12058: url rewriting 302 redirects do not respect custom port.

I was able to reproduce this at HEAD and D17134 should fix it, but please make sure future issues you report are against upstream code -- not forked local code -- and that your install is up to date. Many issues are already fixed by the time they are reported, and we are powerless to troubleshoot issues with local code even if we wanted to.

Jan 3 2017, 5:57 PM · Bug Report
epriestley claimed T12058: url rewriting 302 redirects do not respect custom port.
Jan 3 2017, 5:55 PM · Bug Report
epriestley added a revision to T12058: url rewriting 302 redirects do not respect custom port: Unknown Object (Differential Revision).
Jan 3 2017, 5:54 PM · Bug Report
epriestley closed T12059: Display numerical indicator for authored, ready to land differentials on the differential home page menu item as Invalid.

See Consulting if you'd like a one-on-one answer from the upstream.

Jan 3 2017, 5:40 PM · Feature Request (Needs Information)
epriestley edited projects for T12059: Display numerical indicator for authored, ready to land differentials on the differential home page menu item, added: Feature Request (Needs Information); removed Feature Request.

Please see Contributing Feature Requests for instructions on filing a feature request which can become a maintainable feature in the upstream.

Jan 3 2017, 5:19 PM · Feature Request (Needs Information)
epriestley added a comment to T12057: Cannot reduce the number of lines using backticks and lines=2.

Specifically, the limit is enforced here. You could remove this limit locally if you are not concerned about the usability of the result:

Jan 3 2017, 4:01 PM · Bug Report
epriestley closed T12057: Cannot reduce the number of lines using backticks and lines=2 as Invalid.

This is not a bug. The element has a minimum height because viewing or selecting text from a tiny element would create usability issues: imagine trying to select 30 lines from the middle of a 100-line block with lines=2.

Jan 3 2017, 3:56 PM · Bug Report

Jan 2 2017

epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 2 2017, 7:47 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 2 2017, 7:22 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a comment to T9640: Make Phabricator compatible with PHP7.

See Planning for more information on understanding timelines and priorities, which also answers your question. Thanks!

Jan 2 2017, 7:16 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 2 2017, 6:56 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T9058: PhabricatorPolicyFilter::hasCapability() does not apply application-level "Can Use Application" policy checks as Resolved by committing Restricted Diffusion Commit.
Jan 2 2017, 6:00 PM · Policy, Differential, Daemons
joshuaspence added projects to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward): Diffusion, Herald.
Jan 2 2017, 10:26 AM · Diffusion, Herald, Bug Report
joshuaspence added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

You're watching #twitter.

Jan 2 2017, 1:42 AM · Prioritized, Restricted Project, Arcanist, Bug Report

Jan 1 2017

epriestley added a revision to T9058: PhabricatorPolicyFilter::hasCapability() does not apply application-level "Can Use Application" policy checks: Unknown Object (Differential Revision).
Jan 1 2017, 7:10 PM · Policy, Differential, Daemons
epriestley closed T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there as Resolved by committing Restricted Diffusion Commit.
Jan 1 2017, 5:56 PM · Restricted Project, Differential, Arcanist, Bug Report
epriestley closed T9648: Diffs do not use extended policies, so object policies evaluate in the wrong context as Resolved by committing Restricted Diffusion Commit.
Jan 1 2017, 5:56 PM · Policy, Differential
epriestley closed T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:" as Resolved by committing Restricted Diffusion Commit.
Jan 1 2017, 5:56 PM · Restricted Project, Diffusion, Differential, Arcanist, Bug Report
epriestley closed T8360: Differential commit message field parser does not recover from "Differential Revision: X\nAd-Hoc-Custom-Field: Y" as Resolved by committing Restricted Diffusion Commit.
Jan 1 2017, 5:56 PM · Restricted Project, Differential, FreeBSD
epriestley moved T9058: PhabricatorPolicyFilter::hasCapability() does not apply application-level "Can Use Application" policy checks from Backlog to v3 (Infrastructure) on the Differential board.
Jan 1 2017, 5:49 PM · Policy, Differential, Daemons
epriestley renamed T9058: PhabricatorPolicyFilter::hasCapability() does not apply application-level "Can Use Application" policy checks from PhabricatorApplicationTransactionPublishWorker failures to PhabricatorPolicyFilter::hasCapability() does not apply application-level "Can Use Application" policy checks.
Jan 1 2017, 5:48 PM · Policy, Differential, Daemons
epriestley added a comment to T9058: PhabricatorPolicyFilter::hasCapability() does not apply application-level "Can Use Application" policy checks.

I think the desired behavior is to silently drop the notifications, yes. Specifically, they should be dropped in PhabricatorMailReplyHandler->filterRecipientUsers().

Jan 1 2017, 5:48 PM · Policy, Differential, Daemons