When I run
arc diff --reviewers amos
It pops up an edit window that looks like this:
Fix the suite-loading to detect attribute errors as well.
Summary:
I now iterate through the test-suite properly.
Reviewers: amos
Test Plan:
I modified selenium_tests/tests/pageload/loggedout_e2etest.py to set
the first ALL_LANGUAGE_TEST to `util.Page("", "/")`, which raise a
value-error at import time. I then ran
tools/rune2etests.py selenium_tests/tests/pageload
and it died.
Reviewers:
Subscribers:As you can see, it has an empty Reviewers: line (and Subscribers:) at the end, in addition to the properly-populated Reviewers:` line earlier in the message.
When I save, it notices and asks me to edit the message, which is great, but it would be even greater if it didn't create the problem in the first place.