Page MenuHomePhabricator
Create Task
Maniphest T12064

Tooltip for "Preview" in comment box overflows horizontally
Closed, ResolvedPublic
Actions

Description

When using haunt mode, extra scrollbars appear when hovering over the "Preview" icon and triggering the Tooltip. To reproduce:

  • Master (HEAD)
  • Enable Haunt mode by hitting Z or clicking the pin icon in the comment toolbar
  • Hover mouse over preview icon
  • Entire haunt mode div jumps repeatedly (Chrome, Mac, Desktop)

FWIW, I can't duplicate this on a laptop. T10687 is still likely the root issue, but maybe there s a div we can overflow: hidden here.

Revisions and Commits

rP Phabricator
D17145rP5ff02058a4b0 Make JX.Tooltip more conservative about positioning

Related Objects

Event Timeline

diagramatics created this task.Jan 5 2017, 1:08 AM
chad closed this task as a duplicate of T10687: jx-tooltip does whatever it feels like.Jan 5 2017, 2:01 AM
chad reopened this task as Open.Jan 5 2017, 2:07 AM
chad added a subscriber: chad.

Actually, this is a haunt mode bug, I'll update the description with a full set of reproducible steps.

chad updated the task description. (Show Details)Jan 5 2017, 2:09 AM
chad updated the task description. (Show Details)
chad updated the task description. (Show Details)Jan 5 2017, 3:00 AM
epriestley added a subscriber: epriestley.Jan 5 2017, 3:21 AM

I think this really is the same as T10687, but the jittery bad degenerate behavior is only when a scrollbar gets added, so probably laptop + mouse works to repro but not laptop + touchpad?

I'll just look at fixing this and T10687 and see where we end up.

chad added a comment.Jan 5 2017, 3:23 AM

On my laptop it triggers either to the right of the preview icon or to the bottom, on my desktop, it does top, and gets jittery.

epriestley added a revision: D17145: Make JX.Tooltip more conservative about positioning.Jan 5 2017, 4:52 PM
epriestley closed this task as Resolved by committing rP5ff02058a4b0: Make JX.Tooltip more conservative about positioning.Jan 6 2017, 12:03 AM
epriestley added a commit: rP5ff02058a4b0: Make JX.Tooltip more conservative about positioning.
Phabricator · Built by Phacility