Page MenuHomePhabricator
Feed Advanced Search

Mar 23 2016

epriestley updated subscribers of T10635: Loading differential revision slow when lots of unit test messages exist.
Mar 23 2016, 5:49 PM · Restricted Project, Haskell.org, Harbormaster, Performance
epriestley merged task T9704: Differential pages slow to a crawl when there are a lot (tens of thousands) of tests on the diff. into T10635: Loading differential revision slow when lots of unit test messages exist.
Mar 23 2016, 5:49 PM · Restricted Project, Harbormaster
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Mar 23 2016, 5:36 PM
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Mar 23 2016, 5:35 PM
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Mar 23 2016, 5:35 PM
epriestley added a comment to T10635: Loading differential revision slow when lots of unit test messages exist.

We don't currently have a sortable column on the unit message table, since pass, fail, etc., aren't naturally sortable by any key MySQL can construct.

Mar 23 2016, 5:34 PM · Restricted Project, Haskell.org, Harbormaster, Performance
epriestley triaged T10645: Accepting a closed diff causes diff to be re-opened as Low priority.
Mar 23 2016, 5:19 PM · Differential, Bug Report
epriestley added a comment to T10645: Accepting a closed diff causes diff to be re-opened.

This is probably not a true race in the strict technical sense, I suspect you can reproduce it by doing one of these at walking speed:

Mar 23 2016, 5:18 PM · Differential, Bug Report
epriestley closed T5485: Write a script to discover orphaned PHIDs as Wontfix.

I think it's very unlikely that we'll ever write some kind of script to just fix this stuff. I suspect such a script is impossible to write (i.e., the "correct" value for most fields is ambiguous) and that maintaining it is very difficult.

Mar 23 2016, 5:05 PM · Restricted Project, Infrastructure
epriestley added a comment to T10644: Implement an "ASIDE" or "MEMO" Remarkup element for de-emphasis.

I don't particularly love ASIDE as the trigger, maybe MEMO is a little better? But it doesn't really capture the intent particularly well, I think.

Mar 23 2016, 4:38 PM · Remarkup, Feature Request
epriestley renamed T10644: Implement an "ASIDE" or "MEMO" Remarkup element for de-emphasis from small text in remarkup to Implement an "ASIDE" or "MEMO" Remarkup element for de-emphasis.
Mar 23 2016, 4:30 PM · Remarkup, Feature Request
epriestley closed T10652: Allow arcanist to plan changes to a revision as Wontfix.

I think this option would very rarely see use, and @avivey's suggestion (arc browse D1234 + use web UI) is a pretty good workaround.

Mar 23 2016, 4:17 PM · Arcanist, Feature Request
epriestley added a comment to T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.

T7789 has some discussion, but there's now a clear pathway forward here which doesn't require anything too drastic. Specifically:

Mar 23 2016, 4:07 PM · Diffusion (v3), Restricted Project
• spiridon-alexandru awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Mar 23 2016, 11:50 AM · Workboards (v3), Restricted Project
epriestley added a comment to T10653: Add Herald condition to act on pushing commits that have more than 1 parent.

I added you to Community so you should have task edit powers now.

Mar 23 2016, 2:25 AM · Feature Request
epriestley added a member for Community: swisspol.
Mar 23 2016, 2:25 AM
epriestley closed T10653: Add Herald condition to act on pushing commits that have more than 1 parent as Resolved.
Mar 23 2016, 2:19 AM · Feature Request
epriestley closed T10651: Attempting to create a credential of type API Token always results in an exception as Resolved by committing Restricted Diffusion Commit.
Mar 23 2016, 1:53 AM · Passphrase, Bug Report
epriestley added a comment to T10651: Attempting to create a credential of type API Token always results in an exception.

Whoops, thanks. This got rebased across 200 years of changes and I didn't re-test creating a credential. D15512 should fix it.

Mar 23 2016, 1:52 AM · Passphrase, Bug Report
epriestley added a revision to T10651: Attempting to create a credential of type API Token always results in an exception: Unknown Object (Differential Revision).
Mar 23 2016, 1:52 AM · Passphrase, Bug Report
epriestley added a comment to T10653: Add Herald condition to act on pushing commits that have more than 1 parent.

"Is merge commit" detects this.

Mar 23 2016, 1:49 AM · Feature Request

Mar 22 2016

epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 22 2016, 11:09 PM · Nuance, GitHub
nornagon awarded T10363: Reorient Doorkeeper publishing around transactions instead of feed stories a Piece of Eight token.
Mar 22 2016, 10:59 PM · Nuance, Restricted Project, Feed, Doorkeeper
epriestley added a comment to T5462: How do I publish Phabricator events into remote systems?.

See T5726, T10363.

Mar 22 2016, 10:55 PM · Guides, Herald, Feed, Doorkeeper
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 22 2016, 10:21 PM · Nuance, GitHub
epriestley added a comment to T10642: Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS.

just convinced that Phab search didn't work and feeling powerless over it

Mar 22 2016, 9:35 PM · Search, Bug Report
epriestley added a comment to T10640: Allow application queries to be promoted as global search modes.

See also T4103.

Mar 22 2016, 9:07 PM · Search, Feature Request
dpaola2 awarded T9456: Evaluate upstream support for third-party build systems a Mountain of Wealth token.
Mar 22 2016, 8:22 PM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

CircleCI fixed build_parameters in their API so support is now in HEAD of master. There's probably some remaining work but it seems to work properly locally. Let us know if you run into issues with it.

Mar 22 2016, 7:16 PM · Restricted Project, Harbormaster
epriestley closed T10649: more flexibility in Herald rules as Resolved.

Sounds like this is resolved one way or the other. In the general case, "Another Herald rule" effectively allows you to group, negate, and combine conditions in addition to reusing/including them.

Mar 22 2016, 5:05 PM · Feature Request
epriestley added a comment to T10649: more flexibility in Herald rules.

You can use two rules:

Mar 22 2016, 5:02 PM · Feature Request
epriestley created T10650: `arc land` can raise misleading error message if a branch exists in the remote but has never been fetched.
Mar 22 2016, 5:00 PM · Restricted Project, Arcanist
epriestley added a comment to T10648: Task project list ellipsis displays unecessary.

This should be fixed in HEAD of master. Let us know if you're still seeing issues after updating. Thanks for the report!

Mar 22 2016, 4:29 PM · Bug Report
epriestley closed T10648: Task project list ellipsis displays unecessary as Resolved by committing Restricted Diffusion Commit.
Mar 22 2016, 4:29 PM · Bug Report
Luke081515.2 awarded T10538: Bridge GitHub to Phabricator a Mountain of Wealth token.
Mar 22 2016, 4:26 PM · Nuance, GitHub
epriestley added a revision to T10648: Task project list ellipsis displays unecessary: Unknown Object (Differential Revision).
Mar 22 2016, 4:21 PM · Bug Report
epriestley added a comment to T10646: Actions are not populated when creating herald rule (Chrome v49 issue).

I think this should be fixed in HEAD, let us know if you're still seeing it after updating. Thanks for the report!

Mar 22 2016, 4:14 PM · Herald, Bug Report
epriestley closed T10646: Actions are not populated when creating herald rule (Chrome v49 issue) as Resolved by committing Restricted Diffusion Commit.
Mar 22 2016, 4:13 PM · Herald, Bug Report
epriestley added a revision to T10646: Actions are not populated when creating herald rule (Chrome v49 issue): Unknown Object (Differential Revision).
Mar 22 2016, 4:11 PM · Herald, Bug Report
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 22 2016, 2:36 PM · Nuance (v1)
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 22 2016, 1:43 PM · Nuance, GitHub
epriestley added a comment to T10643: support icon in links.

This is already documented, do you have any suggestions for improving the existing documentation?

Mar 22 2016, 4:09 AM · Remarkup, Feature Request
epriestley added a comment to T10644: Implement an "ASIDE" or "MEMO" Remarkup element for de-emphasis.

Yeah, I think changing text size inline often tends to look pretty bad since line heights get all messed up, too.

Mar 22 2016, 3:32 AM · Remarkup, Feature Request
epriestley added a comment to T10643: support icon in links.

Note that you can do this today:

Mar 22 2016, 2:07 AM · Remarkup, Feature Request
epriestley added a comment to T10643: support icon in links.

We're planning to do this at some point:

Mar 22 2016, 2:05 AM · Remarkup, Feature Request
epriestley added a comment to T10644: Implement an "ASIDE" or "MEMO" Remarkup element for de-emphasis.

Do you have some examples of things you'd like to use this for?

Mar 22 2016, 2:01 AM · Remarkup, Feature Request
epriestley added a comment to T10638: A Task can end up on a Milestone workboard column without being in that Milestone.

Yeah -- it's not very clear on its own, but this comment is specifically referring to that issue:

Mar 22 2016, 1:26 AM · Projects (v3), Bug Report
epriestley closed T10589: Create useable search experience for Maniphest as Resolved.

Closing this in favor of followups.

Mar 22 2016, 1:24 AM · Feature Request
epriestley added a project to T10640: Allow application queries to be promoted as global search modes: Search.
Mar 22 2016, 1:23 AM · Search, Feature Request
epriestley added a project to T10642: Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS: Search.
Mar 22 2016, 1:23 AM · Search, Bug Report
epriestley added a project to T10639: Implement a complex Gmail-style "to:<name>" query language: Search.
Mar 22 2016, 1:22 AM · Search, Feature Request
epriestley renamed T10639: Implement a complex Gmail-style "to:<name>" query language from Search: Gmail-style "to:<name>", etc. searching to significantly speed up power users to Implement a complex Gmail-style "to:<name>" query language.
Mar 22 2016, 1:22 AM · Search, Feature Request
epriestley triaged T10639: Implement a complex Gmail-style "to:<name>" query language as Wishlist priority.

We are vanishingly unlikely to pursue this naturally. It is very complex and we do not consider it valuable. We have never seen similar requests from other installs, and this UI seems far worse for most users because it makes discovery difficult.

Mar 22 2016, 1:22 AM · Search, Feature Request
epriestley added a comment to T10642: Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS.

We can resolve this by parsing the query and rewriting the query we submit to the engine as "+x +y" if ft_boolean_syntax has not been adjusted.

Mar 22 2016, 1:14 AM · Search, Bug Report
epriestley renamed T10642: Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS from Search experience is not useable on Amazon RDS to Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS.
Mar 22 2016, 1:11 AM · Search, Bug Report
epriestley renamed T10640: Allow application queries to be promoted as global search modes from Expose advanced maniphest search filters in main search to Allow application queries to be promoted as global search modes.
Mar 22 2016, 1:10 AM · Search, Feature Request
epriestley triaged T10640: Allow application queries to be promoted as global search modes as Wishlist priority.

These fields don't apply to other document types, and other document types have other fields which do apply to these results. It does not make sense to search all documents by, e.g., "Priorities". We definitely aren't going to pursue this as described.

Mar 22 2016, 1:10 AM · Search, Feature Request
epriestley updated subscribers of T8646: Provide more context for search results, particularly wiki documents.
Mar 22 2016, 12:58 AM · Design, Search, Restricted Project
epriestley merged task T10641: show same visual detailing on tasks in "all documents" search as is shown in maniphest search into T8646: Provide more context for search results, particularly wiki documents.
Mar 22 2016, 12:58 AM · Feature Request
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 22 2016, 12:40 AM · Nuance (v1)
epriestley added a comment to T10638: A Task can end up on a Milestone workboard column without being in that Milestone.

T10486 is related; T6027 and T5214 are somewhat related.

Mar 22 2016, 12:10 AM · Projects (v3), Bug Report

Mar 21 2016

epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 21 2016, 6:42 PM · Nuance (v1)
epriestley changed the status of T10234: When using a PhabricatorRemarkupCustomInlineRule with caching disabled, custom rules may end up with incorrect engines from Invalid to Resolved by committing Restricted Diffusion Commit.
Mar 21 2016, 6:24 PM · Remarkup, Bug Report
epriestley added a revision to T10234: When using a PhabricatorRemarkupCustomInlineRule with caching disabled, custom rules may end up with incorrect engines: Unknown Object (Differential Revision).
Mar 21 2016, 6:21 PM · Remarkup, Bug Report
epriestley added a comment to Q347: task hierarchy template.

T7190 has discussion of a similar case.

Mar 21 2016, 6:07 PM · Maniphest
epriestley closed T10634: sorenalara as Spite.
Mar 21 2016, 5:06 PM · Feature Request
epriestley moved T10633: Render timezones explicitly in email from Backlog to Unprototype (v1) on the Calendar board.
Mar 21 2016, 4:41 PM · Calendar, Mail, Countdown, Bug Report
epriestley added a project to T10633: Render timezones explicitly in email: Calendar.

I think this isn't tremendously important for Countdown but should definitely be sorted out before we unbeta Calendar.

Mar 21 2016, 4:41 PM · Calendar, Mail, Countdown, Bug Report
epriestley added a comment to T10633: Render timezones explicitly in email.

It might not be bad to always show timezones in email explicitly to deal with cases related to T3025 better (e.g., you fly to the east coast for a conference, get prompted to reconcile your timezone after T3025, and it may not be obvious that this also affects mail you receive until you return and re-reconicle back to PST).

Mar 21 2016, 4:15 PM · Calendar, Mail, Countdown, Bug Report
epriestley triaged T10633: Render timezones explicitly in email as Wishlist priority.

With metamta.one-mail-per-recipient on, we can adjust this to the viewer's preferences.

Mar 21 2016, 4:13 PM · Calendar, Mail, Countdown, Bug Report

Mar 20 2016

avivey awarded T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential a Doubloon token.
Mar 20 2016, 6:45 PM · Restricted Project, Differential
epriestley added a comment to T1258: Add an "Automatically CC Owners on Differential Revisions" checkbox to Owners.

I also may just restore this at some point to align with user expectation, even though I think it's a bad feature and we benefited on the balance from removing it.

Mar 20 2016, 5:20 PM · Restricted Project, Owners
epriestley added a comment to T10623: Allow Herald actions to reference conditions.

T1258 might be another attack on this, not sure how much that overlaps things.

Mar 20 2016, 5:18 PM · Restricted Project, Herald, Feature Request
epriestley added a comment to T10623: Allow Herald actions to reference conditions.

We have a large, and growing, set of teams that would like to get CCed whenever a review is created in a repository they work in.

Mar 20 2016, 5:12 PM · Restricted Project, Herald, Feature Request
chad awarded T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential a Piece of Eight token.
Mar 20 2016, 3:22 PM · Restricted Project, Differential
epriestley added a comment to T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential.

Yeah, pretty much the same for me. I believe "Open Revisions" has a small population of fans and "Local Commits" may get more useful eventually (e.g., after whatever happens with T1508) but I think we're on fairly firm ground shoving these into tabs.

Mar 20 2016, 12:55 PM · Restricted Project, Differential
epriestley added a comment to T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential.

I spent some time on this, but this ends up being more involved than I thought because there's a lot of weirdness around how actions and property lists interact, so this is probably blocked on making all UIs which use property list tabs and actions switch to the two column view.

Mar 20 2016, 12:23 PM · Restricted Project, Differential
epriestley added a comment to T5214: Add Conduit API methods for workboards.

To provide some context, until recently, the API was in bad shape. Basically, the first time we wrote an application we'd maybe write some application.whatever methods, which shared some code with the rest of the application but not all of it, and then the API and application wouldn't always get changed in the same way. This resulted in methods like repository.create which can do maybe 20% of what the web UI can, does it in different, inconsistent ways, and edits made by the API might look or work differently than web UI edits. In bad cases, they'd even do different policy/permissions checks. This caused many many problems for a very long time.

Mar 20 2016, 12:10 PM · Restricted Project, Conduit, Maniphest, Workboards
epriestley added a comment to T5214: Add Conduit API methods for workboards.

Changes like T10569 should probably happen first. This is likely to be very complex, and is probably not a good task for a new contributor.

Mar 20 2016, 11:15 AM · Restricted Project, Conduit, Maniphest, Workboards
epriestley closed T10565: Make Phriction articles accessible via version control or arc as Invalid.

This request doesn't describe a root problem and we don't seem to be making progress toward one, so we can't move forward on it.

Mar 20 2016, 10:09 AM · Phriction, Feature Request
epriestley added a comment to T6027: Way to edit which column a task is in from the task itself.

No, we're not open to implementing this as multiple separate select controls. We don't really have a UI in mind that we're happy with, but we have several we're less unhappy with than multiple select controls (leading contenders: single optgrouped select, alternate actions menu for workboard actions; possible contenders: visual table-layout control, select per-project in a dialog).

Mar 20 2016, 10:07 AM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a comment to T10621: Create projects from external thing (extension to T3980).

How do you imagine Phabricator learning about the existence of new external groups? Just polling a list of every group in LDAP every hour or whatever?

Mar 20 2016, 9:38 AM · Restricted Project, Restricted Project, LDAP, Projects, Feature Request
epriestley added a comment to T10620: Support complex mappings from branch names to JIRA/Maniphest tasks.

Like T10622, I think this is reasonable to expose as an extensible behavior, but it should wait for T10329 so we have better tools to support it.

Mar 20 2016, 9:30 AM · Restricted Project, Arcanist, Feature Request
epriestley added a comment to T10622: Auto add reviewers based on custom logic.

I think this is generally reasonable but would like it to happen after T10329 (roughly, "proper extension infrastructure for arc"), when we'll have the tools we need to better manage versioning and deploying client changes.

Mar 20 2016, 9:29 AM · Restricted Project, Arcanist, Feature Request
epriestley added a comment to T10623: Allow Herald actions to reference conditions.

Can you describe the root problem? What kind of rules are these? Revision rules?

Mar 20 2016, 9:28 AM · Restricted Project, Herald, Feature Request
epriestley added a comment to T10619: Permit custom harbormaster actions from the diffusion/differential pages.

You can already do some of this: "Land Revision" itself is added to the menu via DifferentialLandingActionMenuEventListener. You can use listeners like this to extend the menu.

Mar 20 2016, 9:22 AM · Restricted Project, Diffusion, Differential, Harbormaster, Feature Request

Mar 19 2016

ofbeaton awarded T1139: Internationalize Phabricator a Like token.
Mar 19 2016, 11:36 PM · Localization
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

I've updated D14284 + D14286 + D14288 for the new API and rebased them onto modern code.

Mar 19 2016, 10:51 PM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

It seems that tag builds do not support build_parameters. We need to pass parameters, so this is blocked on them again.

Mar 19 2016, 10:46 PM · Restricted Project, Harbormaster
epriestley added a comment to T7789: Support Git Large File Storage.
  • Once D15499 lands, this is available as a prototype.
Mar 19 2016, 8:20 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 19 2016, 6:11 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

According to CircleCI this really truly works now, so I'll see if I can push our integration forward shortly.

Mar 19 2016, 1:36 PM · Restricted Project, Harbormaster
epriestley added a comment to T10629: Rotate the `secure.phabricator.com` SSL certificate.

I renewed the certificate and launched a new VPC load balancer, which can forward port 22 traffic:

Mar 19 2016, 1:35 PM · Phacility, Ops
epriestley added a comment to T10629: Rotate the `secure.phabricator.com` SSL certificate.

We use secure.phabricator.com for both HTTP/HTTPS and SSH traffic and ELB can't currently forward port 22 -- except the docs now say EC2-VPC LBs can? So I need to figure out what's going on with that.

Mar 19 2016, 1:00 PM · Phacility, Ops
epriestley edited the content of Changelog.
Mar 19 2016, 12:35 PM
epriestley created 2016 Week 12 (Late March).
Mar 19 2016, 12:34 PM
epriestley created T10629: Rotate the `secure.phabricator.com` SSL certificate.
Mar 19 2016, 12:29 PM · Phacility, Ops
epriestley removed a watcher for Arcanist: • stephane.chaperot.
Mar 19 2016, 2:33 AM
epriestley added a parent task for T10329: Implement internal workflows / a build engine in Arcanist: T10622: Auto add reviewers based on custom logic.
Mar 19 2016, 2:31 AM · Restricted Project, Arcanist
epriestley added a subtask for T10622: Auto add reviewers based on custom logic: T10329: Implement internal workflows / a build engine in Arcanist.
Mar 19 2016, 2:31 AM · Restricted Project, Arcanist, Feature Request