Page MenuHomePhabricator
Feed Advanced Search

Mar 19 2016

epriestley added a subtask for T10620: Support complex mappings from branch names to JIRA/Maniphest tasks: T10329: Implement internal workflows / a build engine in Arcanist.
Mar 19 2016, 2:30 AM · Restricted Project, Arcanist, Feature Request
epriestley added a parent task for T10329: Implement internal workflows / a build engine in Arcanist: T10620: Support complex mappings from branch names to JIRA/Maniphest tasks.
Mar 19 2016, 2:30 AM · Restricted Project, Arcanist
epriestley created T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential.
Mar 19 2016, 2:28 AM · Restricted Project, Differential
epriestley closed T9788: config/versions page - also show dates of commits as Resolved.

I think the remaining part was "show a lot more versions of different things", but I can't immediately think of cases where that would have helped us resolve something faster.

Mar 19 2016, 2:11 AM · Config
epriestley added a comment to T4188: Put expires headers on js/css/img on dotorg.

CORGI will fix this and clearly it is too hard for me.

Mar 19 2016, 2:02 AM · Public & Media Relations
joshuaspence created T10627: Subproject tasks do not appear on parent project workboard.
Mar 19 2016, 12:19 AM · Projects, Workboards
joshuaspence created T10626: Spacing issue in Diffusion.
Mar 19 2016, 12:16 AM · Bug Report, Diffusion

Mar 18 2016

epriestley added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

That one worked OK, yell if you're still seeing an issue?

Mar 18 2016, 11:02 PM · Phurl, Bug Report
epriestley added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

Test: User Guide: Prototype Applications

Mar 18 2016, 11:02 PM · Phurl, Bug Report
epriestley closed T10625: Links like "((prototype))" are not expanded properly in email as Resolved by committing Restricted Diffusion Commit.
Mar 18 2016, 11:00 PM · Phurl, Bug Report
epriestley added a revision to T10625: Links like "((prototype))" are not expanded properly in email: Unknown Object (Differential Revision).
Mar 18 2016, 10:59 PM · Phurl, Bug Report
epriestley added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

Oh -- I misunderstood. The issue isn't that we're getting invalid markup or emitting markup in a text context, but that the link is relative.

Mar 18 2016, 10:51 PM · Phurl, Bug Report
epriestley added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

This is probably very easy to fix, let me spend 3 seconds on it.

Mar 18 2016, 10:49 PM · Phurl, Bug Report
epriestley added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

Yes, Phurl provides URL shortening. U10 is the root object providing ((prototype)).

Mar 18 2016, 10:48 PM · Phurl, Bug Report
chad awarded T7789: Support Git Large File Storage a Haypence token.
Mar 18 2016, 6:24 PM · Customer Impact, Restricted Project, Files, Diffusion
avivey awarded T7789: Support Git Large File Storage a Mountain of Wealth token.
Mar 18 2016, 5:25 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T7789: Support Git Large File Storage.

The technically-functional-prototype code is live on this install, now:

Mar 18 2016, 4:46 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 18 2016, 3:44 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley reopened T10618: Prevent duplicate notifications about blocking tasks as "Open".

This isn't really the same as T7013 or T9161. T7013 was intended as a pure infrastructure optimization, I just named it really badly. And even if we had the fanciest rules imaginable, T9161 wouldn't help, because this case is currently unknowable.

Mar 18 2016, 3:38 PM · Restricted Project, Maniphest, Feature Request
epriestley added a comment to T7013: Support bulk transmission of notification frames in internal Aphlict protocol.

Sorry, I picked a really bad name for it originally.

Mar 18 2016, 3:31 PM · Aphlict, Conpherence
epriestley added a comment to T7013: Support bulk transmission of notification frames in internal Aphlict protocol.

This task has nothing to do with any user-visible behavior and is purely a performance/network optimization, despite all the discussion about batching emails here. :)

Mar 18 2016, 3:27 PM · Aphlict, Conpherence
epriestley renamed T7013: Support bulk transmission of notification frames in internal Aphlict protocol from Support message batching in the notification pipeline to Support bulk transmission of notification frames in internal Aphlict protocol.
Mar 18 2016, 3:27 PM · Aphlict, Conpherence
epriestley added a comment to T10589: Create useable search experience for Maniphest.

You can use the default syntax (+x +y) to perform an AND search explicitly. See:

Mar 18 2016, 3:23 PM · Feature Request
epriestley added a comment to T10614: Images in Diffusion don't register as such in BrowseTable.

(There is also a different type of cache from <object hash -> metadata> we could build in Git, but that's kind of a lot of work.)

Mar 18 2016, 2:43 PM · Diffusion, Bug Report
epriestley added a comment to T10614: Images in Diffusion don't register as such in BrowseTable.

In SVN, we can use a different icon because we have prebuilt cache of file types (and must have this cache for other reasons, and can build this cache efficiently, and SVN distinguishes between binary and text files).

Mar 18 2016, 2:40 PM · Diffusion, Bug Report
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 18 2016, 2:25 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T9987: Diffs in a task should be sorted by the dependency tree.

Please tell me if you would merge this improvement if we implement it.

Mar 18 2016, 2:09 PM · Maniphest, Feature Request
epriestley added a comment to T7789: Support Git Large File Storage.

Quick update:

Mar 18 2016, 1:42 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 18 2016, 1:27 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T10604: Allow application code to stream request data: Unknown Object (Differential Revision).
Mar 18 2016, 1:27 PM · Diffusion (v3), Restricted Project
epriestley edited the content of Organizations Using Phabricator.
Mar 18 2016, 1:19 PM
epriestley changed the visibility for Organizations Using Phabricator.
Mar 18 2016, 1:19 PM
epriestley added a revision to T10604: Allow application code to stream request data: Unknown Object (Differential Revision).
Mar 18 2016, 12:05 PM · Diffusion (v3), Restricted Project
ivo awarded T10034: Plan the future of Maniphest task relationships a Like token.
Mar 18 2016, 9:59 AM · Maniphest
epriestley added a comment to T7789: Support Git Large File Storage.

One issue which we'll hit eventually is that git-lfs doesn't currently support pushing to remotes by URL, but we push to staging areas by URL:

Mar 18 2016, 1:27 AM · Customer Impact, Restricted Project, Files, Diffusion

Mar 17 2016

epriestley added a comment to T6027: Way to edit which column a task is in from the task itself.

Is there any chance that this feature will be implemented sometime soon?

Mar 17 2016, 10:16 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 17 2016, 8:33 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley created T10617: Improve raw-PHID remarkup rules.
Mar 17 2016, 7:48 PM · Remarkup
epriestley added a comment to T7789: Support Git Large File Storage.

No way for the upload API to say "no thanks, I already have that file"?

Mar 17 2016, 6:49 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

Why are users who shouldn't be changing priorities doing it?

Mar 17 2016, 6:06 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

See T10333 for plans to make dragging cards in sorted workboards more clear (and T8135 for additional discussion). Those UIs aren't as clear as they should be and we'd like them to be more clear.

Mar 17 2016, 4:54 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T10611: No option to specify a Space when editing a Project's visibility policy.

"project" there just the noun, not "Project-object", but we could probably pick a different word to avoid ambiguity.

Mar 17 2016, 4:22 PM · Projects, Restricted Project, Feature Request, Spaces
epriestley added a comment to T7789: Support Git Large File Storage.

Quick progress update:

Mar 17 2016, 3:41 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

D15483 changes the constant to 47 (15 window size + 32 for gzip + zlib), which should accept and decode the broadest possible range of inputs. If this somehow breaks something, 31 (15 window size + 16 for gzip only) is probably the next thing to try. See that change for discussion.

Mar 17 2016, 3:34 PM · Bug Report, Diffusion
epriestley added a comment to T10610: ExecFuture does not kill child processes on timeout.

This is probably a variant on T4551.

Mar 17 2016, 3:00 PM · libphutil, Bug Report
epriestley added a comment to T10609: Add @username style typeahead search to other node types .

For searching across all types of everything, I lean toward adding an "Insert object reference..." button to the header which pops up a search box (similar to the "Edit Blocking Tasks" box) instead of trying to trigger on {T... and such. I think this is a lot friendlier for new users, and we'll have a bit more room to let you filter/customize the query, and this operation is probably not so common that it needs to be triggered on a whim inline. For power users, we could maybe add a keystroke (say, Ctrl/Alt + @) or something so you didn't need to actually click the button.

Mar 17 2016, 1:20 PM · Feature Request

Mar 16 2016

epriestley removed a watcher for Infrastructure: • 9999999999.
Mar 16 2016, 10:58 PM
epriestley updated the task description for T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.
Mar 16 2016, 10:49 PM · Infrastructure
epriestley renamed T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates from missing index on repository_pathchange table to Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.
Mar 16 2016, 10:46 PM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Here's a diff to make bin/storage adjust always run ANALYZE on every table after it makes other adjustments, but I'm not really sure if that's actually helpful or not (e.g., from the documentation, it sounds like the good analysis can be immediately overwritten by a bad one in some cases?):

Mar 16 2016, 10:01 PM · Infrastructure
epriestley added a revision to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates: Unknown Object (Differential Revision).
Mar 16 2016, 9:50 PM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

I think so. Sorry for the originally misleading claim.Sorry for the originally misleading claim.

Mar 16 2016, 9:48 PM · Infrastructure
epriestley added a comment to T10260: Harbormaster Herald Rules.

Oh, I might not have made subscribers actually do anything, I don't remember. They definitely should, though, even if they don't yet.

Mar 16 2016, 9:39 PM · Haskell.org, Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Well, the docs suggest not doing that:

Mar 16 2016, 9:29 PM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Should we get rid of the <commitID, isDirect, changeType> key, then?

Mar 16 2016, 9:24 PM · Infrastructure
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 16 2016, 7:49 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T10601: Scale retina images when they are used in a mock.

We could also maybe do something ridiculous like assume it's @2x if both dimensions are even, but M1461 has a 2X image with an odd height (1717px!) so that probably won't get us very far ignoring all the false positives for 400x300px images and such.

Mar 16 2016, 6:45 PM · Pholio, Feature Request
epriestley added a comment to T10601: Scale retina images when they are used in a mock.

I think this is reasonable to build as:

Mar 16 2016, 6:44 PM · Pholio, Feature Request
epriestley added a revision to T10604: Allow application code to stream request data: Unknown Object (Differential Revision).
Mar 16 2016, 6:06 PM · Diffusion (v3), Restricted Project
epriestley added a comment to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver.

Assuming this mode does not exist, the clearest pathway forward is for you or someone else to:

Mar 16 2016, 6:03 PM · Lint, Feature Request
epriestley added a comment to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver.

Does RuboCop actually have a mode where it emits errors and replacement text?

Mar 16 2016, 5:59 PM · Lint, Feature Request
epriestley added a revision to T10264: git clone using http hangs after update: Unknown Object (Differential Revision).
Mar 16 2016, 5:51 PM · Bug Report, Diffusion
epriestley added a revision to T10604: Allow application code to stream request data: Unknown Object (Differential Revision).
Mar 16 2016, 5:51 PM · Diffusion (v3), Restricted Project
epriestley created T10604: Allow application code to stream request data.
Mar 16 2016, 5:46 PM · Diffusion (v3), Restricted Project
epriestley closed T10603: Make AuthTemporaryTokens suitable for use as LFS tokens, a subtask of T7789: Support Git Large File Storage, as Resolved.
Mar 16 2016, 4:35 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley closed T10603: Make AuthTemporaryTokens suitable for use as LFS tokens as Resolved by committing Restricted Diffusion Commit.
Mar 16 2016, 4:34 PM · Auth
r0bbie awarded T7789: Support Git Large File Storage a Like token.
Mar 16 2016, 4:12 PM · Customer Impact, Restricted Project, Files, Diffusion
Luke081515.2 awarded T8887: Allow owners packages to add blocking reviewers a Love token.
Mar 16 2016, 4:10 PM · Haskell.org, Restricted Project, Owners
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 16 2016, 2:51 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley closed T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs as Resolved.
Mar 16 2016, 2:49 PM · Installing & Upgrading, Bug Report
epriestley added a comment to T10254: Assign projects to spaces.

There is not, and never will be. Associated projects never affect policies, so there is no possibility to make them start affecting policies. I'm not sure what's unclear about this.

Mar 16 2016, 2:21 PM · Restricted Project, Spaces, Projects, Feature Request
epriestley added a comment to T10601: Scale retina images when they are used in a mock.

That one might be better to merge here, since it's probably impossible (at least, in the general case) but this talks about some things we can do in the general case.

Mar 16 2016, 2:20 PM · Pholio, Feature Request
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 2:11 PM · Auth
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 1:56 PM · Auth
epriestley added a comment to T10254: Assign projects to spaces.

By design, changing projects never affects policies. See the documentation here:

Mar 16 2016, 1:52 PM · Restricted Project, Spaces, Projects, Feature Request
epriestley added a comment to T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs.

@jlvillapalos, can you shed some light on why you didn't include that information in the first place or how we could improve the process?

Mar 16 2016, 1:49 PM · Installing & Upgrading, Bug Report
epriestley closed T10530: Exception: Cursor "11972" does not identify a valid object in query "DiffusionCommitQuery". as Resolved.

bin/remove destroy gives you a huge scary red skull-and-crossbones ASCII art for good reason, and you're accepting that issues like this may occur when you confirm the prompt.

Mar 16 2016, 1:40 PM · Audit, Diffusion, Bug Report
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 1:26 PM · Auth
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 1:14 PM · Auth
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 12:37 PM · Auth
epriestley added a revision to T10603: Make AuthTemporaryTokens suitable for use as LFS tokens: Unknown Object (Differential Revision).
Mar 16 2016, 12:24 PM · Auth
epriestley changed the edit policy for T10603: Make AuthTemporaryTokens suitable for use as LFS tokens.
Mar 16 2016, 12:18 PM · Auth
epriestley changed the edit policy for T7789: Support Git Large File Storage.
Mar 16 2016, 12:18 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley created T10603: Make AuthTemporaryTokens suitable for use as LFS tokens.
Mar 16 2016, 12:15 PM · Auth
epriestley added a comment to T5214: Add Conduit API methods for workboards.

T10599 asks for column move APIs, which are adjacent to this.

Mar 16 2016, 11:49 AM · Restricted Project, Conduit, Maniphest, Workboards
epriestley updated subscribers of T5214: Add Conduit API methods for workboards.
Mar 16 2016, 11:49 AM · Restricted Project, Conduit, Maniphest, Workboards
epriestley merged task T10599: Conduit - 「maniphest.edit 」when changing column, always throw「Validation errors」 into T5214: Add Conduit API methods for workboards.
Mar 16 2016, 11:49 AM · Bug Report
epriestley added a comment to T10599: Conduit - 「maniphest.edit 」when changing column, always throw「Validation errors」.

This transaction can only create a task into a column, it can't move a task. That's why the documentation says "Create into a workboard column.".

Mar 16 2016, 11:48 AM · Bug Report
epriestley added a comment to T10601: Scale retina images when they are used in a mock.

I don't think we can detect this automatically -- a, say, web-ready PNG from Photoshop generally won't have DPI information, as far as I know.

Mar 16 2016, 11:46 AM · Pholio, Feature Request
epriestley added a comment to T3167: Use full names in Conpherence messages.

We are vanishingly unlikely to revisit this decision. If this is important to your organization, you should look into forking the codebase to provide the functionality you are interested in.

Mar 16 2016, 11:40 AM · Conpherence
epriestley added Q338: How can I edit the documentation? (Answer 344).
Mar 16 2016, 11:36 AM
ofbeaton awarded T6703: Allow multiple copies of the same auth provider type a Like token.
Mar 16 2016, 2:21 AM · Auth
epriestley added a comment to T6703: Allow multiple copies of the same auth provider type.

You can "Award Token".

Mar 16 2016, 2:21 AM · Auth
Krenair awarded T6703: Allow multiple copies of the same auth provider type a Love token.
Mar 16 2016, 2:19 AM · Auth
epriestley closed T10597: Custom Project query results in . url which nginx blocks as Resolved.

We'll consider adding a setup issue if we see other users having issues with this. Previously, we haven't, so we presume users having or uncommenting these blocks in the wild to be very rare.

Mar 16 2016, 2:05 AM · Bug Report

Mar 15 2016

epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Interesting (and weird). Thanks for the update -- and good luck figuring things out.

Mar 15 2016, 8:54 PM · Infrastructure
epriestley closed T4210: arc diff --create failed to create revision as Resolved.

I'm not immediately able to get --create to bring up a template with "Differential Revision". Here's what I tried:

Mar 15 2016, 6:51 PM · Arcanist
epriestley added a comment to T4210: arc diff --create failed to create revision.

I think we should ideally try to be more clear about the issue when the user passes --create, even if something in range says "Differential Revision: Whatever". That said "a little bit before I look at it" has been like two years now. Let me spend like 5 minutes on it and if it's a big mess we can just write it off.

Mar 15 2016, 6:40 PM · Arcanist
epriestley added a comment to T10588: PhabricatorWorkerActiveTask continuously reports connection error in logs.

The issue you're experiencing is because you're out of date.

Mar 15 2016, 5:02 PM · Installing & Upgrading, Bug Report
epriestley added a comment to T10262: Scramble file secrets when attached objects change their view policies.

In some cases, the effects of the theater can be mitigated issue-by-issue. For example, we may be able to write caching/rendering logic in Javascript to mitigate the performance impact on lightboxes and Pholio. We may be able to attach images directly to email. There may be a workaround for the Safari issue, or we may be able to do preview rendering partially in Javascript. With Quicksand, we can also increase the "hit rate" of client-side Javascript caches, at the cost of additional complexity.

Mar 15 2016, 4:33 PM · Restricted Project, Restricted Project, Wikimedia, Files