Page MenuHomePhabricator
Feed Advanced Search

Nov 25 2015

epriestley added a comment to T9853: Support comments in Herald Actions .
This is totally unsupported, use at your own risk, etc, etc.
Nov 25 2015, 9:02 PM · Restricted Project
chad awarded P1895 AddCommentHeraldAction.php a Piece of Eight token.
Nov 25 2015, 9:01 PM · Herald
epriestley updated the title for P1895 AddCommentHeraldAction.php from untitled to AddCommentHeraldAction.php.
Nov 25 2015, 8:59 PM · Herald
epriestley added a comment to T9853: Support comments in Herald Actions .

I can give you an extension for this in about 15 minutes (at consulting rates).

Nov 25 2015, 8:45 PM · Restricted Project
joshuaspence added a project to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events: Maniphest.
Nov 25 2015, 7:07 PM · Modernization, Maniphest
joshuaspence created T9852: Inline comments not appearing in mail.
Nov 25 2015, 6:57 PM · Differential
epriestley added a comment to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

You can't currently examine the most-recently-applied set of transactions, although we could reasonably pass them down and expose them.

Nov 25 2015, 6:46 PM · Modernization, Maniphest
epriestley added a comment to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

I'd like to remove this event, because (a) it doesn't work right and never has and (b) all use cases we've seen are better suited to either Herald or mechanisms covered in T5462.

Nov 25 2015, 6:38 PM · Modernization, Maniphest
epriestley added a comment to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

Can you do that with Herald instead?

Nov 25 2015, 5:26 PM · Modernization, Maniphest
epriestley added a comment to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

What does the logic in your listener do?

Nov 25 2015, 5:06 PM · Modernization, Maniphest
epriestley updated the title for P1894 test Page from untitled to test Page.
Nov 25 2015, 4:29 PM
epriestley added a comment to T9850: Creating a new paste fails with unhandled exception.

Thanks! Should be fixed in HEAD.

Nov 25 2015, 4:29 PM · ApplicationEditor, Paste
epriestley closed T9850: Creating a new paste fails with unhandled exception as Resolved by committing Restricted Diffusion Commit.
Nov 25 2015, 4:25 PM · ApplicationEditor, Paste
epriestley added a revision to T9850: Creating a new paste fails with unhandled exception: Unknown Object (Differential Revision).
Nov 25 2015, 4:24 PM · ApplicationEditor, Paste
epriestley claimed T9850: Creating a new paste fails with unhandled exception.
Nov 25 2015, 4:12 PM · ApplicationEditor, Paste
joshuaspence added a project to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction: Differential.
Nov 25 2015, 2:50 AM · Differential

Nov 24 2015

epriestley updated subscribers of T4768: Phabricator silently overwrites concurrent changes (no conflict detection).
Nov 24 2015, 10:37 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
epriestley merged task T9847: bug: race condition in updating reviews into T4768: Phabricator silently overwrites concurrent changes (no conflict detection).
Nov 24 2015, 10:37 PM · Differential
epriestley added a comment to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.

Yeah, I'd really like to just get rid of this option. It's definitely not something we'd accept upstream today.

Nov 24 2015, 10:11 PM · Differential
epriestley created T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.
Nov 24 2015, 9:10 PM · Differential
joshuaspence deleted Open Source Students 2013.
Nov 24 2015, 8:58 PM
joshuaspence added a comment to T9773: Unit tests are slow.

Sorry about the delay... here's the trace from running /bin/storage upgrade --namespace testT9773_$RANDOM --force --no-adjust --trace:

Nov 24 2015, 8:46 PM · Infrastructure
joshuaspence edited the content of Starmap.
Nov 24 2015, 7:47 PM
joshuaspence added a comment to T9601: Herald rule not working as expected.

Gah, details of the Herald transcript have already been garbage collected.

Nov 24 2015, 7:32 PM · Herald
joshuaspence added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

Out pf curiosity, why not use the @{article:...} syntax instead of copy-pasting the full URL?

Nov 24 2015, 7:25 PM · Phurl
joshuaspence added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Nov 24 2015, 7:23 PM · Prioritized, Restricted Project, Infrastructure
joshuaspence added a project to T9839: Support Bitbucket Webhook.: Diffusion.
Nov 24 2015, 7:20 PM · Diffusion
epriestley closed T1273: There should be a way to specify phutil library dependencies as Wontfix.

We haven't seen other installs encounter difficulty here. T5055 will eventually build some flavor of first-party package manager which should address a large superset of this problem class.

Nov 24 2015, 6:54 PM · libphutil
epriestley updated subscribers of T7805: Use ApplicationSearch in the ObjectSelector dialog.
Nov 24 2015, 6:52 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley changed the visibility for T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function.
Nov 24 2015, 6:51 PM · libphutil
epriestley added a comment to T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function.

D14523 possibly describes a cleaner fix for this (special case autoloads when class_exists() is on the stack).

Nov 24 2015, 6:51 PM · libphutil
epriestley added a comment to T9601: Herald rule not working as expected.

Who does the transcript show as the "Reviewer" for the change?

Nov 24 2015, 6:46 PM · Herald
epriestley closed T9844: Differential descriptions should highlight and identify maniphest tasks regardless of case as Wontfix.

This is intentional, consistent, documented, etc.

Nov 24 2015, 6:42 PM · Differential
epriestley awarded T9789: Make it easier to write custom transaction types a Piece of Eight token.
Nov 24 2015, 5:26 PM · Modernization, Transactions
epriestley triaged T9789: Make it easier to write custom transaction types as Normal priority.
Nov 24 2015, 5:26 PM · Modernization, Transactions
epriestley closed T9773: Unit tests are slow as Invalid.

No one else can reproduce this. storage upgrade --trace ... might provide some insight, or add --xprofile to that or whatever. We can look at it in more detail if you can narrow it down more.

Nov 24 2015, 5:25 PM · Infrastructure
epriestley renamed T9818: Memes with multiline texts have their text placed incorrectly from Memes with multiline texts have their text placed incorrect to Memes with multiline texts have their text placed incorrectly.
Nov 24 2015, 5:22 PM · Macros
epriestley triaged T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments as Wishlist priority.
Nov 24 2015, 5:22 PM · Prioritized, Restricted Project, Remarkup, Mail
epriestley moved T7593: Allow administrators to disable files to prevent "l33t w4r3z" abuse cases from Backlog to vNext on the Files board.
Nov 24 2015, 5:20 PM · Abuse, Files
epriestley triaged T7593: Allow administrators to disable files to prevent "l33t w4r3z" abuse cases as Low priority.
Nov 24 2015, 5:20 PM · Abuse, Files
epriestley renamed T7593: Allow administrators to disable files to prevent "l33t w4r3z" abuse cases from Files should provide policies to limit the size/types of files that can be uploaded to Allow administrators to disable files to prevent "l33t w4r3z" abuse cases.
Nov 24 2015, 5:20 PM · Abuse, Files
epriestley moved T7789: Support Git Large File Storage from Backlog to Far Future on the Files board.
Nov 24 2015, 5:19 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley moved T8253: Upload file fails, probably my fault from Backlog to vNext on the Files board.
Nov 24 2015, 5:19 PM · Files
epriestley moved T8124: Construction of "default" file resources may lose a race with itself from Backlog to vNext on the Files board.
Nov 24 2015, 5:19 PM · Files
epriestley triaged T9133: Allow to search Files by Project as Low priority.
Nov 24 2015, 5:18 PM · Projects, Files
epriestley moved T9133: Allow to search Files by Project from Backlog to v3 on the Files board.
Nov 24 2015, 5:18 PM · Projects, Files
epriestley moved T8865: Automatically compact storage from Backlog to vNext on the Files board.
Nov 24 2015, 5:18 PM · Files
epriestley moved T8593: Allow files to have a description from Backlog to v3 on the Files board.
Nov 24 2015, 5:18 PM · Restricted Project, Files
epriestley closed T8928: GitHub external provider Profile Photos are created continuously as Wontfix.

This report doesn't appear to describe a specific problem.

Nov 24 2015, 5:17 PM · Files, GitHub, Auth
epriestley renamed T9085: "Temporary" badges on Files has odd size/alignment on mobile from "Temporary" badges on file looks too small to "Temporary" badges on Files has odd size/alignment on mobile.
Nov 24 2015, 5:11 PM · PHUI
epriestley added a comment to T9842: Can't navigate to phriction page with apostrophe in title.

It's intentional that we normalize the slugs to try to make typing URLs a little more forgiving: For example, if you go to any of these links:

Nov 24 2015, 5:10 PM · Phriction
epriestley moved T9169: Downloading Attachment Extremely Slow from Backlog to Far Future on the Files board.
Nov 24 2015, 5:06 PM · Bug Report (Needs Information), Files
epriestley added a comment to T9169: Downloading Attachment Extremely Slow.

Just to set expectations:

Nov 24 2015, 5:06 PM · Bug Report (Needs Information), Files
epriestley triaged T9169: Downloading Attachment Extremely Slow as Wishlist priority.
Nov 24 2015, 4:59 PM · Bug Report (Needs Information), Files
epriestley removed a project from T9319: Accessing image file in Diffusion must not generate error (unhandled exception): Files.
Nov 24 2015, 4:59 PM · Phacility, Diffusion, Phacility Support
epriestley moved T7501: Documentation for Files from Backlog to vNext on the Files board.
Nov 24 2015, 4:58 PM · Files, Documentation
epriestley moved T5187: Make "Upload File" dialog have a vanilla file upload control from Backlog to vNext on the Files board.
Nov 24 2015, 4:58 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley moved T5258: Memes use older image transform code without modern error handling from Backlog to vNext on the Files board.
Nov 24 2015, 4:58 PM · Restricted Project, Files, Macros
epriestley moved T9828: Make migrating files less scary from Backlog to vNext on the Files board.
Nov 24 2015, 4:57 PM · Restricted Project, Files
epriestley triaged T9838: Add sub-state for Revision: "Closed from Accepted" as Low priority.
Nov 24 2015, 4:57 PM · Restricted Project, Differential
epriestley moved T9838: Add sub-state for Revision: "Closed from Accepted" from Backlog to v2 (UI/Mobile) on the Differential board.
Nov 24 2015, 4:57 PM · Restricted Project, Differential
epriestley updated subscribers of T7858: Typeahead/Tokenizer Errata.
Nov 24 2015, 4:56 PM · Restricted Project, Typeahead
epriestley merged task T9840: Projects get displayed without icon and color when setting Custom Policy into T7858: Typeahead/Tokenizer Errata.
Nov 24 2015, 4:56 PM · Spaces
epriestley added a comment to T9842: Can't navigate to phriction page with apostrophe in title.

There were some changes to slugs about 6 weeks ago (D14260, D14261, D14287) but I don't think they would have affected this.

Nov 24 2015, 4:55 PM · Phriction
epriestley closed T9842: Can't navigate to phriction page with apostrophe in title as Invalid.

Since we can't reproduce this, I'm not sure how we could fix it.

Nov 24 2015, 4:53 PM · Phriction
epriestley closed T9843: LDAP login for few accounts not working. as Invalid.

This task doesn't contain enough information for us to reproduce the problem you're encountering. Please see Contributing Bug Reports for an outline of what we need in an actionable bug report.

Nov 24 2015, 4:49 PM · LDAP
epriestley added a comment to T3725: Using keyword @ to address users does not autocomplete names.

I have made these changes to the planning document which are hopefully more clear:

Nov 24 2015, 4:39 PM · FreeBSD, User Delight, Remarkup
epriestley edited the content of Planning.
Nov 24 2015, 4:38 PM
epriestley added a comment to T3725: Using keyword @ to address users does not autocomplete names.

Just to confirm, there are no plans to implement this within some timeframe, right?

Nov 24 2015, 4:37 PM · FreeBSD, User Delight, Remarkup
epriestley added a comment to T3725: Using keyword @ to address users does not autocomplete names.

That isn't what the planning document is intended to convey. I'll update it to make it more clear.

Nov 24 2015, 2:13 PM · FreeBSD, User Delight, Remarkup
epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

I've been using the ((alias)) syntax pretty frequently and it's been really helpful -- we have a bunch of documentation we point people at all the time, and before Phurl I'd open a new tab, search for the document, copy-paste the URL, and maybe put some [[ ... | nice title ]] syntax around it. Now I just ((thing)) and it's way easier. The search + copy/paste workflow wasn't hugely time consuming, but it was really annoying.

Nov 24 2015, 2:00 PM · Phurl
epriestley added a comment to T3725: Using keyword @ to address users does not autocomplete names.

Phurl (T6049) is still a prototype and not yet documented.

Nov 24 2015, 1:54 PM · FreeBSD, User Delight, Remarkup
epriestley added a comment to T3725: Using keyword @ to address users does not autocomplete names.

@polybuildr, please see Planning.

Nov 24 2015, 1:40 PM · FreeBSD, User Delight, Remarkup
epriestley closed T9841: Add Portal NS to Pashto Wikipedia as Invalid.

This Phabricator install is not related to Wikipedia.

Nov 24 2015, 12:12 PM
epriestley closed T9839: Support Bitbucket Webhook. as Wontfix.

We don't plan to support these webhooks.

Nov 24 2015, 12:12 PM · Diffusion
joshuaspence added a member for Pholio: joshuaspence.
Nov 24 2015, 10:32 AM
joshuaspence added a member for Ponder: joshuaspence.
Nov 24 2015, 10:32 AM
joshuaspence added a member for Modernization: joshuaspence.
Nov 24 2015, 10:29 AM
joshuaspence added a member for Nuance: joshuaspence.
Nov 24 2015, 10:29 AM
joshuaspence added a member for Documentation: joshuaspence.
Nov 24 2015, 10:01 AM
joshuaspence added a member for Countdown: joshuaspence.
Nov 24 2015, 10:01 AM
joshuaspence added a member for ApplicationEditor: joshuaspence.
Nov 24 2015, 10:00 AM

Nov 23 2015

epriestley renamed T9562: Show only the first N branches/tags on commits in Diffusion, with a "Show all..." link from Option to hide the branches and tags for a commit by default to Show only the first N branches/tags on commits in Diffusion, with a "Show all..." link.
Nov 23 2015, 11:00 PM · Diffusion (v3), Restricted Project
epriestley closed T9837: Add ability to deep-link lists of tasks in project in Phriction as Resolved.

Cool. We definitely want to make dashboards easier to use in the future, but it's entangled with a bunch of "Welcome" / "Role Profiles" / "New User Experience" stuff that makes it a big project. Maaaaaaaaaybe Q1 2016-ish-ish. Maybe?

Nov 23 2015, 10:58 PM
epriestley added a comment to T9838: Add sub-state for Revision: "Closed from Accepted".

Just to make sure I remember things, specific issue is:

Nov 23 2015, 10:23 PM · Restricted Project, Differential
epriestley added a comment to T9837: Add ability to deep-link lists of tasks in project in Phriction.

Alternatively, you could use a dashboard to provide the "executive dashboard" view, and bring text into that with text panels:

Nov 23 2015, 10:15 PM
epriestley added a comment to T9837: Add ability to deep-link lists of tasks in project in Phriction.
  1. Create a query in Maniphest with the stuff you want to show.
  2. Save it as a named query.
  3. Create a new Dashboard panel with that query.
  4. Embed the view with {W...}. For example, here's {W402} on this install below (which shows a few recent tasks in Phriction):
  5. You can delete the named query now.
Nov 23 2015, 10:13 PM
epriestley updated subscribers of T9771: Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted".
Nov 23 2015, 8:54 PM · Policy, Spaces
epriestley merged task T9836: Feed doesn't correctly show Restricted Objects into T9771: Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted".
Nov 23 2015, 8:54 PM · Feed
epriestley added a revision to T9306: Improve Phacility trial period behavior: Unknown Object (Differential Revision).
Nov 23 2015, 7:52 PM · Phacility
epriestley added a revision to T9306: Improve Phacility trial period behavior: Unknown Object (Differential Revision).
Nov 23 2015, 7:51 PM · Phacility
joshuaspence merged task T9831: Opening Changelog 2015.46 shows a PhutilInvalidState exception into T9829: Exception after Updating Phabricator.
Nov 23 2015, 7:35 PM · Phriction
joshuaspence updated subscribers of T9829: Exception after Updating Phabricator.
Nov 23 2015, 7:35 PM · Phriction
joshuaspence added a project to T9827: Provide a more structured way of interfacing with external linters: Lint.
Nov 23 2015, 7:33 PM · Lint, Arcanist
epriestley added a comment to T9306: Improve Phacility trial period behavior.

We need to hard-wire stuff like that, Herald can't do "after X days" and I don't plan to add that capability in the near future.

Nov 23 2015, 6:57 PM · Phacility
epriestley added a revision to T9306: Improve Phacility trial period behavior: Unknown Object (Differential Revision).
Nov 23 2015, 6:28 PM · Phacility
epriestley closed mock M1453: <--`<img/src=` onerror=alert(1)> --!>.
Nov 23 2015, 6:06 PM
epriestley closed T9834: "><script>alert(String.fromCharCode(88, 83, 83))</script> as Spite.
Nov 23 2015, 6:05 PM · Almanac
epriestley closed T9835: "><script>alert(String.fromCharCode(88, 83, 83))</script> as Spite.
Nov 23 2015, 6:05 PM · Almanac
epriestley closed T9835: "><script>alert(String.fromCharCode(88, 83, 83))</script>, a subtask of T9834: "><script>alert(String.fromCharCode(88, 83, 83))</script>, as Spite.
Nov 23 2015, 6:05 PM · Almanac