Page MenuHomePhabricator
Create Task
Maniphest T9601

Herald rule not working as expected
Closed, InvalidPublic
Actions

Assigned To
epriestley
Authored By
joshuaspence
Oct 20 2015, 2:49 AM
Tags
Referenced Files
F898207: herald.png
Oct 20 2015, 2:49 AM
F898212: trans.png
Oct 20 2015, 2:49 AM
F898210: diff.png
Oct 20 2015, 2:49 AM
Subscribers
epriestley
joshuaspence

Description

I wrote the following Herald rule:

herald.png (153×319 px, 17 KB)

My expectation here was that I would be added as an auditor to a commit if the commit touched an Owners package which I cared about and if I had not accepted the original diff (i.e. someone else had reviewed it).

However, when this diff was landed:

diff.png (225×645 px, 23 KB)

An audit was triggered:

trans.png (175×419 px, 24 KB)

Event Timeline

joshuaspence created this task.Oct 20 2015, 2:49 AM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Herald.
joshuaspence added a subscriber: joshuaspence.
epriestley added a subscriber: epriestley.Nov 24 2015, 6:46 PM

Who does the transcript show as the "Reviewer" for the change?

joshuaspence added a comment.Nov 24 2015, 7:32 PM

Gah, details of the Herald transcript have already been garbage collected.

epriestley closed this task as Invalid.Dec 5 2015, 8:26 PM
epriestley claimed this task.

No clue how to reproduce. If you see it again, grab the field value too? My guess is that it's something like the reviewer PHID ending up as the project PHID instead of your PHID and "Reviewer" needing to be updated to "Reviewers" or similar.

Phabricator · Built by Phacility