Page MenuHomePhabricator

GitHub external provider Profile Photos are created continuously
Closed, WontfixPublic

Description

I'm using GitHub as an external Auth provider. Login in to my Phabricator account works fine, but I'm facing the following problem when I do so:

It looks like everytime, I'm using GitHub Provider for anything, a new file is created in my file storage, containing my GitHub profile image over and over again. When there will be more users than but one, this might very quick lead to several thousands of senseless File - Elements:

Files_list.png (564×1 px, 78 KB)

F18.png (837×1 px, 228 KB)

F20.png (837×1 px, 228 KB)

F17.png (837×1 px, 228 KB)

Event Timeline

Judge raised the priority of this task from to Needs Triage.
Judge updated the task description. (Show Details)
Judge added projects: Auth, GitHub, Files.
Judge added a subscriber: Judge.
chad renamed this task from GitHub external provider Profile Photos are created infinitely to GitHub external provider Profile Photos are created continuously.Jul 22 2015, 2:48 PM
chad added a subscriber: chad.

I can confirm on this install, only seems to be GitHub from my limited testing.

epriestley claimed this task.
epriestley added a subscriber: epriestley.

This report doesn't appear to describe a specific problem.

  • Refreshing your image on login is an intentional behavior. Users complained about stale images when we didn't, and no longer do.
  • Identical file data is internally deduplicated. We do not store multiple copies of the data. This is not a data storage problem.
  • A few thousand extra rows in the file table is not a scalability problem.