GitHub external provider Profile Photos are created continuously
Closed, WontfixPublic
Actions

Assigned To

Authored By

	Judge
	Jul 22 2015, 9:24 AM

Description

I'm using GitHub as an external Auth provider. Login in to my Phabricator account works fine, but I'm facing the following problem when I do so:

It looks like everytime, I'm using GitHub Provider for anything, a new file is created in my file storage, containing my GitHub profile image over and over again. When there will be more users than but one, this might very quick lead to several thousands of senseless File - Elements:

Event Timeline

Judge created this task.Jul 22 2015, 9:24 AM

Judge raised the priority of this task from to Needs Triage.

Judge updated the task description. (Show Details)

Judge added projects: Auth, GitHub, Files.

Judge added a subscriber: Judge.

I can confirm on this install, only seems to be GitHub from my limited testing.

revi added a subscriber: revi.Sep 30 2015, 12:28 PM

This report doesn't appear to describe a specific problem.

Refreshing your image on login is an intentional behavior. Users complained about stale images when we didn't, and no longer do.
Identical file data is internally deduplicated. We do not store multiple copies of the data. This is not a data storage problem.
A few thousand extra rows in the file table is not a scalability problem.

GitHub external provider Profile Photos are created continuouslyClosed, WontfixPublicActions

Description

Event Timeline

GitHub external provider Profile Photos are created continuously
Closed, WontfixPublic
Actions