Page MenuHomePhabricator
Feed Advanced Search

Nov 30 2015

niedzielski awarded T929: Allow two arbitrary revisions to be compared in Diffusion a Love token.
Nov 30 2015, 7:15 PM · Diffusion (v3), Restricted Project
epriestley added a comment to T9873: arc alias outputs a confusing message when adding a shell command alias.

Aliased 'arc foo' to 'foo'.

Nov 30 2015, 6:36 PM · Arcanist
epriestley triaged T9873: arc alias outputs a confusing message when adding a shell command alias as Wishlist priority.
Nov 30 2015, 6:34 PM · Arcanist
epriestley moved T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml) from Backlog to Far Future on the Harbormaster board.
Nov 30 2015, 4:48 PM · Restricted Project, Harbormaster
epriestley renamed T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml) from Implement POST request body text field to Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).
Nov 30 2015, 4:48 PM · Restricted Project, Harbormaster
epriestley closed T9663: improve builds/buildables search as Invalid.

There's no description of what problems this is trying to solve. I don't want to just add random fields in the hope that some will be useful; see Contributing Feature Requests.

Nov 30 2015, 4:47 PM · Harbormaster
epriestley added a subtask for T6455: Implement support for dynamically building new AMI / disk image blueprints in Drydock: T5544: Implement EC2 blueprint for Drydock.
Nov 30 2015, 4:45 PM · Drydock
epriestley added a parent task for T5544: Implement EC2 blueprint for Drydock: T6455: Implement support for dynamically building new AMI / disk image blueprints in Drydock.
Nov 30 2015, 4:45 PM · Drydock
epriestley triaged T6455: Implement support for dynamically building new AMI / disk image blueprints in Drydock as Wishlist priority.
Nov 30 2015, 4:45 PM · Drydock
epriestley closed T9872: Give Drydock Working Copies useful names as Invalid.

I'll need to at some point go and clean these up.

Nov 30 2015, 4:44 PM · Drydock
epriestley closed T9698: Allow bots to have email addresses assigned to them as Invalid.
  • I believe username association works correctly.
  • Assigning an email is already mandatory when creating a bot:
Nov 30 2015, 4:42 PM · Drydock, People, Diffusion
epriestley moved T1816: Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag from Backlog to Future on the Drydock board.
Nov 30 2015, 4:40 PM · Drydock, Diffusion
epriestley merged task T9760: Autoscaling for Almanac devices into T5544: Implement EC2 blueprint for Drydock.
Nov 30 2015, 4:40 PM · Drydock, Almanac
epriestley merged T9760: Autoscaling for Almanac devices into T5544: Implement EC2 blueprint for Drydock.
Nov 30 2015, 4:40 PM · Drydock
epriestley added a comment to T9760: Autoscaling for Almanac devices.

I don't plan Almanac to ever autoscale. Autoscaling would be via a new, non-Almanac EC2 blueprint (or similar blueprints, which permit creation of new host resources). I'm just going to merge this into T5544.

Nov 30 2015, 4:39 PM · Drydock, Almanac
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Restricted Differential Revision.
Nov 30 2015, 4:39 PM · Restricted Project, ApplicationEditor, Transactions
epriestley moved T9872: Give Drydock Working Copies useful names from Backlog to Future on the Drydock board.
Nov 30 2015, 4:39 PM · Drydock
josetesan awarded T9378: Build Projects v3 a Love token.
Nov 30 2015, 3:15 PM · Projects (v3), Prioritized
epriestley closed T9869: Certain transactions not viewable while logged out? as Resolved by committing Restricted Diffusion Commit.
Nov 30 2015, 2:55 PM · Policy, Transactions
epriestley added a revision to T9869: Certain transactions not viewable while logged out?: Unknown Object (Differential Revision).
Nov 30 2015, 2:52 PM · Policy, Transactions
epriestley added a comment to T9869: Certain transactions not viewable while logged out?.

Perfect! This should be easy to fix.

Nov 30 2015, 2:50 PM · Policy, Transactions
epriestley added a comment to T9869: Certain transactions not viewable while logged out?.

I can reproduce the bug on what I think is a relatively up-to-date production installation.

Nov 30 2015, 2:40 PM · Policy, Transactions
epriestley added a comment to T9869: Certain transactions not viewable while logged out?.

You need to give us steps we can actually follow in a development environment to reproduce the issue. We can not examine database data, logs, etc, on the WMF install.

Nov 30 2015, 2:36 PM · Policy, Transactions
epriestley added a comment to T9869: Certain transactions not viewable while logged out?.

Here's what I get. Note:

Nov 30 2015, 2:33 PM · Policy, Transactions
epriestley added a comment to T9869: Certain transactions not viewable while logged out?.

I can't reproduce, those steps work fine for me on this install. I can click "Show Details" on the transaction above while logged out and get a dialog showing the details.

Nov 30 2015, 2:32 PM · Policy, Transactions
epriestley updated the task description for T9869: Certain transactions not viewable while logged out?.
Nov 30 2015, 2:31 PM · Policy, Transactions
epriestley added a comment to T9869: Certain transactions not viewable while logged out?.

Here's my guess at how to reproduce:

Nov 30 2015, 2:31 PM · Policy, Transactions
epriestley added a comment to T6889: Evaluate PHP alternatives to NodeJS for Aphlict.

This is very unlikely to happen.

Nov 30 2015, 2:26 PM · Aphlict
epriestley updated subscribers of T6889: Evaluate PHP alternatives to NodeJS for Aphlict.
Nov 30 2015, 1:46 PM · Aphlict
epriestley renamed T6889: Evaluate PHP alternatives to NodeJS for Aphlict from Remove NodeJS dependency to Evaluate PHP alternatives to NodeJS for Aphlict.
Nov 30 2015, 1:46 PM · Aphlict

Nov 29 2015

epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 29 2015, 9:45 PM · Restricted Project, ApplicationEditor, Transactions
joshuaspence closed T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function as Resolved by committing Restricted Diffusion Commit.
Nov 29 2015, 8:50 PM · libphutil
joshuaspence renamed T9871: Some PHUI form controls do not have identifiable "disabled" states from Some PHUI form controls do not have identifiable "disabled'" states to Some PHUI form controls do not have identifiable "disabled" states.
Nov 29 2015, 8:18 PM · ApplicationEditor
joshuaspence added a project to T9870: Include clang-format-lint as a linter: Lint.
Nov 29 2015, 8:17 PM · Restricted Project, Lint, Arcanist
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 29 2015, 7:31 PM · Restricted Project, ApplicationEditor, Transactions
featherless awarded T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges a Like token.
Nov 29 2015, 6:26 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 29 2015, 6:14 PM · Restricted Project, ApplicationEditor, Transactions
epriestley created T9871: Some PHUI form controls do not have identifiable "disabled" states.
Nov 29 2015, 5:40 PM · ApplicationEditor
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 29 2015, 5:37 PM · Restricted Project, ApplicationEditor, Transactions

Nov 28 2015

joshuaspence added a comment to T9848: CustomLinter Fails.
In T9848#145894, @OCram wrote:

Hmm strange, I do not use any md5 function. I simply copied the ArcanistTextLinter and changed it to work with files containing \r\n line ends. Thats the reason why I do not know where the md5 function all or the variables come from ^^

Nov 28 2015, 11:47 PM · Lint
epriestley added a comment to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.

D14589 should fix the immediate issue. I've also cherry-picked it into stable.

Nov 28 2015, 9:43 PM · Differential
epriestley renamed T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction from `metamta.differential.unified-comment-context` not working at HEAD? to Straighten out addTextSection() / addRemarkupSection() in mail body construction.
Nov 28 2015, 9:42 PM · Differential
epriestley added a revision to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction: Unknown Object (Differential Revision).
Nov 28 2015, 9:33 PM · Differential
epriestley added a comment to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.

Context here is:

Nov 28 2015, 8:44 PM · Differential
epriestley added a comment to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.

I think this is just junked up and I hadn't pushed this server when I claimed it works.

Nov 28 2015, 8:37 PM · Differential
epriestley added a comment to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.

This is likely the next cause up the line:

Nov 28 2015, 8:34 PM · Differential
epriestley added a comment to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.

I just saw this happen on this install (no metamta.differential.unified-comment-context) so my guess was probably incorrect.

Nov 28 2015, 8:29 PM · Differential
epriestley claimed T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.
Nov 28 2015, 8:29 PM · Differential
epriestley closed T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune as Resolved by committing Restricted Diffusion Commit.
Nov 28 2015, 5:14 PM · Phacility, Phortune
epriestley added a revision to T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune: Unknown Object (Differential Revision).
Nov 28 2015, 5:01 PM · Phacility, Phortune
epriestley added a comment to T9862: Harbormaster fails to queue lease .

Can you point out which parts of Contributing Bug Reports, User Guide: Prototype Applications and Support Resources are unclear to you with respect to this report so we can improve the documentation?

Nov 28 2015, 4:25 PM · Drydock, Harbormaster
epriestley renamed Blog Post: Development Notes (2015 Week 48) blog post from to Development Notes (2015 Week 48).
Nov 28 2015, 1:51 PM
epriestley edited the content of Changelog.
Nov 28 2015, 1:29 PM
epriestley created 2015 Week 48 (Very Late November).
Nov 28 2015, 1:28 PM
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 28 2015, 1:02 PM · Restricted Project, ApplicationEditor, Transactions

Nov 27 2015

epriestley added a comment to T9756: Allow Blogs and Posts to be archived.

Yeah, consistency and like "attacker gets into your account and deletes all your stuff and it's gone forever and you are so very sad" and such.

Nov 27 2015, 9:59 PM · Phame
epriestley added a comment to T9756: Allow Blogs and Posts to be archived.

We could probably just do unpublished for now and wait until we have a stronger use case for a real "archive".

Nov 27 2015, 9:56 PM · Phame
epriestley awarded T9866: Preambles in Legalpad aren't clearly visually distinguished from document text a Mountain of Wealth token.
Nov 27 2015, 9:35 PM · PHUI
epriestley added a comment to T9866: Preambles in Legalpad aren't clearly visually distinguished from document text.

Way better on my monitor now, thanks!

Nov 27 2015, 9:35 PM · PHUI
epriestley added a comment to T9867: Articulate meaningful corporate values.

I am also fine with articulating meaningless corporate values.

Nov 27 2015, 9:34 PM · Phacility
epriestley created T9867: Articulate meaningful corporate values.
Nov 27 2015, 9:26 PM · Phacility
epriestley added a comment to T9866: Preambles in Legalpad aren't clearly visually distinguished from document text.

Here's a super helpful photo of my screen :3 :3 :3 :3

Nov 27 2015, 6:29 PM · PHUI
epriestley added a comment to T9866: Preambles in Legalpad aren't clearly visually distinguished from document text.

Yeah, I'm using a Dell U3011.

Nov 27 2015, 6:26 PM · PHUI
epriestley created T9866: Preambles in Legalpad aren't clearly visually distinguished from document text.
Nov 27 2015, 6:03 PM · PHUI
epriestley closed T9856: array_diff(): Argument #1 is not an array as Invalid.

I don't know how to reproduce this, either. This may fix itself as T9132 evolves.

Nov 27 2015, 5:55 PM · Paste, Infrastructure
epriestley closed T9858: Cryptic error message when running `arc install certificate` as Resolved by committing Restricted Diffusion Commit.
Nov 27 2015, 5:05 PM · Arcanist
epriestley added a revision to T9858: Cryptic error message when running `arc install certificate`: Unknown Object (Differential Revision).
Nov 27 2015, 4:37 PM · Arcanist
epriestley added a comment to T9858: Cryptic error message when running `arc install certificate`.

Here's what's happening, in detail:

Nov 27 2015, 4:31 PM · Arcanist
epriestley renamed T9859: `arc diff` allows addition of empty directories in SVN but `arc patch` creates files from `arc diff` allows addition of empty directories but `arc patch` creates files to `arc diff` allows addition of empty directories in SVN but `arc patch` creates files.
Nov 27 2015, 4:26 PM · FreeBSD, Arcanist, Subversion
epriestley triaged T9859: `arc diff` allows addition of empty directories in SVN but `arc patch` creates files as Low priority.

This seems straightforward to reproduce:

Nov 27 2015, 4:25 PM · FreeBSD, Arcanist, Subversion
epriestley closed T9862: Harbormaster fails to queue lease as Invalid.

Drydock is also a prototype, see User Guide: Prototype Applications.

Nov 27 2015, 4:14 PM · Drydock, Harbormaster
epriestley closed T9861: Daemon PhabricatorTaskmasterDaemon throws alot of exceptions as Invalid.

You are about 4 months out of date.

Nov 27 2015, 4:14 PM · Daemons
joshuaspence edited P1896 CountTransactionsHeraldAction.php.
Nov 27 2015, 9:03 AM
featherless awarded T4103: Implement "Role Profiles" to provide search, homepage and application defaults a Like token.
Nov 27 2015, 1:58 AM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards

Nov 26 2015

epriestley added a comment to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

Cool, let us know if you run into trouble. I think it should be pretty easy to port any existing code which does generally transaction-like things, but might have missed something.

Nov 26 2015, 5:12 PM · Modernization, Maniphest
epriestley triaged T9854: Support date/time reformatting in Remarkup as Low priority.
Nov 26 2015, 3:43 PM · Contributor Onboarding, Restricted Project, Remarkup
epriestley added a comment to T9854: Support date/time reformatting in Remarkup.

My initial thought is that we should maybe just parse strings in various "almost certainly time" formats -- rather than adding a special syntax -- like:

Nov 26 2015, 3:42 PM · Contributor Onboarding, Restricted Project, Remarkup
epriestley updated the task description for T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.
Nov 26 2015, 3:29 PM · Maniphest, Installing & Upgrading
epriestley added a parent task for T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events: T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.
Nov 26 2015, 3:29 PM · Modernization, Maniphest
epriestley added a subtask for T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed: T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.
Nov 26 2015, 3:29 PM · Maniphest, Installing & Upgrading
epriestley renamed T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events from Creating/editing Maniphest task via email should trigger PhabricatorEventType::TYPE_MANIPHEST_WILLEDITTASK event to Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.
Nov 26 2015, 3:28 PM · Modernization, Maniphest
epriestley added a comment to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

D14575 passes transactions to HeraldAdapters, so custom HeraldActions may examine them. The action will receive concrete, persisted transactions which have been validated, merged, checked, and applied. This will land shortly.

Nov 26 2015, 3:27 PM · Modernization, Maniphest
epriestley added a comment to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

Problems with these events which you are exposed to:

Nov 26 2015, 3:23 PM · Modernization, Maniphest
epriestley added a revision to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events: Unknown Object (Differential Revision).
Nov 26 2015, 3:08 PM · Modernization, Maniphest
epriestley added a revision to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events: Unknown Object (Differential Revision).
Nov 26 2015, 2:58 PM · Modernization, Maniphest
epriestley created T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.
Nov 26 2015, 2:57 PM · Maniphest, Installing & Upgrading
epriestley edited P1896 CountTransactionsHeraldAction.php.
Nov 26 2015, 2:55 PM
epriestley updated the title for P1896 CountTransactionsHeraldAction.php from untitled to CountTransactionsHeraldAction.php.
Nov 26 2015, 2:52 PM
epriestley added a comment to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

Primarily, it only fires some of the time, per this task.

Nov 26 2015, 1:28 PM · Modernization, Maniphest
• andrask awarded I2 Donate to Phacility a Mountain of Wealth token.
Nov 26 2015, 11:41 AM · Phacility
joshuaspence created T9858: Cryptic error message when running `arc install certificate`.
Nov 26 2015, 4:29 AM · Arcanist
epriestley closed T9857: Column 'content' cannot be null as Resolved.

Fixed in HEAD (D14571).

Nov 26 2015, 12:39 AM · Infrastructure, Paste
joshuaspence created T9857: Column 'content' cannot be null.
Nov 26 2015, 12:07 AM · Infrastructure, Paste
joshuaspence created T9856: array_diff(): Argument #1 is not an array.
Nov 26 2015, 12:06 AM · Paste, Infrastructure
joshuaspence added a comment to T9855: DifferentialChangesSinceLastUpdateField may fail policy checks and prevent mail from sending.

Some more information:

Nov 26 2015, 12:04 AM · Daemons, Differential
joshuaspence created T9855: DifferentialChangesSinceLastUpdateField may fail policy checks and prevent mail from sending.
Nov 26 2015, 12:00 AM · Daemons, Differential

Nov 25 2015

avivey awarded T9854: Support date/time reformatting in Remarkup a Doubloon token.
Nov 25 2015, 11:00 PM · Contributor Onboarding, Restricted Project, Remarkup
joshuaspence created T9854: Support date/time reformatting in Remarkup.
Nov 25 2015, 10:19 PM · Contributor Onboarding, Restricted Project, Remarkup
epriestley added a comment to T9853: Support comments in Herald Actions .

Haha, no problem. Definitely not a big deal either way.

Nov 25 2015, 9:24 PM · Restricted Project
epriestley added a comment to T9853: Support comments in Herald Actions .

Ah, okay, I wasn't sure if "cool!" meant "approved" or "I'll look into it".

Nov 25 2015, 9:04 PM · Restricted Project