Page MenuHomePhabricator
Create Task
Maniphest T9838

Add sub-state for Revision: "Closed from Accepted"
Closed, ResolvedPublic
Actions

Description

see irc.

users probably expect "Is Accepted" rule to be considered "true" for "Closed, but was Accepted before that, and not Rejected Since".

Add a substate of "closed" which is "Closed-from-accepted", and check against that. See precommitRevisionStatus field on commits.

Revisions and Commits

rARC Arcanist
AbandonedD15084 Revision substate CLOSED_FROM_ACCEPTED
rP Phabricator
D15085rPde6349dd67af Revision substate CLOSED_FROM_ACCEPTED

Related Objects

Event Timeline

avivey created this task.Nov 23 2015, 10:19 PM
avivey raised the priority of this task from to Needs Triage.
avivey updated the task description. (Show Details)
avivey added a project: Differential.
avivey added subscribers: avivey, epriestley.
epriestley added a comment.Nov 23 2015, 10:23 PM

Just to make sure I remember things, specific issue is:

  • Change is reviewed, accepted, landed to master.
  • Now, cherry-picks of the commit to different branches will fail DiffusionPreCommitContentRevisionAcceptedHeraldField pre-commit rules. The correct revision is selected, but it is already closed, and the rule is strict about requiring "Accepted".
  • Replacing the precommitRevisionStatus stuff with this "Closed from Accepted" substate seems cleaner for both the pre-commit and post-commit rules.
  • While very unlikely, reopen + reject is theoretically possible, so we should ideally also un-set this flag in some situations.
joshuaspence added a subscriber: joshuaspence.Nov 24 2015, 7:01 AM
epriestley triaged this task as Low priority.Nov 24 2015, 4:57 PM
epriestley moved this task from Backlog to v2 (UI/Mobile) on the Differential board.
avivey added a project: Restricted Project.Dec 23 2015, 1:15 AM
avivey mentioned this in Z1336: General Chat.Jan 8 2016, 7:29 AM
chad renamed this task from add sub-state for Revision: "Closed from Accepted" to Add sub-state for Revision: "Closed from Accepted".Jan 10 2016, 9:30 PM
avivey moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jan 21 2016, 7:38 PM
avivey added a revision: D15084: Revision substate CLOSED_FROM_ACCEPTED.Jan 22 2016, 2:52 AM
avivey added a revision: D15085: Revision substate CLOSED_FROM_ACCEPTED.Jan 22 2016, 3:08 AM
epriestley mentioned this in D16180: Status Closed should also concieved as Accepted.Jun 27 2016, 12:00 PM
avivey added a commit: rPde6349dd67af: Revision substate CLOSED_FROM_ACCEPTED.Jun 27 2016, 8:29 PM
Herald added a subscriber: eadler. · View Herald TranscriptJun 27 2016, 8:29 PM
avivey closed this task as Resolved.Jul 12 2016, 9:55 PM
avivey claimed this task.
Phabricator · Built by Phacility