Page MenuHomePhabricator
Feed Advanced Search

Aug 19 2016

epriestley updated subscribers of T11498: "Change Subscribers" field does not include subscribers that will be added to a task when a Maniphest comment is submitted.

Sorry, I was responding primarily to @chad there -- the preview is at the bottom. I've circled what I was talking about here:

Aug 19 2016, 4:11 AM · Bug Report

Aug 18 2016

epriestley added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

(I believe we already show any changes that pressing the submit button will make to subscribers accurately in the preview. This wasn't always true prior to EditEngine and I think the preview/actual effect would sometimes disagree in weird cases, but I believe the preview is now always fully accurate. However, it's quite easy to miss.)

Aug 18 2016, 9:51 PM · Remarkup, Bug Report
epriestley closed T11472: STDERR svn: Authentication error from server: Username not found as Invalid.

This isn't a valid bug report, and we haven't received new information in several days.

Aug 18 2016, 9:46 PM · Bug Report (Needs Information)
epriestley closed T11486: not a valid stream resource as Invalid.

Sorry, we don't offer installation and setup help. See Support Resources for help understanding what kind of support is and isn't available from the upstream.

Aug 18 2016, 9:45 PM · Bug Report (Needs Information)
epriestley added Q463: Restricting File upload to certain groups or project (Answer 435).
Aug 18 2016, 5:37 PM
epriestley closed T11497: 哈哈 as Invalid.
Aug 18 2016, 1:42 PM · Feature Request
epriestley closed T11494: test as Spite.
Aug 18 2016, 11:51 AM · Bug Report
epriestley closed T11492: Test as Spite.
Aug 18 2016, 1:40 AM · Bug Report

Aug 17 2016

epriestley created T11490: phabricator_worker.worker_archivetask has unkeyed query on dateModified.
Aug 17 2016, 7:47 PM · Restricted Project, Daemons
epriestley changed the name of U31 Configuring Backups and Performing Migrations from to Configuring Backups and Performing Migrations.
Aug 17 2016, 6:32 PM
epriestley closed T11489: Arcanist: Duplicate at question as Resolved.

Resolved by D16415.

Aug 17 2016, 5:36 PM · Arcanist, Bug Report
epriestley added a comment to T11413: Support renaming Phacility instances.

Another possibility is to not rename any of the resources and just do the rename at the display level. This is a little messy, and occasionally a little confusing (instance newname will still have databases, backups, etc., named oldname) but we can probably do a fairly good job of covering that up.

Aug 17 2016, 5:35 PM · Phacility
epriestley added a comment to T11488: Herald Test thinks commits are not objects.

Thanks for the report! This should be fixed in HEAD of master, and promote to stable in a few days. Let me know if I missed anything or you're seeing other issues.

Aug 17 2016, 4:03 PM · Herald, Bug Report
epriestley closed T11488: Herald Test thinks commits are not objects as Resolved by committing Restricted Diffusion Commit.
Aug 17 2016, 4:03 PM · Herald, Bug Report
epriestley added a comment to T11413: Support renaming Phacility instances.

I don't really have a pathway forward on this that I like, so I'm just planning to do the one outstanding request for this manually as a copy operation and kick the can down the road.

Aug 17 2016, 4:02 PM · Phacility
epriestley lowered the priority of T11413: Support renaming Phacility instances from Normal to Low.
Aug 17 2016, 4:01 PM · Phacility
epriestley added a comment to T11413: Support renaming Phacility instances.

I think that makes things fairly easy technically:

Aug 17 2016, 3:43 PM · Phacility
epriestley added a revision to T11488: Herald Test thinks commits are not objects: Unknown Object (Differential Revision).
Aug 17 2016, 3:37 PM · Herald, Bug Report
epriestley added a comment to T11488: Herald Test thinks commits are not objects.

I broke this in D16360, on August 1.

Aug 17 2016, 3:34 PM · Herald, Bug Report
epriestley claimed T11488: Herald Test thinks commits are not objects.
Aug 17 2016, 3:34 PM · Herald, Bug Report
epriestley added a revision to T7148: Allow users to export their data from Phacility: Unknown Object (Differential Revision).
Aug 17 2016, 3:29 PM · Phacility
epriestley added a revision to T7148: Allow users to export their data from Phacility: Unknown Object (Differential Revision).
Aug 17 2016, 3:16 PM · Phacility
epriestley added a revision to T6996: Write an `--output <file>` mode for `storage dump` which can gzip: Unknown Object (Differential Revision).
Aug 17 2016, 3:12 PM · Infrastructure, Phacility
epriestley added a comment to T11413: Support renaming Phacility instances.

Thinking about the S3 issue, It's probably better to just migrate all the file data to the blob store, rename the database (which we have to do anyway), then migrate it out of the blob store.

Aug 17 2016, 3:07 PM · Phacility
epriestley added a revision to T7148: Allow users to export their data from Phacility: Unknown Object (Differential Revision).
Aug 17 2016, 2:05 PM · Phacility
epriestley added a revision to T7148: Allow users to export their data from Phacility: Unknown Object (Differential Revision).
Aug 17 2016, 2:00 PM · Phacility
epriestley added a revision to T6996: Write an `--output <file>` mode for `storage dump` which can gzip: Unknown Object (Differential Revision).
Aug 17 2016, 1:35 PM · Infrastructure, Phacility
epriestley claimed T6996: Write an `--output <file>` mode for `storage dump` which can gzip.
Aug 17 2016, 1:11 PM · Infrastructure, Phacility
epriestley added a comment to T6996: Write an `--output <file>` mode for `storage dump` which can gzip.

I'm running into a need for this to make automated export reliable, too, and don't really want to put a second copy of set -o pipefail in the codebase.

Aug 17 2016, 1:11 PM · Infrastructure, Phacility
epriestley added a parent task for T6996: Write an `--output <file>` mode for `storage dump` which can gzip: T7148: Allow users to export their data from Phacility.
Aug 17 2016, 1:10 PM · Infrastructure, Phacility
epriestley added a subtask for T7148: Allow users to export their data from Phacility: T6996: Write an `--output <file>` mode for `storage dump` which can gzip.
Aug 17 2016, 1:10 PM · Phacility
epriestley added a comment to M1467: New NUX.

Yeah, I think splitting it out is reasonable. There are a lot of reasonable ways forward that make this more of a standalone app, and it's going to need its own storage to keep track of stuff you skipped, I think. We could probably shoehorn it into Config but I don't think there's any real downside/cost to splitting it.

Aug 17 2016, 12:29 PM

Aug 16 2016

epriestley added a comment to T11481: Allow customization of forms for Workboards.

There is no actual cost to the form having more fields though, right? It doesn't actually slow you down, it just "feels" more complex?

Aug 16 2016, 11:48 PM · Workboards, Feature Request
epriestley closed T11359: "httpoxy" HTTP Proxy Environmental Vulnerability as Resolved.

This has been live for several weeks without causing any apparent issues, so I believe we're in good shape.

Aug 16 2016, 11:36 PM · Security
epriestley added a comment to T11481: Allow customization of forms for Workboards.

It sounds like you really want Workboards to work exactly like Trello, not just to be able to customize the form? That is, if we let you simplify the form down to this:

Aug 16 2016, 11:33 PM · Workboards, Feature Request
epriestley added a comment to T11487: Update preamble documentation to consider cluster mode and loadbalancers in series.

This should be fixed in HEAD of master, and in the documentation on this host whenever it regenerates (every other rainy Tuesday during a full moon).

Aug 16 2016, 11:06 PM · Documentation, Diffusion
epriestley closed T11487: Update preamble documentation to consider cluster mode and loadbalancers in series as Resolved by committing Restricted Diffusion Commit.
Aug 16 2016, 11:05 PM · Documentation, Diffusion
epriestley closed T11484: Mention actions to fix failed Autoclose in the Autoclose documentation as Resolved by committing Restricted Diffusion Commit.
Aug 16 2016, 11:04 PM · Documentation
epriestley moved T11482: Build a changeset cache for Diffusion to improve move/copy detection behvaior from Backlog to v3 on the Diffusion board.
Aug 16 2016, 11:00 PM · Diffusion (v3), Bug Report
epriestley renamed T11482: Build a changeset cache for Diffusion to improve move/copy detection behvaior from Audits don't show line-level diffs for changed and moved files to Build a changeset cache for Diffusion to improve move/copy detection behvaior.
Aug 16 2016, 10:59 PM · Diffusion (v3), Bug Report
epriestley merged task T11485: Diffusion & Auditing with GIT (Windows style newlines) into T5028: Commit message text formatting in remote git repository (SSH) is not preserved.
Aug 16 2016, 10:59 PM · Diffusion, Bug Report
epriestley merged T11485: Diffusion & Auditing with GIT (Windows style newlines) into T5028: Commit message text formatting in remote git repository (SSH) is not preserved.
Aug 16 2016, 10:59 PM · Diffusion
epriestley added a comment to T11485: Diffusion & Auditing with GIT (Windows style newlines).

I'm just going to merge this into T5028 since I think that ultimately is essentially the same issue.

Aug 16 2016, 10:58 PM · Diffusion, Bug Report
epriestley added a revision to T11484: Mention actions to fix failed Autoclose in the Autoclose documentation: Unknown Object (Differential Revision).
Aug 16 2016, 10:58 PM · Documentation
epriestley closed T11444: Bug in Milestone feature involving metadata assignments. as Invalid.

We are unable to reproduce this, and haven't received more information in about a week. Feel free to file a new task if you're able to develop reproduction steps which we can follow to reproduce the issue.

Aug 16 2016, 10:52 PM · Bug Report (Needs Information)
epriestley closed T11480: Stop sending misbehaving user nonsense to the error log as Resolved by committing Restricted Diffusion Commit.
Aug 16 2016, 10:50 PM
epriestley added a revision to T11487: Update preamble documentation to consider cluster mode and loadbalancers in series: Unknown Object (Differential Revision).
Aug 16 2016, 10:49 PM · Documentation, Diffusion
epriestley renamed T11487: Update preamble documentation to consider cluster mode and loadbalancers in series from diffusion unable to retrieve repo information when in cluster repo mode to Update preamble documentation to consider cluster mode and loadbalancers in series.
Aug 16 2016, 10:40 PM · Documentation, Diffusion
epriestley added a comment to T11481: Allow customization of forms for Workboards.

Why does having more fields make creating a task slower? I'm not able to create tasks any more quickly using a form with fewer fields.

Aug 16 2016, 10:37 PM · Workboards, Feature Request
epriestley added a revision to T11480: Stop sending misbehaving user nonsense to the error log: Unknown Object (Differential Revision).
Aug 16 2016, 9:07 PM
epriestley added a comment to T11487: Update preamble documentation to consider cluster mode and loadbalancers in series.

(T8850 is vaguely related.)

Aug 16 2016, 8:43 PM · Documentation, Diffusion
yelirekim awarded T2334: Implement Google Calendar v3 API into Calendar a Cup of Joe token.
Aug 16 2016, 8:40 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to M1467: New NUX.

Yeah, totally fine with replacing home. I think hitting this first and then having a way to skip it is good.

Aug 16 2016, 8:05 PM
epriestley added a comment to M1467: New NUX.

I like the installation / quick start split. Feels good to me for installs in general and should also give us good behavior in the Phacility cluster.

Aug 16 2016, 7:53 PM
epriestley added a comment to T11487: Update preamble documentation to consider cluster mode and loadbalancers in series.

cluster.instance is only used when serving multiple separate instances from a single cluster (for example, when hosting Phabricator for multiple clients), and should normally be left alone. This setting is used in the Phacility cluster to make x.phacility.com, y.phacility.com, etc., work correctly. This is sort of confusing because we use "cluster" to refer both to instancing and redundancy/scale; both are "clusters" in some sense but we don't generally expect users to care about instancing.

Aug 16 2016, 7:36 PM · Documentation, Diffusion
robertkraig awarded T2334: Implement Google Calendar v3 API into Calendar a Love token.
Aug 16 2016, 6:53 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11486: not a valid stream resource.

This report lacks reproduction steps, so I'm not sure how to reproduce the issue. We can't fix issues we aren't able to reproduce.

Aug 16 2016, 6:50 PM · Bug Report (Needs Information)
epriestley added a comment to T11353: Uploaded file "isn't redirecting properly".

Yes, that's correct.

Aug 16 2016, 6:20 PM · Bug Report
epriestley added a comment to T11485: Diffusion & Auditing with GIT (Windows style newlines).

Yeah, I think this is because of --format=%s. Some discussion in T5028, which is probably most of this.

Aug 16 2016, 5:46 PM · Diffusion, Bug Report
epriestley added a comment to T11353: Uploaded file "isn't redirecting properly".

I don't have any ideas on how to build a simpler reproduction case offhand.

Aug 16 2016, 5:32 PM · Bug Report
epriestley added a comment to T11353: Uploaded file "isn't redirecting properly".

Oh, sorry -- you won't be able to reproduce this particular issue in the Phacility cluster.

Aug 16 2016, 5:23 PM · Bug Report
epriestley added a project to T11485: Diffusion & Auditing with GIT (Windows style newlines): Diffusion.
Aug 16 2016, 4:35 PM · Diffusion, Bug Report
epriestley added a comment to T11485: Diffusion & Auditing with GIT (Windows style newlines).

You misspelled my username but that's enough for me to go on, thanks.

Aug 16 2016, 4:35 PM · Diffusion, Bug Report
epriestley added a comment to T11485: Diffusion & Auditing with GIT (Windows style newlines).

Can you push a commit to rGITTEST on this server which reproduces the problem? Specify "Auditors: epriestley".

Aug 16 2016, 4:21 PM · Diffusion, Bug Report
epriestley added a comment to T11482: Build a changeset cache for Diffusion to improve move/copy detection behvaior.

This may also be a good opportunity to fix T10423 since we'd end up testing the same code.

Aug 16 2016, 4:14 PM · Diffusion (v3), Bug Report
epriestley added a comment to T11485: Diffusion & Auditing with GIT (Windows style newlines).

The first line of a commit is always interpreted as a commit title, so the behavior you describe is expected.

Aug 16 2016, 3:36 PM · Diffusion, Bug Report
fooishbar awarded T11480: Stop sending misbehaving user nonsense to the error log a Burninate token.
Aug 16 2016, 3:05 PM
epriestley added a comment to T11482: Build a changeset cache for Diffusion to improve move/copy detection behvaior.

Also, thanks for providing pointers to reproduction cases on this install. Being able to fiddle with those commits locally was helpful in confirming the behavior of -M and -C with paths.

Aug 16 2016, 3:05 PM · Diffusion (v3), Bug Report
epriestley added a comment to T11482: Build a changeset cache for Diffusion to improve move/copy detection behvaior.

I think there are two issues here:

Aug 16 2016, 3:04 PM · Diffusion (v3), Bug Report
epriestley added a comment to T11482: Build a changeset cache for Diffusion to improve move/copy detection behvaior.

This is because we hate code reuse.

Aug 16 2016, 2:33 PM · Diffusion (v3), Bug Report
epriestley added a comment to T11353: Uploaded file "isn't redirecting properly".

We need detailed reproduction steps which work against a clean environment, as described in Providing Reproduction Steps. We run our entire production cluster through CloudFlare so I'm unable to reproduce the issue as described purely by using CloudFlare.

Aug 16 2016, 2:28 PM · Bug Report
epriestley created T11484: Mention actions to fix failed Autoclose in the Autoclose documentation.
Aug 16 2016, 2:05 PM · Documentation

Aug 15 2016

epriestley added a comment to T11469: Checking out from Phacility sometimes fails.

No smoking guns in the access or error logs on admin. The cache/load theory may just be a goose chase, since I don't see any evidence of unusual load around that time.

Aug 15 2016, 11:54 PM · Phacility, Bug Report
epriestley created T11480: Stop sending misbehaving user nonsense to the error log.
Aug 15 2016, 11:44 PM
venky awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Aug 15 2016, 11:36 PM · Workboards (v3), Restricted Project
epriestley added a comment to T11476: Record transaction histories when users edit application capabilities.

These are sort of technically visible in Config → Settings History, by looking at changes to phabricator.application-settings. However, this is mixed in with all the other settings and the actual diff is pretty hard to read (includes all adjusted settings; has raw JSON).

Aug 15 2016, 10:20 PM · Contributor Onboarding, Restricted Project, Applications, Feature Request

Aug 14 2016

epriestley closed T11473: harbormaster.build.search doesn't appear to constrain on 'buildables' as Resolved.
  • This constraint should be fixed at HEAD of master. We just missed the deploy so it won't go until the cluster until next week (around August 20). Let me know if I missed anything.
  • Empty constraints should be fixed at HEAD of master (they now error instead of being ignored).
  • buildablePHID vs objectPHID confusion and inconsistencies should be fixed in the future by harbormaster.buildable.search. If you want a skeletal version of this now to reduce API tweaks later, let me know and we can get one in pretty easily.
  • Linking to pre-filled forms seems maybe not hugely useful in practice, with some small risk of social engineering attacks? Feel free to file a separate request if you have use cases I'm not thinking of or whatever.
Aug 14 2016, 5:59 PM · Harbormaster, Conduit, Bug Report
epriestley added a comment to T11469: Checking out from Phacility sometimes fails.

Fix CORGI errors, check if that reveals any obvious indicators of instance information fetch issues.

Aug 14 2016, 5:52 PM · Phacility, Bug Report
epriestley added a comment to T5102: Markdown syntax of README.md file present in a repository is not well rendered.

READMEs are only rendered in the browse view:

Aug 14 2016, 5:38 PM · Diffusion
epriestley closed T11468: Intermittent "Cannot read property 'setNaturalOrder' of undefined" quick-editing tasks from workboard as Resolved by committing Restricted Diffusion Commit.
Aug 14 2016, 4:13 PM · Workboards, Bug Report (Needs Information)
epriestley added a revision to T11468: Intermittent "Cannot read property 'setNaturalOrder' of undefined" quick-editing tasks from workboard: Unknown Object (Differential Revision).
Aug 14 2016, 4:04 PM · Workboards, Bug Report (Needs Information)
epriestley added a comment to T11468: Intermittent "Cannot read property 'setNaturalOrder' of undefined" quick-editing tasks from workboard.

Slightly easier is:

Aug 14 2016, 4:01 PM · Workboards, Bug Report (Needs Information)
epriestley added a comment to T11468: Intermittent "Cannot read property 'setNaturalOrder' of undefined" quick-editing tasks from workboard.

I was able to reproduce this, possibly, by following these steps:

Aug 14 2016, 3:54 PM · Workboards, Bug Report (Needs Information)
epriestley claimed T11469: Checking out from Phacility sometimes fails.
Aug 14 2016, 3:30 PM · Phacility, Bug Report
epriestley added a comment to T11469: Checking out from Phacility sometimes fails.

No disruption is expected and there was no maintenance or known disruption at those times. Nothing jumps out at me immediately in monitoring, either, and I can't reproduce this by casually cloning stuff.

Aug 14 2016, 3:30 PM · Phacility, Bug Report
epriestley claimed T11473: harbormaster.build.search doesn't appear to constrain on 'buildables'.
Aug 14 2016, 2:54 PM · Harbormaster, Conduit, Bug Report
epriestley added a comment to T11473: harbormaster.build.search doesn't appear to constrain on 'buildables'.

D16396 should make us raise a narrow error for "ids": [], "phids": [], "whateverPHIDs": [], etc., instructing you to pass a nonempty list.

Aug 14 2016, 2:32 PM · Harbormaster, Conduit, Bug Report
epriestley added a revision to T11473: harbormaster.build.search doesn't appear to constrain on 'buildables': Unknown Object (Differential Revision).
Aug 14 2016, 2:31 PM · Harbormaster, Conduit, Bug Report
epriestley added a comment to T11473: harbormaster.build.search doesn't appear to constrain on 'buildables'.

I think fixing "ids":[] is trivial; it just works like that because we use the same Conduit type ("PHIDList") both for constraints and other things which can accept an empty array (like setting subscribers to [] to remove all the subscribers on an object).

Aug 14 2016, 1:51 PM · Harbormaster, Conduit, Bug Report
epriestley added a revision to T11473: harbormaster.build.search doesn't appear to constrain on 'buildables': Unknown Object (Differential Revision).
Aug 14 2016, 1:49 PM · Harbormaster, Conduit, Bug Report
epriestley updated subscribers of T11473: harbormaster.build.search doesn't appear to constrain on 'buildables'.

(@yelirekim, just a heads up since whatever comes of this might impact you somehow.)

Aug 14 2016, 1:41 PM · Harbormaster, Conduit, Bug Report
epriestley closed T11458: Make daemons less aggressive about cycling connections as Resolved.

Great! It looks like we're down from about 18K to 3K on repo001 too, so it appears that this pretty much works as expected.

Aug 14 2016, 1:09 PM · Restricted Project, Daemons
epriestley added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

If you don't like the @mention-implies-CC behavior, you can disable it by applying this patch to your install:

Aug 14 2016, 12:38 PM · Remarkup, Bug Report
epriestley closed T11428: Upcoming: Personal Herald Rules No Longer Semi-Private as Resolved.

This has promoted to stable and doesn't seem like a contentious change so I don't currently anticipate any need to keep this open or revisit it.

Aug 14 2016, 12:19 PM · Policy, Installing & Upgrading, Herald
epriestley added a comment to T11428: Upcoming: Personal Herald Rules No Longer Semi-Private.

Personal Herald rules do not run for disabled users, so disabling a user will disable all of their personal rules.

Aug 14 2016, 12:18 PM · Policy, Installing & Upgrading, Herald
epriestley edited the content of Changelog.
Aug 14 2016, 12:14 PM
epriestley created 2016 Week 33 (Mid August).
Aug 14 2016, 12:13 PM
epriestley added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

I also don't necessarily consider this a bug (I think a human explicitly @mention-ing a user definitely should add them again, and that quoting someone is pretty close to mentioning them, and that reasonable users could probably expect either behavior, and perhaps that the "add them again" behavior is more obvious or more expected) but T11035 discusses this and some other behaviors which have varying amounts of grey area.

Aug 14 2016, 11:56 AM · Remarkup, Bug Report
epriestley closed T11474: Incorrect rendering of links with adjanced text as Invalid.

The use case in that linked task is "using Remarkup to demonstrate the behavior of a different markup language", which isn't something we expect Remarkup to support.

Aug 14 2016, 11:46 AM · Remarkup, Bug Report
epriestley added a comment to T11474: Incorrect rendering of links with adjanced text.

Why do you want to link part of a word?

Aug 14 2016, 11:31 AM · Remarkup, Bug Report