Page MenuHomePhabricator

Herald Test thinks commits are not objects
Closed, ResolvedPublic


In the form at, enter a commit like "rGITTESTaa11a8a574db", then select "Commits" on the following form and Run Tests.

The following error page results:


Call to a member function getCommitDetail() on a non-object


┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻

The bug is present in the stable branch (updated this week), but this isn't a feature I use frequently, so it could have been around much longer.

Event Timeline

epriestley triaged this task as Normal priority.

I broke this in D16360, on August 1.

Thanks for the report! This should be fixed in HEAD of master, and promote to stable in a few days. Let me know if I missed anything or you're seeing other issues.