Page MenuHomePhabricator
Create Task
Maniphest T11488

Herald Test thinks commits are not objects
Closed, ResolvedPublic
Actions

Description

In the form at https://secure.phabricator.com/herald/test/, enter a commit like "rGITTESTaa11a8a574db", then select "Commits" on the following form and Run Tests.

The following error page results:

>>> UNRECOVERABLE FATAL ERROR <<<

Call to a member function getCommitDetail() on a non-object

/core/lib/phabricator/src/applications/diffusion/herald/HeraldCommitAdapter.php:191


┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻

The bug is present in the stable branch (updated this week), but this isn't a feature I use frequently, so it could have been around much longer.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

jasonrumney created this task.Aug 17 2016, 2:47 PM
Herald added a subscriber: eadler. · View Herald TranscriptAug 17 2016, 2:47 PM
epriestley claimed this task.Aug 17 2016, 3:34 PM
epriestley triaged this task as Normal priority.

I broke this in D16360, on August 1.

epriestley added a revision: Restricted Differential Revision.Aug 17 2016, 3:37 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Aug 17 2016, 4:02 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a comment.Aug 17 2016, 4:03 PM

Thanks for the report! This should be fixed in HEAD of master, and promote to stable in a few days. Let me know if I missed anything or you're seeing other issues.

Phabricator · Built by Phacility