Maniphest T11490

phabricator_worker.worker_archivetask has unkeyed query on dateModified
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	epriestley
	Aug 17 2016, 7:47 PM

Tags

Referenced Files

None

Subscribers

Description

The daemon status page issues this query:

SELECT * FROM `worker_archivetask` WHERE (dateModified > 1471462314) ORDER BY id DESC

There is no key on dateModified, and this table may be enormous.

Revisions and Commits

rP Phabricator
	D16423	rP3bd0da0ec243 Add a missing table key to improve performance of "Recently Completed Tasks"…

Event Timeline

epriestley created this task.Aug 17 2016, 7:47 PM

Herald added a subscriber: eadler. · View Herald TranscriptAug 17 2016, 7:47 PM

eadler added a project: Restricted Project.Aug 18 2016, 2:33 PM

epriestley added a revision: D16423: Add a missing table key to improve performance of "Recently Completed Tasks" query.Aug 19 2016, 6:32 PM

epriestley closed this task as Resolved by committing rP3bd0da0ec243: Add a missing table key to improve performance of "Recently Completed Tasks"….Aug 19 2016, 6:53 PM

epriestley added a commit: rP3bd0da0ec243: Add a missing table key to improve performance of "Recently Completed Tasks"….

This should now be fixed in HEAD of master. Thanks for the report!

(The actual key will be created the next time you run bin/storage adjust explicitly, or implicitly via bin/storage upgrade.)