Page MenuHomePhabricator
Feed Advanced Search

May 16 2017

epriestley added a revision to T12632: Resizing a diff does not resize the keyboard focus reticle: Restricted Differential Revision.
May 16 2017, 1:54 PM · Inline Comments
epriestley added a revision to T8047: Differential inline reticle can persist across Quicksand navigations: Unknown Object (Differential Revision).
May 16 2017, 1:47 PM · Inline Comments, Quicksand
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Unknown Object (Differential Revision).
May 16 2017, 1:47 PM · Differential, Inline Comments
epriestley created T12717: KeyboardShortcutManager is not Quicksand-aware.
May 16 2017, 1:45 PM · Inline Comments, Quicksand
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Unknown Object (Differential Revision).
May 16 2017, 1:39 PM · Differential, Inline Comments
epriestley moved T8047: Differential inline reticle can persist across Quicksand navigations from Glitches to Reticle on the Inline Comments board.
May 16 2017, 1:28 PM · Inline Comments, Quicksand
epriestley closed T11093: DifferentialInlineCommentEditor retains state across Quicksand requests as Resolved.

I believe this is now resolved by the series of changes attached to T12616. In particular, D17840 introduced Quicksand-aware state to changeset lists.

May 16 2017, 1:26 PM · Inline Comments, Restricted Project, Quicksand, Differential
epriestley closed T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000 as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 1:20 PM · Inline Comments, Differential, Bug Report
epriestley added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

That's partly because "\n" isn't a newline in bash:

May 16 2017, 12:58 PM · Bug Report
reet- added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

Yes, the behavior depends on the shell. I was using bash.

May 16 2017, 12:56 PM · Bug Report
sgielen added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

Ah, I see that it works differently in other shells. The above output was from zsh. In bash, indeed all output is written to the file:

May 16 2017, 12:52 PM · Bug Report
sgielen added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

It shows no output because there are no warnings. If you replace phabricator/bin/storage dump with a command that does give various formats of warnings on stderr, you see that it works:

$ sh -c 'echo "output1"; echo "error\nwarning\nerror2" 1>&2; echo "output2"' >foo.txt 2> >(grep -v warning)
error
error2
$ cat foo.txt
output1
output2
May 16 2017, 12:47 PM · Bug Report
joshuaspence added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

A vaguely related question... how is the /status/ endpoint meant to work behind an ELB? AWS ELB's don't pass a Host header to the healthcheck endpoint, so by default it just returns a 500. I worked around this by using some nginx voodoo to rewrite the Host header if the User-Agent header matches ^ELB-HealthChecker/\d+\.\d+$, but this is less-than-ideal.

May 16 2017, 12:43 PM · Phacility
reet- added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

I'm not sure this works as expected.

May 16 2017, 12:36 PM · Bug Report
sgielen added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

I used the subshell redirection trick as mentioned by @epriestley to hide this warning from our cron output as well:

May 16 2017, 11:43 AM · Bug Report
• pvgiang106 deleted Hello.
May 16 2017, 8:57 AM
• pvgiang106 deleted Add.
May 16 2017, 8:56 AM
• pvgiang106 created Add.
May 16 2017, 8:56 AM
• pvgiang106 edited the content of Hello.
May 16 2017, 8:53 AM
• pvgiang106 created Hello.
May 16 2017, 8:52 AM
wjiang added a comment to T12716: PHPCompatibility lint rule can't handle namespaced class/function name..
In T12716#223717, @chad wrote:

I assume this is T4334

May 16 2017, 3:03 AM · Bug Report
chad added a comment to T12716: PHPCompatibility lint rule can't handle namespaced class/function name..

I assume this is T4334

May 16 2017, 2:27 AM · Bug Report
wjiang updated the task description for T12716: PHPCompatibility lint rule can't handle namespaced class/function name..
May 16 2017, 2:07 AM · Bug Report
wjiang created T12716: PHPCompatibility lint rule can't handle namespaced class/function name..
May 16 2017, 2:06 AM · Bug Report
mirage315 closed Q615: Does Conduit API support close task as 'Resolved"? as resolved.
May 16 2017, 1:43 AM · Conduit
mirage315 added Q615: Does Conduit API support close task as 'Resolved"? (Answer 546).
May 16 2017, 1:43 AM
cspeckmim added a comment to T12616: Modernize display code for inline comments.

missionstatus.jpg (500×500 px, 48 KB)

May 16 2017, 12:50 AM · Inline Comments
epriestley added a comment to T12616: Modernize display code for inline comments.

I think we're mostly in the clear, now. This stuff likely introduces some bugs beyond the (mostly minor) ones I'm aware of, but I think it's all correct enough in the substantial ways. I'm going to take a break for a bit; I may get back to it tonight and land everything or may wait until tomorrow.

May 16 2017, 12:45 AM · Inline Comments
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 16 2017, 12:36 AM · Inline Comments
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 16 2017, 12:35 AM · Inline Comments
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 16 2017, 12:35 AM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 16 2017, 12:33 AM · Inline Comments

May 15 2017

epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 15 2017, 11:49 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 15 2017, 11:30 PM · Inline Comments
epriestley changed the point value for T12715: Availability of inline "Reply" action is inconsistent from 2 to 1.
May 15 2017, 11:27 PM · Inline Comments
• tomekj2ee awarded T8783: Unprototype Nuance (v1) a Love token.
May 15 2017, 10:30 PM · Nuance, Restricted Project
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 15 2017, 10:10 PM · Inline Comments
joshuaspence asked Q617: Does `repository.default-local-path` need to exist if I am not storing repositories on the web server?.
May 15 2017, 9:34 PM · Setup
epriestley added a comment to T12688: Inline Comment Design Opportunities for Improvement.

All of the inline comment icons got mis-aligned slightly a while ago. This is particularly visible with "Reply", I think. Note that the tooltip is centered, but the icon is too low (I think?) and too far to the right.

May 15 2017, 9:12 PM · Design, Differential, Inline Comments
chad added a comment to T12715: Availability of inline "Reply" action is inconsistent.

Really need an icon for points.

May 15 2017, 9:07 PM · Inline Comments
chad set the point value for T12715: Availability of inline "Reply" action is inconsistent to 2.
May 15 2017, 9:07 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 15 2017, 8:15 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 15 2017, 7:53 PM · Inline Comments
epriestley moved T12715: Availability of inline "Reply" action is inconsistent from Backlog to Glitches on the Inline Comments board.
May 15 2017, 7:43 PM · Inline Comments
epriestley created T12715: Availability of inline "Reply" action is inconsistent.
May 15 2017, 7:43 PM · Inline Comments
chad updated the task description for T10448: Modularize mail tags.
May 15 2017, 6:31 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad closed T12671: Update Maniphest for modular transactions, a subtask of T10448: Modularize mail tags, as Resolved.
May 15 2017, 6:31 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad closed T12671: Update Maniphest for modular transactions as Resolved.
May 15 2017, 6:31 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad renamed T12714: `differential.createcomment` can race automatic revision closure from differential.createcomment can race automatic revision closure to `differential.createcomment` can race automatic revision closure.
May 15 2017, 6:27 PM · Transactions, Bug Report, Restricted Project
epriestley added a comment to T4096: Generated gif-macros are not animated.

@jeffprouty Shoot us an email at support@phacility.com with details about your instance and the issue you're hitting if you're a paying customer; see also https://admin.phacility.com/book/phacility/article/support/.

May 15 2017, 5:54 PM · Macros
jeffprouty added a comment to T4096: Generated gif-macros are not animated.

Just confirming this is broken for phacility hosted instances (it is for us at least) and that there is no work around to date? Should this be it's own issue? Or should we reopen this issue?

May 15 2017, 5:51 PM · Macros
chad added a comment to T12714: `differential.createcomment` can race automatic revision closure.

uuuuuuuuuuuuuugh

May 15 2017, 5:38 PM · Transactions, Bug Report, Restricted Project
chad renamed T12714: `differential.createcomment` can race automatic revision closure from `differential.createcomment` can race automatic revision closure to differential.createcomment can race automatic revision closure.
May 15 2017, 5:38 PM · Transactions, Bug Report, Restricted Project
epriestley removed a project from T12714: `differential.createcomment` can race automatic revision closure: EditEngine.
May 15 2017, 5:10 PM · Transactions, Bug Report, Restricted Project
epriestley added a project to T12714: `differential.createcomment` can race automatic revision closure: EditEngine.
May 15 2017, 5:10 PM · Transactions, Bug Report, Restricted Project
epriestley added a project to T12714: `differential.createcomment` can race automatic revision closure: Transactions.
May 15 2017, 5:10 PM · Transactions, Bug Report, Restricted Project
epriestley created T12714: `differential.createcomment` can race automatic revision closure.
May 15 2017, 5:09 PM · Transactions, Bug Report, Restricted Project
alexmv added a comment to T7477: Handle inbound email with phabricator address in the CC.

Understood -- thanks for the clarification. One isn't always aware of how special-case one is. :)

May 15 2017, 4:14 PM · llvm, Restricted Project, Restricted Project, Mail
chad closed T12713: Can't view user profiles as Resolved by committing Restricted Diffusion Commit.
May 15 2017, 4:05 PM · Bug Report
chad added a revision to T12713: Can't view user profiles: Unknown Object (Differential Revision).
May 15 2017, 3:59 PM · Bug Report
epriestley reassigned T12713: Can't view user profiles from epriestley to chad.
May 15 2017, 3:48 PM · Bug Report
epriestley added a comment to T12713: Can't view user profiles.

Go for it, a couple emails came in that I'm still digging through. Thanks!

May 15 2017, 3:47 PM · Bug Report
chad added a comment to T12713: Can't view user profiles.

Do you have this or should I snipe? I'm home now.

May 15 2017, 3:47 PM · Bug Report
epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

We currently (at least, in theory) prevent this situation from ever occurring by preventing simultaneous tagging with both "Warp Drive > Thermocoupling" and "Warp Drive > Milestone 1". Since a task can not appear in both a milestone and subproject of a particular parent task, users can never be faced with the opportunity to perform a destructive drag operation.

May 15 2017, 3:39 PM · Bug Report
epriestley claimed T12713: Can't view user profiles.
May 15 2017, 3:31 PM · Bug Report
Luke081515.2 created T12713: Can't view user profiles.
May 15 2017, 3:15 PM · Bug Report
epriestley added a comment to T7477: Handle inbound email with phabricator address in the CC.

Many of the patches you've personally contributed in the past have bypassed the bulk of the requirements under the "Rise to Prominence" clause of Contributing Code, since you have a history with the project, are a member of Community, and have generally contributed very focused patches with clear context:

May 15 2017, 3:11 PM · llvm, Restricted Project, Restricted Project, Mail
eliaspro added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

Okay. When a task is in "Warp Drive > Thermocoupling" and "Warp Drive > Milestone 1", and you view the "Warp Drive" board and drag the task from "Milestone 1" to "Backlog", what do you expect to happen to the projecs the task is tagged with?

May 15 2017, 3:11 PM · Bug Report
alexmv added a comment to T7477: Handle inbound email with phabricator address in the CC.

Sorry, that seemed to be in response to "are you working on this?" A user has since provided a patch for the feature, which is the sort of thing which in the past you folks have generally been nice enough to review.

May 15 2017, 2:53 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

Okay. When a task is in "Warp Drive > Thermocoupling" and "Warp Drive > Milestone 1", and you view the "Warp Drive" board and drag the task from "Milestone 1" to "Backlog", what do you expect to happen to the projecs the task is tagged with?

May 15 2017, 2:52 PM · Bug Report
eliaspro added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

Do you expect a task to be able to be tagged with "Warp Drive" and also simultaneously tagged with subproject "Warp Drive > Thermocoupling"?

No, Thermocoupling alone is enough, as it implies it's part of Warp Drive.

Do you expect a task to be able to be tagged with "Warp Drive" and also simultaneously tagged with milestone "Warp Drive > Milestone 1"?

No, Milestone 1 alone is enough, as it implies it's part of Warp Drive

May 15 2017, 2:50 PM · Bug Report
epriestley added a comment to T7477: Handle inbound email with phabricator address in the CC.

Per above, see Planning. If that isn't clear, let me know how we could improve it.

May 15 2017, 2:48 PM · llvm, Restricted Project, Restricted Project, Mail
alexmv added a comment to T7477: Handle inbound email with phabricator address in the CC.

Phacility folks, do you have thoughts about the patch provided by @lyngvi above? Would be it be easier to review if submitted as a Diff?

May 15 2017, 2:45 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

Do you expect a task to be able to be tagged with "Warp Drive" and also simultaneously tagged with subproject "Warp Drive > Thermocoupling"?
Do you expect a task to be able to be tagged with "Warp Drive" and also simultaneously tagged with milestone "Warp Drive > Milestone 1"?

May 15 2017, 2:44 PM · Bug Report
eliaspro added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

What it looks like here:
We have the project Grammofy Collections which represents one of our products.
It has a milestone Full Catalog Access
It also has a subproject Grammofy Collections: Frontend/Web

May 15 2017, 2:38 PM · Bug Report
RikiWiki added a comment to T12711: Add the "Print" in each task page .

As usual, thank you very much (to both of you) for your precision and speed.

May 15 2017, 1:53 PM · Feature Request
epriestley added a comment to T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.

This should now be resolved in HEAD of master and stable. Thanks for the report!

May 15 2017, 1:45 PM · Projects, Bug Report
epriestley closed T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them as Resolved by committing Restricted Diffusion Commit.
May 15 2017, 1:44 PM · Projects, Bug Report
epriestley renamed T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them from Project profile broken to Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.
May 15 2017, 1:43 PM · Projects, Bug Report
epriestley edited projects for T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them, added: Bug Report, Projects; removed Bug Report (Needs Information).
May 15 2017, 1:42 PM · Projects, Bug Report
cspeckmim added a comment to T12711: Add the "Print" in each task page .

I think the phabricator pages typically have CSS for @media=print or whatever HTML is -- which means you can print or print-to-pdf and generally get a good result. I hadn't done it in several months, but trying it on this task it's a little narrow

May 15 2017, 1:41 PM · Feature Request
chad closed T12711: Add the "Print" in each task page as Invalid.

If you have a very narrow and specific need for Phabricator, our expectation is you will fork the product and provide the feature to your install. This feature is unfortunately too specific for your needs since you can already easily print any page in Phabricator via your browser, already formatted for printing.

May 15 2017, 1:40 PM · Feature Request
epriestley added a revision to T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them: Unknown Object (Differential Revision).
May 15 2017, 1:38 PM · Projects, Bug Report
epriestley added a comment to T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.

I'll just ship up the "unbreak" diff, and you can either counter-diff me or figure out something else.

May 15 2017, 1:36 PM · Projects, Bug Report
epriestley updated subscribers of T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.

I think more narrow reproduction instructions are:

May 15 2017, 1:35 PM · Projects, Bug Report
RikiWiki added a comment to T12711: Add the "Print" in each task page .

It would be enough just to be able to print the title and the description, that is to say, what you actually see when you click on a task (leaving out comments). As an example, see the file attached.

May 15 2017, 12:52 PM · Feature Request
RikiWiki added a comment to T12712: Sort tasks in the advance search by creation date.

thank you! sorry for this stupid question :)

May 15 2017, 12:43 PM · Feature Request
mrthomasbrix added a comment to T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.

Yes on the Almanac project profile.

May 15 2017, 11:38 AM · Projects, Bug Report
epriestley edited projects for T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them, added: Bug Report (Needs Information); removed Bug Report.
May 15 2017, 11:12 AM · Projects, Bug Report
epriestley added a comment to T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.

I can't reproduce this. Here's an example of a profile working correctly for me locally:

May 15 2017, 11:12 AM · Projects, Bug Report
epriestley closed T12712: Sort tasks in the advance search by creation date as Resolved.

Select "Order By: Creation (Newest First)" or "Order By: Creation (Oldest First)".

May 15 2017, 11:10 AM · Feature Request
RikiWiki created T12712: Sort tasks in the advance search by creation date.
May 15 2017, 9:18 AM · Feature Request
RikiWiki created T12711: Add the "Print" in each task page .
May 15 2017, 7:50 AM · Feature Request
mrthomasbrix created T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.
May 15 2017, 7:31 AM · Projects, Bug Report
richardvanvelzen added Q614: Does notification server has some ring tone when message pop up? (Answer 544).
May 15 2017, 3:31 AM
chad added Q597: Is there any Forum integrated with Phabricator? (Answer 543).
May 15 2017, 3:31 AM
maxie added Q468: Create task from emails (Answer 545).
May 15 2017, 3:31 AM
• tranba moved T5375: Tokenizers fail in Firefox on Android from Backlog to Icebox on the Android board.
May 15 2017, 3:05 AM · Firefox, Android
• tranba moved T5375: Tokenizers fail in Firefox on Android from Icebox to Backlog on the Android board.
May 15 2017, 3:05 AM · Firefox, Android
chad added a revision to T12707: Add "watching" to Project ApplicationSearch: Unknown Object (Differential Revision).
May 15 2017, 12:35 AM · Projects