Page MenuHomePhabricator
Feed Advanced Search

Aug 15 2016

chad added a project to T11476: Record transaction histories when users edit application capabilities: Applications.
Aug 15 2016, 5:37 PM · Contributor Onboarding, Restricted Project, Applications, Feature Request
chad added a comment to T11475: Allow users to bulk-change visibility and editability policies for Phriction documents.

I'm vaguely assuming this should work reading the code for PhrictionDocument.

Aug 15 2016, 5:37 PM · Phriction, Feature Request
chad added a project to T11475: Allow users to bulk-change visibility and editability policies for Phriction documents: Phriction.

See T4675#57776 for a local workaround for now.

Aug 15 2016, 5:32 PM · Phriction, Feature Request
chad added a revision to T11477: Typo in User Display Preferences: Unknown Object (Differential Revision).
Aug 15 2016, 5:07 PM · Bug Report
chad created M1467: New NUX.
Aug 15 2016, 4:59 PM
werter created T11477: Typo in User Display Preferences.
Aug 15 2016, 11:39 AM · Bug Report
Alofoxx added a comment to T3179: Importing data from external systems (like GitHub, JIRA, Trac, Asana, Trello, etc.).
In T3179#169180, @Kunda wrote:

Any MantisBT -> Phabricator migration scripts ?

Aug 15 2016, 9:19 AM · Guides, Doorkeeper
yelirekim created T11476: Record transaction histories when users edit application capabilities.
Aug 15 2016, 6:05 AM · Contributor Onboarding, Restricted Project, Applications, Feature Request

Aug 14 2016

mbm created T11475: Allow users to bulk-change visibility and editability policies for Phriction documents.
Aug 14 2016, 10:56 PM · Phriction, Feature Request
venky added a comment to T11473: harbormaster.build.search doesn't appear to constrain on 'buildables'.

Awesome! I appreciate the quick fixes!

Aug 14 2016, 10:07 PM · Harbormaster, Conduit, Bug Report
epriestley closed T11473: harbormaster.build.search doesn't appear to constrain on 'buildables' as Resolved.
  • This constraint should be fixed at HEAD of master. We just missed the deploy so it won't go until the cluster until next week (around August 20). Let me know if I missed anything.
  • Empty constraints should be fixed at HEAD of master (they now error instead of being ignored).
  • buildablePHID vs objectPHID confusion and inconsistencies should be fixed in the future by harbormaster.buildable.search. If you want a skeletal version of this now to reduce API tweaks later, let me know and we can get one in pretty easily.
  • Linking to pre-filled forms seems maybe not hugely useful in practice, with some small risk of social engineering attacks? Feel free to file a separate request if you have use cases I'm not thinking of or whatever.
Aug 14 2016, 5:59 PM · Harbormaster, Conduit, Bug Report
epriestley added a comment to T11469: Checking out from Phacility sometimes fails.

Fix CORGI errors, check if that reveals any obvious indicators of instance information fetch issues.

Aug 14 2016, 5:52 PM · Phacility, Bug Report
epriestley added a comment to T5102: Markdown syntax of README.md file present in a repository is not well rendered.

READMEs are only rendered in the browse view:

Aug 14 2016, 5:38 PM · Diffusion
nemobis added a comment to T5102: Markdown syntax of README.md file present in a repository is not well rendered.

Was rendering disabled altogether? https://secure.phabricator.com/diffusion/P/browse/master/README.md shows up as a mere textarea.

Aug 14 2016, 5:14 PM · Diffusion
epriestley closed T11468: Intermittent "Cannot read property 'setNaturalOrder' of undefined" quick-editing tasks from workboard as Resolved by committing Restricted Diffusion Commit.
Aug 14 2016, 4:13 PM · Workboards, Bug Report (Needs Information)
epriestley added a revision to T11468: Intermittent "Cannot read property 'setNaturalOrder' of undefined" quick-editing tasks from workboard: Unknown Object (Differential Revision).
Aug 14 2016, 4:04 PM · Workboards, Bug Report (Needs Information)
epriestley added a comment to T11468: Intermittent "Cannot read property 'setNaturalOrder' of undefined" quick-editing tasks from workboard.

Slightly easier is:

Aug 14 2016, 4:01 PM · Workboards, Bug Report (Needs Information)
epriestley added a comment to T11468: Intermittent "Cannot read property 'setNaturalOrder' of undefined" quick-editing tasks from workboard.

I was able to reproduce this, possibly, by following these steps:

Aug 14 2016, 3:54 PM · Workboards, Bug Report (Needs Information)
epriestley claimed T11469: Checking out from Phacility sometimes fails.
Aug 14 2016, 3:30 PM · Phacility, Bug Report
epriestley added a comment to T11469: Checking out from Phacility sometimes fails.

No disruption is expected and there was no maintenance or known disruption at those times. Nothing jumps out at me immediately in monitoring, either, and I can't reproduce this by casually cloning stuff.

Aug 14 2016, 3:30 PM · Phacility, Bug Report
epriestley claimed T11473: harbormaster.build.search doesn't appear to constrain on 'buildables'.
Aug 14 2016, 2:54 PM · Harbormaster, Conduit, Bug Report
epriestley added a comment to T11473: harbormaster.build.search doesn't appear to constrain on 'buildables'.

D16396 should make us raise a narrow error for "ids": [], "phids": [], "whateverPHIDs": [], etc., instructing you to pass a nonempty list.

Aug 14 2016, 2:32 PM · Harbormaster, Conduit, Bug Report
epriestley added a revision to T11473: harbormaster.build.search doesn't appear to constrain on 'buildables': Unknown Object (Differential Revision).
Aug 14 2016, 2:31 PM · Harbormaster, Conduit, Bug Report
epriestley added a comment to T11473: harbormaster.build.search doesn't appear to constrain on 'buildables'.

I think fixing "ids":[] is trivial; it just works like that because we use the same Conduit type ("PHIDList") both for constraints and other things which can accept an empty array (like setting subscribers to [] to remove all the subscribers on an object).

Aug 14 2016, 1:51 PM · Harbormaster, Conduit, Bug Report
epriestley added a revision to T11473: harbormaster.build.search doesn't appear to constrain on 'buildables': Unknown Object (Differential Revision).
Aug 14 2016, 1:49 PM · Harbormaster, Conduit, Bug Report
epriestley updated subscribers of T11473: harbormaster.build.search doesn't appear to constrain on 'buildables'.

(@yelirekim, just a heads up since whatever comes of this might impact you somehow.)

Aug 14 2016, 1:41 PM · Harbormaster, Conduit, Bug Report
epriestley closed T11458: Make daemons less aggressive about cycling connections as Resolved.

Great! It looks like we're down from about 18K to 3K on repo001 too, so it appears that this pretty much works as expected.

Aug 14 2016, 1:09 PM · Restricted Project, Daemons
epriestley added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

If you don't like the @mention-implies-CC behavior, you can disable it by applying this patch to your install:

Aug 14 2016, 12:38 PM · Remarkup, Bug Report
MZMcBride added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.
In T11471#190079, @chad wrote:

I don't consider this to be a bug and any fix would likely lead to additional user confusion over "magic".

Aug 14 2016, 12:21 PM · Remarkup, Bug Report
epriestley closed T11428: Upcoming: Personal Herald Rules No Longer Semi-Private as Resolved.

This has promoted to stable and doesn't seem like a contentious change so I don't currently anticipate any need to keep this open or revisit it.

Aug 14 2016, 12:19 PM · Policy, Installing & Upgrading, Herald
epriestley added a comment to T11428: Upcoming: Personal Herald Rules No Longer Semi-Private.

Personal Herald rules do not run for disabled users, so disabling a user will disable all of their personal rules.

Aug 14 2016, 12:18 PM · Policy, Installing & Upgrading, Herald
epriestley edited the content of Changelog.
Aug 14 2016, 12:14 PM
epriestley created 2016 Week 33 (Mid August).
Aug 14 2016, 12:13 PM
MZMcBride updated the task description for T4828: Suggest/propose possible duplicates when creating a new task.
Aug 14 2016, 11:59 AM · Wikimedia, Maniphest
epriestley added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

I also don't necessarily consider this a bug (I think a human explicitly @mention-ing a user definitely should add them again, and that quoting someone is pretty close to mentioning them, and that reasonable users could probably expect either behavior, and perhaps that the "add them again" behavior is more obvious or more expected) but T11035 discusses this and some other behaviors which have varying amounts of grey area.

Aug 14 2016, 11:56 AM · Remarkup, Bug Report
epriestley closed T11474: Incorrect rendering of links with adjanced text as Invalid.

The use case in that linked task is "using Remarkup to demonstrate the behavior of a different markup language", which isn't something we expect Remarkup to support.

Aug 14 2016, 11:46 AM · Remarkup, Bug Report
Danny_B added a comment to T11474: Incorrect rendering of links with adjanced text.

The example is pretty descriptive, I'd say. Because of linking to the description of that exact part of the word.

Aug 14 2016, 11:44 AM · Remarkup, Bug Report
epriestley added a comment to T11474: Incorrect rendering of links with adjanced text.

Why do you want to link part of a word?

Aug 14 2016, 11:31 AM · Remarkup, Bug Report
Danny_B created T11474: Incorrect rendering of links with adjanced text.
Aug 14 2016, 11:28 AM · Remarkup, Bug Report
epriestley edited projects for T11472: STDERR svn: Authentication error from server: Username not found, added: Bug Report (Needs Information); removed Bug Report.

What specific steps can I follow to reproduce this issue? See Providing Reproduction Steps for help.

Aug 14 2016, 11:27 AM · Bug Report (Needs Information)
• gaojiji added Q315: How can I get the column PHID via Conduit method? (Answer 431).
Aug 14 2016, 9:43 AM
venky added a comment to T11473: harbormaster.build.search doesn't appear to constrain on 'buildables'.

slightly related: there's some confusing naming in the result for harbormaster.querybuildables:

Aug 14 2016, 8:46 AM · Harbormaster, Conduit, Bug Report
venky added projects to T11473: harbormaster.build.search doesn't appear to constrain on 'buildables': Conduit, Harbormaster.
Aug 14 2016, 8:41 AM · Harbormaster, Conduit, Bug Report
venky created T11473: harbormaster.build.search doesn't appear to constrain on 'buildables'.
Aug 14 2016, 8:41 AM · Harbormaster, Conduit, Bug Report
• homemoon created T11472: STDERR svn: Authentication error from server: Username not found.
Aug 14 2016, 7:50 AM · Bug Report (Needs Information)
epriestley merged T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks into T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.
Aug 14 2016, 2:33 AM · Prioritized, Wikimedia, Remarkup
epriestley merged task T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks into T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.
Aug 14 2016, 2:33 AM · Remarkup, Bug Report

Aug 13 2016

chad added a project to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks: Remarkup.
Aug 13 2016, 11:54 PM · Remarkup, Bug Report
chad removed a project from T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks: Maniphest.
Aug 13 2016, 11:43 PM · Remarkup, Bug Report
chad added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

I don't consider this to be a bug and any fix would likely lead to additional user confusion over "magic".

Aug 13 2016, 11:43 PM · Remarkup, Bug Report
Danny_B added a project to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks: Maniphest.
Aug 13 2016, 11:37 PM · Remarkup, Bug Report
MZMcBride created T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.
Aug 13 2016, 11:26 PM · Remarkup, Bug Report
cspeckmim added a comment to T4322: Diffusion show folders first.

I've used a mac for ~6 years now and still get annoyed that Finder won't list folders above files sorted by name. For me the folders work as a navigation control instead of content which is why I usually like them separate. My preference said, it doesn't really affect me in Diffusion.

Aug 13 2016, 7:59 PM · Diffusion
epriestley added a comment to T4322: Diffusion show folders first.

See additional discussion in D9343.

Aug 13 2016, 3:47 PM · Diffusion
epriestley merged task T11470: Provide a way to have directories first in Diffusion into T4322: Diffusion show folders first.
Aug 13 2016, 3:45 PM · Diffusion, Feature Request
epriestley merged T11470: Provide a way to have directories first in Diffusion into T4322: Diffusion show folders first.
Aug 13 2016, 3:45 PM · Diffusion
Danny_B created T11470: Provide a way to have directories first in Diffusion.
Aug 13 2016, 3:33 PM · Diffusion, Feature Request
chad added a comment to T11469: Checking out from Phacility sometimes fails.

secure.phabricator.com isn't in the Phacility cluster

Aug 13 2016, 3:09 PM · Phacility, Bug Report
swisspol added a comment to T11469: Checking out from Phacility sometimes fails.

Why do you mean by "this instance"?

Aug 13 2016, 2:27 PM · Phacility, Bug Report
Luke081515.2 added a comment to T11469: Checking out from Phacility sometimes fails.

I got code 500 as I checked out from this instance, was about 23:50 UTC, yesterday. Maybe related? After getting that code, I tried it again after about 10 seconds, then, everything was ok.

Aug 13 2016, 11:58 AM · Phacility, Bug Report
swisspol updated the task description for T11469: Checking out from Phacility sometimes fails.
Aug 13 2016, 5:34 AM · Phacility, Bug Report

Aug 12 2016

chad added a project to T11469: Checking out from Phacility sometimes fails: Phacility.
Aug 12 2016, 10:12 PM · Phacility, Bug Report
DanSheps added a comment to T10349: Projects v3 Errata.

I just wanted to pop in and comment on the UI for projects.

Aug 12 2016, 9:08 PM · Restricted Project, Projects (v3)
swisspol created T11469: Checking out from Phacility sometimes fails.
Aug 12 2016, 8:58 PM · Phacility, Bug Report
bcooksley added a comment to T4245: Make repository URIs slightly prettier.

How difficult would this be for someone to implement / does upstream have an implementation timeline for this?

Aug 12 2016, 7:22 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
batcha added a comment to T8345: Add task tabs for "Mentions" and "Merged".

If commits will end up in a tab, are there any plans on changing the link format at the commit list in the details section? It can sometimes become poorly readable since the links consists of repo and revision data prior to the messages.

Aug 12 2016, 6:33 PM · Restricted Project, FreeBSD, Maniphest
jmeador added a comment to T11458: Make daemons less aggressive about cycling connections.

After merging with upstream, we were able to increase our taskmasters up to 32, and still not come anywhere close to the number of connections that were previously used. So far, so good on our end.

Aug 12 2016, 6:26 PM · Restricted Project, Daemons
chad added a comment to T11132: New Phabricator NUX.

I have 7 panels for new Phacility Admin, trying to think of one last action panel..... .... .... memes?!? Good idea or great idea?

Aug 12 2016, 6:22 PM · Design, Phacility, NUX
chad added a comment to T11468: Intermittent "Cannot read property 'setNaturalOrder' of undefined" quick-editing tasks from workboard.

I would also maybe check webserver error logs, too. OS/Browser might help to know as well.

Aug 12 2016, 4:23 PM · Workboards, Bug Report (Needs Information)
chad edited projects for T11468: Intermittent "Cannot read property 'setNaturalOrder' of undefined" quick-editing tasks from workboard, added: Bug Report (Needs Information), Workboards; removed Bug Report.
Aug 12 2016, 4:21 PM · Workboards, Bug Report (Needs Information)
chad added a comment to T11468: Intermittent "Cannot read property 'setNaturalOrder' of undefined" quick-editing tasks from workboard.

I can't reproduce this based on the steps provided. Have you been able to reproduce in a clean environment like a test instance on http://phacility.com ?

Aug 12 2016, 4:14 PM · Workboards, Bug Report (Needs Information)
stevex added a comment to T4411: Adding a CC to a Maniphest Task should give View rights for that user.

In my personal opinion adding a CC that cannot see the task is an error and like this should be treated, meaning ux should just report as error when try to save it. It is important that ux reports it since it can be overlooked by the person changing the task.

Aug 12 2016, 2:21 PM · Wikimedia, Policy
epriestley closed T11411: Commits to github branch close Differential revision as Resolved.

I added you to Community, granting you sweeping janitorial powers on this install.

Aug 12 2016, 2:00 PM · Documentation, Diffusion
epriestley added a member for Community: venky.
Aug 12 2016, 2:00 PM
epriestley added a comment to T11132: New Phabricator NUX.

It's not 100% reliable but we can use that to make a pretty good guess.

Aug 12 2016, 1:55 PM · Design, Phacility, NUX
FauxFaux created T11468: Intermittent "Cannot read property 'setNaturalOrder' of undefined" quick-editing tasks from workboard.
Aug 12 2016, 11:24 AM · Workboards, Bug Report (Needs Information)
vanmeeuwen awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Aug 12 2016, 6:13 AM · Workboards (v3), Restricted Project
Alofoxx added a comment to T3179: Importing data from external systems (like GitHub, JIRA, Trac, Asana, Trello, etc.).

For those moving from MantisBT into Phabricator Maniphest I'm activily building a full import web based tool that will extract just about anything from mantis, allow editing/ touching up, then process the import into a Phab conduit.

Aug 12 2016, 5:05 AM · Guides, Doorkeeper
chad added a revision to T11132: New Phabricator NUX: Unknown Object (Differential Revision).
Aug 12 2016, 3:06 AM · Design, Phacility, NUX
venky added a comment to T11411: Commits to github branch close Differential revision.

This is resolved on my end.

Aug 12 2016, 2:50 AM · Documentation, Diffusion
chad added a comment to T11132: New Phabricator NUX.

We know if someone has set up arcanist, correct? They ran arc install-certificate?

Aug 12 2016, 2:48 AM · Design, Phacility, NUX
chad closed T11467: Deleting a mailing list user on hosted instance as Resolved.
Aug 12 2016, 2:41 AM · Bug Report
venky removed a project from T11467: Deleting a mailing list user on hosted instance: Phacility.
Aug 12 2016, 2:38 AM · Bug Report
venky added a comment to T11467: Deleting a mailing list user on hosted instance.

Please close - I figured out how to change the username. Not sure why I missed it the first time :(

Aug 12 2016, 2:37 AM · Bug Report
venky created T11467: Deleting a mailing list user on hosted instance.
Aug 12 2016, 2:21 AM · Bug Report
chad closed T11457: Can't scroll filetree in revision as Resolved by committing Restricted Diffusion Commit.
Aug 12 2016, 12:27 AM · Differential, Bug Report
chad added a revision to T11457: Can't scroll filetree in revision: Unknown Object (Differential Revision).
Aug 12 2016, 12:12 AM · Differential, Bug Report

Aug 11 2016

chad added a comment to T11462: `exact()` function cannot have `viewer()` as argument.

Yeah, my main concern here is it sounds like you're working around #reviewers by installing a different dashboard on everyone's homepage. In which case maybe moving #reviewers to a CC instead might be better. People will still retain awareness, but the reviews will be optional. Pinterest also has some sort of round robin thing built for not overloading a group of reviewers. https://engineering.pinterest.com/blog/shipping-faster-new-pr-processing-system

Aug 11 2016, 10:22 PM · Restricted Project, Feature Request
em added a comment to T11462: `exact()` function cannot have `viewer()` as argument.

It's very likely that our workflow is suboptimal, to be honest I just learned about this #reviewers group so I'll definitely discuss this with other people here.

Aug 11 2016, 10:18 PM · Restricted Project, Feature Request
chad updated subscribers of T11462: `exact()` function cannot have `viewer()` as argument.

Is it a reasonable possibility at looking at being more surgical with how project reviewers are added? Our general MO here is reviews should programmatically get targeted to the minimum set of responsible individuals, and people who want to be included outside of that use tools like Herald to watch for diffs they are not included on. Things like setting up code ownership packages, or making different projects for different types of diffs might make reviewing much easier.

Aug 11 2016, 10:03 PM · Restricted Project, Feature Request
em added a comment to T11462: `exact()` function cannot have `viewer()` as argument.

No worries, I just started reporting issues upstream and it takes a while for me to understand what are your expectations and where they differ from mine. :D

Aug 11 2016, 9:57 PM · Restricted Project, Feature Request
chad added a comment to T11462: `exact()` function cannot have `viewer()` as argument.

Thanks, this is super helpful. Sorry for the back and forth.

Aug 11 2016, 9:54 PM · Restricted Project, Feature Request
em added a comment to T11462: `exact()` function cannot have `viewer()` as argument.

The current status:

Aug 11 2016, 9:53 PM · Restricted Project, Feature Request
chad added a comment to T11462: `exact()` function cannot have `viewer()` as argument.

Specifically, it sounds like you want to exclude diffs you're on as a project reviewer for? But only as a panel, you still want to be on those diffs overall?

Aug 11 2016, 9:37 PM · Restricted Project, Feature Request
avivey renamed T11466: Build status on Differential search results from Build status on Differential inboxes to Build status on Differential search results.
Aug 11 2016, 9:36 PM · Differential, Feature Request
chad added a comment to T11462: `exact()` function cannot have `viewer()` as argument.

I'm trying to set up a panel listing reviews where the current user has been explicitly tagged.

Aug 11 2016, 9:32 PM · Restricted Project, Feature Request
em added a comment to T11462: `exact()` function cannot have `viewer()` as argument.

I'm sorry if I sound like proposing solutions instead of taking more time to think about the larger problem, it's just that I have two readily available tools (viewer() and exact()) that combined would do exactly what I needed right now, but I just cannot combine them.

Aug 11 2016, 9:10 PM · Restricted Project, Feature Request
venky updated the task description for T11466: Build status on Differential search results.
Aug 11 2016, 9:05 PM · Differential, Feature Request
venky added a comment to T11466: Build status on Differential search results.

Here's github's version of this, as an example.

Aug 11 2016, 9:04 PM · Differential, Feature Request
venky created T11466: Build status on Differential search results.
Aug 11 2016, 9:03 PM · Differential, Feature Request