Page MenuHomePhabricator
Feed Advanced Search

Jul 31 2016

epriestley added a comment to T11404: Improve the performance of custom field queries.

Ah, there are really a couple of issues here.

Jul 31 2016, 3:02 PM · Performance, Feature Request
Danny_B added a comment to T11405: Need to watch the project programmatically.

Come on, Evan, seriously? :-/

Jul 31 2016, 2:56 PM · Feature Request (Needs Information), Conduit
epriestley closed T11405: Need to watch the project programmatically as Invalid.

Please please please please please please please please please please please please read Describing Root Problems carefully and think about what it is asking for.

Jul 31 2016, 2:49 PM · Feature Request (Needs Information), Conduit
aklapper added a comment to T11312: Watch / Subscribe project Herald action needed.

there is no (preferably customizable) real feed (Atom, RSS). [...] there was some task here about it but I can't find it now.

Jul 31 2016, 2:35 PM · Herald, Feature Request
Danny_B added a comment to T11312: Watch / Subscribe project Herald action needed.

A small (partially off-topic) note about feed - in such a high traffic Phabricator instance like ours (WMF), it is nearly unusable. Fortiori if there is no (preferably customizable) real feed (Atom, RSS). Lack of feed support in Phabricator is one of its biggest disadvantages. I know there was some task here about it but I can't find it now.

Jul 31 2016, 2:33 PM · Herald, Feature Request
aklapper added a comment to T11312: Watch / Subscribe project Herald action needed.

As I was asked to provide some input here:

  • Why aren't they using "Send me an email" rules?

That is what I am currently doing via Herald in our Maniphest installation. :)

  • Why aren't they using Feed?

As a bugmaster, my workflow is primarily email-based (describing a fact here that likely could be challenged). I receive notifications on Maniphest task changes which interest me and filter / process them. I abuse the "Unread" status of certain emails to mark stuff I'd like to follow up on later. I have not played with Feed (or an application to consume feeds) to be able to judge whether that would also suit my needs on processing large amounts of information and acting on some of that.

  • Why do they want all of this information in the first place?

As a bugmaster, I'd like to get informed of most / nearly all changes on tasks, to allow me clarifying task descriptions (steps to reproduce etc), escalate issues that seem important, manage expectations, etc., to support our many stakeholders.

Jul 31 2016, 2:28 PM · Herald, Feature Request
Danny_B created T11405: Need to watch the project programmatically.
Jul 31 2016, 2:23 PM · Feature Request (Needs Information), Conduit
epriestley added a comment to T11404: Improve the performance of custom field queries.

That looks broadly correct to me, I just want to try to remove the assumption that the first object's first field's storage is universally the right storage in fixing this upstream. It's always true today and for the foreseeable future, just obviously not a Fundamental Axiom of the System. Let me review D16346 and I'll spend 10 minutes on this, I'm pretty sure it's straightforward, not a weird snowbally mess, and that the upstreamable patch is only cosmetically different from that one.

Jul 31 2016, 1:15 PM · Performance, Feature Request
yelirekim added a comment to T11404: Improve the performance of custom field queries.

This is brittle but it works if your objects all use the native storage.

Jul 31 2016, 1:08 PM · Performance, Feature Request
epriestley added a comment to T11404: Improve the performance of custom field queries.

I think the issue is that there's no callable thing for bulk-loading custom fields right now, which is why SearchEngineExtension doesn't have a hook for it. Other SearchEngine extensions don't need it since none currently load any data.

Jul 31 2016, 12:57 PM · Performance, Feature Request
epriestley added a comment to T11402: Garbage collect and/or compress/archive harbormaster build unit messages.

T10635 is vaguely related, too.

Jul 31 2016, 12:37 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T2495: Improve whitespace expansion of tab literals.

See Planning for help understanding timelines and priorities.

Jul 31 2016, 12:31 PM · Restricted Project, FreeBSD, Diffusion, Differential
epriestley added a comment to T11403: Phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail...

I can't reproduce this here, locally, or in the Phacility cluster. Can you? You should be able to push to rGITTEST on this install, or launch a test instance from admin.phacility.com and create a repository there.

Jul 31 2016, 12:30 PM · Diffusion, Bug Report
epriestley added a project to T11404: Improve the performance of custom field queries: Performance.
Jul 31 2016, 12:20 PM · Performance, Feature Request
william.pursell added a comment to T2495: Improve whitespace expansion of tab literals.

Is this still actively being worked on, is there a different solution than View Options->Set Tab Width, or should I apply the patch referenced by raman.rathod?

Jul 31 2016, 11:34 AM · Restricted Project, FreeBSD, Diffusion, Differential
yelirekim created T11404: Improve the performance of custom field queries.
Jul 31 2016, 10:48 AM · Performance, Feature Request
Info-Screen awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Jul 31 2016, 8:20 AM · Prioritized, Restricted Project, Infrastructure
Fordy created T11403: Phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail...
Jul 31 2016, 7:47 AM · Diffusion, Bug Report
Fordy added a comment to Q456: Why do phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail, even though the push works?.

It would probably help if I knew what 'refs' git was trying to push and failed on. Normally git is meant to tell you what failed if I read all the git pages/help - but it seems git isn't telling me anything about the failure!

Jul 31 2016, 7:28 AM
Fordy added a comment to Q456: Why do phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail, even though the push works?.

Thanks for feedback so far :)

Jul 31 2016, 7:26 AM

Jul 30 2016

chad added a comment to T11402: Garbage collect and/or compress/archive harbormaster build unit messages.

(ノಠ益ಠ)ノ彡 sboן ʇsǝʇ ʇıun

Jul 30 2016, 11:15 PM · Restricted Project, Harbormaster, Feature Request
yelirekim added a comment to T11402: Garbage collect and/or compress/archive harbormaster build unit messages.

Yeah, unit messages are stored in a different table.

Jul 30 2016, 11:03 PM · Restricted Project, Harbormaster, Feature Request
chad added a comment to T11402: Garbage collect and/or compress/archive harbormaster build unit messages.

Is this different than T5822?

Jul 30 2016, 11:03 PM · Restricted Project, Harbormaster, Feature Request
yelirekim created T11402: Garbage collect and/or compress/archive harbormaster build unit messages.
Jul 30 2016, 11:01 PM · Restricted Project, Harbormaster, Feature Request
isfs created T11401: Add ability to quote, edit, view raw, view history, and remove inline comments.
Jul 30 2016, 9:44 PM · Inline Comments, Restricted Project, Differential, Feature Request
rabahmeradi added a comment to Q456: Why do phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail, even though the push works?.

You should check if the user has write access to the folder where the repositories are stored. It happened to me (I wasn't using Phabricator). I can clone because I have read to access but can't push because I didn't have write permission.

Jul 30 2016, 5:52 PM
epriestley added a comment to Q456: Why do phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail, even though the push works?.

This is not an expected behavior.

Jul 30 2016, 3:53 PM
chad added a comment to Q456: Why do phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail, even though the push works?.

(I'm not super adept at troubleshooting git, so I can't help much more on this question).

Jul 30 2016, 3:43 PM
chad added a comment to Q456: Why do phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail, even though the push works?.

I don't believe we alter your commands, it should be a direct passthrough.

Jul 30 2016, 3:42 PM
Fordy added a comment to Q456: Why do phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail, even though the push works?.

It is definitely a git error - but if i use git to access the repostory directly on the hosting server (clone it from the actual stored repo path) that works fine, and I can then push ok with no errors, which leads me to think git is working ok.

Jul 30 2016, 3:26 PM
chad added a comment to Q456: Why do phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail, even though the push works?.

This is a git error, isn't it? That is, if you're not using Phabricator to access the repository, the same error occurs?

Jul 30 2016, 3:24 PM
Fordy updated the question details for Q456: Why do phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail, even though the push works?.
Jul 30 2016, 2:55 PM
Fordy updated Q456: Why do phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail, even though the push works? from to Why do phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail, even though the push works?.
Jul 30 2016, 2:53 PM
epriestley updated the task description for T11400: Packages v1 Errata.
Jul 30 2016, 12:47 PM · Restricted Project, Packages
epriestley created T11400: Packages v1 Errata.
Jul 30 2016, 12:47 PM · Restricted Project, Packages
epriestley created Phacility.
Jul 30 2016, 12:45 PM · Phacility
epriestley edited the content of Changelog.
Jul 30 2016, 12:43 PM
epriestley created 2016 Week 31 (Very Late July).
Jul 30 2016, 12:42 PM
epriestley moved T7939: Support Herald rules for Calendar events from Backlog to Next on the Herald board.
Jul 30 2016, 12:28 PM · Herald, Calendar
epriestley merged task T9305: "A task is moved between columns on a workboard." email preference not respected into T10448: Modularize mail tags.
Jul 30 2016, 12:27 PM · Herald
epriestley merged T9305: "A task is moved between columns on a workboard." email preference not respected into T10448: Modularize mail tags.
Jul 30 2016, 12:27 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley added a comment to T9305: "A task is moved between columns on a workboard." email preference not respected.

I'm going to close this in favor of T10448, which discusses fixing "other" tags and generally improving how tags work.

Jul 30 2016, 12:27 PM · Herald
epriestley closed T10966: Let Herald move objects between Spaces as Wontfix.

I think custom forms (today), workboard support for custom forms (likely, in the future), and T8442 are the most promising ways forward here.

Jul 30 2016, 12:24 PM · Herald, Feature Request
epriestley closed T11312: Watch / Subscribe project Herald action needed as Invalid.

It's still not really clear to me what this issue is describing. Here are my best guesses at how to fix various things which might be problems?

Jul 30 2016, 12:17 PM · Herald, Feature Request
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

T7961 is probably worth fixing while I'm in here.

Jul 30 2016, 11:50 AM · Documentation, Herald
epriestley added a subtask for T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess: T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules.
Jul 30 2016, 11:50 AM · Documentation, Herald
epriestley added a parent task for T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules: T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
Jul 30 2016, 11:50 AM · Applications, Herald
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

I'm going to at least fix the instanceof mess before adding a Calendar adapter in T7939.

Jul 30 2016, 11:48 AM · Documentation, Herald
epriestley claimed T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
Jul 30 2016, 11:48 AM · Documentation, Herald
epriestley added a subtask for T7939: Support Herald rules for Calendar events: T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
Jul 30 2016, 11:48 AM · Herald, Calendar
epriestley added a parent task for T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess: T7939: Support Herald rules for Calendar events.
Jul 30 2016, 11:48 AM · Documentation, Herald
epriestley added a comment to T11399: Add support for locations in calendar events.

Calendar is currently prioritized, but the scope is focused on basic functionality (getting it out of the "prototype" stage, roughly described in T11326 with more recent activity in T11326) and API integrations (Google Calendar in T2334, ICS in T10747).

Jul 30 2016, 11:47 AM · Calendar, Feature Request
epriestley claimed T7931: Create Calendar triggers which notify users before meetings.
Jul 30 2016, 11:45 AM · Calendar
epriestley claimed T7939: Support Herald rules for Calendar events.
Jul 30 2016, 11:45 AM · Herald, Calendar
epriestley moved T7931: Create Calendar triggers which notify users before meetings from Future Work (v2+) to Unprototype (v1) on the Calendar board.
Jul 30 2016, 11:43 AM · Calendar
epriestley closed T11397: Overcommit -> arc lint as Wontfix.

I'm just going to close this in favor of T10038. The short answer is: write bindings.

Jul 30 2016, 11:38 AM · Feature Request
epriestley closed T11397: Overcommit -> arc lint, a subtask of T10038: Plan the mid-term pathway for unit-test/linter bindings, as Wontfix.
Jul 30 2016, 11:38 AM · Lint, Arcanist
epriestley moved T11399: Add support for locations in calendar events from Backlog to Future Work (v2+) on the Calendar board.
Jul 30 2016, 11:34 AM · Calendar, Feature Request
epriestley added a comment to T11399: Add support for locations in calendar events.

I expect to do this eventually, but I'm hesitant to just put a freeform "Location" text field on events. If we do, we can't prevent double-booking physical meeting rooms, since users may spell physical space names differently and we can't know for sure that "Meeting 6", "Meeting Room 6", "Meting Rum Six", and "Meeting Room#6" are all the same.

Jul 30 2016, 11:33 AM · Calendar, Feature Request
epriestley added a revision to T11392: Unhandled Exception when opening specific Task while not logged in: Unknown Object (Differential Revision).
Jul 30 2016, 11:24 AM · Bug Report
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 30 2016, 11:24 AM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
eadler added a parent task for T11397: Overcommit -> arc lint: T10038: Plan the mid-term pathway for unit-test/linter bindings.
Jul 30 2016, 8:52 AM · Feature Request
eadler added a subtask for T10038: Plan the mid-term pathway for unit-test/linter bindings: T11397: Overcommit -> arc lint.
Jul 30 2016, 8:52 AM · Lint, Arcanist
• JerrySLau moved T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges from Important to Nice To Have on the FreeBSD board.
Jul 30 2016, 7:14 AM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
helenhousandi updated the task description for T11399: Add support for locations in calendar events.
Jul 30 2016, 4:04 AM · Calendar, Feature Request
helenhousandi created T11399: Add support for locations in calendar events.
Jul 30 2016, 4:00 AM · Calendar, Feature Request
• dunktang removed a revision from T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 30 2016, 3:43 AM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
• dunktang removed a revision from T11392: Unhandled Exception when opening specific Task while not logged in: Unknown Object (Differential Revision).
Jul 30 2016, 3:41 AM · Bug Report
• dunktang added a revision to T11392: Unhandled Exception when opening specific Task while not logged in: Unknown Object (Differential Revision).
Jul 30 2016, 3:41 AM · Bug Report
• dunktang removed a revision from T11392: Unhandled Exception when opening specific Task while not logged in: Unknown Object (Differential Revision).
Jul 30 2016, 3:38 AM · Bug Report
venky added a comment to T11397: Overcommit -> arc lint.

Not claiming it's better (it seems to do a lot of what arc lint does, minus the ability to amend), just that we already have linting set up through it and have custom linters implemented in that framework.

Jul 30 2016, 1:09 AM · Feature Request
chad added a comment to T11398: Bug with Phab.

This isn't a valid bug report. Valid bug reports include reproduction steps, version information, and if there is a log or error message, the exact message generated. We also don't have access to third party installs. We'd be happy to re-open this report once missing information and steps are filled in.

Jul 30 2016, 12:58 AM · Bug Report
chad closed T11398: Bug with Phab as Invalid.
Jul 30 2016, 12:55 AM · Bug Report
tarik created T11398: Bug with Phab.
Jul 30 2016, 12:34 AM · Bug Report

Jul 29 2016

chad added a comment to T11397: Overcommit -> arc lint.

Does overcommit emit patches? I'm reading through the docs, and not clear what the benefit specifically is over arcanist. If it's ease of distribution, we're actively working on that.

Jul 29 2016, 11:58 PM · Feature Request
ysood added a comment to T8075: arc patch fails on Windows with SVN (because it uses "cd", not "setCWD").

@oujesky thanks for the git link. I was able to get the arc patch command working in the meanwhile with these changes.

Jul 29 2016, 11:17 PM · Windows, Arcanist
venky created T11397: Overcommit -> arc lint.
Jul 29 2016, 11:13 PM · Feature Request
epriestley created T11396: Calendar stub events do not respect recurring event end dates.
Jul 29 2016, 5:19 PM · Restricted Project, Calendar
chad added a comment to T4863: Allow Workboard Cards to be customized for display.

How can we make the title and description more clear?

Jul 29 2016, 5:04 PM · Projects, Workboards, Wikimedia
r8j3 added a comment to T4863: Allow Workboard Cards to be customized for display.

Hi Chad,

Jul 29 2016, 4:49 PM · Projects, Workboards, Wikimedia
chad added a comment to T11395: Lost diffusion git repos?.

(We've not heard any similar issues like this, unfortunately).

Jul 29 2016, 4:33 PM
chad added a comment to T11395: Lost diffusion git repos?.

See Support Resources for how to get general community help with Phabricator. Thanks!

Jul 29 2016, 4:25 PM
chad closed T11395: Lost diffusion git repos? as Invalid.

We don't take bug reports without reproduction steps and we don't support older versions of Phabricator.

Jul 29 2016, 4:24 PM
allywilson created T11395: Lost diffusion git repos?.
Jul 29 2016, 4:22 PM
eadler added a project to T11389: Object links merged in plain text email: Bug Report.
Jul 29 2016, 4:17 PM · Remarkup, Bug Report, Mail
eadler edited projects for T11391: Unable to add uri to Diffusion, added: Diffusion, Bug Report (Needs Information); removed Bug Report.
Jul 29 2016, 4:16 PM · Bug Report (Needs Information), Diffusion
chad added a comment to T4863: Allow Workboard Cards to be customized for display.

any customization.

Jul 29 2016, 3:55 PM · Projects, Workboards, Wikimedia
r8j3 added a comment to T4863: Allow Workboard Cards to be customized for display.

Does this ticket request include displaying Status of each Task on the Workboard display?

Jul 29 2016, 3:36 PM · Projects, Workboards, Wikimedia
• Instinct64 awarded T6002: Allow characters to be escaped in Remarkup a Like token.
Jul 29 2016, 3:03 PM · Remarkup
chad merged T11394: Allow multiple Tags OR inherit Parent Project Tag in Subprojects and Milestones into T1562: Build "Facts", an ETL pipeline and charting application.
Jul 29 2016, 2:47 PM · Restricted Project, Wikimedia, Facts
chad merged task T11394: Allow multiple Tags OR inherit Parent Project Tag in Subprojects and Milestones into T1562: Build "Facts", an ETL pipeline and charting application.
Jul 29 2016, 2:47 PM · Maniphest
r8j3 created T11394: Allow multiple Tags OR inherit Parent Project Tag in Subprojects and Milestones.
Jul 29 2016, 2:33 PM · Maniphest
epriestley edited this Badge.
Jul 29 2016, 2:30 PM
epriestley added a comment to T11392: Unhandled Exception when opening specific Task while not logged in.

Thanks for the report, and for including detailed reproduction steps which allowed us to reproduce the issue.

Jul 29 2016, 2:29 PM · Bug Report
epriestley closed T11393: separate the git html diff into a separate component as Wontfix.

See T5447 for information on reusing Phabricator code in third-party applications.

Jul 29 2016, 2:23 PM · Process Improvement
epriestley closed T11392: Unhandled Exception when opening specific Task while not logged in as Resolved by committing Restricted Diffusion Commit.
Jul 29 2016, 2:21 PM · Bug Report
domnulnopcea created T11393: separate the git html diff into a separate component.
Jul 29 2016, 2:04 PM · Process Improvement
epriestley added a revision to T11392: Unhandled Exception when opening specific Task while not logged in: Unknown Object (Differential Revision).
Jul 29 2016, 2:03 PM · Bug Report
r8j3 edited the content of Organizations Using Phabricator.
Jul 29 2016, 1:45 PM
chad added a comment to T11391: Unable to add uri to Diffusion.

It sounds like you're running an out of date version of Phabricator. Please update to the latest version and see if the issue reproduces.

Jul 29 2016, 1:43 PM · Bug Report (Needs Information), Diffusion