Page MenuHomePhabricator
Feed Advanced Search

Mar 20 2017

epriestley added a comment to T12399: Documentation for Conduit Phrequent seems to be missing.

No, it would not.

Mar 20 2017, 1:44 PM · Conduit, Phrequent, Feature Request
saggid awarded T4721: Improve user-facing documentation for Passphrase a Love token.
Mar 20 2017, 1:40 PM · Documentation, Passphrase
OCram updated Q596: How to add Workboard Column in Maniphest: Export To Excel Format from to How to add Workboard Column in Maniphest: Export To Excel Format.
Mar 20 2017, 1:01 PM · Maniphest, Workboards
20after4 added a comment to T9530: Release Server / Workflow app / Future of Releeph .

@avivey: I'm somewhat interested in this if you have any tips for getting it working locally I would like to try it out and see if I can contribute anything towards a finished extension.

Mar 20 2017, 12:32 PM · Restricted Project, Harbormaster
urzds added a comment to T12399: Documentation for Conduit Phrequent seems to be missing.

Thanks for the hint!

Mar 20 2017, 12:20 PM · Conduit, Phrequent, Feature Request
20after4 abandoned D16304: Fall back to parent tasks / subtasks when the task graph is big.
Mar 20 2017, 12:05 PM
saggid updated the task description for T12420: Failed to load resource: net::ERR_CONTENT_LENGTH_MISMATCH.
Mar 20 2017, 12:01 PM · Bug Report
saggid added a comment to T12420: Failed to load resource: net::ERR_CONTENT_LENGTH_MISMATCH.

For example, just try to load few times this file from our webserver.

Mar 20 2017, 11:55 AM · Bug Report
saggid updated the task description for T12420: Failed to load resource: net::ERR_CONTENT_LENGTH_MISMATCH.
Mar 20 2017, 11:51 AM · Bug Report
saggid updated the task description for T12420: Failed to load resource: net::ERR_CONTENT_LENGTH_MISMATCH.
Mar 20 2017, 11:51 AM · Bug Report
saggid created T12420: Failed to load resource: net::ERR_CONTENT_LENGTH_MISMATCH.
Mar 20 2017, 11:47 AM · Bug Report
d.maznekov added a comment to T12335: Ability to lock a task to prevent further edits.

Any resolution/guide how to avoid that obstacle ?

Mar 20 2017, 10:36 AM · Maniphest, Feature Request
d.maznekov added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

Still facing the problem with Locked task in any new task created. Even on new install. It's database/app config. Please guide where to check about that "locked task" flag BEFORE is created object.

Mar 20 2017, 10:35 AM · Bug Report, EditEngine

Mar 19 2017

chad renamed T9785: Add ESLint Linter from Add ESLint Linter to Add ESLint Linter.
Mar 19 2017, 11:06 PM · Lint
chad merged T12419: Sorting doesn't work in Maniphest > Reports into T1562: Build "Facts", an ETL pipeline and charting application.
Mar 19 2017, 11:05 PM · Restricted Project, Wikimedia, Facts
chad merged task T12419: Sorting doesn't work in Maniphest > Reports into T1562: Build "Facts", an ETL pipeline and charting application.
Mar 19 2017, 11:05 PM · Bug Report
swisspol created T12419: Sorting doesn't work in Maniphest > Reports.
Mar 19 2017, 10:52 PM · Bug Report
isfs added a comment to T9785: Add ESLint Linter.

See T10038: Plan the mid-term pathway for unit-test/linter bindings and Community Resources.

Mar 19 2017, 10:49 PM · Lint
• david.lebert.60 added a watcher for Oncall Tool: • david.lebert.60.
Mar 19 2017, 2:39 PM
jasonrumney created T12418: Link to Configuring other editors needs updating.
Mar 19 2017, 2:58 AM · Documentation, Bug Report
epriestley added a comment to T12416: Repository mirroring fails due to new `git ls-remote` usage.

This should now be fixed in HEAD of master. I've also cherry-picked it to stable. Thanks for the report!

Mar 19 2017, 12:55 AM · Diffusion, Bug Report
epriestley closed T12416: Repository mirroring fails due to new `git ls-remote` usage as Resolved by committing Restricted Diffusion Commit.
Mar 19 2017, 12:54 AM · Diffusion, Bug Report
epriestley added a revision to T12416: Repository mirroring fails due to new `git ls-remote` usage: Unknown Object (Differential Revision).
Mar 19 2017, 12:32 AM · Diffusion, Bug Report
epriestley added a comment to T12416: Repository mirroring fails due to new `git ls-remote` usage.

I think this commit in the Git upstream is probably the culprit (January 2016):

Mar 19 2017, 12:28 AM · Diffusion, Bug Report
eliaspro added a comment to T12416: Repository mirroring fails due to new `git ls-remote` usage.

Just tried that too, and strangely: it does.

Mar 19 2017, 12:24 AM · Diffusion, Bug Report
epriestley added a comment to T12416: Repository mirroring fails due to new `git ls-remote` usage.

Does it work without the --?

Mar 19 2017, 12:21 AM · Diffusion, Bug Report
eliaspro added a comment to T12416: Repository mirroring fails due to new `git ls-remote` usage.

I can't immediately reproduce this, although the systems I have immediate access to are all running Git 2.11.0.

Does this command work on your system?

$ git ls-remote -- https://github.com/phacility/libphutil.git
Mar 19 2017, 12:20 AM · Diffusion, Bug Report
epriestley added a comment to T12416: Repository mirroring fails due to new `git ls-remote` usage.

I can't immediately reproduce this, although the systems I have immediate access to are all running Git 2.11.0.

Mar 19 2017, 12:14 AM · Diffusion, Bug Report
epriestley closed T12417: Show failing status of Diffusion repositories in top main menu bar. as Wontfix.
Mar 19 2017, 12:07 AM · Diffusion, PHUI, Feature Request

Mar 18 2017

eliaspro added a project to T12416: Repository mirroring fails due to new `git ls-remote` usage: Diffusion.
Mar 18 2017, 11:12 PM · Diffusion, Bug Report
eliaspro created T12417: Show failing status of Diffusion repositories in top main menu bar..
Mar 18 2017, 11:09 PM · Diffusion, PHUI, Feature Request
eliaspro created T12416: Repository mirroring fails due to new `git ls-remote` usage.
Mar 18 2017, 10:34 PM · Diffusion, Bug Report
enckse edited the content of Community Resources.
Mar 18 2017, 9:47 PM
NameFILIP awarded T10038: Plan the mid-term pathway for unit-test/linter bindings a Love token.
Mar 18 2017, 8:40 PM · Lint, Arcanist
NameFILIP added a comment to T9785: Add ESLint Linter.

Found these related diffs:
https://secure.phabricator.com/D13557
https://secure.phabricator.com/D12198
https://secure.phabricator.com/D15124

Mar 18 2017, 8:38 PM · Lint
NameFILIP added a comment to T9785: Add ESLint Linter.

ESLinter it the best linter in the JavaScript world. Are there any plans on adding support for it in the near future?

Mar 18 2017, 8:36 PM · Lint
NameFILIP awarded T9785: Add ESLint Linter a Love token.
Mar 18 2017, 8:35 PM · Lint
swisspol created T12415: Comment field action in batch action doesn't render correctly.
Mar 18 2017, 7:17 PM · Bug Report
epriestley closed T12355: Daemons are having a rough time starting on `admin` as Resolved.

The setsid() appears to have resolved the issue, in the sense that daemons are now starting cleanly every time without receiving any inexplicable signals.

Mar 18 2017, 12:35 PM · Phacility, Daemons, Ops
epriestley added a comment to T12355: Daemons are having a rough time starting on `admin`.

The MySQL stuff seems to be in the old daemons (them trying to do logging while MySQL restarts), not the new daemons, and not the cause of the issue.

Mar 18 2017, 12:23 PM · Phacility, Daemons, Ops
hach-que added a comment to T7789: Support Git Large File Storage.

So our only option is to convert all our LFS objects into normal Git objects, increasing both our download times, and increasing your storage and bandwidth costs? Like our Git LFS objects for the entire repository total around 800MB, and without Git LFS, our build server will have to download that from Phacility every single time it does a build.

Mar 18 2017, 5:04 AM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T7789: Support Git Large File Storage.

We have no plans to move this forward or enable it in the Phacility cluster in the near future.

Mar 18 2017, 4:56 AM · Customer Impact, Restricted Project, Files, Diffusion
hach-que added a comment to T7789: Support Git Large File Storage.

Is this going to be enabled in Phacility soon? We just realised that Phacility doesn't appear to have it on, and this is a major blocker for us moving from our own instance to Phacility:

Mar 18 2017, 4:52 AM · Customer Impact, Restricted Project, Files, Diffusion
chad added a comment to T12217: Reduce the hardware cost of Phacility free instances.

Even with a very conservative policy, we're going to drop 80% of the instances it sounds like.

Mar 18 2017, 4:33 AM · Ops, Phacility
chad added a comment to T12217: Reduce the hardware cost of Phacility free instances.

Well, I think it's reasonable to possibly not log in for a while like I keep dormant projects on GH. I don't want them to disappear, but I prefer to keep them in the cloud.

Mar 18 2017, 4:32 AM · Ops, Phacility
epriestley added a comment to T12217: Reduce the hardware cost of Phacility free instances.

We can also do other stuff like "never archive an instance with 2+ users", "after an instance emails us to unsuspend, have a flag to mark it as exempt from cleanup in the future", "don't destroy data for 365 days, instead of 90, if an instance had hosted repositories", or other sorts of things like that, but I suspect measures like that will be largely unnecessary for years to come and that "no one loaded a page for 45 days" is already a nearly perfect signal for "no one cares about this instance".

Mar 18 2017, 4:30 AM · Ops, Phacility
chad added a comment to T12217: Reduce the hardware cost of Phacility free instances.

I'd say 180 day destruction window, and mostly that's just for us to feel good about deleting stuff.

Mar 18 2017, 4:29 AM · Ops, Phacility
chad added a comment to T12217: Reduce the hardware cost of Phacility free instances.

Fair points.

Mar 18 2017, 4:27 AM · Ops, Phacility
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

Continuing from above, I queried a subset of instances for session counts to help us understand usage patterns for free instances (see T12217):

Mar 18 2017, 4:27 AM · Phacility
epriestley added a comment to T12217: Reduce the hardware cost of Phacility free instances.

Picking a random shard, 80% of the active instances have zero sessions in the last 30 days -- so no user has loaded a single page in at least a month. Most (maybe all?) of these have only one account. These include (anonymized) free instances like "alsdknfasf", "test2", "test2017", "testinstance9", "testforme", "mytest", "myinstance", "bbbbbbb", "ddeemmoo". Of the 20% of active instances which do have activity in the last 30 days, many are recently-launched free instances with only one user session, and I'd guess many of those users are never coming back and these instances will join the boneyard shortly.

Mar 18 2017, 4:25 AM · Ops, Phacility
epriestley added a comment to T12217: Reduce the hardware cost of Phacility free instances.

My thinking is that v1 would work like this:

Mar 18 2017, 4:09 AM · Ops, Phacility
chad added a comment to T12217: Reduce the hardware cost of Phacility free instances.

I suppose we could get pretty far changing the language from "Disabled" to "Inactive". That is, send a warning after n days, then after 3 warnings, set it to "Inactive" but have a means they can contact us or click a button to re-activate it?

Mar 18 2017, 3:27 AM · Ops, Phacility
chad added a comment to T12217: Reduce the hardware cost of Phacility free instances.

So I've read this a few times and I'm still a little unclear what happens if "activity requirement" isn't met. It sounds like we'll just disable them like we do non-paying instances - which I don't think users expect and feels like a crumby experience. Would it just be possible to "hibernate/sleep" the instance (no daemons run, user has to wait and spin them up to log back in if 90 days later they get back to using the instance)?

Mar 18 2017, 1:49 AM · Ops, Phacility
epriestley edited the content of Changelog.
Mar 18 2017, 12:22 AM
epriestley created 2017 Week 11 (Late March).
Mar 18 2017, 12:21 AM

Mar 17 2017

epriestley added a comment to T12392: Instance reporting that synchronizeWorkingCopyBeforeRead() effectively fails.

I'm going to put D17497 + D17498 into this release even though they don't directly tackle the issue here and I think they're slightly risky changes (mostly because git ls-remote may have odd behaviors in some cases, and we don't currently use it in other workflows). But they may help with T12296 and general cluster load issues, and the followup changes will generally be more complicated to reason about (more locking/concurrency stuff), so I think getting these in earlier spreads risk out somewhat even though they're something to watch out for in this release.

Mar 17 2017, 11:42 PM · Bug Report, Clusters, Diffusion
chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

I imagine Facts will have similar workflows. The easier we can make it, the less worried I am about re-using panels.

Mar 17 2017, 10:04 PM · Dashboards
epriestley added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

Yep, that's what I'm thinking too.

Mar 17 2017, 10:04 PM · Dashboards
epriestley added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

Yeah, and the sane version (add to dashboard, not to tab panel) is probably not too awful and won't really make fixing T8033 any harder.

Mar 17 2017, 10:04 PM · Dashboards
chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

I want it to work like like installing to home does basically, see query, click add, confirm, get take to arrange with the panel built and added.

Mar 17 2017, 10:04 PM · Dashboards
chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

Yeah maybe I should optimize that workflow first, seems higher leveredged. T5307

Mar 17 2017, 10:03 PM · Dashboards
epriestley added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

Getting rid of all "Select Existing Panel" flows also makes simplifying the "Run a query -> turn it into a panel -> put it on a dashboard" workflow a bit more of a mess, especially if we want to try to do "run a query -> turn it into a panel -> add it to a tab panel". But I think in the long term making the T8033 problem impossible and then trying to do our best with the "query -> panel -> dashboard" flow is the best bet.

Mar 17 2017, 10:00 PM · Dashboards
chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

frickin' tab panels make everything 10x harder.

Mar 17 2017, 9:53 PM · Dashboards
epriestley added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

As long as you're selecting existing panels in any interface, we're stuck with the problem in T8033. I think we can only fix that elegantly by removing all interfaces where you select panels, and replacing them with interfaces where you create panels.

Mar 17 2017, 9:52 PM · Dashboards
chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

Or maybe icons... everyone loves icons.

Mar 17 2017, 9:49 PM · Dashboards
chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

If I add "short name" as an optional Panel field, I could get rid of naming tabs. Then you just have to select a bunch of panels.

Mar 17 2017, 9:48 PM · Dashboards
epriestley added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

The change I imagined there was:

Mar 17 2017, 9:44 PM · Dashboards
epriestley added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

If we make the permission changes discussed elsewhere (T8033, I think?), this might just become something like a containerPHID which points at a Dashboard for panels created from dashboards, another Panel for panels embedded in panels, and null for standalone panels.

Mar 17 2017, 9:41 PM · Dashboards
chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

Oh I see above you mention using edges too.

Mar 17 2017, 7:47 PM · Dashboards
chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

I don't think there is much value here in having "appears on", since panels work on dashboards, other panels, or any remarkup, anywhere. Does anyone have a good reason to keep this function? I could create an edge for panel -> panel if we want to keep something like this. But I'm concerned if the point is to "prune" panels, then we'd need to maybe build out mentions as well.

Mar 17 2017, 7:46 PM · Dashboards
remusvrm updated Q595: Is it possible to get all the tasks which I am not assigned? from to Is it possible to get all the tasks which I am not assigned?.
Mar 17 2017, 5:16 PM · Maniphest
chad added a comment to Q594: Support PHP namespaces.

So, we prefer to not use externals, because that makes rebasing difficult.

Mar 17 2017, 4:53 PM
avivey updated the question details for Q594: Support PHP namespaces.
Mar 17 2017, 4:45 PM
epriestley added a project to T12414: Implement Almanac edit endpoints in Conduit: Conduit.
Mar 17 2017, 2:46 PM · Conduit, Almanac, Ops, Phacility
epriestley created T12414: Implement Almanac edit endpoints in Conduit.
Mar 17 2017, 2:46 PM · Conduit, Almanac, Ops, Phacility
epriestley edited the content of Phacility Cluster Devices.
Mar 17 2017, 12:41 PM
epriestley closed T12401: Ability to run build rules for open revisions on a Herald Rule as Invalid.

We don't plan to support this. Large installs often have hundreds or thousands of open revisions, so "build all open revisions" would trigger hundreds or thousands of builds for every push.

Mar 17 2017, 12:28 PM · Feature Request
tamal updated the question details for Q594: Support PHP namespaces.
Mar 17 2017, 7:09 AM
tamal updated Q594: Support PHP namespaces from to Support PHP namespaces.
Mar 17 2017, 7:06 AM
chad added a comment to T12411: Support PHP namespaces.

Stripe's library is in externals and is not run under arc liberate.

Mar 17 2017, 5:38 AM · Feature Request
chad added a comment to T12411: Support PHP namespaces.

You can use Conpherence or Ponder if you have questions about developing on Phabricator.

Mar 17 2017, 5:25 AM · Feature Request
tamal added a comment to T12411: Support PHP namespaces.

We are using Braintree for our payments. This is the error I get when trying to run arc liberate on Braintree SDK:

Mar 17 2017, 5:07 AM · Feature Request
epriestley awarded T12412: PhutilDaemonOverseer's pidfile updates break `phd status`'s dead-daemon detection a Mountain of Wealth token.
Mar 17 2017, 3:01 AM · Restricted Project, Bug Report
epriestley added a comment to T12412: PhutilDaemonOverseer's pidfile updates break `phd status`'s dead-daemon detection.

Thanks! This code has been churning recently (T12298 / T12217) and I likely broke this in D17389. I think I observed this behavior, but this report should save me a great deal of time hunting the bug down.

Mar 17 2017, 3:01 AM · Restricted Project, Bug Report
epriestley closed T12411: Support PHP namespaces as Invalid.

You can already use third-party externals that use namespaces, and we already bundle some (Twilio, Balanced until it was removed in D12074).

Mar 17 2017, 2:59 AM · Feature Request
chad added a comment to T12411: Support PHP namespaces.

Specifically, we don't provide support for custom libraries or writing your own Phabricator applications, this is "at your own risk". I don't know what you're using Braintree for (Phortune?) or what problem using it solves for you. I think questions about Phabricator development are better suited for Ponder/Conpherence to get started. Plenty of other admins with experience there.

Mar 17 2017, 1:34 AM · Feature Request
chad added a comment to T12411: Support PHP namespaces.

What problem or issue are you currently having with Phabricator that you expect this feature to solve. Please see Contributing Feature Requests and Describing Root Problems for what information we require from feature requests.

Mar 17 2017, 1:21 AM · Feature Request
jboning added a project to T12412: PhutilDaemonOverseer's pidfile updates break `phd status`'s dead-daemon detection: Restricted Project.
Mar 17 2017, 1:02 AM · Restricted Project, Bug Report
jboning created T12412: PhutilDaemonOverseer's pidfile updates break `phd status`'s dead-daemon detection.
Mar 17 2017, 12:43 AM · Restricted Project, Bug Report
tamal created T12411: Support PHP namespaces.
Mar 17 2017, 12:31 AM · Feature Request

Mar 16 2017

caov297 updated the question details for Q593: Cluster: if you update an AWS instance to use elastic IP, do I have to update anything else other than the almanac device?.
Mar 16 2017, 10:23 PM
caov297 updated Q593: Cluster: if you update an AWS instance to use elastic IP, do I have to update anything else other than the almanac device? from to Cluster: if you update an AWS instance to use elastic IP, do I have to update anything else other than the almanac device?.
Mar 16 2017, 10:22 PM
jaufrecht updated the task description for T12410: Cycle Time and Lead Time Reports.
Mar 16 2017, 9:23 PM · Feature Request
jaufrecht created T12410: Cycle Time and Lead Time Reports.
Mar 16 2017, 9:22 PM · Feature Request
epriestley closed T12406: Importing commits which name themselves as the auditor can cause stuck tasks as Resolved by committing Restricted Diffusion Commit.
Mar 16 2017, 8:57 PM · Bug Report
epriestley added a comment to T12408: Security: "Show Raw File" in Differential generated files with overbroad permissions.

(You could also pipe the list into bin/remove destroy --force, equivalently.)

Mar 16 2017, 8:22 PM · Differential, Files, Security
epriestley added a comment to T12408: Security: "Show Raw File" in Differential generated files with overbroad permissions.

You can re-run the migration explicitly with:

Mar 16 2017, 8:22 PM · Differential, Files, Security
cspeckmim added a comment to T12408: Security: "Show Raw File" in Differential generated files with overbroad permissions.

We ran the script provided above to get an audit of at-risk files. Afterwards we upgraded our instance and the upgrade succeeded however its attempts to delete the affected files failed. The failure is due to using a local file store which is accessible to our web service account but not the phabricator phd services account (T4752). After correcting the file permissions so both accounts have appropriate access, running upgrade again doesn't seem to remove the files.

Mar 16 2017, 8:11 PM · Differential, Files, Security
gd added a comment to T12409: `./bin/config set --database` does not handle deleted keys.

Thank you! This fixed the issue.

Mar 16 2017, 7:30 PM · Bug Report
epriestley closed T12409: `./bin/config set --database` does not handle deleted keys as Resolved by committing Restricted Diffusion Commit.
Mar 16 2017, 7:26 PM · Bug Report