Page MenuHomePhabricator

PhutilDaemonOverseer's pidfile updates break `phd status`'s dead-daemon detection
Closed, DuplicatePublic

Assigned To
Authored By
Mar 17 2017, 12:43 AM
Referenced Files
"Mountain of Wealth" token, awarded by epriestley.


phd status contains logic to notice when a local daemon isn't running, and mark that fact in the database. To do this, it reads daemon pids from pidfiles and checks to see whether the processes are still running.

After a daemon dies, PhutilDaemonOverseer immediately writes out an updated pidfile with only pids from still-running daemons, so phd status never finds the pid of the dead daemon.

Event Timeline

jboning added a project: Restricted Project.Mar 17 2017, 1:02 AM

Thanks! This code has been churning recently (T12298 / T12217) and I likely broke this in D17389. I think I observed this behavior, but this report should save me a great deal of time hunting the bug down.

Actually, this is a little different from what I've been seeing locally. I'm just going to merge this into T11037, which discusses some general improvements to phd status output.