Paths

Table of Contentst

Differential D15124

Add linter to support eslint
AbandonedPublic
Actions

Authored by vm on Jan 28 2016, 12:16 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

Added linter support for eslint http://eslint.org/

Test Plan

Added test cases

Diff Detail

Branch

eslint

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10354
Build 12625: arc lint + arc unit

Event Timeline

vm updated this revision to Diff 36514.Jan 28 2016, 12:16 AM

vm retitled this revision from to Add linter to support eslint.

vm updated this object.

vm edited the test plan for this revision. (Show Details)

vm added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 28 2016, 12:16 AM

Herald added a subscriber: Korvin. · View Herald Transcript

See D12198, T9785, and T10038.

In D15124#173386, @avivey wrote:

See D12198, T9785, and T10038.

Clearly I should have used the search functionality before writing this ...
Might leave this here anyway since this implementation uses JSON output instead of relying on regexes to match linter output.

I presume that relying on script-and-regex is the only answer until T10038 is addressed?

ogonkov mentioned this in D12198: Added ESLint Support.Jul 7 2016, 11:00 AM

stevex added a subscriber: stevex.Sep 20 2016, 8:06 AM

vm abandoned this revision.Jun 7 2022, 9:42 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

lint/

linter/

ArcanistESLintLinter.php

149 lines

__tests__/

.eslintrc

3 lines

ArcanistESLintLinterTestCase.php

18 lines

eslint/

eslint.lint-test

11 lines

expected-conditional.lint-test

7 lines

missing-semicolon.lint-test

4 lines

parse-failure.lint-test

4 lines

unnecessary-semicolon.lint-test

6 lines

Diff 36514

View Options

src/__phutil_library_map__.php

View Options

src/lint/linter/ArcanistESLintLinter.php

View Options

src/lint/linter/tests/.eslintrc

View Options

src/lint/linter/tests/ArcanistESLintLinterTestCase.php

View Options

src/lint/linter/tests/eslint/eslint.lint-test

View Options

src/lint/linter/tests/eslint/expected-conditional.lint-test

View Options

src/lint/linter/tests/eslint/missing-semicolon.lint-test

View Options

src/lint/linter/tests/eslint/parse-failure.lint-test

View Options

src/lint/linter/tests/eslint/unnecessary-semicolon.lint-test

Add linter to support eslintAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36514

src/__phutil_library_map__.php

src/lint/linter/ArcanistESLintLinter.php

src/lint/linter/__tests__/.eslintrc

src/lint/linter/__tests__/ArcanistESLintLinterTestCase.php

src/lint/linter/__tests__/eslint/eslint.lint-test

src/lint/linter/__tests__/eslint/expected-conditional.lint-test

src/lint/linter/__tests__/eslint/missing-semicolon.lint-test

src/lint/linter/__tests__/eslint/parse-failure.lint-test

src/lint/linter/__tests__/eslint/unnecessary-semicolon.lint-test

Add linter to support eslint
AbandonedPublic
Actions

Revision Contents
Changeset List

src/lint/linter/tests/.eslintrc

src/lint/linter/tests/ArcanistESLintLinterTestCase.php

src/lint/linter/tests/eslint/eslint.lint-test

src/lint/linter/tests/eslint/expected-conditional.lint-test

src/lint/linter/tests/eslint/missing-semicolon.lint-test

src/lint/linter/tests/eslint/parse-failure.lint-test

src/lint/linter/tests/eslint/unnecessary-semicolon.lint-test