Page MenuHomePhabricator

Add linter to support eslint
Needs ReviewPublic

Authored by vm on Jan 28 2016, 12:16 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Added linter support for eslint http://eslint.org/

Test Plan

Added test cases

Diff Detail

Branch
eslint
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 10354
Build 12625: arc lint + arc unit

Event Timeline

vm updated this revision to Diff 36514.Jan 28 2016, 12:16 AM
vm retitled this revision from to Add linter to support eslint.
vm updated this object.
vm edited the test plan for this revision. (Show Details)
vm added a reviewer: epriestley.
vm added a comment.Jan 28 2016, 1:09 AM

See D12198, T9785, and T10038.

Clearly I should have used the search functionality before writing this ...
Might leave this here anyway since this implementation uses JSON output instead of relying on regexes to match linter output.

I presume that relying on script-and-regex is the only answer until T10038 is addressed?

stevex added a subscriber: stevex.Sep 20 2016, 8:06 AM