Page MenuHomePhabricator
Feed Advanced Search

Jun 17 2016

epriestley closed T10694: Improve behavior of context for inline comments in mail as Resolved.

This appears to be resolved and accounted for. There's one followup in T11120 (8bit vs base64 mail encoding) which also might be fixed now. If anyone runs into issues, let us know.

Jun 17 2016, 2:01 AM · Prioritized, Restricted Project, Differential, Mail
epriestley closed T6916: Allow video embed in remarkup as Resolved.

I believe this is now resolved and accounted for. See the remarkup documentation for some details.

Jun 17 2016, 1:57 AM · Prioritized, Remarkup
epriestley added a revision to T6916: Allow video embed in remarkup: Unknown Object (Differential Revision).
Jun 17 2016, 1:48 AM · Prioritized, Remarkup
epriestley closed T5187: Make "Upload File" dialog have a vanilla file upload control as Resolved.

I believe this is resolved and accounted for, let us know if anyone is hitting issues.

Jun 17 2016, 1:47 AM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley closed T5187: Make "Upload File" dialog have a vanilla file upload control, a subtask of T6523: Allow creating/adding images to mocks with a vanilla upload control, as Resolved.
Jun 17 2016, 1:47 AM · Prioritized, Pholio, Wikimedia
epriestley closed T6523: Allow creating/adding images to mocks with a vanilla upload control as Resolved.

I believe this is now fixed and all the business stuff is wrapped up on our side. If anyone runs into issues, feel free to file a followup describing what you're hitting.

Jun 17 2016, 1:46 AM · Prioritized, Pholio, Wikimedia
epriestley added a comment to T11166: When an install has no footer, Maniphest task previews have no bottom margin.

Sorry, my screenshot was garbage since all the text to the right was INCREDIBLY CONFIDENTIAL SECRETS.

Jun 17 2016, 1:43 AM · PHUI
chad added a comment to T11166: When an install has no footer, Maniphest task previews have no bottom margin.

Oh, on task view, I was looking the edit page.

Jun 17 2016, 1:42 AM · PHUI
chad moved T11167: Unbeta Feedback on Badges from v1 to v0 on the Badges board.
Jun 17 2016, 1:41 AM · Restricted Project, Badges (v0)
chad created T11167: Unbeta Feedback on Badges.
Jun 17 2016, 1:41 AM · Restricted Project, Badges (v0)
chad added a comment to T11164: Badges: Unwanted entry at the history.

Isn't Badges a Prototype?

Jun 17 2016, 1:34 AM · Badges, Bug Report
chad added a comment to T11166: When an install has no footer, Maniphest task previews have no bottom margin.

Yeah doesn't repro in Chrome.

Jun 17 2016, 1:33 AM · PHUI
epriestley created T11166: When an install has no footer, Maniphest task previews have no bottom margin.
Jun 17 2016, 12:31 AM · PHUI
Luke081515.2 created T11165: Changing a callsign throws a 404.
Jun 17 2016, 12:19 AM · Diffusion (v3), Bug Report
Luke081515.2 created T11164: Badges: Unwanted entry at the history.
Jun 17 2016, 12:04 AM · Badges, Bug Report

Jun 16 2016

carlos.prado.vsys edited the content of Organizations Using Phabricator.
Jun 16 2016, 11:39 PM
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

FWIW, examining every ref like that is a complete no-go for our situation

Jun 16 2016, 11:29 PM · Restricted Project, Prioritized, Audit, Restricted Project
joshuaspence added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

OK, so I just manually removed the branch from info/refs and packed-refs and I think that maybe that worked?

Jun 16 2016, 11:03 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

I think D16136 will "fix" the problem and I can't come up with any problems it creates, although it would be nice to figure out where the mystery ref is coming from.

Jun 16 2016, 11:02 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a revision to T9028: Phabricator handles commits which are published and later deleted poorly: Unknown Object (Differential Revision).
Jun 16 2016, 11:01 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

okay so basically ghosts?

Jun 16 2016, 11:00 PM · Restricted Project, Prioritized, Audit, Restricted Project
joshuaspence added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

Ah interesting. From our GitLab host, I see that git branch --all shows a whole bunch of local branches and only a single branch of the form remotes/origin/url_shortener.

Jun 16 2016, 10:58 PM · Restricted Project, Prioritized, Audit, Restricted Project
joshuaspence added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

Ah interesting. From our GitLab host, I see that git branch --all shows a whole bunch of local branches and only a single branch of the form remotes/origin/url_shortener.

Jun 16 2016, 10:54 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

I think checking if git ls-remote origin in the working copy lists a refs/remotes/origin/XYZ ref in the authoritative remote is the easiest way to check, although I'm not 100% sure that refs/remotes/ isn't magic with respect to ls-remote.

Jun 16 2016, 10:53 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

I wonder if the actual authoritative repository has a refs/remotes/origin/XYZ ref which we're mirroring?

Jun 16 2016, 10:50 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

We fetch bare working copies with git fetch origin +refs/*:refs/* --prune.

Jun 16 2016, 10:45 PM · Restricted Project, Prioritized, Audit, Restricted Project
joshuaspence added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

Hrrm -- is the repository a non-bare working copy (e.g., has files and folders in it instead of just config/, hooks/, info/, etc)?

Jun 16 2016, 10:44 PM · Restricted Project, Prioritized, Audit, Restricted Project
scode added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

Is there a lack of a git remote prune origin or similar?

Jun 16 2016, 10:43 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

Hrrm -- is the repository a non-bare working copy (e.g., has files and folders in it instead of just config/, hooks/, info/, etc)?

Jun 16 2016, 10:43 PM · Restricted Project, Prioritized, Audit, Restricted Project
joshuaspence added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

OK, running ./bin/repository discover --verbose rX gives me a bunch of output including this:

Jun 16 2016, 10:40 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

We have Diffusion configured to track only the master branch, but now Diffusion is importing commits from all branches, it seems.

Jun 16 2016, 10:31 PM · Restricted Project, Prioritized, Audit, Restricted Project
joshuaspence added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

Updated our Phabricator install just now. One issue I discovered is that we are having a bunch of audits triggered for commits that are newly discovered. We have Diffusion configured to track only the master branch, but now Diffusion is importing commits from all branches, it seems.

Jun 16 2016, 10:28 PM · Restricted Project, Prioritized, Audit, Restricted Project
shpytyack.artem updated the task description for T11163: Speed up wiki documents creation.
Jun 16 2016, 10:26 PM · Phriction, Feature Request
shpytyack.artem created T11163: Speed up wiki documents creation.
Jun 16 2016, 10:24 PM · Phriction, Feature Request
• medemi68 created T11162: Unable to Edit Projects as Administrator, Showing Restricted.
Jun 16 2016, 10:10 PM · Projects, Bug Report (Needs Information)
thoughtpolice added a comment to Q426: How can I trigger a harbormaster build when a differential review is accepted and ready to land (Answer 398).

I updated my original answer (since I can't post a new one; I meant to add it as a comment on your original Q) with instructions on how to write the Herald rule you need, so you can accept that answer as "the accepted answer" for this Ponder.

Jun 16 2016, 8:26 PM
thoughtpolice updated the answer details for Q426: How can I trigger a harbormaster build when a differential review is accepted and ready to land (Answer 397).
Jun 16 2016, 8:25 PM
avivey renamed T11152: Some workflows of arc are broken on Windows from EXCEPTION: The current working directory is not part of a working copy for a supported version control system to Some workflows of arc are broken on Windows.
Jun 16 2016, 8:20 PM · Arcanist, Windows, Bug Report
avivey added a comment to T11152: Some workflows of arc are broken on Windows.

We're basically having lots of problems with Windows; There are a few reports about arc version just not working on Windows (I'm a little surprised @hach-que doesn't run into this; Can you maybe do a quick phriction page about your Windows setup, as in "this setup works, do this"?).

Jun 16 2016, 8:17 PM · Arcanist, Windows, Bug Report
scode added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

Yeah. I just wanted to make sure whether mark-reachable was safe to run without fear of accidentally marking something unreachable that isn't (i.e., if the command were to imply "mark everything in the import queue as unreachable no matter what"). Sorry it was probably a bit of a lazy question since a more careful re-reading of the rest of the ticket would probably have answered it for me.

Jun 16 2016, 8:11 PM · Restricted Project, Prioritized, Audit, Restricted Project
avivey added Q426: How can I trigger a harbormaster build when a differential review is accepted and ready to land (Answer 399).
Jun 16 2016, 8:09 PM
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

It basically runs git log --all, then checks every commit in the database against that list and marks the missing ones as unreachable.

Jun 16 2016, 7:44 PM · Restricted Project, Prioritized, Audit, Restricted Project
jsturgeon added Q426: How can I trigger a harbormaster build when a differential review is accepted and ready to land (Answer 398).
Jun 16 2016, 7:41 PM
scode added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

If the mark-reachable command is used, is it subject to races in the sense that in-flight legit newly importing commits may be marked unreachable, or does it just trigger the process of going back and re-evaluating true reachability of all commits?

Jun 16 2016, 7:35 PM · Restricted Project, Prioritized, Audit, Restricted Project
thoughtpolice added Q426: How can I trigger a harbormaster build when a differential review is accepted and ready to land (Answer 397).
Jun 16 2016, 7:33 PM
jsturgeon updated Q426: How can I trigger a harbormaster build when a differential review is accepted and ready to land from to How can I trigger a harbormaster build when a differential review is accepted and ready to land.
Jun 16 2016, 7:17 PM
• rmaspoch updated Q425: Any way to select the "correct answer" from to Any way to select the "correct answer".
Jun 16 2016, 7:09 PM · Ponder Moderators, Ponder
epriestley added a revision to T9028: Phabricator handles commits which are published and later deleted poorly: Unknown Object (Differential Revision).
Jun 16 2016, 6:52 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley moved T9028: Phabricator handles commits which are published and later deleted poorly from The Queue to Paused on the Prioritized board.

I've pushed this here, and enabled dangerous changes on rGITTEST if anyone wants to try anything.

Jun 16 2016, 6:49 PM · Restricted Project, Prioritized, Audit, Restricted Project
chad added a comment to T11160: View Wiki Docs that only pertain to a certain group.

Your best workaround for now is multiple text panels for each organization.

Jun 16 2016, 6:41 PM · Dashboards, Phriction, Bug Report
chad added a comment to T11160: View Wiki Docs that only pertain to a certain group.

T11161 is the follow up for Dashboards

Jun 16 2016, 6:40 PM · Dashboards, Phriction, Bug Report
chad created T11161: Panel creation can be confusing.
Jun 16 2016, 6:36 PM · Design, Dashboards (v2)
epriestley added a project to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI: Prioritized.
Jun 16 2016, 6:32 PM · Prioritized, Restricted Project, Arcanist, Bug Report
chad added a comment to T11160: View Wiki Docs that only pertain to a certain group.

I'll create a separate task to re-think Panel creation UI.

Jun 16 2016, 6:31 PM · Dashboards, Phriction, Bug Report
chad merged T11160: View Wiki Docs that only pertain to a certain group into T9622: Allow Phriction pages to have Project tags.
Jun 16 2016, 6:31 PM · Projects, Phriction, Restricted Project
chad merged task T11160: View Wiki Docs that only pertain to a certain group into T9622: Allow Phriction pages to have Project tags.
Jun 16 2016, 6:31 PM · Dashboards, Phriction, Bug Report
eadler moved T10967: Move Differential reviewers back to a dedicated database storage table from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 16 2016, 6:28 PM · Restricted Project, Infrastructure, Differential
eadler moved T11145: Dialog submit buttons don't disable on click from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 16 2016, 6:28 PM · Restricted Project, PHUI, Bug Report
eadler moved T11150: ArcanistTextLinter: Support UTF8 from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 16 2016, 6:28 PM · Restricted Project, Lint, Feature Request
eadler moved T11153: Provide better tools for preventing deadlocks in build plans which acquire multiple resources from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 16 2016, 6:28 PM · Restricted Project, Drydock, Harbormaster, Feature Request
eadler moved T11154: Build results don't always get conferred to their buildable from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 16 2016, 6:28 PM · Restricted Project, Harbormaster, Bug Report
eadler moved T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 16 2016, 6:28 PM · Prioritized, Restricted Project, Arcanist, Bug Report
eadler moved T3875: Allow arc to perform cascading rebases, maybe during or after `arc land` from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 16 2016, 6:28 PM · Prioritized, Restricted Project, Arcanist
chad added a comment to T11160: View Wiki Docs that only pertain to a certain group.

You're not creating a custom query, at least in that screenshot. The query is "All Documents", which is what you're getting.

Jun 16 2016, 6:27 PM · Dashboards, Phriction, Bug Report
eadler added a project to T11154: Build results don't always get conferred to their buildable: Restricted Project.
Jun 16 2016, 6:26 PM · Restricted Project, Harbormaster, Bug Report
eadler added a project to T11153: Provide better tools for preventing deadlocks in build plans which acquire multiple resources: Restricted Project.
Jun 16 2016, 6:26 PM · Restricted Project, Drydock, Harbormaster, Feature Request
eadler added a project to T11145: Dialog submit buttons don't disable on click: Restricted Project.
Jun 16 2016, 6:26 PM · Restricted Project, PHUI, Bug Report
eadler added a project to T11150: ArcanistTextLinter: Support UTF8: Restricted Project.
Jun 16 2016, 6:26 PM · Restricted Project, Lint, Feature Request
epriestley added a comment to T6878: Tagged commits which are not ancestors of any branch head don't get imported.

I think this is resolved, but see T9028 for related followups.

Jun 16 2016, 6:22 PM · Wikimedia, Restricted Project, Diffusion
epriestley closed T6878: Tagged commits which are not ancestors of any branch head don't get imported as Resolved by committing Restricted Diffusion Commit.
Jun 16 2016, 6:20 PM · Wikimedia, Restricted Project, Diffusion
epriestley closed T6878: Tagged commits which are not ancestors of any branch head don't get imported, a subtask of T9028: Phabricator handles commits which are published and later deleted poorly, as Resolved.
Jun 16 2016, 6:20 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

I'm vaguely suspicious that I may have missed some weird stuff here since this pipeline is complicated, but I'm going to land this stuff now and just plan to hold the release a bit if it feels shaky tomorrow.

Jun 16 2016, 6:19 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a comment to T7047: Add user preference for diffs in emails.

Can anyone interested in this explain the use case for making it per-Herald or per-user instead of global? Are half your users bitterly opposed to inline diffs, even after we fixed the Differential ones to not be terrible (T10694)?

Jun 16 2016, 6:17 PM · Restricted Project, Differential, Mail, Diffusion
epriestley merged T10742: PhabricatorRepositoryCommitParserWorker fails on deleted commits into T9028: Phabricator handles commits which are published and later deleted poorly.
Jun 16 2016, 6:08 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley merged task T10742: PhabricatorRepositoryCommitParserWorker fails on deleted commits into T9028: Phabricator handles commits which are published and later deleted poorly.
Jun 16 2016, 6:08 PM · Diffusion, Bug Report
epriestley added a comment to T10742: PhabricatorRepositoryCommitParserWorker fails on deleted commits.

I'm going to merge this into T9028. Specifically, daemons should be able to permanently fail operations on unreachable commits after D16131. That task discusses deleted/unreachable commits more broadly.

Jun 16 2016, 6:08 PM · Diffusion, Bug Report
epriestley closed T10933: You Shall Not Pass: Unknown Object (Repository) as Invalid.

We can't reproduce this, so we can't move forward. Feel free to open a new issue if you are able to provide reproduction steps.

Jun 16 2016, 6:05 PM · Diffusion, Bug Report
epriestley closed T10922: Upgrading: New Repository UI, APIs, and URI management as Resolved.

There don't appear to be any major outstanding issues here.

Jun 16 2016, 6:03 PM · Diffusion (v3), Installing & Upgrading
epriestley closed T10923: Diffusion API/URI Errata as Resolved.

This has seemed pretty stable for about a month. Future work is tracked in more specific tasks.

Jun 16 2016, 6:03 PM · Diffusion (v3)
epriestley closed T11137: Unable to update Git repositories with latest stable as Resolved.

This fix appears to be holding.

Jun 16 2016, 6:02 PM · Diffusion, Bug Report
epriestley merged T5715: Diffusion commit count is incorrect after forced push into T9028: Phabricator handles commits which are published and later deleted poorly.
Jun 16 2016, 6:01 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley merged task T5715: Diffusion commit count is incorrect after forced push into T9028: Phabricator handles commits which are published and later deleted poorly.
Jun 16 2016, 6:01 PM · Restricted Project, Diffusion
epriestley added a comment to T5715: Diffusion commit count is incorrect after forced push.

I'm going to merge this into T9028. Specifically, D16133 rebuilds the summary table after any commit becomes unreachable, which should produce the correct commit count and other summary details.

Jun 16 2016, 6:01 PM · Restricted Project, Diffusion
avivey added a comment to T6878: Tagged commits which are not ancestors of any branch head don't get imported.

black-listing phabricator/ sounds good to me :)

Jun 16 2016, 6:00 PM · Wikimedia, Restricted Project, Diffusion
epriestley added a comment to T6878: Tagged commits which are not ancestors of any branch head don't get imported.

D16134 just hard-codes phabricator/ tags as untracked, which should minimize collateral damage.

Jun 16 2016, 5:59 PM · Wikimedia, Restricted Project, Diffusion
epriestley added a revision to T6878: Tagged commits which are not ancestors of any branch head don't get imported: Unknown Object (Differential Revision).
Jun 16 2016, 5:57 PM · Wikimedia, Restricted Project, Diffusion
epriestley added a revision to T9028: Phabricator handles commits which are published and later deleted poorly: Unknown Object (Differential Revision).
Jun 16 2016, 5:57 PM · Restricted Project, Prioritized, Audit, Restricted Project
• rmaspoch created T11160: View Wiki Docs that only pertain to a certain group.
Jun 16 2016, 5:53 PM · Dashboards, Phriction, Bug Report
epriestley created T11159: Cluster detection of "replication OK" is unreasonably optimistic.
Jun 16 2016, 5:50 PM · Prioritized, Clusters
epriestley added a revision to T9028: Phabricator handles commits which are published and later deleted poorly: Unknown Object (Differential Revision).
Jun 16 2016, 5:48 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a comment to T6878: Tagged commits which are not ancestors of any branch head don't get imported.

Yeah, the actual rule D16129 implements is this:

Jun 16 2016, 5:33 PM · Wikimedia, Restricted Project, Diffusion
avivey added a comment to T6878: Tagged commits which are not ancestors of any branch head don't get imported.

For now, I think we can assume tags are always autoclose/track, but may need to refine this in the future.

Jun 16 2016, 5:29 PM · Wikimedia, Restricted Project, Diffusion
epriestley merged T11158: Allow arbitrary status updates to harbormaster via harbormaster.sendmessage into T9124: Support uploading build log data via the Harbormaster API.
Jun 16 2016, 4:43 PM · Restricted Project, Harbormaster
epriestley merged task T11158: Allow arbitrary status updates to harbormaster via harbormaster.sendmessage into T9124: Support uploading build log data via the Harbormaster API.
Jun 16 2016, 4:43 PM · Harbormaster, Feature Request
chad added a comment to T10901: Support title art for Phame blogs.

oh wow

Jun 16 2016, 4:41 PM · Phacility, Phame
epriestley added a comment to T10901: Support title art for Phame blogs.

high-horse-soapbox.jpg (1×1 px, 330 KB)

Jun 16 2016, 4:40 PM · Phacility, Phame
epriestley added a comment to T10901: Support title art for Phame blogs.

they are mine T.T

Jun 16 2016, 4:39 PM · Phacility, Phame
chad added a comment to T10901: Support title art for Phame blogs.

i can has arts

Jun 16 2016, 4:39 PM · Phacility, Phame
epriestley added a comment to T10901: Support title art for Phame blogs.

We could do posts too, but I only have 3 arts so far, so blogs seemed easier to start with.

Jun 16 2016, 4:38 PM · Phacility, Phame
chad added a comment to T10901: Support title art for Phame blogs.

Oh for blogs, not posts.

Jun 16 2016, 4:36 PM · Phacility, Phame