Page MenuHomePhabricator
Feed Advanced Search

Jan 16 2016

epriestley added a revision to T10163: Remarkup Autocomplete Errata: D15036: Immediately cancel autocomplete if the user types certain characters anywhere.
Jan 16 2016, 9:40 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: D15035: Allow autocomplete to activate after ">", ":" or "!".
Jan 16 2016, 9:17 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 16 2016, 9:14 PM · Remarkup, Typeahead
cspeckmim added a comment to T10163: Remarkup Autocomplete Errata.

That would change your case of @epriestley xvnoinoandsonaf having autosuggest stick around though.

Jan 16 2016, 8:39 PM · Remarkup, Typeahead
cspeckmim added a comment to T10163: Remarkup Autocomplete Errata.

I like that idea. Should it also hide if there are 0-1 matches? When mentioning users with short usernames or project names it's often faster to just type, @chad, @cspeck, #enad, etc.

Jan 16 2016, 8:27 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

Maybe we can do this:

Jan 16 2016, 8:20 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

That'll break @evan danger priestley and #differential mobile unbeta. I don't really see a clean way to resolve that based on spaces-typed, since both human and project names may contain an arbitrary number of internal words. We could put some artificial cutoff (three words? maybe four or five for projects?) but I don't immediately see a way to write a rule that always does what you users want.

Jan 16 2016, 8:18 PM · Remarkup, Typeahead
cspeckmim added a comment to T10163: Remarkup Autocomplete Errata.

@epriestley - Sorry, was just noting the different cases while testing -- most of the 'prefix' ones I gather made sense for the exact reasons you described. The only change I would prefer is if space also dismissed the typeahead - if completely ignoring typeahead it feels like it's in the way.

Jan 16 2016, 8:14 PM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

Another errata is when the typeahead appears off the page and you have to scroll. In Conpherence it, uh, scrolls the main header off the page.

Jan 16 2016, 8:14 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

Let's try the less-annoying way and see if it actually causes problems, it's definitely the behavior I would prefer personally.

Jan 16 2016, 8:14 PM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

But maybe it will feel weird, since I don't think most inline typeaheads work like that. On github as soon as I hit @, it pops a typeahead with you at the top (presumably, you're the commit author?)

Jan 16 2016, 8:05 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 16 2016, 8:04 PM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

From a design POV I see typeaheads as "Search", not "Browse". They should have some idea when they did @ or # what they were looking to link to.

Jan 16 2016, 8:03 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

Do you think that's preferable? I think it's probably much better for experienced users, but I'm a little worried some users will type a #, sit there, then tell us it's broken if we do that.

Jan 16 2016, 8:02 PM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

We could also decline to pop the typeahead until the user types the first (valid) character. Currently we pop it on @ or # immediately to show the user that it's available and aid discovery, but it might be better to wait until they type one valid character before we pop it, so there wouldn't be a flash on cases of ##, etc.

Jan 16 2016, 8:00 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

We could also decline to pop the typeahead until the user types the first (valid) character. Currently we pop it on @ or # immediately to show the user that it's available and aid discovery, but it might be better to wait until they type one valid character before we pop it, so there wouldn't be a flash on cases of ##, etc.

Jan 16 2016, 7:59 PM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

url.png (276×182 px, 2 KB)

Jan 16 2016, 7:59 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 16 2016, 7:58 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

Typeahead starts when preceded by ., -, (, |, #, @

Jan 16 2016, 7:57 PM · Remarkup, Typeahead
cspeckmim added a comment to T10163: Remarkup Autocomplete Errata.

Some nuances I've tested:

  1. Typeahead starts when preceded by ., -, (, |, #, @
  2. Typeahead does not start when preceded by most other characters including ', ", ?, ,, /, {, }, [, ], ), :, >, < +, _, ;, !
Jan 16 2016, 7:42 PM · Remarkup, Typeahead
cspeckmim added a comment to T10163: Remarkup Autocomplete Errata.

Not sure if rP2d495e97014d made it on this install, but typing two # in a row still tries to autocomplete. Should it be dismissed if prior text is # as well (for headings/sections)?

Jan 16 2016, 6:57 PM · Remarkup, Typeahead

Jan 15 2016

epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 15 2016, 7:14 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: D15033: Improve autocomplete behavior when typing ordered lists.
Jan 15 2016, 7:13 PM · Remarkup, Typeahead
scp added a comment to T10163: Remarkup Autocomplete Errata.

Seeing as how you don't need to select a result for the mention to work, the inability to get the typeahead results back after dismissing them isn't that big of a deal either way, imo.

Jan 15 2016, 7:10 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

(1) is currently intentional -- I'm being pretty aggressive about throwing the prompt away, and dismiss it if you use "up" or "down" to get off the ends of the list, under the assumption those actions mean "throw this away, I hate it". I'm definitely open to changing those to just eat the inputs.

Jan 15 2016, 7:04 PM · Remarkup, Typeahead
scp added a comment to T10163: Remarkup Autocomplete Errata.

Ok, here's what just happened on my initial test run:

Jan 15 2016, 7:00 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

One thing I've done differently than, e.g., Facebook is that I've made summoning the completer explicit (when you type "@" or "#"), not implicit (when you position your cursor somewhere in something that looks like a username in the text).

Jan 15 2016, 6:05 PM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

(This seems to work really well for me, btw)

Jan 15 2016, 5:56 PM · Remarkup, Typeahead
chad updated subscribers of T10163: Remarkup Autocomplete Errata.

I heard @scp is also good at breaking things.

Jan 15 2016, 5:56 PM · Remarkup, Typeahead
chad updated subscribers of T10163: Remarkup Autocomplete Errata.

I can't break it with 30 seconds of attempt. Wonder what @joshuaspence will find.

Jan 15 2016, 5:51 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

That appears to be working better, now.

Jan 15 2016, 5:49 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 15 2016, 5:41 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 15 2016, 5:40 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: D15032: Better fix for autocomplete blur (select on mousedown instead of delaying blur).
Jan 15 2016, 5:40 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

I think my analysis of the blur thing wasn't quite right, I'm still getting intermittent success with clicking results. I'll dig into that a bit more.

Jan 15 2016, 5:35 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 15 2016, 5:33 PM · Remarkup, Typeahead
epriestley triaged T10163: Remarkup Autocomplete Errata as Normal priority.
Jan 15 2016, 5:33 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: D15031: Fix blur and sort behavior for autocomplete.
Jan 15 2016, 5:32 PM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

derp

Jan 15 2016, 5:27 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.
In T10163#154221, @chad wrote:

If I type @demo and then tab it changes to @abuna

Jan 15 2016, 5:27 PM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

If I type @demo and then tab it changes to @abuna

Jan 15 2016, 5:26 PM · Remarkup, Typeahead
epriestley created T10163: Remarkup Autocomplete Errata.
Jan 15 2016, 5:20 PM · Remarkup, Typeahead

Dec 27 2015

eadler added a comment to T8399: Support Áçčềñṭ-Ḟøłɖǐṅg in typeaheads.

http://www.gyro-php.org/documentation/contributions/group__Unidecode.html seems relevant.

Dec 27 2015, 12:14 AM · Typeahead

Dec 26 2015

epriestley added a comment to T8399: Support Áçčềñṭ-Ḟøłɖǐṅg in typeaheads.

It may also make sense to fold accents when normalizing strings for ngram indexes.

Dec 26 2015, 11:21 PM · Typeahead

Dec 24 2015

epriestley updated subscribers of T7858: Typeahead/Tokenizer Errata.
Dec 24 2015, 6:26 PM · Restricted Project, Typeahead
epriestley updated the task description for T7858: Typeahead/Tokenizer Errata.
Dec 24 2015, 6:22 PM · Restricted Project, Typeahead

Dec 11 2015

epriestley closed T8396: projects autofill text box as Wontfix.

I think this behavior is reasonable as-is.

Dec 11 2015, 1:51 AM · Typeahead
epriestley updated the task description for T7858: Typeahead/Tokenizer Errata.
Dec 11 2015, 1:38 AM · Restricted Project, Typeahead
epriestley added a revision to T7858: Typeahead/Tokenizer Errata: D14738: Disable tokenizer "Browse" button once tokenizer is full.
Dec 11 2015, 1:37 AM · Restricted Project, Typeahead

Dec 10 2015

epriestley updated the task description for T7858: Typeahead/Tokenizer Errata.
Dec 10 2015, 11:47 PM · Restricted Project, Typeahead
epriestley merged T9761: tokenizer search button ignores limit into T7858: Typeahead/Tokenizer Errata.
Dec 10 2015, 11:45 PM · Restricted Project, Typeahead
chad updated the task description for T7858: Typeahead/Tokenizer Errata.
Dec 10 2015, 11:45 PM · Restricted Project, Typeahead
chad updated subscribers of T7858: Typeahead/Tokenizer Errata.
Dec 10 2015, 11:44 PM · Restricted Project, Typeahead

Dec 5 2015

epriestley closed T9206: Herald unable to place task up for grabs as Resolved by committing rPbc331f0fbf54: Allow "Assign task" Herald Action in Maniphest to accept "None" to unassign.
Dec 5 2015, 8:39 PM · Typeahead, Herald
epriestley added a revision to T9206: Herald unable to place task up for grabs: D14684: Allow "Assign task" Herald Action in Maniphest to accept "None" to unassign.
Dec 5 2015, 8:38 PM · Typeahead, Herald

Nov 24 2015

epriestley updated subscribers of T7858: Typeahead/Tokenizer Errata.
Nov 24 2015, 4:56 PM · Restricted Project, Typeahead

Oct 20 2015

epriestley merged task T8624: Typeahead for repository requires the 'r' to autocomplete callsigns into T9523: Make search autocomplete show repository names.
Oct 20 2015, 1:58 PM · Typeahead, Diffusion

Oct 14 2015

angie moved T5750: Implement typeahead browse mode from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Oct 14 2015, 6:42 PM · Restricted Project, Wikimedia, Typeahead, Design, Maniphest

Oct 13 2015

epriestley removed subtasks for T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch: T9452: Cloudsme, T9469: Redirect loop after fresh installation, T9478: Working with harbormaster.sendmessage, T9500: Active dashboards not shown with "Active" search filter, T9512: "Change Password" should prompt users to "Reset Password" if no password has been set, T9511: asdasda, T9510: sadasdasd.
Oct 13 2015, 12:59 AM · Restricted Project, Typeahead, Audit
554816806 added subtasks for T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch: T9510: sadasdasd, T9511: asdasda, T9512: "Change Password" should prompt users to "Reset Password" if no password has been set, T9500: Active dashboards not shown with "Active" search filter, T9478: Working with harbormaster.sendmessage, T9469: Redirect loop after fresh installation, T9452: Cloudsme.
Oct 13 2015, 12:58 AM · Restricted Project, Typeahead, Audit

Sep 9 2015

epriestley added a comment to T8444: Increase typeahead speed.

I ideally want to resolve T8588 before pursuing this since it's the more fundamental performance issue, even though this isn't particularly entwined with that.

Sep 9 2015, 11:01 PM · Typeahead, PHUI, Restricted Project
epriestley added a subtask for T8444: Increase typeahead speed: T8588: One instance has a severe, global performance issue.
Sep 9 2015, 10:58 PM · Typeahead, PHUI, Restricted Project

Sep 8 2015

epriestley renamed T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch from support fancy typeahead functions in audit search to Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Sep 8 2015, 8:53 PM · Restricted Project, Typeahead, Audit
cburroughs added a comment to T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.

Sorry I had several instances of phabricator up comparing results and must have messed up which one was which. As you pointed out viewerprojects() specifically (which really is the one I was interested in) is not available on this install.

Sep 8 2015, 7:50 PM · Restricted Project, Typeahead, Audit
epriestley added a comment to T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.

It looks like viewerprojects(), specifically, isn't included in these sources at HEAD.

Sep 8 2015, 7:44 PM · Restricted Project, Typeahead, Audit
epriestley added a comment to T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.

Are you at HEAD / does this problem still exist on this install?

Sep 8 2015, 7:43 PM · Restricted Project, Typeahead, Audit
cburroughs created T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Sep 8 2015, 7:06 PM · Restricted Project, Typeahead, Audit

Aug 18 2015

dpaola2 added a comment to T9206: Herald unable to place task up for grabs.

Excellent point, thanks for clarifying.

Aug 18 2015, 6:50 PM · Typeahead, Herald
epriestley added a comment to T9206: Herald unable to place task up for grabs.

In the past, the bulk editor worked like this under a similar theory (and or laziness, I don't remember which contributed more), but we had at least one (and maybe a few? I don't recall offhand) user who failed to guess it and didn't even try the interaction in the bulk editor.

Aug 18 2015, 6:41 PM · Typeahead, Herald
epriestley added a comment to T9206: Herald unable to place task up for grabs.
Aug 18 2015, 6:41 PM · Typeahead, Herald
dpaola2 added a comment to T9206: Herald unable to place task up for grabs.

I'd be curious how important it is to the project to maintain UI consistency between Herald and Maniphest. Currently leaving the field blank in Maniphest places the task up for grabs -- wouldn't it be preferable to maintain the same expectations in Herald?

Aug 18 2015, 6:18 PM · Typeahead, Herald
epriestley added a project to T9206: Herald unable to place task up for grabs: Typeahead.
Aug 18 2015, 5:57 PM · Typeahead, Herald

Aug 14 2015

chad updated subscribers of T7858: Typeahead/Tokenizer Errata.
Aug 14 2015, 2:29 PM · Restricted Project, Typeahead

Aug 6 2015

joshuaspence added a member for Typeahead: joshuaspence.
Aug 6 2015, 9:07 AM

Jul 21 2015

swisspol added a comment to T8904: Make tag bubbles clickable in text field popovers.

I always use this menu to access the special items as I have no idea what to type to auto-complete them e.g. "not in any project".

Jul 21 2015, 4:05 PM · Typeahead
epriestley edited projects for T8904: Make tag bubbles clickable in text field popovers, added: Typeahead; removed PHUI.
Jul 21 2015, 11:17 AM · Typeahead

Jun 22 2015

chad added projects to T8624: Typeahead for repository requires the 'r' to autocomplete callsigns: Diffusion, Typeahead.
Jun 22 2015, 8:08 PM · Typeahead, Diffusion

Jun 17 2015

joshuaspence added a project to T8444: Increase typeahead speed: Typeahead.
Jun 17 2015, 10:04 AM · Typeahead, PHUI, Restricted Project

Jun 16 2015

epriestley closed T8563: Typeahead search button should permit the selection of multiple items as Wontfix.

This interaction would be less clear in the general case. This problem is better solved through T3670.

Jun 16 2015, 4:55 PM · Typeahead
hach-que created T8563: Typeahead search button should permit the selection of multiple items.
Jun 16 2015, 5:32 AM · Typeahead

Jun 3 2015

angie moved T5750: Implement typeahead browse mode from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 3 2015, 8:35 PM · Restricted Project, Wikimedia, Typeahead, Design, Maniphest
tycho.tatitscheff added a comment to T8399: Support Áçčềñṭ-Ḟøłɖǐṅg in typeaheads.

chad changed the title from "Support accent folding in typeaheads" to "Support Áçčềñṭ-Ḟøłɖǐṅg in typeaheads".

Jun 3 2015, 7:18 PM · Typeahead
chad added a comment to T8399: Support Áçčềñṭ-Ḟøłɖǐṅg in typeaheads.

tumblr_litkzaldnn1qghlk1o1_500.jpg (459×600 px, 47 KB)

Jun 3 2015, 7:17 PM · Typeahead
chad renamed T8399: Support Áçčềñṭ-Ḟøłɖǐṅg in typeaheads from Support accent folding in typeaheads to Support Áçčềñṭ-Ḟøłɖǐṅg in typeaheads.
Jun 3 2015, 7:16 PM · Typeahead
chad renamed T8399: Support Áçčềñṭ-Ḟøłɖǐṅg in typeaheads from TypeAhead should handle the char with accent in a better way to Support accent folding in typeaheads.
Jun 3 2015, 7:16 PM · Typeahead
tycho.tatitscheff created T8399: Support Áçčềñṭ-Ḟøłɖǐṅg in typeaheads.
Jun 3 2015, 7:06 PM · Typeahead
joshuaspence added a project to T8396: projects autofill text box: Typeahead.
Jun 3 2015, 1:16 PM · Typeahead

May 21 2015

epriestley reopened T3670: Add subprojects, a subtask of T6634: Typeahead default should maybe be more than 5, as Open.
May 21 2015, 2:09 PM · Typeahead, Maniphest

May 20 2015

angie added a project to T5750: Implement typeahead browse mode: Restricted Project.
May 20 2015, 5:11 PM · Restricted Project, Wikimedia, Typeahead, Design, Maniphest

Apr 24 2015

epriestley updated the task description for T7858: Typeahead/Tokenizer Errata.
Apr 24 2015, 3:41 PM · Restricted Project, Typeahead

Apr 23 2015

matmarex added a comment to T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.

These containers can both contain <a /> elements, which aren't valid inside an <a /> even in HTML5, which is why the containers are <div /> instead of <a />. We can possibly either add some sort of floating invisible <a /> under them to solve this in CSS/HTML, or implement additional behaviors in JS to simulate link clicks.

Apr 23 2015, 8:38 PM · Typeahead, Notifications
epriestley triaged T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked as Wishlist priority.
Apr 23 2015, 8:28 PM · Typeahead, Notifications
chad added a comment to T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.

Apr 23 2015, 8:25 PM · Typeahead, Notifications
epriestley renamed T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked from Event Listeners should respect middle and right clicks if possible to Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.
Apr 23 2015, 8:25 PM · Typeahead, Notifications
epriestley closed T4100: Support query parameterization in typeaheads as Resolved.

These aren't universally deployed yet, but are substantially complete and are deployed in multiple applications. See T7858 for some followups. These will deploy everywhere over time, although they may not come to some lesser-used applications for a bit.

Apr 23 2015, 7:08 PM · Typeahead, User Delight, Maniphest
epriestley closed T4100: Support query parameterization in typeaheads, a subtask of T7729: No Typeahead on Herald object rule creation, as Resolved.
Apr 23 2015, 7:08 PM · Typeahead, Herald
epriestley added a revision to T4100: Support query parameterization in typeaheads: D12533: Support tokenizer functions in Diffusion.
Apr 23 2015, 3:26 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T4100: Support query parameterization in typeaheads: D12532: Rename TypehaeadUserParameterizedDatasource to PeopleUserFunctionDatasource.
Apr 23 2015, 3:08 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T4100: Support query parameterization in typeaheads: D12531: Parameterize search in Pholio.
Apr 23 2015, 3:05 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T4100: Support query parameterization in typeaheads: D12530: Implement open() and closed() Maniphest tokenizer status functions, plus cleanup.
Apr 23 2015, 1:49 PM · Typeahead, User Delight, Maniphest