Page MenuHomePhabricator

matmarex (Bartosz Dziewoński)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Nov 23 2014, 11:30 PM (333 w, 4 d)
Availability
Available

Recent Activity

May 12 2016

matmarex added a comment to T6616: Typeahead uses locale-specific comparison.

Please unassign me from this task (why can't I do it myself?). My patch was rejected.

May 12 2016, 5:30 PM · Typeahead, PHUI

Jul 25 2015

nemobis awarded T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view a Doubloon token.
Jul 25 2015, 12:27 PM · Wikimedia, Notifications

Jul 24 2015

matmarex created T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view.
Jul 24 2015, 11:02 PM · Wikimedia, Notifications

Jun 5 2015

matmarex placed T5187: Make "Upload File" dialog have a vanilla file upload control up for grabs.

My patch seems to be stuck. Oh well.

Jun 5 2015, 1:51 AM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia

Apr 23 2015

matmarex added a comment to T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.

These containers can both contain <a /> elements, which aren't valid inside an <a /> even in HTML5, which is why the containers are <div /> instead of <a />. We can possibly either add some sort of floating invisible <a /> under them to solve this in CSS/HTML, or implement additional behaviors in JS to simulate link clicks.

Apr 23 2015, 8:38 PM · Typeahead, Notifications

Apr 21 2015

matmarex added a comment to T7164: "Resolved" should be the first (default) option in "Change Status" action.

We can avoid all the issues with "order" parameter by using an entire
separate setting like `'maniphest.statuses.order' => ['open', 'resolved',
'declined']`, and indeed falling back to object order. If the set of
values specified in it would not match the set of keys of
maniphest.statuses, it could just be ignored.

Apr 21 2015, 3:29 PM · Maniphest

Feb 18 2015

matmarex added a comment to D11472: Replace the primary scrollbar with a fake one to prepare for a persistent chat column.

While I am definitely not a fan of these, I must commend you for the least bad implementation of custom scrollbars I have seen so far. :)

Feb 18 2015, 5:06 PM

Feb 9 2015

matmarex updated D11706: Remarkup: Correctly render inline embed layout.
Feb 9 2015, 3:43 PM · Remarkup
matmarex added a comment to D11706: Remarkup: Correctly render inline embed layout.

It already implies display: inline in CSS, but as I have explained on the task that is not sufficient. Browser's HTML parser doesn't care what CSS rules will be applied, it only deals with the meanings of tags, and <p/> is specified as not being allowed to have a <div/> inside it. This is the same kind of thing as if you tried to nest <a/> tags, it's just not possible.

Feb 9 2015, 3:35 PM · Remarkup

Feb 6 2015

matmarex retitled D11706: Remarkup: Correctly render inline embed layout from to Remarkup: Correctly render inline embed layout.
Feb 6 2015, 10:56 PM · Remarkup
matmarex added a revision to T7201: Remarkup {Fxxx,layout=inline} not actually rendered inline: D11706: Remarkup: Correctly render inline embed layout.
Feb 6 2015, 10:56 PM · Remarkup
matmarex added a comment to T7201: Remarkup {Fxxx,layout=inline} not actually rendered inline.

Screenshot from description for posterity:

Feb 6 2015, 10:48 PM · Remarkup
matmarex created T7201: Remarkup {Fxxx,layout=inline} not actually rendered inline.
Feb 6 2015, 10:47 PM · Remarkup

Feb 2 2015

matmarex added a comment to D11513: (T5187) Allow uploading files directly when editing a comment without drag&drop/copy&paste.

Any feedback?

Feb 2 2015, 11:51 PM · Remarkup, Files

Jan 27 2015

matmarex added a revision to T5187: Make "Upload File" dialog have a vanilla file upload control: D11513: (T5187) Allow uploading files directly when editing a comment without drag&drop/copy&paste.
Jan 27 2015, 6:51 AM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
matmarex added a task to D11513: (T5187) Allow uploading files directly when editing a comment without drag&drop/copy&paste: T5187: Make "Upload File" dialog have a vanilla file upload control.
Jan 27 2015, 6:51 AM · Remarkup, Files
matmarex retitled D11513: (T5187) Allow uploading files directly when editing a comment without drag&drop/copy&paste from to (T5187) Allow uploading files directly when editing a comment without drag&drop/copy&paste.
Jan 27 2015, 6:50 AM · Remarkup, Files
matmarex claimed T5187: Make "Upload File" dialog have a vanilla file upload control.

It would be a lot simpler to use HTML 5 File API together with a regular <input type=file /> field. This won't help the IE8s of the world, but will help users of non-standard, but modern operating systems and browsers.

Jan 27 2015, 6:44 AM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia

Jan 14 2015

matmarex added a comment to T6968: Bottom margin inconsistent for paragraphs/lists that are last children in comments.

Thanks!

Jan 14 2015, 8:20 PM · Remarkup
matmarex updated the diff for D11382: remarkup.css: Consistently zero top/bottom margins for first/last block-level children.

bin/celerity map

Jan 14 2015, 7:07 PM · Remarkup
matmarex added a comment to D11382: remarkup.css: Consistently zero top/bottom margins for first/last block-level children.

Am I expected to include the result of running bin/celerity map in the diff? That feels like something that should be done automatically on merge, since it would cause tons of merge conflicts otherwise, but I see it in some commits in Git.

Jan 14 2015, 6:59 AM · Remarkup
matmarex added a comment to T6968: Bottom margin inconsistent for paragraphs/lists that are last children in comments.

Note the lack of double spacing and the glorious even margins.

Jan 14 2015, 6:57 AM · Remarkup
matmarex added a revision to T6968: Bottom margin inconsistent for paragraphs/lists that are last children in comments: D11382: remarkup.css: Consistently zero top/bottom margins for first/last block-level children.
Jan 14 2015, 6:56 AM · Remarkup
matmarex added a task to D11382: remarkup.css: Consistently zero top/bottom margins for first/last block-level children: T6968: Bottom margin inconsistent for paragraphs/lists that are last children in comments.
Jan 14 2015, 6:56 AM · Remarkup
matmarex retitled D11382: remarkup.css: Consistently zero top/bottom margins for first/last block-level children from to remarkup.css: Consistently zero top/bottom margins for first/last block-level children.
Jan 14 2015, 6:56 AM · Remarkup
matmarex created T6968: Bottom margin inconsistent for paragraphs/lists that are last children in comments.
Jan 14 2015, 6:38 AM · Remarkup

Jan 3 2015

matmarex abandoned D10896: Typeahead: Do not use locale-specific comparisons.

Meh.

Jan 3 2015, 8:29 PM · Phabricator, Javelin

Dec 5 2014

matmarex awarded T6700: Opening new tabs from search dropdown results a Like token.
Dec 5 2014, 4:24 PM · PHUI, Search

Nov 24 2014

matmarex added a comment to T6616: Typeahead uses locale-specific comparison.

I want the strings to collate as the user expects strings in their language to collate, even if the strings are not actually written in their language. This will produce the best result if the strings are written in their language, and a reasonable (consistent with expectations) result if the strings are written in some other language or a mixture of languages.

Nov 24 2014, 7:30 PM · Typeahead, PHUI
matmarex added a comment to T6616: Typeahead uses locale-specific comparison.

Assuming locale compares work in a reasonable way, it seems like they should be more correct.

For example, as an English speaker, I expect strings to sort from "a -> z". Even if I'm viewing Australian strings on an Australian install, it's still better for me as a user to see an "a -> z" sort than an Australian "z -> a" sort of the strings, because it's one I'm more familiar with.

I do get a better result for localeCompare() than for < with Ł, in English: localeCompare() correctly puts it between "L" and "M". This is where I'd expect it to appear as an English speaker, and presumably a Polish speaker searching on an English-language install would still prefer a colleague named "Stanisław" to sort between "Staniskaw" and "Stanismaw", not after "Staniszaw".

Nov 24 2014, 5:39 PM · Typeahead, PHUI
matmarex claimed T6616: Typeahead uses locale-specific comparison.

I tried submitting a patch and it seems to have worked, so I guess I could "claim" this…?

Nov 24 2014, 12:20 AM · Typeahead, PHUI
matmarex added a revision to T6616: Typeahead uses locale-specific comparison: D10896: Typeahead: Do not use locale-specific comparisons.
Nov 24 2014, 12:15 AM · Typeahead, PHUI
matmarex added a task to D10896: Typeahead: Do not use locale-specific comparisons: T6616: Typeahead uses locale-specific comparison.
Nov 24 2014, 12:15 AM · Phabricator, Javelin
matmarex retitled D10896: Typeahead: Do not use locale-specific comparisons from to Typeahead: Do not use locale-specific comparisons.
Nov 24 2014, 12:15 AM · Phabricator, Javelin
matmarex added a project to T6616: Typeahead uses locale-specific comparison: Phabricator.
Nov 24 2014, 12:15 AM · Typeahead, PHUI

Nov 23 2014

matmarex added a project to T6616: Typeahead uses locale-specific comparison: Wikimedia.
Nov 23 2014, 11:44 PM · Typeahead, PHUI
matmarex added a comment to T6616: Typeahead uses locale-specific comparison.

I debugged this in browser console, so no idea where this code comes from in the source, but lines that needs changing look like:

Nov 23 2014, 11:40 PM · Typeahead, PHUI
matmarex created T6616: Typeahead uses locale-specific comparison.
Nov 23 2014, 11:39 PM · Typeahead, PHUI