- User Since
- Nov 23 2014, 11:30 PM (434 w, 5 d)
May 12 2016
Please unassign me from this task (why can't I do it myself?). My patch was rejected.
Jul 25 2015
Jul 24 2015
Jun 5 2015
My patch seems to be stuck. Oh well.
Apr 23 2015
Apr 21 2015
We can avoid all the issues with "order" parameter by using an entire
separate setting like `'maniphest.statuses.order' => ['open', 'resolved',
'declined']`, and indeed falling back to object order. If the set of
values specified in it would not match the set of keys of
maniphest.statuses, it could just be ignored.
Feb 18 2015
While I am definitely not a fan of these, I must commend you for the least bad implementation of custom scrollbars I have seen so far. :)
Feb 9 2015
It already implies display: inline in CSS, but as I have explained on the task that is not sufficient. Browser's HTML parser doesn't care what CSS rules will be applied, it only deals with the meanings of tags, and <p/> is specified as not being allowed to have a <div/> inside it. This is the same kind of thing as if you tried to nest <a/> tags, it's just not possible.
Feb 6 2015
Screenshot from description for posterity:
Feb 2 2015
Jan 27 2015
It would be a lot simpler to use HTML 5 File API together with a regular <input type=file /> field. This won't help the IE8s of the world, but will help users of non-standard, but modern operating systems and browsers.
Jan 14 2015
Am I expected to include the result of running bin/celerity map in the diff? That feels like something that should be done automatically on merge, since it would cause tons of merge conflicts otherwise, but I see it in some commits in Git.
Note the lack of double spacing and the glorious even margins.
Jan 3 2015
Dec 5 2014
Nov 24 2014
I want the strings to collate as the user expects strings in their language to collate, even if the strings are not actually written in their language. This will produce the best result if the strings are written in their language, and a reasonable (consistent with expectations) result if the strings are written in some other language or a mixture of languages.
I tried submitting a patch and it seems to have worked, so I guess I could "claim" this…?
Nov 23 2014
I debugged this in browser console, so no idea where this code comes from in the source, but lines that needs changing look like: