Page MenuHomePhabricator

Improve autocomplete behavior when typing ordered lists
ClosedPublic

Authored by epriestley on Jan 15 2016, 7:13 PM.
Tags
None
Referenced Files
F14051171: D15033.diff
Thu, Nov 14, 10:46 PM
F14037520: D15033.diff
Sun, Nov 10, 4:43 PM
F14024406: D15033.diff
Thu, Nov 7, 9:11 AM
F14004412: D15033.id.diff
Sat, Oct 26, 8:11 PM
F13999238: D15033.diff
Thu, Oct 24, 1:37 PM
F13992810: D15033.id36313.diff
Tue, Oct 22, 6:57 PM
F13992409: D15033.id36312.diff
Tue, Oct 22, 4:22 PM
F13986680: D15033.diff
Mon, Oct 21, 4:49 AM
Subscribers
None

Details

Summary

Ref T10163.

  • If a user types an autocomplete character ("@" or "#") and then a space, deactivate immediately (probably an ordered list).
  • If a user types an autocomplete character indented on a line with no other prior text, don't activate (probably an ordered list or code block).
Test Plan

Typed:

  • # , saw immediate deactivation.
  • #, saw no activation in the first place.
  • #x, saw activation.
  • asdf #x, saw activation.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve autocomplete behavior when typing ordered lists.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2016, 7:17 PM
This revision was automatically updated to reflect the committed changes.