Differential D15032

Better fix for autocomplete blur (select on mousedown instead of delaying blur)
ClosedPublic
Actions

Authored by epriestley on Jan 15 2016, 5:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 3:23 AM

	Unknown Object (File)
	Mon, Apr 22, 11:16 PM

	Unknown Object (File)
	Sun, Apr 21, 6:17 AM

	Unknown Object (File)
	Fri, Apr 19, 4:06 PM

	Unknown Object (File)
	Thu, Apr 11, 1:59 PM

	Unknown Object (File)
	Thu, Apr 11, 10:45 AM

	Unknown Object (File)
	Sun, Mar 31, 2:06 AM

	Unknown Object (File)
	Mar 21 2024, 4:20 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10163: Remarkup Autocomplete Errata

Commits

Restricted Diffusion Commit
rP7f19216e4499: Better fix for autocomplete blur (select on mousedown instead of delaying blur)

Summary

Ref T10163. I would still sometimes not get a replacement after clicking with the delayed blur. This seems to fix the issue more consistently: instead of listening for a click event (which fires after the blur), listen for a mousedown event (which fires before the blur).

Test Plan

Observed consistent selection via mouse locally.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36310.Jan 15 2016, 5:40 PM

epriestley retitled this revision from to Better fix for autocomplete blur (select on mousedown instead of delaying blur).

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10163: Remarkup Autocomplete Errata.

chad accepted this revision.Jan 15 2016, 5:47 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 15 2016, 5:47 PM

Closed by commit rP7f19216e4499: Better fix for autocomplete blur (select on mousedown instead of delaying blur) (authored by epriestley, committed by epriestley). · Explain WhyJan 15 2016, 5:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

16 lines

webroot/

rsrc/

js/

phuix/

PHUIXAutocomplete.js

12 lines

Diff 36311

resources/celerity/map.php

Loading...

webroot/rsrc/js/phuix/PHUIXAutocomplete.js

Loading...