Page MenuHomePhabricator

Better fix for autocomplete blur (select on mousedown instead of delaying blur)
ClosedPublic

Authored by epriestley on Jan 15 2016, 5:40 PM.
Tags
None
Referenced Files
F14058408: D15032.diff
Sun, Nov 17, 11:42 AM
F14037557: D15032.id36311.diff
Sun, Nov 10, 5:01 PM
F13990080: D15032.id36311.diff
Tue, Oct 22, 12:58 AM
F13973547: D15032.diff
Oct 18 2024, 1:22 AM
Unknown Object (File)
Sep 7 2024, 5:19 AM
Unknown Object (File)
Sep 6 2024, 4:31 AM
Unknown Object (File)
Aug 31 2024, 11:38 PM
Unknown Object (File)
Aug 21 2024, 3:20 PM
Subscribers
None

Details

Summary

Ref T10163. I would still sometimes not get a replacement after clicking with the delayed blur. This seems to fix the issue more consistently: instead of listening for a click event (which fires after the blur), listen for a mousedown event (which fires before the blur).

Test Plan

Observed consistent selection via mouse locally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Better fix for autocomplete blur (select on mousedown instead of delaying blur).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2016, 5:47 PM
This revision was automatically updated to reflect the committed changes.