Differential D14738

Disable tokenizer "Browse" button once tokenizer is full
ClosedPublic
Actions

Authored by epriestley on Dec 11 2015, 1:37 AM.

Details

Reviewers

chad

Maniphest Tasks

T7858: Typeahead/Tokenizer Errata

Commits

Restricted Diffusion Commit
rP3680d959ddd6: Disable tokenizer "Browse" button once tokenizer is full

Summary

Ref T7858. Don't let users add multiple values to single-value tokenizers by using the "Browse" button.

Test Plan

Added a token, browse button was disabled.
Removed the token, browse button was enabled again.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35646.Dec 11 2015, 1:37 AM

epriestley retitled this revision from to Disable tokenizer "Browse" button once tokenizer is full.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T7858: Typeahead/Tokenizer Errata.

epriestley mentioned this in T7858: Typeahead/Tokenizer Errata.Dec 11 2015, 1:38 AM

chad accepted this revision.Dec 11 2015, 1:49 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 11 2015, 1:49 AM

Closed by commit rP3680d959ddd6: Disable tokenizer "Browse" button once tokenizer is full (authored by epriestley, committed by epriestley). · Explain WhyDec 11 2015, 1:50 AM

This revision was automatically updated to reflect the committed changes.

mememori awarded a token.Dec 11 2015, 3:32 AM

epriestley mentioned this in T9952: Let "Land Revision" target branches other than master.Dec 14 2015, 10:27 PM

epriestley mentioned this in T9984: For limit=1 tokenizers, allow browse but replace the value.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

18 lines

webroot/

rsrc/

externals/

javelin/

lib/

control/

tokenizer/

Tokenizer.js

30 lines

Diff 35647

View Options

resources/celerity/map.php