Page MenuHomePhabricator

Fix blur and sort behavior for autocomplete
ClosedPublic

Authored by epriestley on Jan 15 2016, 5:32 PM.
Tags
None
Referenced Files
F15455253: D15031.id36308.diff
Sat, Mar 29, 11:09 PM
F15452055: D15031.id.diff
Sat, Mar 29, 1:26 AM
F15443933: D15031.diff
Thu, Mar 27, 6:57 AM
F15429313: D15031.id.diff
Mon, Mar 24, 1:36 AM
F15428522: D15031.id.diff
Sun, Mar 23, 8:55 PM
F15414993: D15031.id36308.diff
Thu, Mar 20, 3:27 AM
F15414961: D15031.diff
Thu, Mar 20, 3:17 AM
F15407083: D15031.diff
Tue, Mar 18, 3:33 PM
Subscribers
None

Details

Summary

Ref T10163.

  • If you click a result, we get a blur before your click hits, and deactivate before the click can work. Instead, wait before responding to blur.
  • Use the standard sort handler which puts unixnames over human names. Also use the standard filter which deals with disabled users not matching unless they're the only match.
Test Plan
  • Clicked a result, got a replacement.
  • Named myself "dog dog", typed "@dog", user "@dog" was now first match despite me being "@admin".
  • Used normal typeaheads to make sure I didn't break sort handler.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix blur and sort behavior for autocomplete.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2016, 5:33 PM
This revision was automatically updated to reflect the committed changes.