Page MenuHomePhabricator

Immediately cancel autocomplete if the user types certain characters anywhere
ClosedPublic

Authored by epriestley on Jan 16 2016, 9:40 PM.
Tags
None
Referenced Files
F13992414: D15036.id36317.diff
Tue, Oct 22, 4:27 PM
Unknown Object (File)
Fri, Oct 11, 8:51 AM
Unknown Object (File)
Oct 8 2024, 10:00 PM
Unknown Object (File)
Oct 1 2024, 2:59 AM
Unknown Object (File)
Sep 25 2024, 5:27 AM
Unknown Object (File)
Sep 21 2024, 2:50 PM
Unknown Object (File)
Sep 9 2024, 9:37 PM
Unknown Object (File)
Sep 2 2024, 4:56 AM
Subscribers
None

Details

Summary

Ref T10163. Some characters are almost certainly punctuation or markup rather than autocomplete requests. Immediately cancel any active autocomplete when the user types one of these.

Note that some of these are also suffix characters. If you type @dog,, you have until the next character to decide you actually mean to autocomplete. Once you type something else we deactivate.

If you type #dog# or ##, we deactivate immediately.

Test Plan

Typed @dog#, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Immediately cancel autocomplete if the user types certain characters anywhere.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 16 2016, 9:44 PM
This revision was automatically updated to reflect the committed changes.