Page MenuHomePhabricator
Feed Advanced Search

May 17 2022

epriestley closed T13681: Ancient "feed.publish" API is (at best) long obsolete, and arguably exploitable as Resolved.
May 17 2022, 11:31 PM · Security, Feed
epriestley added a revision to T13681: Ancient "feed.publish" API is (at best) long obsolete, and arguably exploitable: D21826: Remove "feed.publish" API.
May 17 2022, 11:29 PM · Security, Feed
epriestley triaged T13681: Ancient "feed.publish" API is (at best) long obsolete, and arguably exploitable as Normal priority.
May 17 2022, 11:27 PM · Security, Feed

Feb 22 2020

epriestley triaged T13494: Feed stories which summarize a transaction list with a user comment and a Herald comment may show both comments as Wishlist priority.
Feb 22 2020, 4:41 PM · Feed

Oct 22 2019

artms added a revision to T13416: Transaction logs may overheat explosively: D20855: Add index on dateCreated database field because it is used by Feed->Transactions functionality.
Oct 22 2019, 7:43 AM · Feed

Oct 10 2019

epriestley added a revision to T13416: Transaction logs may overheat explosively: D20856: Allow partial response of transaction history if it is overheating.
Oct 10 2019, 2:35 PM · Feed

Sep 12 2019

epriestley triaged T13416: Transaction logs may overheat explosively as Low priority.
Sep 12 2019, 11:22 PM · Feed

Sep 9 2019

epriestley closed T8952: Hide "Herald added subscribers..." stories from feed completely as Resolved by committing rP7593a265d593: When Herald changes object subscribers, always hide the feed story.
Sep 9 2019, 8:17 PM · Feed, Herald
epriestley added a comment to T8952: Hide "Herald added subscribers..." stories from feed completely.

0.00000000001 is very funny and we would be losing a truly great joke at such a young age

Sep 9 2019, 8:15 PM · Feed, Herald
epriestley added a revision to T8952: Hide "Herald added subscribers..." stories from feed completely: D20797: When Herald changes object subscribers, always hide the feed story.
Sep 9 2019, 8:14 PM · Feed, Herald

Aug 8 2019

epriestley added a revision to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core: D20704: When the feed query on project profile pages overheats, contain the damage.
Aug 8 2019, 5:37 PM · Feed
epriestley added a comment to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core.

See downstream https://phabricator.wikimedia.org/T230001 for a similar issue on project pages.

Aug 8 2019, 5:31 PM · Feed

Jul 30 2019

epriestley triaged T13351: "Settings" objects render very generically in the transaction log as Low priority.
Jul 30 2019, 11:21 PM · User Preferences, Feed

Jul 24 2019

epriestley closed T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core as Resolved by committing rP6831ed94faf6: Contain fallout from overheating feed queries on user profile pages.
Jul 24 2019, 2:09 PM · Feed

Jul 23 2019

epriestley added a revision to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core: D20678: Contain fallout from overheating feed queries on user profile pages.
Jul 23 2019, 11:03 PM · Feed
epriestley added a comment to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core.

To reproduce this easily:

Jul 23 2019, 10:57 PM · Feed
epriestley triaged T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core as Low priority.
Jul 23 2019, 10:47 PM · Feed

May 22 2019

epriestley added a comment to T13294: Provide a transaction-level view of feed.

Per D20533, the major query this UI uses is currently unkeyed (no dateCreated key on transaction tables).

May 22 2019, 3:44 PM · Feed, Transactions

May 21 2019

epriestley added a revision to T13294: Provide a transaction-level view of feed: D20535: Support export of feed transactions to CSV/Excel/etc.
May 21 2019, 1:06 PM · Feed, Transactions
epriestley added a revision to T13294: Provide a transaction-level view of feed: D20533: Add support for querying feed transactions by author and date range.
May 21 2019, 12:25 PM · Feed, Transactions

May 20 2019

epriestley added a revision to T13294: Provide a transaction-level view of feed: D20531: Build a rough transaction-level view of Feed.
May 20 2019, 9:23 PM · Feed, Transactions
epriestley triaged T13294: Provide a transaction-level view of feed as Normal priority.
May 20 2019, 1:03 PM · Feed, Transactions

May 3 2019

epriestley closed T5462: How do I publish Phabricator events into remote systems? as Resolved.

The answer here is now pretty unambiguously "Use Webhooks". feed.http-hooks is formally deprecated, Herald remains a terrible idea, and anyone brave enough to touch Doorkeeper can probably figure things out for themselves.

May 3 2019, 4:57 AM · Guides, Feed, Herald, Doorkeeper

Apr 15 2019

epriestley closed T5457: Add Feed Queries to select individual app/object types as Wontfix.

No outstanding customer requests for this.

Apr 15 2019, 3:59 PM · Feed
epriestley added a parent task for T10613: Include commit's branch information in activity feed: T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".
Apr 15 2019, 3:56 PM · Diffusion, Feed, Feature Request
epriestley closed T10613: Include commit's branch information in activity feed as Wontfix.

Changes connected to T13277 likely moot this. If users are pushing temporary personal branches to a repository, configure "Permanent Refs" to exclude them. Commits pushed to these branches will no longer publish feed stories, trigger audits, etc.

Apr 15 2019, 3:55 PM · Diffusion, Feed, Feature Request

Mar 17 2018

ekubischta added a comment to T13070: Deprecate and remove `feed.http-hooks`.

aaaannnndddd..... I found it. D19050

Mar 17 2018, 1:32 AM · Feed
epriestley added a comment to T13070: Deprecate and remove `feed.http-hooks`.

What steps did you take to try to find the documentation?

Mar 17 2018, 1:11 AM · Feed
ekubischta added a comment to T13070: Deprecate and remove `feed.http-hooks`.

We currently use this extension at BisManOnline to integrate with our CRM system. Also, I believe that the Phabulous Slack Bot uses it as well https://github.com/etcinit/phabulous

Mar 17 2018, 1:09 AM · Feed

Mar 7 2018

epriestley added a revision to T12787: Creating a subtask 'reopens' the new task: D19179: Hide "abraham landed Dxyz irresponsibly" stories from feed.
Mar 7 2018, 1:41 AM · Feed, Bug Report

Feb 9 2018

epriestley triaged T13070: Deprecate and remove `feed.http-hooks` as Wishlist priority.
Feb 9 2018, 11:08 PM · Feed
epriestley renamed T10363: Reorient Doorkeeper publishing around transactions instead of feed stories from Reorient publishing (Doorkeeper, feed.http-hooks) around transactions instead of feed stories to Reorient Doorkeeper publishing around transactions instead of feed stories.
Feb 9 2018, 11:06 PM · Nuance, Restricted Project, Feed, Doorkeeper
epriestley updated the task description for T5462: How do I publish Phabricator events into remote systems?.
Feb 9 2018, 11:05 PM · Guides, Feed, Herald, Doorkeeper
epriestley closed T11330: Allow Herald to "Queue Call to Webhook: ...", a subtask of T5462: How do I publish Phabricator events into remote systems?, as Resolved.
Feb 9 2018, 9:57 PM · Guides, Feed, Herald, Doorkeeper
epriestley closed T5726: Add more information to story POSTs during the feed.http-hooks hook as Wontfix.

I'm planning to build T11330 ("policy-blind" webhooks) instead, and deprecate feed.http-hooks. See that task for details.

Feb 9 2018, 1:29 PM · Feed

Feb 6 2018

arrowd added a comment to T5726: Add more information to story POSTs during the feed.http-hooks hook.

One concern about this is that this information is policy-bypassing.

Feb 6 2018, 4:57 PM · Feed

Jan 26 2018

epriestley renamed T8952: Hide "Herald added subscribers..." stories from feed completely from herald showing as cause of feed item to Hide "Herald added subscribers..." stories from feed completely.
Jan 26 2018, 5:32 PM · Feed, Herald

Jul 9 2017

chad removed the image for Feed.
Jul 9 2017, 7:33 PM

Jun 23 2017

epriestley closed T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField as Resolved by committing rPf704f905d260: Let PhabricatorSearchCheckboxesField survive saved query data with mismatched….
Jun 23 2017, 7:29 PM · Feed, Bug Report
epriestley triaged T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField as Low priority.

(I think D18132 should fix this once someone gets a chance to look at it.)

Jun 23 2017, 4:22 PM · Feed, Bug Report

Jun 19 2017

epriestley added a comment to T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField.

This came from D18028, when I changed the Include stories about projects I am a member of. checkbox to be a CheckboxesField. I think the issue is that existing saved queries may have the old value for the field stored (true), instead of the new value (array('self')). These queries would be impossible to construct in the UI now.

Jun 19 2017, 5:04 PM · Feed, Bug Report
epriestley added a revision to T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField: D18132: Let PhabricatorSearchCheckboxesField survive saved query data with mismatched types.
Jun 19 2017, 3:56 PM · Feed, Bug Report

Jun 18 2017

20after4 created T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField.
Jun 18 2017, 8:14 AM · Feed, Bug Report

Jun 8 2017

Ben_RMCon added a comment to T6973: Associating Diffusion commits to Projects.

Hello, we used this function (add project to a commit by Herald rule) as well happily for about two years (last update of phabricator was 03/16/2016). The current phabricator update (06/06/2017) now lead to messages in the activity feed in the form of "Herald added a project to rXXXXX: <message>: <project>" and the commit itself (or better the message) does not appear anymore. When we disable the Herald rule the commit-messages appear in the feed again as before and expected.

Jun 8 2017, 10:25 AM · Feed, Projects, Diffusion

Jun 1 2017

epriestley added a revision to T12787: Creating a subtask 'reopens' the new task: D18059: Remove non-operational `shouldHideFromFeed()` from ManiphestTaskPointsTransaction.
Jun 1 2017, 3:20 PM · Feed, Bug Report
epriestley added a comment to T12787: Creating a subtask 'reopens' the new task.

This transaction uses shouldHideForFeed(), which isn't currently supported by Modular Transactions. It got swapped over in D17844 or some related change and we didn't catch that the logic wasn't firing anymore since this is a bit of an obscure case.

Jun 1 2017, 3:15 PM · Feed, Bug Report
epriestley closed T12787: Creating a subtask 'reopens' the new task as Resolved by committing rP995c1503e7ef: Hide "X created Y, a subtask of P." feed stories again.
Jun 1 2017, 3:08 PM · Feed, Bug Report
epriestley added a revision to T12787: Creating a subtask 'reopens' the new task: D18058: Hide "X created Y, a subtask of P." feed stories again.
Jun 1 2017, 2:59 PM · Feed, Bug Report
epriestley closed T12788: Test for T12787 as Invalid.
Jun 1 2017, 12:56 PM · Feed, Bug Report
epriestley closed T12788: Test for T12787, a subtask of T12787: Creating a subtask 'reopens' the new task, as Invalid.
Jun 1 2017, 12:56 PM · Feed, Bug Report
epriestley claimed T12787: Creating a subtask 'reopens' the new task.

Thanks, this reproduces here for me.

Jun 1 2017, 12:56 PM · Feed, Bug Report
epriestley created T12788: Test for T12787.
Jun 1 2017, 12:55 PM · Feed, Bug Report
ivo added a project to T12787: Creating a subtask 'reopens' the new task: Feed.
Jun 1 2017, 12:55 PM · Feed, Bug Report

May 31 2017

chad added a comment to T8553: Allow Feed Item Deletion.

Oh! If it's just a comment on an item, admins can remove comment on the drop down on the item and it should also be removed from feed.

May 31 2017, 5:11 PM · Feed
retterolf added a comment to T8553: Allow Feed Item Deletion.

You're likely right. I'll move down both corridors and see what I find. The system is fine.

May 31 2017, 5:07 PM · Feed
chad added a comment to T8553: Allow Feed Item Deletion.

I get what you're asking, but professionally it feels like you're trying to put a band-aid on a broken bone. It needs to be addressed. As admin you should be able to nuke most things from CLI or DB.

May 31 2017, 2:38 PM · Feed
chad added a comment to T8553: Allow Feed Item Deletion.

Bad hires are not a reason to ask the upstream to prioritize work. Even if feed had "delete" it doesn't solve the emails that already left the system.

May 31 2017, 2:35 PM · Feed
retterolf added a comment to T8553: Allow Feed Item Deletion.

Task deletion usage:
Colleague submits something for archival, but accidentally leaves in a bunch of dramatic content which does not reflect positively on hisself.

May 31 2017, 2:32 PM · Feed

May 26 2017

epriestley closed T12762: Feed queries should support date range constraints as Resolved by committing rPfc8465252fb1: Add "View All" header buttons to user and project feed boxes.
May 26 2017, 7:24 PM · Customer Impact, ApplicationSearch, Feed
epriestley added a revision to T12762: Feed queries should support date range constraints: D18031: Automatically AJAX in the first 5 pages of project feed content as the user scrolls.
May 26 2017, 6:24 PM · Customer Impact, ApplicationSearch, Feed
epriestley added a revision to T12762: Feed queries should support date range constraints: D18030: Add "View All" header buttons to user and project feed boxes.
May 26 2017, 5:44 PM · Customer Impact, ApplicationSearch, Feed
epriestley added a revision to T12762: Feed queries should support date range constraints: D18029: Allow users to query feed by a date range.
May 26 2017, 5:24 PM · Customer Impact, ApplicationSearch, Feed
epriestley added a revision to T12762: Feed queries should support date range constraints: D18028: Modernize FeedSearchEngine a little bit.
May 26 2017, 5:11 PM · Customer Impact, ApplicationSearch, Feed
chad added a comment to T12762: Feed queries should support date range constraints.

Anyways, let's just go with "See all" in the header for now.

May 26 2017, 5:02 PM · Customer Impact, ApplicationSearch, Feed
chad added a comment to T12762: Feed queries should support date range constraints.

I'm also not sure how that works with pagination, like, do you update the URL so people can send links?

May 26 2017, 4:58 PM · Customer Impact, ApplicationSearch, Feed
chad added a comment to T12762: Feed queries should support date range constraints.

But that sounds like a lot of work.

May 26 2017, 4:57 PM · Customer Impact, ApplicationSearch, Feed
chad added a comment to T12762: Feed queries should support date range constraints.

Basically what I'd like is something that auto-pulls maybe 5 times, then just makes you click a button thereafter. That solves the footer issue, makes it nicer for people who only want 2-3 more pages, and then the edge case of "no really I want to keep reading past 500 results" have to click a button.

May 26 2017, 4:57 PM · Customer Impact, ApplicationSearch, Feed
chad added a comment to T12762: Feed queries should support date range constraints.

Let me marinate on it.

May 26 2017, 4:52 PM · Customer Impact, ApplicationSearch, Feed
epriestley added a comment to T12762: Feed queries should support date range constraints.

Sure, we can do that too.

May 26 2017, 4:49 PM · Customer Impact, ApplicationSearch, Feed
epriestley added a revision to T12762: Feed queries should support date range constraints: D18027: Modernize FeedQuery a little bit.
May 26 2017, 4:45 PM · Customer Impact, ApplicationSearch, Feed
chad added a comment to T12762: Feed queries should support date range constraints.

Isn't auto-scroll with lots of JavaScript the right answer?

May 26 2017, 4:44 PM · Customer Impact, ApplicationSearch, Feed
epriestley claimed T12762: Feed queries should support date range constraints.
May 26 2017, 4:44 PM · Customer Impact, ApplicationSearch, Feed
epriestley added a comment to T12762: Feed queries should support date range constraints.

Ah, that makes sense. If there's some "good enough" way to get a button/link into these things today I'm happy to drop that in place while I'm in here, but we can just leave it for fiddling later too.

May 26 2017, 4:42 PM · Customer Impact, ApplicationSearch, Feed
chad added a comment to T12762: Feed queries should support date range constraints.

I don't think the current feed UI looks good in blue header, which is why I haven't moved it over. I'd need to fiddle with feed-view

May 26 2017, 4:40 PM · Customer Impact, ApplicationSearch, Feed
epriestley updated subscribers of T12762: Feed queries should support date range constraints.

@chad, I'd ideally like to put a "view more" on the feed on the project page so that the original issue here (wanting to page back in history) is easier to solve. This is what it looks like right now:

May 26 2017, 4:39 PM · Customer Impact, ApplicationSearch, Feed

May 25 2017

epriestley moved T12762: Feed queries should support date range constraints from Backlog to Requests on the Customer Impact board.
May 25 2017, 11:01 PM · Customer Impact, ApplicationSearch, Feed
epriestley created T12762: Feed queries should support date range constraints.
May 25 2017, 11:01 PM · Customer Impact, ApplicationSearch, Feed

May 21 2017

epriestley moved T10363: Reorient Doorkeeper publishing around transactions instead of feed stories from v1 to Backlog on the Nuance board.
May 21 2017, 12:43 PM · Nuance, Restricted Project, Feed, Doorkeeper

May 12 2017

rabahmeradi updated the task description for T7759: A feed search for "include users" also embeds other users who just gave tokens.
May 12 2017, 11:27 AM · Tokens, Feed
thirupu.somu updated the task description for T7759: A feed search for "include users" also embeds other users who just gave tokens.
May 12 2017, 10:56 AM · Tokens, Feed

Apr 12 2017

epriestley edited projects for T5726: Add more information to story POSTs during the feed.http-hooks hook, added: Feed; removed Support Impact.
Apr 12 2017, 2:49 PM · Feed

Mar 20 2017

epriestley closed T12405: Feed story failed to render as Resolved.

It sounds like this is resolved.

Mar 20 2017, 2:18 PM · Feed, Bug Report

Mar 16 2017

PyRowMan added a comment to T12405: Feed story failed to render.

After 6 month seeing the bug, i think i've found why it does that.

Mar 16 2017, 3:17 AM · Feed, Bug Report
epriestley added a comment to T12405: Feed story failed to render.

To move forward, we need complete reproduction instructions which we can follow to reproduce this issue in a clean environment. See Contributing Bug Reports and Providing Reproduction Steps.

Mar 16 2017, 3:10 AM · Feed, Bug Report
PyRowMan updated the task description for T12405: Feed story failed to render.
Mar 16 2017, 3:03 AM · Feed, Bug Report
PyRowMan created T12405: Feed story failed to render.
Mar 16 2017, 3:02 AM · Feed, Bug Report

Feb 15 2017

chad added a comment to T11432: Ability to exclude self ("Current Viewer") from Feed panels.

pasted_file (218×242 px, 13 KB)

Feb 15 2017, 7:12 PM · Feed, Feature Request
nornagon added a comment to T11432: Ability to exclude self ("Current Viewer") from Feed panels.

Yep, this is no longer a problem with the new audit bucketing. 🏅

Feb 15 2017, 7:11 PM · Feed, Feature Request

Jan 26 2017

epriestley added a comment to T11432: Ability to exclude self ("Current Viewer") from Feed panels.

Particularly, see T9430.

Jan 26 2017, 11:36 PM · Feed, Feature Request
epriestley added a comment to T11432: Ability to exclude self ("Current Viewer") from Feed panels.

Is that feedback based on the Audit dashboard at HEAD of master?

Jan 26 2017, 11:03 PM · Feed, Feature Request
nornagon added a comment to T11432: Ability to exclude self ("Current Viewer") from Feed panels.

This would also be useful for the Audit dashboard, e.g. to build the query "what audits am I responsible for that I didn't author?" (given that the viewer belongs to a project which is responsible for auditing the commit).

Jan 26 2017, 10:59 PM · Feed, Feature Request

Dec 15 2016

chad added a parent task for T11432: Ability to exclude self ("Current Viewer") from Feed panels: T12022: Build not(viewer) and not(user) for ApplicationSearch.
Dec 15 2016, 4:58 PM · Feed, Feature Request

Oct 20 2016

epriestley added a revision to T11773: Improve behaviors for "overheated" policy queries: D16736: Add developer UI for accessing NUX and "Overheated" query states.
Oct 20 2016, 4:11 PM · Performance
epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

Pagination isn't quite as simple as I'd remembered. Specifically, we do not expose internal pagination cursors to viewers today because doing so permits an information discovery attack that goes like this:

Oct 20 2016, 3:51 PM · Performance
epriestley added a revision to T11773: Improve behaviors for "overheated" policy queries: D16735: Make query engines "overheat" instead of stalling when filtering too many results.
Oct 20 2016, 3:36 PM · Performance

Oct 19 2016

epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

I think this behavior is very good

Oct 19 2016, 10:37 PM · Performance
epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

This is also a potential problem in the general case, although the general case of this is very rare.

Oct 19 2016, 10:30 PM · Performance
epriestley renamed T11773: Improve behaviors for "overheated" policy queries from Feed does not perform well in the presence of exclusive spaces? to Feed does not perform well in the presence of exclusive spaces.
Oct 19 2016, 10:11 PM · Performance
epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

Broadly, most applications can execute Spaces queries cheaply by querying ... AND spacePHID IN (<list of spaces the viewer can see>) when Spaces are configured, which is efficient until some install decides to create 30,000 Spaces for some reason.

Oct 19 2016, 10:10 PM · Performance
epriestley added projects to T11773: Improve behaviors for "overheated" policy queries: Feed, Performance.
Oct 19 2016, 9:59 PM · Performance