Page MenuHomePhabricator

When Herald changes object subscribers, always hide the feed story
ClosedPublic

Authored by epriestley on Sep 9 2019, 8:14 PM.
Tags
None
Referenced Files
F15333244: D20797.id.diff
Sat, Mar 8, 1:13 AM
F15332663: D20797.id49590.diff
Fri, Mar 7, 6:59 PM
F15311847: D20797.id49588.diff
Thu, Mar 6, 11:40 AM
F15306525: D20797.diff
Thu, Mar 6, 4:08 AM
Unknown Object (File)
Mon, Feb 17, 5:08 AM
Unknown Object (File)
Feb 9 2025, 8:06 AM
Unknown Object (File)
Feb 9 2025, 8:06 AM
Unknown Object (File)
Feb 9 2025, 8:06 AM
Subscribers
None

Details

Summary

Fixes T8952. These feed stories are not interesting and tend to be generated as collateral damage when a non-story update is made to an old task and someone has a "subscribe me" Herald rule.

Also clean up some of the Herald field/condition indexing behavior slightly.

Test Plan

Wrote a "Subscribe X" herald rule, made a trivial update to a task. Before: low-value feed story; after: no feed story.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:15 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.