Page MenuHomePhabricator

When Herald changes object subscribers, always hide the feed story
ClosedPublic

Authored by epriestley on Sep 9 2019, 8:14 PM.

Details

Summary

Fixes T8952. These feed stories are not interesting and tend to be generated as collateral damage when a non-story update is made to an old task and someone has a "subscribe me" Herald rule.

Also clean up some of the Herald field/condition indexing behavior slightly.

Test Plan

Wrote a "Subscribe X" herald rule, made a trivial update to a task. Before: low-value feed story; after: no feed story.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 9 2019, 8:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:15 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.