Remove non-operational `shouldHideFromFeed()` from ManiphestTaskPointsTransaction
ClosedPublic
Actions

Authored by epriestley on Jun 1 2017, 3:20 PM.

Tags

None

Referenced Files

	F19399047: D18059.id43436.diff
	Sat, Dec 27, 11:40 AM

	F19312599: D18059.id43436.diff
	Thu, Dec 25, 12:31 AM

	F18846401: D18059.diff
	Oct 29 2025, 6:45 PM

	F18750041: D18059.id.diff
	Oct 4 2025, 6:16 AM

	F18748451: D18059.diff
	Oct 3 2025, 10:40 PM

	F18740560: D18059.id43437.diff
	Oct 2 2025, 4:00 AM

	F18678558: D18059.diff
	Sep 25 2025, 10:48 PM

	F18566355: D18059.id.diff
	Sep 9 2025, 2:31 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12787: Creating a subtask 'reopens' the new task

Commits

rPb69174a4c8f7: Remove non-operational `shouldHideFromFeed()` from…

Summary

See D18018. Ref T12787. This doesn't actually work; we started publishing these stories as a side effect of converting to ModularTransactions, then I fixed the rendering.

This mechanism has very few callsites and I suspect we may want to get rid of it (see T12787) so just keep publishing these stories for now.

Test Plan

Changed the point value of a task, saw a feed story both before and after the patch.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 1 2017, 3:20 PM

Harbormaster completed remote builds in B17349: Diff 43436.Jun 1 2017, 3:21 PM

chad accepted this revision.Jun 1 2017, 4:09 PM

This revision is now accepted and ready to land.Jun 1 2017, 4:09 PM

Closed by commit rPb69174a4c8f7: Remove non-operational `shouldHideFromFeed()` from… (authored by epriestley, committed by epriestley). · Explain WhyJun 1 2017, 4:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

xaction/

ManiphestTaskPointsTransaction.php

4 lines

Diff 43437

View Options

src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php

Remove non-operational `shouldHideFromFeed()` from ManiphestTaskPointsTransactionClosedPublicActions