Page MenuHomePhabricator

Remove non-operational `shouldHideFromFeed()` from ManiphestTaskPointsTransaction
ClosedPublic

Authored by epriestley on Jun 1 2017, 3:20 PM.
Tags
None
Referenced Files
F18750041: D18059.id.diff
Sat, Oct 4, 6:16 AM
F18748451: D18059.diff
Fri, Oct 3, 10:40 PM
F18740560: D18059.id43437.diff
Thu, Oct 2, 4:00 AM
F18678558: D18059.diff
Thu, Sep 25, 10:48 PM
F18566355: D18059.id.diff
Tue, Sep 9, 2:31 PM
F18501185: D18059.diff
Sep 4 2025, 9:35 PM
F18454963: D18059.id.diff
Sep 1 2025, 6:15 AM
F18443068: D18059.diff
Aug 31 2025, 6:40 PM
Subscribers
None

Details

Summary

See D18018. Ref T12787. This doesn't actually work; we started publishing these stories as a side effect of converting to ModularTransactions, then I fixed the rendering.

This mechanism has very few callsites and I suspect we may want to get rid of it (see T12787) so just keep publishing these stories for now.

Test Plan

Changed the point value of a task, saw a feed story both before and after the patch.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 1 2017, 4:09 PM
This revision was automatically updated to reflect the committed changes.