Page MenuHomePhabricator

Feed queries should support date range constraints
Closed, ResolvedPublic


A SAAS install has an issue where they need to document project activity in a particular date range for reporting/documentation purposes. Although clicking "Next Page" a few times was sufficient, this would be slightly cleaner as an explicit date constraint.

Outside of this narrow use case, it generally it seems reasonable to apply date constraints to feed queries to review activity in a particular range (like the last month, or Q1 of the current year) so you can, e.g., write a changelog, review your team's work in the last month, summarize what you've done in the last quarter for a performance review, etc.

Event Timeline

epriestley moved this task from Backlog to Requests on the Customer Impact board.

@chad, I'd ideally like to put a "view more" on the feed on the project page so that the original issue here (wanting to page back in history) is easier to solve. This is what it looks like right now:

My ideas are:

  • Put a "View All" button on the right side, like "Members", "Subprojects", etc.
  • Or, put a fake pager element at the bottom? This makes a little more sense to me in this case, but I don't think we do this anywhere else, and just faking it with an actual pager might look weird -- and in most other cases where we do this (members, subprojects, etc) this probably wouldn't be a very good fit.
    • This could also be a full-width [ More... ] sort of button/link, kind of like how we fold timelines?

Other stuff:

  • Regardless, should this be converted to a blue header?
  • Whatever we pick, I'd do the same thing on user profile pages.
chad added a comment.May 26 2017, 4:40 PM

I don't think the current feed UI looks good in blue header, which is why I haven't moved it over. I'd need to fiddle with feed-view

Ah, that makes sense. If there's some "good enough" way to get a button/link into these things today I'm happy to drop that in place while I'm in here, but we can just leave it for fiddling later too.

chad added a comment.May 26 2017, 4:44 PM

Isn't auto-scroll with lots of JavaScript the right answer?

Sure, we can do that too.

  • Do you want to convert main /feed/ too?
  • Do you want to convert all other standard ApplicationSearch UIs?
  • What do we do about the page footer? Just remove it from UIs with infinite scroll?
chad added a comment.May 26 2017, 4:52 PM

Let me marinate on it.

chad added a comment.May 26 2017, 4:57 PM

Basically what I'd like is something that auto-pulls maybe 5 times, then just makes you click a button thereafter. That solves the footer issue, makes it nicer for people who only want 2-3 more pages, and then the edge case of "no really I want to keep reading past 500 results" have to click a button.

chad added a comment.May 26 2017, 4:57 PM

But that sounds like a lot of work.

chad added a comment.May 26 2017, 4:58 PM

I'm also not sure how that works with pagination, like, do you update the URL so people can send links?

chad added a comment.May 26 2017, 5:02 PM

Anyways, let's just go with "See all" in the header for now.