Page MenuHomePhabricator

Hide "abraham landed Dxyz irresponsibly" stories from feed

Authored by epriestley on Mar 7 2018, 1:41 AM.



Ref T13099. Ref T12787. See PHI417. Differential has new "irresponsible" warnings in the timeline somewhat recently, but these publish feed stories that don't link to the revision or have other relevant details, so they're confusing on the balance.

These have a high strength so they render on top, but we actually just want to hide them from the feed and let "abraham closed Dxyz by committing rXzzz." be the primary story.

Modularize things more so that we can get this behavior. Also, respect shouldHideForFeed() at display time, not just publishing time.

Test Plan

Used bin/differential attach-commit on a non-accepted revision to "irresponsibly land" a revision. Verified that feed story now shows "closed by commit" instead of "closed irresponsibly".

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 7 2018, 1:41 AM
epriestley requested review of this revision.Mar 7 2018, 1:42 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 1:48 AM
This revision was automatically updated to reflect the committed changes.