Page MenuHomePhabricator

Modernize FeedSearchEngine a little bit
ClosedPublic

Authored by epriestley on May 26 2017, 5:11 PM.

Details

Summary

Ref T12762. This updates FeedSeachEngine to user modern construction.

I've tried to retain behavior exactly, although the "Include stories about projects I'm a member of" checkbox is now nonstandard/obsolete. We could likely fold that into "Include Projects" in a future change which does a backward compatibility break.

Test Plan
  • Queried feed without constraints.
  • Queried feed by user, project, "stuff I'm a member of", prebuilt "Tags" query.
  • Viewed user profile / project profile feeds.
  • Used function tokens (viewer(), etc).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 26 2017, 5:11 PM
chad accepted this revision.May 26 2017, 5:34 PM
This revision is now accepted and ready to land.May 26 2017, 5:34 PM
epriestley updated this revision to Diff 43363.May 26 2017, 5:35 PM
  • Use a slightly less fancy project selector, since some of the advanced options do not work because this is not a real EdgeLogic query.
This revision was automatically updated to reflect the committed changes.