Page MenuHomePhabricator

Modernize FeedSearchEngine a little bit
ClosedPublic

Authored by epriestley on May 26 2017, 5:11 PM.
Tags
None
Referenced Files
F15561296: D18028.diff
Tue, Apr 29, 7:09 PM
F15557066: D18028.diff
Mon, Apr 28, 7:42 PM
F15543476: D18028.id43360.diff
Fri, Apr 25, 10:42 PM
F15525590: D18028.diff
Mon, Apr 21, 3:31 PM
F15491209: D18028.id43363.diff
Sat, Apr 12, 12:15 AM
F15456671: D18028.id43360.diff
Mar 30 2025, 11:15 AM
F15451421: D18028.id.diff
Mar 28 2025, 10:00 PM
F15451105: D18028.id43369.diff
Mar 28 2025, 8:09 PM
Subscribers
None

Details

Summary

Ref T12762. This updates FeedSeachEngine to user modern construction.

I've tried to retain behavior exactly, although the "Include stories about projects I'm a member of" checkbox is now nonstandard/obsolete. We could likely fold that into "Include Projects" in a future change which does a backward compatibility break.

Test Plan
  • Queried feed without constraints.
  • Queried feed by user, project, "stuff I'm a member of", prebuilt "Tags" query.
  • Viewed user profile / project profile feeds.
  • Used function tokens (viewer(), etc).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 26 2017, 5:34 PM
  • Use a slightly less fancy project selector, since some of the advanced options do not work because this is not a real EdgeLogic query.
This revision was automatically updated to reflect the committed changes.