Page MenuHomePhabricator
Create Task
Maniphest T12851

The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField
Closed, ResolvedPublic
Actions

Description

Easily reproducible, not so easily explainable:

Error:

  • Argument 1 passed to array_fuse() must be of the type array, boolean given, called in /core/lib/phabricator/src/applications/search/field/PhabricatorSearchCheckboxesField.php on line 26 and defined

Reproducible URL:

I've attempted to work out what combination of form settings results in this query hash, unfortunately without success. I can't seem to reproduce it with the form, however, this seems like like a valid bug with an easy fix. I'll submit a diff.

Revisions and Commits

rP Phabricator
D18132rPf704f905d260 Let PhabricatorSearchCheckboxesField survive saved query data with mismatched…

Related Objects

Event Timeline

20after4 created this task.Jun 18 2017, 8:14 AM
epriestley added a revision: D18132: Let PhabricatorSearchCheckboxesField survive saved query data with mismatched types.Jun 19 2017, 3:56 PM
epriestley added a subscriber: epriestley.EditedJun 19 2017, 5:04 PM

This came from D18028, when I changed the Include stories about projects I am a member of. checkbox to be a CheckboxesField. I think the issue is that existing saved queries may have the old value for the field stored (true), instead of the new value (array('self')). These queries would be impossible to construct in the UI now.

A way to reproduce this is to change the hard-coded array('self') in buildSavedQueryFromBuiltin() to true, then view the default "Tags" query.

However, that has run me into T12855, which ran me into T12124, which probably should get fixed Soon.

epriestley triaged this task as Low priority.Jun 23 2017, 4:22 PM

(I think D18132 should fix this once someone gets a chance to look at it.)

epriestley closed this task as Resolved by committing rPf704f905d260: Let PhabricatorSearchCheckboxesField survive saved query data with mismatched….Jun 23 2017, 7:29 PM
epriestley added a commit: rPf704f905d260: Let PhabricatorSearchCheckboxesField survive saved query data with mismatched….
Phabricator · Built by Phacility