Page MenuHomePhabricator
Feed Advanced Search

Nov 30 2019

epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20934: Give "Config" a full-width, hierarchical layout.
Nov 30 2019, 8:03 PM · Design, Config
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Nov 30 2019, 7:55 PM · Design, Config
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Nov 30 2019, 6:38 PM · Design, Config
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20933: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView".
Nov 30 2019, 6:37 PM · Design, Config

Nov 26 2019

epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20931: Carve out a separate "Services" section of Config.
Nov 26 2019, 11:31 PM · Design, Config
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20930: Carve out a separate "Modules/Extensions" section of Config.
Nov 26 2019, 11:01 PM · Design, Config

Nov 25 2019

epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20925: Extend Config to full-width.
Nov 25 2019, 10:37 PM · Design, Config
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Nov 25 2019, 3:24 PM · Design, Config
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Nov 25 2019, 3:22 PM · Design, Config
epriestley added a comment to T13362: Push the "Config" application UI out to full-width.

...

Nov 25 2019, 3:17 PM · Design, Config

Sep 3 2019

epriestley closed T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues as Resolved.
Sep 3 2019, 7:54 PM · Database, Config
epriestley added a revision to T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues: D20781: Use the "@" operator to silence connection retry messages if initializing the stack with database config optional.
Sep 3 2019, 7:26 PM · Database, Config
epriestley added a revision to T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues: D20780: When "mysqli->real_connect()" fails without setting an error code, recover more gracefully.
Sep 3 2019, 7:23 PM · Database, Config
epriestley added a revision to T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues: D20779: Give "bin/config" a friendlier error message if "local.json" is not writable.
Sep 3 2019, 7:19 PM · Database, Config
epriestley triaged T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues as Low priority.
Sep 3 2019, 7:05 PM · Database, Config

Aug 12 2019

epriestley added a revision to T13373: Clarify some messaging in `bin/config`: D20711: Make the success message from "bin/config" more clear.
Aug 12 2019, 6:22 PM · Setup, Config

Aug 11 2019

epriestley triaged T13373: Clarify some messaging in `bin/config` as Low priority.
Aug 11 2019, 3:45 PM · Setup, Config

Aug 1 2019

epriestley triaged T13362: Push the "Config" application UI out to full-width as Low priority.
Aug 1 2019, 6:53 PM · Design, Config

Jun 23 2018

epriestley closed T13159: The "Config" application renders an extra "Config" crumb as Resolved by committing rPb1f4a974fe03: Fix two minor breadcrumb issues in Config.
Jun 23 2018, 12:38 AM · Config

Jun 22 2018

epriestley added a revision to T13159: The "Config" application renders an extra "Config" crumb: D19501: Fix two minor breadcrumb issues in Config.
Jun 22 2018, 11:59 AM · Config
epriestley triaged T13159: The "Config" application renders an extra "Config" crumb as Low priority.
Jun 22 2018, 11:36 AM · Config

Feb 15 2018

epriestley added a comment to T12845: Convert remaining ancient configuration type classes to modern modular type classes.

See PHI372 -- setting user.custom-field-definitions (or, probably, any similar config) to a string will pass validation but then fatal in use.

Feb 15 2018, 5:15 PM · Infrastructure, Config

Feb 14 2018

epriestley closed T13078: `phabricator.silent` should also silence remote builds and webhooks as Resolved by committing rPf74e6bbf8d70: Make "phabricator.silent" disable build steps which rely on external services.
Feb 14 2018, 7:41 PM · Config
epriestley added a revision to T13078: `phabricator.silent` should also silence remote builds and webhooks: D19085: Make "phabricator.silent" disable build steps which rely on external services.
Feb 14 2018, 7:36 PM · Config
epriestley added a revision to T13078: `phabricator.silent` should also silence remote builds and webhooks: D19084: When "phabricator.silent" is enabled, don't call webhooks.
Feb 14 2018, 7:14 PM · Config
epriestley triaged T13078: `phabricator.silent` should also silence remote builds and webhooks as Normal priority.
Feb 14 2018, 4:40 PM · Config

Jan 31 2018

epriestley added a comment to T13055: Maybe "translation.override" should be locked.

One attack is that you can override the content of email and then send invite or welcome mail that says whatever you want, whether the victim has a Phabricator account (welcome) or not (invite).

Jan 31 2018, 12:33 PM · Config, Security
epriestley triaged T13055: Maybe "translation.override" should be locked as Low priority.
Jan 31 2018, 4:20 AM · Config, Security

Aug 1 2017

epriestley closed T12942: Add a "Binary Versions" page to Config as Resolved by committing rPf48f2dae9f39: Move Phabricator to use PhutilBinaryAnalyzer and show binary versions.
Aug 1 2017, 2:14 PM · Config

Jul 31 2017

epriestley added a revision to T12942: Add a "Binary Versions" page to Config: D18306: Move Phabricator to use PhutilBinaryAnalyzer and show binary versions.
Jul 31 2017, 7:23 PM · Config
epriestley added a revision to T12942: Add a "Binary Versions" page to Config: D18305: Consolidate binary (hg, git, svn) analysis code into one place.
Jul 31 2017, 7:19 PM · Config

Jul 28 2017

epriestley added a comment to T12942: Add a "Binary Versions" page to Config.

This could also just go on the existing page at the bottom. We tell people to copy/paste it when submitting bug reports, but it's probably fine if they're including more information, especially since there is a nice walled garden moat around my personally having to deal with it.

Jul 28 2017, 6:20 PM · Config
epriestley added a comment to T12942: Add a "Binary Versions" page to Config.

See also PHI22.

Jul 28 2017, 6:18 PM · Config
epriestley created T12942: Add a "Binary Versions" page to Config.
Jul 28 2017, 6:15 PM · Config

Jul 9 2017

chad removed the image for Config.
Jul 9 2017, 7:13 PM

Jul 5 2017

zhiyuchen added a comment to Q226: Arcanist with self-signed SSL certificate.

One of our engineers is having a similar issue with slightly different error, running "arc install-certificate" would always fail with the following error:

Jul 5 2017, 10:00 PM · Installing & Upgrading, Config, Arcanist

Jun 27 2017

epriestley closed T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities, a subtask of T12845: Convert remaining ancient configuration type classes to modern modular type classes, as Resolved.
Jun 27 2017, 7:35 PM · Infrastructure, Config
epriestley renamed T12845: Convert remaining ancient configuration type classes to modern modular type classes from Setting and removing a config for maniphest.priorities results in a null config instead of reverting to the default to Convert remaining ancient configuration type classes to modern modular type classes.
Jun 27 2017, 7:12 PM · Infrastructure, Config

Apr 13 2017

amckinley closed T12532: `syntax.filemap` does not validate input as Resolved.
Apr 13 2017, 8:57 PM · Contributor Onboarding, Config, Bug Report
amckinley added a revision to T12532: `syntax.filemap` does not validate input: D17684: Add validation for config settings of type regex.
Apr 13 2017, 8:52 PM · Contributor Onboarding, Config, Bug Report
amckinley claimed T12532: `syntax.filemap` does not validate input.
Apr 13 2017, 8:25 PM · Contributor Onboarding, Config, Bug Report

Apr 12 2017

epriestley added a comment to T12532: `syntax.filemap` does not validate input.
  • PhabricatorSyntaxHighlightingConfigOptions defines this option.
  • Change the type from wild to custom:SomeClassName to switch to a custom type validator.
  • The new validator class should subclass PhabricatorConfigJSONOptionType.
  • You can look at PhabricatorKeyringConfigOptionType for a (more complex) example of how to validate a value.
  • Test by trying to change the value to something invalid, you should get an error.
  • You can test a regexp is valid like this:
Apr 12 2017, 8:40 PM · Contributor Onboarding, Config, Bug Report
epriestley moved T12532: `syntax.filemap` does not validate input from Backlog to Basic on the Contributor Onboarding board.
Apr 12 2017, 8:35 PM · Contributor Onboarding, Config, Bug Report
epriestley added a project to T12532: `syntax.filemap` does not validate input: Contributor Onboarding.
Apr 12 2017, 8:35 PM · Contributor Onboarding, Config, Bug Report

Apr 10 2017

joshuaspence added a project to T12532: `syntax.filemap` does not validate input: Config.
Apr 10 2017, 10:33 PM · Contributor Onboarding, Config, Bug Report

Feb 6 2017

epriestley closed T12216: User can change userpic when account.editable is false (bad config description or restrictions mistake) as Resolved by committing rP3d44208e4f65: Clarify that "account.editable" no longer extends to profile pictures.
Feb 6 2017, 4:37 PM · Profile, Config, Bug Report
epriestley added a revision to T12216: User can change userpic when account.editable is false (bad config description or restrictions mistake): D17317: Clarify that "account.editable" no longer extends to profile pictures.
Feb 6 2017, 1:02 PM · Profile, Config, Bug Report
epriestley added a comment to T12216: User can change userpic when account.editable is false (bad config description or restrictions mistake).

I think I'm just going to remove the "profile picture" text from the description to resolve this. The account.editable option is very old and I'd eventually like to remove it, but making the description more clear is an easier fix for now.

Feb 6 2017, 12:59 PM · Profile, Config, Bug Report
denispugachev added projects to T12216: User can change userpic when account.editable is false (bad config description or restrictions mistake): Config, Profile.
Feb 6 2017, 12:15 PM · Profile, Config, Bug Report

Jan 18 2017

jonathon added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

Righty; I didn't want to create any extra noise. New ticket, ho.

Jan 18 2017, 2:11 PM · Config, Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

If you'd like us to look at it, please file a new issue following Contributing Bug Reports.

Jan 18 2017, 1:50 PM · Config, Bug Report
jonathon added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

arcanist: ade25facfdf22aed1c1e20fed3e58e60c0be3c2b
libphutil: 9d85dfab0f532d50c2343719e92d574a4827341b
phabricator: 2d4eb460abb2ba34a944962c7cfea5741e099ff9

Jan 18 2017, 8:53 AM · Config, Bug Report
jonathon updated the task description for T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.
Jan 18 2017, 8:46 AM · Config, Bug Report

Dec 9 2016

epriestley closed T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site as Resolved by committing rP9c72c1b1daa9: When rendering the "you were invited" header, query the inviting user with the….
Dec 9 2016, 4:35 PM · Config, Bug Report
epriestley added a revision to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site: D17015: When rendering the "you were invited" header, query the inviting user with the omnipotent viewer.
Dec 9 2016, 4:22 PM · Config, Bug Report
epriestley reopened T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site as "Open".

That's similar but not directly related.

Dec 9 2016, 4:18 PM · Config, Bug Report
epriestley closed T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site as Resolved by committing rPcde37acb4bd4: When a custom logo is configured but has a restrictive visibility policy, fall….
Dec 9 2016, 3:51 PM · Config, Bug Report
jonathon added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

Getting another instance of what looks to be a similar issue but for a different function, specifically

Dec 9 2016, 2:22 PM · Config, Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

The "Public" vs "All Users" stuff is sort of a confusing behavior on our part (the workflow is what set "Public", which doesn't really make sense given the rest of your config) but I think it's largely mooted by the fix in D17011, and to be more clear about it we'd have to make this one particular file magical somehow (we can't choose either "users" or "public" as the policy unambiguously, because the install may change the value of policy.allow-public later without also updating the logo).

Dec 9 2016, 1:01 PM · Config, Bug Report
jonathon added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

Oh. No - no it doesn't.

Dec 9 2016, 12:52 PM · Config, Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

No problem -- we gave you a false start in Q528 and this behavior is pretty hard to guess at if you don't know the internals.

Dec 9 2016, 12:43 PM · Config, Bug Report
jonathon added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

OK, after removing the custom logo (even though it's Public) I can't replicate any more.

Dec 9 2016, 12:39 PM · Config, Bug Report
jonathon added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

Same file.

Dec 9 2016, 12:34 PM · Config, Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

Specifically, this is the PHID you're looking for in the UI:

Dec 9 2016, 12:33 PM · Config, Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

If you do this:

Dec 9 2016, 12:32 PM · Config, Bug Report
jonathon added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

Well, the fact that the logo isn't restricted:

Dec 9 2016, 12:31 PM · Config, Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

When you say "fail hard", you specifically mean that you get an exception message beginning with this text?

Dec 9 2016, 12:27 PM · Config, Bug Report
epriestley added a revision to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site: D17011: When a custom logo is configured but has a restrictive visibility policy, fall back to the default logo.
Dec 9 2016, 12:24 PM · Config, Bug Report
jonathon updated the task description for T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.
Dec 9 2016, 12:24 PM · Config, Bug Report
jonathon added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

Um. That's a different bug to the one I'm reporting. The custom logo I have set is visible to Public.

Dec 9 2016, 12:22 PM · Config, Bug Report
epriestley added a project to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site: Config.
Dec 9 2016, 12:18 PM · Config, Bug Report

Dec 5 2016

epriestley closed T11946: Global default settings only apply to logged-out users on public installs as Resolved by committing rP5f593aafb1ac: Allow logged-out users to load global preferences on installs without public….
Dec 5 2016, 7:00 PM · Config, Bug Report
epriestley claimed T11946: Global default settings only apply to logged-out users on public installs.
Dec 5 2016, 5:04 PM · Config, Bug Report

Nov 14 2016

dmgarcia closed Q513: How can I activate Nuance ? as resolved.
Nov 14 2016, 2:18 AM · Config, Nuance
dmgarcia updated Q513: How can I activate Nuance ? from to How can I activate Nuance ?.
Nov 14 2016, 1:39 AM · Config, Nuance

Aug 7 2016

epriestley closed T11437: Provide a usable UI for configuring header logos as Resolved by committing rP3a002b6b83d6: Make new logo and wordmark more reasonably configurable by human users.
Aug 7 2016, 7:00 PM · Config
epriestley added a revision to T11437: Provide a usable UI for configuring header logos: D16377: Make new logo and wordmark more reasonably configurable by human users.
Aug 7 2016, 6:52 PM · Config

Aug 6 2016

epriestley created T11437: Provide a usable UI for configuring header logos.
Aug 6 2016, 2:10 PM · Config

Aug 5 2016

eadler added a project to T10046: Unable to unignore config issues: Restricted Project.
Aug 5 2016, 5:05 PM · Restricted Project, Feature Request, Config

Jun 8 2016

chad added a project to T11047: Entering wrong or empty paths renders configtool unusable: Config.
Jun 8 2016, 4:37 PM · Config, Bug Report

May 27 2016

chad closed Q406: How do I limit the permissions to create a new project only to administrators? as resolved.
May 27 2016, 4:18 PM · Projects, Config
remusvrm updated Q406: How do I limit the permissions to create a new project only to administrators? from to How do I limit the permissions to create a new project only to administrators?.
May 27 2016, 3:34 PM · Projects, Config

May 7 2016

rubenriverae updated the task description for T4752: Daemons may not have permission to remove files from local disk storage engine.
May 7 2016, 1:13 PM · Files
rubenriverae renamed T4752: Daemons may not have permission to remove files from local disk storage engine from Daemons may not have permission to remove files from local disk storage engine to Daemons may have permission to remove files from local disk storage engine.
May 7 2016, 1:08 PM · Files

Apr 12 2016

francois added a comment to T10046: Unable to unignore config issues.

Another workaround is directly editing the Phabricator database (e.g. with phpMyAdmin).

Apr 12 2016, 11:43 PM · Restricted Project, Feature Request, Config

Mar 19 2016

epriestley closed T9788: config/versions page - also show dates of commits as Resolved.

I think the remaining part was "show a lot more versions of different things", but I can't immediately think of cases where that would have helped us resolve something faster.

Mar 19 2016, 2:11 AM · Config
chad added a comment to T9788: config/versions page - also show dates of commits.

Resolved?

Mar 19 2016, 2:04 AM · Config

Mar 18 2016

claudiomelis shifted Q345: creating sub-groups with different rights from the S3 Hyperspace space to the S1 Core space.
Mar 18 2016, 4:18 PM · Differential
claudiomelis updated Q345: creating sub-groups with different rights from to creating sub-groups with different rights.
Mar 18 2016, 4:17 PM · Differential

Mar 4 2016

kaendfinger added a comment to T9550: Atom editor not present in the default uri.allowed-editor-protocols config.

@epriestley I think that's a massive underestimation of the prevalence of the Atom editor. It has a pretty large user base.

Mar 4 2016, 11:38 PM · Config

Feb 15 2016

epriestley merged task T10358: Unicode symbols show as escape sequences in configuration's value editor into T8973: Encoding JSON for presentation could use more human-friendly escaping rules.
Feb 15 2016, 3:13 PM · Config, Bug Report
utrack added a project to T10358: Unicode symbols show as escape sequences in configuration's value editor: Config.
Feb 15 2016, 11:43 AM · Config, Bug Report

Feb 11 2016

JOY updated Q303: Set default menu customization for all users from to Set default menu customization for all users.
Feb 11 2016, 1:04 PM · Config

Jan 25 2016

epriestley closed T10217: reStructuredText appears twice in the syntax highlighting dropdown as Resolved by committing rP1e69f06d7447: Remove redundant restructured text entry in default Paste highlighting options.
Jan 25 2016, 2:47 PM · Config, Paste, Bug Report
epriestley claimed T10217: reStructuredText appears twice in the syntax highlighting dropdown.
Jan 25 2016, 2:47 PM · Config, Paste, Bug Report

Jan 19 2016

chad set the image for Config to F1064789: fa-briefcase-blue.png.
Jan 19 2016, 10:01 PM

Dec 26 2015

epriestley closed T8668: The web interface should alert (show a config issue?) when there are fatal errors or exceptions in the daemon log as Wontfix.

We haven't seen requests for this from other installs and I don't particularly favor this mechanism. Prior alerts in this vein like "daemon and web config differ" have created a lot of noise and little value. T7338 should eventually provide more monitoring tools.

Dec 26 2015, 11:04 PM · Config, Daemons

Dec 25 2015

epriestley edited projects for T10046: Unable to unignore config issues, added: Feature Request; removed Bug Report.
Dec 25 2015, 3:23 PM · Restricted Project, Feature Request, Config

Dec 23 2015

epriestley added a comment to T10046: Unable to unignore config issues.

(That's not possible for all issues, like the conduit.deprecated.* issues, since those no longer fire.)

Dec 23 2015, 12:53 PM · Restricted Project, Feature Request, Config
epriestley added a comment to T10046: Unable to unignore config issues.

We should probably provide a way to do this, but a workaround today is:

Dec 23 2015, 12:52 PM · Restricted Project, Feature Request, Config