Page MenuHomePhabricator
Differential D19084

When "phabricator.silent" is enabled, don't call webhooks
ClosedPublic
Actions

Authored by epriestley on Feb 14 2018, 7:14 PM.
Tags
None
Referenced Files
F18780265: D19084.id45742.diff
Sun, Oct 12, 4:43 AM
F18745182: D19084.id45744.diff
Fri, Oct 3, 5:37 AM
F18741262: D19084.diff
Thu, Oct 2, 9:58 AM
F18739267: D19084.diff
Wed, Oct 1, 8:39 PM
F18697816: D19084.diff
Sat, Sep 27, 10:08 AM
F18627173: D19084.diff
Sep 16 2025, 3:23 AM
F18566588: D19084.id.diff
Sep 9 2025, 2:45 PM
F18538666: D19084.diff
Sep 7 2025, 4:54 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13078: `phabricator.silent` should also silence remote builds and webhooks
Commits
rPa2453706abf1: When "phabricator.silent" is enabled, don't call webhooks
Summary

Ref T13078. The phabricator.silent configuration flag should disable webhook calls, since this is consistent with the documented and desired behavior.

Test Plan

Enabled phabricator.silent, made test hook calls, saw them fail with a "silent" failure reason.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 14 2018, 7:14 PM
Harbormaster completed remote builds in B19546: Diff 45742.Feb 14 2018, 7:15 PM
epriestley requested review of this revision.Feb 14 2018, 7:15 PM
epriestley added a child revision: D19085: Make "phabricator.silent" disable build steps which rely on external services.Feb 14 2018, 7:36 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 14 2018, 7:40 PM
Closed by commit rPa2453706abf1: When "phabricator.silent" is enabled, don't call webhooks (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
worker/
7 lines

Diff 45744

View Options

src/applications/herald/worker/HeraldWebhookWorker.php

Loading...
Phabricator · Built by Phacility